github-actions[bot] commented on pull request #7893:
URL: https://github.com/apache/arrow/pull/7893#issuecomment-668073454
https://issues.apache.org/jira/browse/ARROW-9600
This is an automated message from the Apache Git
wqc200 opened a new pull request #7895:
URL: https://github.com/apache/arrow/pull/7895
I use ExecutionContextSchemaProvider in outside app, so i add keyword "pub"
for ExecutionContextSchemaProvider, and add a new func "new" for
ExecutionContextSchemaProvider.
I add keyword "pub"
wesm commented on pull request #6587:
URL: https://github.com/apache/arrow/pull/6587#issuecomment-668124992
I'm closing this. We need to have a discussion about the future of this code
on the mailing list
This is an
wesm commented on pull request #7881:
URL: https://github.com/apache/arrow/pull/7881#issuecomment-668124432
Seems okay
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
romainfrancois commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r464531038
##
File path: r/tests/testthat/test-Array.R
##
@@ -131,14 +131,14 @@ test_that("Slice() and RangeEquals()", {
expect_true(x$RangeEquals(z, 10,
emkornfield commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r464573782
##
File path: cpp/src/gandiva/precompiled/arithmetic_ops_test.cc
##
@@ -101,4 +101,10 @@ TEST(TestArithmeticOps, TestDiv) {
context.Reset();
}
andygrove closed pull request #7874:
URL: https://github.com/apache/arrow/pull/7874
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #7893:
URL: https://github.com/apache/arrow/pull/7893
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove commented on pull request #7873:
URL: https://github.com/apache/arrow/pull/7873#issuecomment-668049019
@vertexclique I will need to look at the code again but I don't see why
arrrow would depend on a protocol. I think the protocl should depend on arrow.
The core arrow
andygrove opened a new pull request #7893:
URL: https://github.com/apache/arrow/pull/7893
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #7895:
URL: https://github.com/apache/arrow/pull/7895#issuecomment-668096396
https://issues.apache.org/jira/browse/ARROW-9632
This is an automated message from the Apache Git
andygrove opened a new pull request #7892:
URL: https://github.com/apache/arrow/pull/7892
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
vertexclique commented on pull request #7892:
URL: https://github.com/apache/arrow/pull/7892#issuecomment-668072946
Before merging this, please take a look at mine:
https://github.com/apache/arrow/pull/7894
I simplified a bit of what happens when feature gates are enabled.
vertexclique opened a new pull request #7894:
URL: https://github.com/apache/arrow/pull/7894
reexports flight from arrow if enabled.
removes unnecessary datafusion deps.
now by default arrow uses no features. features should be handpicked by the
user.
wesm closed pull request #6981:
URL: https://github.com/apache/arrow/pull/6981
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
emkornfield commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r464575120
##
File path: cpp/src/gandiva/precompiled/arithmetic_ops.cc
##
@@ -234,6 +234,25 @@ DIV_FLOAT(float64)
#undef DIV_FLOAT
+#define ROUND(TYPE)
github-actions[bot] commented on pull request #7816:
URL: https://github.com/apache/arrow/pull/7816#issuecomment-668170595
Revision: b4e3b9d4dcf3da6c7fa3e652d5b77fc4e7abad13
Submitted crossbow builds: [ursa-labs/crossbow @
andygrove commented on pull request #7893:
URL: https://github.com/apache/arrow/pull/7893#issuecomment-668071737
@alamb could you review please?
This is an automated message from the Apache Git Service.
To respond to the
wesm closed pull request #6587:
URL: https://github.com/apache/arrow/pull/6587
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm closed pull request #7881:
URL: https://github.com/apache/arrow/pull/7881
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
andygrove commented on pull request #7873:
URL: https://github.com/apache/arrow/pull/7873#issuecomment-668066624
@vertexclique I already did, but happy to take yours too.
https://github.com/apache/arrow/pull/7892
emkornfield commented on pull request #7816:
URL: https://github.com/apache/arrow/pull/7816#issuecomment-668169810
@github-actions crossbow submit test-conda-python-3.7-spark-branch-3.0
This is an automated message from the
liyafan82 commented on a change in pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#discussion_r464391921
##
File path:
java/algorithm/src/test/java/org/apache/arrow/algorithm/sort/TestSortingUtil.java
##
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache
liyafan82 commented on a change in pull request #7837:
URL: https://github.com/apache/arrow/pull/7837#discussion_r464392286
##
File path:
java/algorithm/src/main/java/org/apache/arrow/algorithm/sort/FixedWidthOutOfPlaceVectorSorter.java
##
@@ -44,6 +45,13 @@ public void
github-actions[bot] commented on pull request #7890:
URL: https://github.com/apache/arrow/pull/7890#issuecomment-668010880
https://issues.apache.org/jira/browse/ARROW-9621
This is an automated message from the Apache Git
andygrove commented on pull request #7874:
URL: https://github.com/apache/arrow/pull/7874#issuecomment-668035017
I agree with @jhorstmann since I am also confused by the naming and comments.
My original requirement was for a method that would tell me how much
physical memory is
jimhester commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r464346839
##
File path: r/src/arrow_rcpp.h
##
@@ -67,120 +71,150 @@ struct ns {
} // namespace arrow
namespace Rcpp {
-namespace internal {
+using
github-actions[bot] commented on pull request #7888:
URL: https://github.com/apache/arrow/pull/7888#issuecomment-667971349
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
alamb opened a new pull request #7889:
URL: https://github.com/apache/arrow/pull/7889
This is another trivial PR not meant to be merged, but rather to trigger CI
workflows for debugging https://issues.apache.org/jira/browse/ARROW-9628 (this
code is my copy of the code in
jhorstmann commented on pull request #7874:
URL: https://github.com/apache/arrow/pull/7874#issuecomment-667921497
> Instead of `buffer_memory_size` and `total_memory_size`, I'm thinking
whether `memory_used` and `memory_capacity` makes more sense.
I think the new names, or maybe the
sagnikc-dremio commented on a change in pull request #7872:
URL: https://github.com/apache/arrow/pull/7872#discussion_r464353530
##
File path: cpp/src/gandiva/precompiled/arithmetic_ops_test.cc
##
@@ -101,4 +101,29 @@ TEST(TestArithmeticOps, TestDiv) {
context.Reset();
}
alamb opened a new pull request #7888:
URL: https://github.com/apache/arrow/pull/7888
This is a trivial PR not meant to be merged, but rather to trigger CI
workflows for debugging https://issues.apache.org/jira/browse/ARROW-9628
jorisvandenbossche opened a new pull request #7890:
URL: https://github.com/apache/arrow/pull/7890
Awaiting a proper fix (ARROW-9621,
https://github.com/intake/filesystem_spec/issues/367), let's disable the test
so it doesn't cause noise in our CI.
jorisvandenbossche commented on pull request #7891:
URL: https://github.com/apache/arrow/pull/7891#issuecomment-668013896
cc @xhochy
Not a very robust fix (future-wise) in case other test dependencies get
added, but not sure if there is a better way (we could in principle use their
jorisvandenbossche commented on pull request #7891:
URL: https://github.com/apache/arrow/pull/7891#issuecomment-668014250
@github-actions crossbow submit test-conda-python-3.7-kartothek-latest
test-conda-python-3.7-kartothek-master
vertexclique edited a comment on pull request #7874:
URL: https://github.com/apache/arrow/pull/7874#issuecomment-668039525
> My original requirement was for a method that would tell me how much
physical memory is occupied by an array's buffers. I would call this something
like
alamb commented on pull request #7888:
URL: https://github.com/apache/arrow/pull/7888#issuecomment-668051492
All the tests pass, so nothing was learned. Closing this PR. Sorry for the
noise
This is an automated message from
alamb closed pull request #7888:
URL: https://github.com/apache/arrow/pull/7888
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vertexclique commented on pull request #7873:
URL: https://github.com/apache/arrow/pull/7873#issuecomment-668050755
@andygrove Exactly! This is definitely the problem we are having with
default feature gating scheme that arrow has, which scattered to arrow
dependant crates.
github-actions[bot] commented on pull request #7891:
URL: https://github.com/apache/arrow/pull/7891#issuecomment-668018918
Revision: de3d2549bea1436ae185d87dcaa899c33ef9a0dd
Submitted crossbow builds: [ursa-labs/crossbow @
github-actions[bot] commented on pull request #7891:
URL: https://github.com/apache/arrow/pull/7891#issuecomment-668018562
https://issues.apache.org/jira/browse/ARROW-9629
This is an automated message from the Apache Git
vertexclique edited a comment on pull request #7873:
URL: https://github.com/apache/arrow/pull/7873#issuecomment-668032973
Parquet crate is using arrow's default features which are `default =
["flight", "prettyprint"]` but flight is not needed, nor prettyprint for
parquet. these are not
vertexclique edited a comment on pull request #7873:
URL: https://github.com/apache/arrow/pull/7873#issuecomment-668032973
Parquet crate is using arrow's default features which are `default =
["flight", "prettyprint"]` but flight is not needed, nor prettyprint for
parquet. these are not
jorisvandenbossche commented on pull request #7891:
URL: https://github.com/apache/arrow/pull/7891#issuecomment-668041763
@github-actions crossbow submit test-conda-python-3.7-kartothek-latest
test-conda-python-3.7-kartothek-master
vertexclique commented on pull request #7874:
URL: https://github.com/apache/arrow/pull/7874#issuecomment-667906216
Is this ok @andygrove ? Can we merge this one as it is?
This is an automated message from the Apache Git
vertexclique commented on pull request #7873:
URL: https://github.com/apache/arrow/pull/7873#issuecomment-667907467
I really want to merge this PR to get rid of flight and it's dependencies
while compiling parquet. My local tests and usage of this version didn't cause
any problems and
tianchen92 opened a new pull request #7887:
URL: https://github.com/apache/arrow/pull/7887
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#issuecomment-667917796
https://issues.apache.org/jira/browse/ARROW-9304
This is an automated message from the Apache Git
zacqed closed issue #7882:
URL: https://github.com/apache/arrow/issues/7882
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
zacqed commented on issue #7882:
URL: https://github.com/apache/arrow/issues/7882#issuecomment-667924646
https://issues.apache.org/jira/browse/ARROW-9623. Closing this.
This is an automated message from the Apache Git
liyafan82 commented on pull request #7248:
URL: https://github.com/apache/arrow/pull/7248#issuecomment-667985790
> @liyafan82 looks like CI is failing from this change?
@emkornfield Thanks a lot for your kind reminder.
The CI was failing because we did not support LargeListVector
github-actions[bot] commented on pull request #7889:
URL: https://github.com/apache/arrow/pull/7889#issuecomment-667985980
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
jhorstmann commented on pull request #7874:
URL: https://github.com/apache/arrow/pull/7874#issuecomment-668038574
The names proposed by @andygrove sound very clear to me. I also don't think
there is a need for a method that includes additional attributes as that
overhead should be
github-actions[bot] commented on pull request #7891:
URL: https://github.com/apache/arrow/pull/7891#issuecomment-668042609
Revision: b9a439c20d5872b30ff054be5f5dcdb07810fd32
Submitted crossbow builds: [ursa-labs/crossbow @
vertexclique edited a comment on pull request #7873:
URL: https://github.com/apache/arrow/pull/7873#issuecomment-668050755
@andygrove Exactly! This is the problem we are having with the default
feature gating scheme that arrow has, which scattered to arrow dependant crates.
alamb closed pull request #7889:
URL: https://github.com/apache/arrow/pull/7889
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb commented on pull request #7889:
URL: https://github.com/apache/arrow/pull/7889#issuecomment-668051529
All the tests pass, so nothing was learned. Closing this PR. Sorry for the
noise
This is an automated message from
andygrove commented on pull request #7873:
URL: https://github.com/apache/arrow/pull/7873#issuecomment-668052705
https://issues.apache.org/jira/browse/ARROW-9631
This is an automated message from the Apache Git Service.
To
vertexclique edited a comment on pull request #7873:
URL: https://github.com/apache/arrow/pull/7873#issuecomment-668054877
@andygrove hold on I will open a pr for that too :)
This is an automated message from the Apache Git
tianchen92 commented on pull request #7861:
URL: https://github.com/apache/arrow/pull/7861#issuecomment-667909215
+1, the build error is unrelated, I'll merge tomorrow.
This is an automated message from the Apache Git
jorisvandenbossche opened a new pull request #7891:
URL: https://github.com/apache/arrow/pull/7891
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
andygrove commented on pull request #7873:
URL: https://github.com/apache/arrow/pull/7873#issuecomment-668028652
I had a general question ... it seems inverted that arrow depends on flight.
I wonder if we have the dependency the wrong way around?
vertexclique commented on pull request #7873:
URL: https://github.com/apache/arrow/pull/7873#issuecomment-668054877
@andygrove hold on I will open a pr for that too
This is an automated message from the Apache Git Service.
tvamsikalyan commented on pull request #7886:
URL: https://github.com/apache/arrow/pull/7886#issuecomment-668006359
looks good to me
This is an automated message from the Apache Git Service.
To respond to the message, please
vertexclique commented on pull request #7874:
URL: https://github.com/apache/arrow/pull/7874#issuecomment-668039525
> My original requirement was for a method that would tell me how much
physical memory is occupied by an array's buffers. I would call this something
like
github-actions[bot] commented on pull request #7891:
URL: https://github.com/apache/arrow/pull/7891#issuecomment-668184404
Revision: c9343cb57685e6deb5ec5e871e4cbf1d8bc38138
Submitted crossbow builds: [ursa-labs/crossbow @
kou commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r464651784
##
File path: cpp/src/arrow/array/util.cc
##
@@ -74,6 +74,186 @@ class ArrayDataWrapper {
std::shared_ptr* out_;
};
+class ArrayDataEndianSwapper {
+
github-actions[bot] commented on pull request #7896:
URL: https://github.com/apache/arrow/pull/7896#issuecomment-668246598
https://issues.apache.org/jira/browse/ARROW-9609
This is an automated message from the Apache Git
nealrichardson commented on a change in pull request #7896:
URL: https://github.com/apache/arrow/pull/7896#discussion_r464676677
##
File path: cpp/src/arrow/dataset/file_csv.cc
##
@@ -39,49 +41,92 @@ namespace dataset {
using internal::checked_cast;
using
wesm closed pull request #7822:
URL: https://github.com/apache/arrow/pull/7822
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jorisvandenbossche commented on pull request #7891:
URL: https://github.com/apache/arrow/pull/7891#issuecomment-668183196
@github-actions crossbow submit test-conda-python-3.7-kartothek-latest
test-conda-python-3.7-kartothek-master
bkietz commented on pull request #7896:
URL: https://github.com/apache/arrow/pull/7896#issuecomment-668244882
@pitrou
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
bkietz opened a new pull request #7896:
URL: https://github.com/apache/arrow/pull/7896
`ConvertOptions::include_missing_columns = true` was insufficient to produce
the required behavior with missing columns: we need to read the csv file's
header to find the names of columns actually
patrickpai commented on a change in pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#discussion_r464602366
##
File path: cpp/src/arrow/util/compression.cc
##
@@ -131,7 +131,7 @@ Result>
Codec::Create(Compression::type codec_type,
if
kou commented on pull request #7818:
URL: https://github.com/apache/arrow/pull/7818#issuecomment-668198167
OK.
I'll merge this.
Thanks.
This is an automated message from the Apache Git Service.
To respond to the
kou closed pull request #7818:
URL: https://github.com/apache/arrow/pull/7818
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou closed pull request #7890:
URL: https://github.com/apache/arrow/pull/7890
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou commented on a change in pull request #7890:
URL: https://github.com/apache/arrow/pull/7890#discussion_r464623956
##
File path: python/pyarrow/tests/test_fs.py
##
@@ -789,6 +789,9 @@ def test_move_directory(fs, pathfn, allow_move_dir):
def test_move_file(fs, pathfn):
jorisvandenbossche commented on pull request #7891:
URL: https://github.com/apache/arrow/pull/7891#issuecomment-668209458
The tests now run, but there are some actual failures now: see eg
https://github.com/ursa-labs/crossbow/runs/941860497?check_suite_focus=true
jorisvandenbossche commented on pull request #7890:
URL: https://github.com/apache/arrow/pull/7890#issuecomment-668209649
> I'll merge this without closing the associated JIRA issue.
We can reuse ARROW-9621 later.
Perfect, thanks!
wqc200 closed pull request #7895:
URL: https://github.com/apache/arrow/pull/7895
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mrkn commented on a change in pull request #7747:
URL: https://github.com/apache/arrow/pull/7747#discussion_r464747555
##
File path: c_glib/arrow-glib/array-builder.cpp
##
@@ -3914,6 +4023,466 @@
garrow_time64_array_builder_append_nulls(GArrowTime64ArrayBuilder *builder,
}
andygrove commented on pull request #7892:
URL: https://github.com/apache/arrow/pull/7892#issuecomment-668328654
@vertexclique I would prefer to have this PR only change the dependency
between arrow and flight. This is quite a large change in itself. We can create
follow-on PRs to make
kiszk commented on a change in pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#discussion_r464803006
##
File path: cpp/src/arrow/util/compression_lz4.cc
##
@@ -349,6 +351,96 @@ class Lz4Codec : public Codec {
const char* name() const override { return
kiszk commented on a change in pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#discussion_r464803006
##
File path: cpp/src/arrow/util/compression_lz4.cc
##
@@ -349,6 +351,96 @@ class Lz4Codec : public Codec {
const char* name() const override { return
kiszk commented on a change in pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#discussion_r464803006
##
File path: cpp/src/arrow/util/compression_lz4.cc
##
@@ -349,6 +351,96 @@ class Lz4Codec : public Codec {
const char* name() const override { return
bkietz commented on a change in pull request #7896:
URL: https://github.com/apache/arrow/pull/7896#discussion_r464742390
##
File path: cpp/src/arrow/dataset/file_csv.cc
##
@@ -39,49 +41,92 @@ namespace dataset {
using internal::checked_cast;
using
kou opened a new pull request #7897:
URL: https://github.com/apache/arrow/pull/7897
This avoids building Red Arrow 1.0.0 with Arrow GLib 0.17.1.
This is an automated message from the Apache Git Service.
To respond to the
kou commented on a change in pull request #7747:
URL: https://github.com/apache/arrow/pull/7747#discussion_r464746088
##
File path: c_glib/arrow-glib/array-builder.cpp
##
@@ -3914,6 +4023,466 @@
garrow_time64_array_builder_append_nulls(GArrowTime64ArrayBuilder *builder,
}
mrkn commented on a change in pull request #7747:
URL: https://github.com/apache/arrow/pull/7747#discussion_r464740479
##
File path: c_glib/arrow-glib/array-builder.cpp
##
@@ -3914,6 +4023,466 @@
garrow_time64_array_builder_append_nulls(GArrowTime64ArrayBuilder *builder,
}
github-actions[bot] commented on pull request #7897:
URL: https://github.com/apache/arrow/pull/7897#issuecomment-668370675
https://issues.apache.org/jira/browse/ARROW-9639
This is an automated message from the Apache Git
emkornfield commented on a change in pull request #7872:
URL: https://github.com/apache/arrow/pull/7872#discussion_r464793815
##
File path: cpp/src/gandiva/precompiled/arithmetic_ops_test.cc
##
@@ -101,4 +101,31 @@ TEST(TestArithmeticOps, TestDiv) {
context.Reset();
}
praveenbingo closed pull request #7886:
URL: https://github.com/apache/arrow/pull/7886
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kou commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-667836959
@github-actions crossbow submit centos-* wheel-win-*
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #7842:
URL: https://github.com/apache/arrow/pull/7842#issuecomment-667837678
Revision: 5617d5b27041a8c4beba8cd4e29d0f0c5929c17d
Submitted crossbow builds: [ursa-labs/crossbow @
GPSnoopy commented on pull request #7818:
URL: https://github.com/apache/arrow/pull/7818#issuecomment-667902430
Hi @kou,
The vcpkg PR has been merged. I think we can merge this PR if you want.
This is an automated
96 matches
Mail list logo
