[GitHub] [arrow] emkornfield commented on a change in pull request #7885: ARROW-9640: [C++][Gandiva] Implement round() for integers and long integers

2020-08-05 Thread GitBox
emkornfield commented on a change in pull request #7885: URL: https://github.com/apache/arrow/pull/7885#discussion_r465485532 ## File path: cpp/src/gandiva/precompiled/arithmetic_ops.cc ## @@ -234,6 +234,25 @@ DIV_FLOAT(float64) #undef DIV_FLOAT +#define ROUND(TYPE)

[GitHub] [arrow] kiszk commented on a change in pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian

2020-08-05 Thread GitBox
kiszk commented on a change in pull request #7507: URL: https://github.com/apache/arrow/pull/7507#discussion_r465505197 ## File path: cpp/src/arrow/ipc/reader.cc ## @@ -449,7 +449,7 @@ Result> LoadRecordBatchSubset( const flatbuf::RecordBatch* metadata, const

[GitHub] [arrow] github-actions[bot] commented on pull request #7903: ARROW-9643: [C++] Only register the SIMD variants when it's supported.

2020-08-05 Thread GitBox
github-actions[bot] commented on pull request #7903: URL: https://github.com/apache/arrow/pull/7903#issuecomment-669047146 https://issues.apache.org/jira/browse/ARROW-9643 This is an automated message from the Apache Git

[GitHub] [arrow] jianxind opened a new pull request #7903: ARROW-9643: [C++] only call the SIMD register when it's suppored.

2020-08-05 Thread GitBox
jianxind opened a new pull request #7903: URL: https://github.com/apache/arrow/pull/7903 Compiler may use advanced instruction just for a register routine. Signed-off-by: Frank Du This is an automated message from

[GitHub] [arrow] jianxind commented on pull request #7871: ARROW-9605: [C++] Speed up aggregate min/max compute kernels on integer types

2020-08-05 Thread GitBox
jianxind commented on pull request #7871: URL: https://github.com/apache/arrow/pull/7871#issuecomment-669047527 Need a rebase after https://github.com/apache/arrow/pull/7903 This is an automated message from the Apache Git

[GitHub] [arrow] sagnikc-dremio commented on a change in pull request #7885: ARROW-9640: [C++][Gandiva] Implement round() for integers and long integers

2020-08-05 Thread GitBox
sagnikc-dremio commented on a change in pull request #7885: URL: https://github.com/apache/arrow/pull/7885#discussion_r465496907 ## File path: cpp/src/gandiva/precompiled/extended_math_ops_test.cc ## @@ -87,6 +87,19 @@ TEST(TestExtendedMathOps, TestLogWithBase) {

[GitHub] [arrow] kiszk commented on a change in pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian

2020-08-05 Thread GitBox
kiszk commented on a change in pull request #7507: URL: https://github.com/apache/arrow/pull/7507#discussion_r465505197 ## File path: cpp/src/arrow/ipc/reader.cc ## @@ -449,7 +449,7 @@ Result> LoadRecordBatchSubset( const flatbuf::RecordBatch* metadata, const

[GitHub] [arrow] jianxind commented on pull request #7903: ARROW-9643: [C++] only call the SIMD register when it's suppored.

2020-08-05 Thread GitBox
jianxind commented on pull request #7903: URL: https://github.com/apache/arrow/pull/7903#issuecomment-669045010 cc @cyb70289 @wesm This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] cyb70289 commented on pull request #7903: ARROW-9643: [C++] Only register the SIMD variants when it's supported.

2020-08-05 Thread GitBox
cyb70289 commented on pull request #7903: URL: https://github.com/apache/arrow/pull/7903#issuecomment-669078062 Validated okay on Haswell This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] emkornfield commented on a change in pull request #7815: ARROW-9536: [Java] Miss parameters in PlasmaOutOfMemoryException.java

2020-08-05 Thread GitBox
emkornfield commented on a change in pull request #7815: URL: https://github.com/apache/arrow/pull/7815#discussion_r466162890 ## File path: java/plasma/src/test/java/org/apache/arrow/plasma/PlasmaClientTest.java ## @@ -277,6 +278,20 @@ public void doByteBufferTest() {

[GitHub] [arrow] arw2019 commented on pull request #7822: ARROW-9096: [Python] Pandas roundtrip with dtype="object" underlying numeric column index

2020-08-05 Thread GitBox
arw2019 commented on pull request #7822: URL: https://github.com/apache/arrow/pull/7822#issuecomment-669656466 thanks @wesm @emkornfield for reviewing!! This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] andygrove commented on pull request #7894: ARROW-9631: [Rust] Make arrow not depend on flight

2020-08-05 Thread GitBox
andygrove commented on pull request #7894: URL: https://github.com/apache/arrow/pull/7894#issuecomment-669233005 @vertexclique I pulled your branch and was able to reproduce the issue by trying to run the datafusion example. The issue is that you changed the datafusion crate to use

[GitHub] [arrow] pitrou commented on a change in pull request #7789: PARQUET-1878: [C++] lz4 codec is not compatible with Hadoop Lz4Codec

2020-08-05 Thread GitBox
pitrou commented on a change in pull request #7789: URL: https://github.com/apache/arrow/pull/7789#discussion_r465764598 ## File path: cpp/src/arrow/util/compression_lz4.cc ## @@ -349,6 +351,96 @@ class Lz4Codec : public Codec { const char* name() const override { return

[GitHub] [arrow] pitrou commented on pull request #7901: ARROW-9543: [C++] Simplify parsing/formatting utilities

2020-08-05 Thread GitBox
pitrou commented on pull request #7901: URL: https://github.com/apache/arrow/pull/7901#issuecomment-669219582 It seems that micro-benchmark performance is regressing with this PR, at least here (clang 9.0, AMD Ryzen): * before: ``` IntegerParsing2396 ns

[GitHub] [arrow] pitrou opened a new pull request #7904: ARROW-9577: [C++] Better error message for posix_madvise()

2020-08-05 Thread GitBox
pitrou opened a new pull request #7904: URL: https://github.com/apache/arrow/pull/7904 posix_madvise() gives its error status as return value, not as errno, so the error message would look like "[errno 0] Success". This doesn't fix the issue reported in ARROW-9577, but should at

[GitHub] [arrow] alamb opened a new pull request #7905: ARROW-9656: [Rust] [DataFusion] Better error messages for unsupported EXTERNAL TABLE types

2020-08-05 Thread GitBox
alamb opened a new pull request #7905: URL: https://github.com/apache/arrow/pull/7905 Previously, the error message for an invalid CREATE EXTERNAL TABLE command told the user there was a problem but not how to fix it. This PR improves the error message and adds some parser tests.

[GitHub] [arrow] pitrou commented on a change in pull request #7866: ARROW-7218: [Python] Conversion from boolean numpy scalars not working

2020-08-05 Thread GitBox
pitrou commented on a change in pull request #7866: URL: https://github.com/apache/arrow/pull/7866#discussion_r465747920 ## File path: python/pyarrow/tests/test_convert_builtin.py ## @@ -182,6 +182,19 @@ def test_sequence_numpy_boolean(seq): assert arr.to_pylist() ==

[GitHub] [arrow] bkietz commented on a change in pull request #7901: ARROW-9543: [C++] Simplify parsing/formatting utilities

2020-08-05 Thread GitBox
bkietz commented on a change in pull request #7901: URL: https://github.com/apache/arrow/pull/7901#discussion_r465750819 ## File path: cpp/src/arrow/util/formatting.cc ## @@ -36,38 +31,29 @@ const char digit_pairs[] = "6061626364656667686970717273747576777879"

[GitHub] [arrow] github-actions[bot] commented on pull request #7904: ARROW-9577: [C++] Better error message for posix_madvise()

2020-08-05 Thread GitBox
github-actions[bot] commented on pull request #7904: URL: https://github.com/apache/arrow/pull/7904#issuecomment-669188509 https://issues.apache.org/jira/browse/ARROW-9577 This is an automated message from the Apache Git

[GitHub] [arrow] pitrou commented on a change in pull request #7901: ARROW-9543: [C++] Simplify parsing/formatting utilities

2020-08-05 Thread GitBox
pitrou commented on a change in pull request #7901: URL: https://github.com/apache/arrow/pull/7901#discussion_r465753604 ## File path: cpp/src/arrow/util/formatting.h ## @@ -40,12 +40,51 @@ namespace arrow { namespace internal { /// \brief The entry point for conversion to

[GitHub] [arrow] pitrou commented on a change in pull request #7891: ARROW-9629: [Python] Fix kartothek integration tests by fixing dependencies

2020-08-05 Thread GitBox
pitrou commented on a change in pull request #7891: URL: https://github.com/apache/arrow/pull/7891#discussion_r465746913 ## File path: ci/docker/conda-python-kartothek.dockerfile ## @@ -32,7 +32,14 @@ RUN conda install -c conda-forge -q \ storefact \ toolz \

[GitHub] [arrow] bkietz commented on a change in pull request #7901: ARROW-9543: [C++] Simplify parsing/formatting utilities

2020-08-05 Thread GitBox
bkietz commented on a change in pull request #7901: URL: https://github.com/apache/arrow/pull/7901#discussion_r465748964 ## File path: cpp/src/arrow/util/formatting.h ## @@ -40,12 +40,51 @@ namespace arrow { namespace internal { /// \brief The entry point for conversion to

[GitHub] [arrow] github-actions[bot] commented on pull request #7905: ARROW-9656: [Rust] [DataFusion] Better error messages for unsupported EXTERNAL TABLE types

2020-08-05 Thread GitBox
github-actions[bot] commented on pull request #7905: URL: https://github.com/apache/arrow/pull/7905#issuecomment-669247235 https://issues.apache.org/jira/browse/ARROW-9656 This is an automated message from the Apache Git

[GitHub] [arrow] bkietz commented on a change in pull request #7901: ARROW-9543: [C++] Simplify parsing/formatting utilities

2020-08-05 Thread GitBox
bkietz commented on a change in pull request #7901: URL: https://github.com/apache/arrow/pull/7901#discussion_r465751971 ## File path: cpp/src/arrow/util/formatting.cc ## @@ -36,38 +31,29 @@ const char digit_pairs[] = "6061626364656667686970717273747576777879"

[GitHub] [arrow] cyb70289 commented on a change in pull request #7903: ARROW-9643: [C++] Only register the SIMD variants when it's supported.

2020-08-05 Thread GitBox
cyb70289 commented on a change in pull request #7903: URL: https://github.com/apache/arrow/pull/7903#discussion_r465597132 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc ## @@ -396,11 +397,16 @@ void RegisterScalarAggregateBasic(FunctionRegistry* registry) {

[GitHub] [arrow] liyafan82 commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-08-05 Thread GitBox
liyafan82 commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r465613604 ## File path: java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionCodec.java ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache

[GitHub] [arrow] liyafan82 commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-08-05 Thread GitBox
liyafan82 commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r465613822 ## File path: java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionUtility.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] [arrow] liyafan82 commented on pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-08-05 Thread GitBox
liyafan82 commented on pull request #7326: URL: https://github.com/apache/arrow/pull/7326#issuecomment-669111978 > At the very least I think this needs more comments as to why it appears that manual serializion of flatbuffer data is being used. > > It would also be nice to avoid

[GitHub] [arrow] vertexclique commented on pull request #7894: ARROW-9631: [Rust] Make arrow not depend on flight

2020-08-05 Thread GitBox
vertexclique commented on pull request #7894: URL: https://github.com/apache/arrow/pull/7894#issuecomment-669145958 I don't see these errors when I ran all these tests locally. I am unsure why this is happening. @andygrove ``` error[E0432]: unresolved import `parquet::arrow`

[GitHub] [arrow] romainfrancois removed a comment on pull request #7819: ARROW-9405: [R] Switch to cpp11

2020-08-05 Thread GitBox
romainfrancois removed a comment on pull request #7819: URL: https://github.com/apache/arrow/pull/7819#issuecomment-668608898 I somehow lost the ability to lint locally: ``` r % CLANG_FORMAT=$(which clang-format) ./lint.sh Traceback (most recent call last): File

[GitHub] [arrow] pitrou commented on a change in pull request #7803: ARROW-9517: [C++/Python] Add optional session_token to S3Options

2020-08-05 Thread GitBox
pitrou commented on a change in pull request #7803: URL: https://github.com/apache/arrow/pull/7803#discussion_r465782709 ## File path: python/pyarrow/_s3fs.pyx ## @@ -105,9 +105,14 @@ cdef class S3FileSystem(FileSystem): raise ValueError(

[GitHub] [arrow] pitrou commented on a change in pull request #7803: ARROW-9517: [C++/Python] Add optional session_token to S3Options

2020-08-05 Thread GitBox
pitrou commented on a change in pull request #7803: URL: https://github.com/apache/arrow/pull/7803#discussion_r465781641 ## File path: python/pyarrow/_s3fs.pyx ## @@ -81,9 +81,9 @@ cdef class S3FileSystem(FileSystem): cdef: CS3FileSystem* s3fs -def

[GitHub] [arrow] pitrou commented on a change in pull request #7901: ARROW-9543: [C++] Simplify parsing/formatting utilities

2020-08-05 Thread GitBox
pitrou commented on a change in pull request #7901: URL: https://github.com/apache/arrow/pull/7901#discussion_r465734624 ## File path: cpp/src/arrow/util/formatting.h ## @@ -40,12 +40,51 @@ namespace arrow { namespace internal { /// \brief The entry point for conversion to

[GitHub] [arrow] liyafan82 commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-08-05 Thread GitBox
liyafan82 commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r465621351 ## File path: java/vector/src/main/java/org/apache/arrow/vector/ipc/message/MessageSerializer.java ## @@ -403,16 +421,29 @@ public static

[GitHub] [arrow] liyafan82 commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-08-05 Thread GitBox
liyafan82 commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r465621861 ## File path: java/flight/flight-core/src/main/java/org/apache/arrow/flight/ArrowMessage.java ## @@ -353,6 +361,23 @@ private InputStream

[GitHub] [arrow] liyafan82 commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-08-05 Thread GitBox
liyafan82 commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r465621532 ## File path: java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionCodec.java ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache

[GitHub] [arrow] jianxind commented on a change in pull request #7903: ARROW-9643: [C++] Only register the SIMD variants when it's supported.

2020-08-05 Thread GitBox
jianxind commented on a change in pull request #7903: URL: https://github.com/apache/arrow/pull/7903#discussion_r465600581 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc ## @@ -396,11 +397,16 @@ void RegisterScalarAggregateBasic(FunctionRegistry* registry) {

[GitHub] [arrow] liyafan82 commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-08-05 Thread GitBox
liyafan82 commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r465622563 ## File path: java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowBodyCompression.java ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache

[GitHub] [arrow] liyafan82 commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-08-05 Thread GitBox
liyafan82 commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r465622358 ## File path: java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowBodyCompression.java ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache

[GitHub] [arrow] nevi-me commented on pull request #7319: ARROW-8289: [Rust] Parquet Arrow writer with nested support

2020-08-05 Thread GitBox
nevi-me commented on pull request #7319: URL: https://github.com/apache/arrow/pull/7319#issuecomment-669128126 @maxburke there's been some interest from other people on this PR. I haven't been able to continue working on it because where I have a bit of free time I've been looking at the

[GitHub] [arrow] liyafan82 commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-08-05 Thread GitBox
liyafan82 commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r465618946 ## File path: java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowRecordBatch.java ## @@ -232,6 +252,12 @@ public long

[GitHub] [arrow] liyafan82 commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-08-05 Thread GitBox
liyafan82 commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r465621351 ## File path: java/vector/src/main/java/org/apache/arrow/vector/ipc/message/MessageSerializer.java ## @@ -403,16 +421,29 @@ public static

[GitHub] [arrow] liyafan82 commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-08-05 Thread GitBox
liyafan82 commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r465619410 ## File path: java/vector/src/main/java/org/apache/arrow/vector/ipc/message/MessageSerializer.java ## @@ -266,8 +266,15 @@ public static ArrowBlock

[GitHub] [arrow] liyafan82 commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-08-05 Thread GitBox
liyafan82 commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r465619212 ## File path: java/vector/src/main/java/org/apache/arrow/vector/ipc/message/MessageSerializer.java ## @@ -266,8 +266,15 @@ public static ArrowBlock

[GitHub] [arrow] liyafan82 commented on pull request #7248: ARROW-8402: [Java] Support ValidateFull methods in Java

2020-08-05 Thread GitBox
liyafan82 commented on pull request #7248: URL: https://github.com/apache/arrow/pull/7248#issuecomment-669150653 @rymurr Thanks a lot for your feedback. We have added support for LargeList. Do you have any more comments?

[GitHub] [arrow] pitrou commented on pull request #7868: ARROW-9429: [Python] ChunkedArray.to_numpy

2020-08-05 Thread GitBox
pitrou commented on pull request #7868: URL: https://github.com/apache/arrow/pull/7868#issuecomment-669257856 @kszucs Can you rebase this PR? Hopefully it will fix AppVeyor. This is an automated message from the Apache Git

[GitHub] [arrow] pitrou commented on a change in pull request #7868: ARROW-9429: [Python] ChunkedArray.to_numpy

2020-08-05 Thread GitBox
pitrou commented on a change in pull request #7868: URL: https://github.com/apache/arrow/pull/7868#discussion_r46580 ## File path: python/pyarrow/table.pxi ## @@ -226,24 +226,34 @@ cdef class ChunkedArray(_PandasConvertible): def _to_pandas(self, options, **kwargs):

[GitHub] [arrow] pitrou commented on a change in pull request #7868: ARROW-9429: [Python] ChunkedArray.to_numpy

2020-08-05 Thread GitBox
pitrou commented on a change in pull request #7868: URL: https://github.com/apache/arrow/pull/7868#discussion_r465810996 ## File path: python/pyarrow/table.pxi ## @@ -425,31 +438,35 @@ def chunked_array(arrays, type=None): Array arr vector[shared_ptr[CArray]]

[GitHub] [arrow] alamb commented on a change in pull request #7906: ARROW-9652: [Rust][DataFusion] Error message rather than panic for external csv tables with no column defs

2020-08-05 Thread GitBox
alamb commented on a change in pull request #7906: URL: https://github.com/apache/arrow/pull/7906#discussion_r465840928 ## File path: rust/datafusion/src/execution/context.rs ## @@ -195,43 +169,6 @@ impl ExecutionContext { _functions } -fn build_schema(,

[GitHub] [arrow] github-actions[bot] commented on pull request #7906: ARROW-9652: [Rust][DataFusion] Error message rather than panic for external csv tables with no column defs

2020-08-05 Thread GitBox
github-actions[bot] commented on pull request #7906: URL: https://github.com/apache/arrow/pull/7906#issuecomment-669289126 https://issues.apache.org/jira/browse/ARROW-9652 This is an automated message from the Apache Git

[GitHub] [arrow] pitrou commented on pull request #7784: ARROW-9402: [C++] Rework portable wrappers for checked integer arithmetic

2020-08-05 Thread GitBox
pitrou commented on pull request #7784: URL: https://github.com/apache/arrow/pull/7784#issuecomment-66933 Rebased. @wesm could you perhaps review this? This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] jhorstmann commented on a change in pull request #7876: ARROW-9615: [Rust] Added kernel to compute length of a string.

2020-08-05 Thread GitBox
jhorstmann commented on a change in pull request #7876: URL: https://github.com/apache/arrow/pull/7876#discussion_r465857294 ## File path: rust/arrow/src/compute/kernels/length.rs ## @@ -0,0 +1,185 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] pitrou commented on pull request #7784: ARROW-9402: [C++] Rework portable wrappers for checked integer arithmetic

2020-08-05 Thread GitBox
pitrou commented on pull request #7784: URL: https://github.com/apache/arrow/pull/7784#issuecomment-669322336 Or perhaps @bkietz . This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] kiszk commented on a change in pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian

2020-08-05 Thread GitBox
kiszk commented on a change in pull request #7507: URL: https://github.com/apache/arrow/pull/7507#discussion_r465839089 ## File path: cpp/src/arrow/ipc/reader.cc ## @@ -449,7 +449,7 @@ Result> LoadRecordBatchSubset( const flatbuf::RecordBatch* metadata, const

[GitHub] [arrow] kiszk commented on a change in pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian

2020-08-05 Thread GitBox
kiszk commented on a change in pull request #7507: URL: https://github.com/apache/arrow/pull/7507#discussion_r465839089 ## File path: cpp/src/arrow/ipc/reader.cc ## @@ -449,7 +449,7 @@ Result> LoadRecordBatchSubset( const flatbuf::RecordBatch* metadata, const

[GitHub] [arrow] alamb opened a new pull request #7906: ARROW-9652: Error message rather than panic csv with no column defs

2020-08-05 Thread GitBox
alamb opened a new pull request #7906: URL: https://github.com/apache/arrow/pull/7906 This PR builds on https://github.com/apache/arrow/pull/7905 to do two things: 1. Make better error messages for CREATE EXTERNAL TABLE commands that are not semantically valid and prevents a subsequent

[GitHub] [arrow] bkietz opened a new pull request #7907: ARROW-9644: [C++][Dataset] Don't apply ignore_prefixes to partition base_dir

2020-08-05 Thread GitBox
bkietz opened a new pull request #7907: URL: https://github.com/apache/arrow/pull/7907 I still apply ignore_prefixes to all segments of paths yielded by a selector which lie *outside* an explicit partition base directory.

[GitHub] [arrow] github-actions[bot] commented on pull request #7907: ARROW-9644: [C++][Dataset] Don't apply ignore_prefixes to partition base_dir

2020-08-05 Thread GitBox
github-actions[bot] commented on pull request #7907: URL: https://github.com/apache/arrow/pull/7907#issuecomment-669516018 https://issues.apache.org/jira/browse/ARROW-9644 This is an automated message from the Apache Git

[GitHub] [arrow] lidavidm opened a new pull request #7908: ARROW-9358: [Integration] remove generated_large_batch.json

2020-08-05 Thread GitBox
lidavidm opened a new pull request #7908: URL: https://github.com/apache/arrow/pull/7908 This should speed up integration tests by moving the expensive large batch test to the individual Flight implementations. This is an

[GitHub] [arrow] github-actions[bot] commented on pull request #7908: ARROW-9358: [Integration] remove generated_large_batch.json

2020-08-05 Thread GitBox
github-actions[bot] commented on pull request #7908: URL: https://github.com/apache/arrow/pull/7908#issuecomment-669522949 https://issues.apache.org/jira/browse/ARROW-9358 This is an automated message from the Apache Git

[GitHub] [arrow] bkietz closed pull request #7869: ARROW-8002: [C++][Dataset][R] Support partitioned dataset writing

2020-08-05 Thread GitBox
bkietz closed pull request #7869: URL: https://github.com/apache/arrow/pull/7869 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] github-actions[bot] commented on pull request #7909: ARROW-9659: [C++] Fix RecordBatchStreamReader when source is CudaBufferReader

2020-08-05 Thread GitBox
github-actions[bot] commented on pull request #7909: URL: https://github.com/apache/arrow/pull/7909#issuecomment-669549486 https://issues.apache.org/jira/browse/ARROW-9659 This is an automated message from the Apache Git

[GitHub] [arrow] trxcllnt opened a new pull request #7909: ARROW-9659: [C++] RecordBatchStreamReader when source is CudaBufferReader

2020-08-05 Thread GitBox
trxcllnt opened a new pull request #7909: URL: https://github.com/apache/arrow/pull/7909 Related JIRA: [ARROW-9659](https://issues.apache.org/jira/browse/ARROW-9659) Prior to 1.0.0, the `RecordBatchStreamReader` was capable of reading source CudaBuffers wrapped in a

[GitHub] [arrow] trxcllnt commented on pull request #7909: ARROW-9659: [C++] Fix RecordBatchStreamReader when source is CudaBufferReader

2020-08-05 Thread GitBox
trxcllnt commented on pull request #7909: URL: https://github.com/apache/arrow/pull/7909#issuecomment-669551982 cc: @bkietz This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] offthewall123 commented on pull request #7815: ARROW-9536: [Java] Miss parameters in PlasmaOutOfMemoryException.java

2020-08-05 Thread GitBox
offthewall123 commented on pull request #7815: URL: https://github.com/apache/arrow/pull/7815#issuecomment-669629818 > LGTM Hi @rymurr ,will you merge this PR? This is an automated message from the Apache Git Service.