[GitHub] [arrow] kszucs commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-19 Thread GitBox
kszucs commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r491386279 ## File path: cpp/src/arrow/util/converter.h ## @@ -0,0 +1,353 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] kszucs commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-19 Thread GitBox
kszucs commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r491386599 ## File path: cpp/src/arrow/python/python_to_arrow.cc ## @@ -329,186 +300,106 @@ struct ValueConverter { default: return

[GitHub] [arrow] kszucs commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-19 Thread GitBox
kszucs commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r491376858 ## File path: cpp/src/arrow/util/converter.h ## @@ -0,0 +1,353 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] kszucs commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-19 Thread GitBox
kszucs commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r491384129 ## File path: python/pyarrow/includes/libarrow.pxd ## @@ -969,11 +969,13 @@ cdef extern from "arrow/api.h" namespace "arrow" nogil:

[GitHub] [arrow] kszucs commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-19 Thread GitBox
kszucs commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r491368480 ## File path: cpp/src/arrow/util/converter.h ## @@ -0,0 +1,353 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] kszucs commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-19 Thread GitBox
kszucs commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r491377495 ## File path: cpp/src/arrow/util/converter.h ## @@ -0,0 +1,353 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] kszucs commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-19 Thread GitBox
kszucs commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r491377151 ## File path: cpp/src/arrow/util/converter.h ## @@ -0,0 +1,353 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] bkietz commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-19 Thread GitBox
bkietz commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r491397449 ## File path: cpp/src/arrow/util/converter.h ## @@ -0,0 +1,353 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] kszucs commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-19 Thread GitBox
kszucs commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r491304867 ## File path: cpp/src/arrow/python/python_to_arrow.cc ## @@ -329,186 +300,106 @@ struct ValueConverter { default: return

[GitHub] [arrow] kszucs commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-19 Thread GitBox
kszucs commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r491309216 ## File path: cpp/src/arrow/python/python_to_arrow.cc ## @@ -1352,64 +927,40 @@ Status ConvertToSequenceAndInferSize(PyObject* obj, PyObject** seq,

[GitHub] [arrow] jorgecarleitao commented on pull request #8118: ARROW-9922: [Rust] Add StructArray::TryFrom (+40%)

2020-09-19 Thread GitBox
jorgecarleitao commented on pull request #8118: URL: https://github.com/apache/arrow/pull/8118#issuecomment-695335519 @nevi-me and @andygrove , I reverted the change wrt to the builder, so that this is an additive PR. @andygrove, wrt to the dynamically building the array, note that

[GitHub] [arrow] wjones1 commented on pull request #6979: ARROW-7800 [Python] implement iter_batches() method for ParquetFile and ParquetReader

2020-09-19 Thread GitBox
wjones1 commented on pull request #6979: URL: https://github.com/apache/arrow/pull/6979#issuecomment-695343480 I'm back on this for the weekend and will be back as needed the week after next. @jorisvandenbossche I can confirm that once I merge in the latest changes from apache

[GitHub] [arrow] drusso opened a new pull request #8222: ARROW-10043: [Rust][DataFusion] Implement COUNT(DISTINCT col)

2020-09-19 Thread GitBox
drusso opened a new pull request #8222: URL: https://github.com/apache/arrow/pull/8222 This is a proposal for an initial and partial implementation of the `DISTINCT` keyword. Only `COUNT(DISTINCT)` is supported, with the following conditions: (a) only one argument, i.e.

[GitHub] [arrow] github-actions[bot] commented on pull request #8222: ARROW-10043: [Rust][DataFusion] Implement COUNT(DISTINCT col)

2020-09-19 Thread GitBox
github-actions[bot] commented on pull request #8222: URL: https://github.com/apache/arrow/pull/8222#issuecomment-695345313 https://issues.apache.org/jira/browse/ARROW-10043 This is an automated message from the Apache Git

[GitHub] [arrow] nevi-me commented on pull request #8223: ARROW-10040: [Rust] Add slice that realigns Buffer

2020-09-19 Thread GitBox
nevi-me commented on pull request #8223: URL: https://github.com/apache/arrow/pull/8223#issuecomment-695347849 @jhorstmann @paddyhoran this is related to the alignment fixes made recently. I noticed while reviewing another PR that we had a limitation on boolean kernels if offsets weren't

[GitHub] [arrow] github-actions[bot] commented on pull request #8223: ARROW-10040: [Rust] Add slice that realigns Buffer

2020-09-19 Thread GitBox
github-actions[bot] commented on pull request #8223: URL: https://github.com/apache/arrow/pull/8223#issuecomment-695347870 https://issues.apache.org/jira/browse/ARROW-10040 This is an automated message from the Apache Git

[GitHub] [arrow] trxcllnt commented on pull request #2035: ARROW-2116: [JS] implement IPC writers

2020-09-19 Thread GitBox
trxcllnt commented on pull request #2035: URL: https://github.com/apache/arrow/pull/2035#issuecomment-695349165 > @t829702 if JS is not the way to interact with Arrow, then what is the purpose of JS implementation? Is the JS implementation supposed to be read-only uses? My comment

[GitHub] [arrow] arw2019 commented on a change in pull request #6979: ARROW-7800 [Python] implement iter_batches() method for ParquetFile and ParquetReader

2020-09-19 Thread GitBox
arw2019 commented on a change in pull request #6979: URL: https://github.com/apache/arrow/pull/6979#discussion_r491479021 ## File path: python/pyarrow/parquet.py ## @@ -301,6 +301,45 @@ def read_row_groups(self, row_groups, columns=None, use_threads=True,

[GitHub] [arrow] wjones1 commented on a change in pull request #6979: ARROW-7800 [Python] implement iter_batches() method for ParquetFile and ParquetReader

2020-09-19 Thread GitBox
wjones1 commented on a change in pull request #6979: URL: https://github.com/apache/arrow/pull/6979#discussion_r491481801 ## File path: python/pyarrow/parquet.py ## @@ -301,6 +301,45 @@ def read_row_groups(self, row_groups, columns=None, use_threads=True,

[GitHub] [arrow] nevi-me commented on pull request #8221: ARROW-9338: [Rust] Add clippy instructions

2020-09-19 Thread GitBox
nevi-me commented on pull request #8221: URL: https://github.com/apache/arrow/pull/8221#issuecomment-695351599 I'm unable to merge, something wrong with my local setup. @andygrove may you please merge if you see this message

[GitHub] [arrow] emkornfield commented on pull request #8219: ARROW-9603: Fix parquet write

2020-09-19 Thread GitBox
emkornfield commented on pull request #8219: URL: https://github.com/apache/arrow/pull/8219#issuecomment-695392925 Nm, I think this is likely the only reasonable approach. We might consider pushing bitmap building up the stack at some point.

[GitHub] [arrow] bkietz commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-19 Thread GitBox
bkietz commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r491639719 ## File path: python/pyarrow/array.pxi ## @@ -158,24 +158,44 @@ def array(object obj, type=None, mask=None, size=None, from_pandas=None, Notes

[GitHub] [arrow] jorgecarleitao commented on pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

2020-09-19 Thread GitBox
jorgecarleitao commented on pull request #8172: URL: https://github.com/apache/arrow/pull/8172#issuecomment-695358864 @alamb , I tried to take the ScalarValue out of the PR for over 2hs, but I was unable: there is too much dependency on it on the current accumulators, and it would be a

[GitHub] [arrow] jorgecarleitao opened a new pull request #8224: ARROW-10044: [Rust] Improved Arrow's README.

2020-09-19 Thread GitBox
jorgecarleitao opened a new pull request #8224: URL: https://github.com/apache/arrow/pull/8224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] emkornfield commented on pull request #8219: ARROW-9603: Fix parquet write

2020-09-19 Thread GitBox
emkornfield commented on pull request #8219: URL: https://github.com/apache/arrow/pull/8219#issuecomment-695361437 There is a better solution. I'll update the PR This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #8224: ARROW-10044: [Rust] Improved Arrow's README.

2020-09-19 Thread GitBox
github-actions[bot] commented on pull request #8224: URL: https://github.com/apache/arrow/pull/8224#issuecomment-695361993 https://issues.apache.org/jira/browse/ARROW-10044 This is an automated message from the Apache Git