[GitHub] [arrow] ianmcook commented on a change in pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on a change in pull request #9610: URL: https://github.com/apache/arrow/pull/9610#discussion_r587765098 ## File path: r/tools/autobrew ## @@ -48,7 +48,8 @@ fi # Hardcode this for my custom autobrew build rm -f $BREWDIR/lib/*.dylib

[GitHub] [arrow] Dandandan commented on pull request #9588: ARROW-11799: [Rust] fix len of string and binary arrays created from unbound iterator

Dandandan commented on pull request #9588: URL: https://github.com/apache/arrow/pull/9588#issuecomment-790962611 @yordan-pavlov Would be very interested in a faster parquet reader. Was doing some benchmarking with some queries in DataFusion with Parquet, looks like there is a lot to

[GitHub] [arrow] ianmcook commented on pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

ianmcook commented on pull request #9553: URL: https://github.com/apache/arrow/pull/9553#issuecomment-790963128 @kou let me know if there is anything I can do to help you complete your review. Thank you! This is an

[GitHub] [arrow] Dandandan edited a comment on pull request #9588: ARROW-11799: [Rust] fix len of string and binary arrays created from unbound iterator

Dandandan edited a comment on pull request #9588: URL: https://github.com/apache/arrow/pull/9588#issuecomment-790962611 @yordan-pavlov Would be very interested in a faster parquet reader. Was doing some benchmarking with some queries in DataFusion with Parquet, looks like there is a

[GitHub] [arrow] github-actions[bot] commented on pull request #9634: ARROW-11864: [R] Document arrow.int64_downcast option

github-actions[bot] commented on pull request #9634: URL: https://github.com/apache/arrow/pull/9634#issuecomment-790968132 https://issues.apache.org/jira/browse/ARROW-11864 This is an automated message from the Apache Git

[GitHub] [arrow] alamb commented on a change in pull request #9588: ARROW-11799: [Rust] fix len of string and binary arrays created from unbound iterator

alamb commented on a change in pull request #9588: URL: https://github.com/apache/arrow/pull/9588#discussion_r587849026 ## File path: rust/arrow/src/array/array_binary.rs ## @@ -258,6 +258,8 @@ where } } +// calculate actual data_len, which may

[GitHub] [arrow] ianmcook commented on a change in pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

ianmcook commented on a change in pull request #9553: URL: https://github.com/apache/arrow/pull/9553#discussion_r587887231 ## File path: cpp/cmake_modules/Usevcpkg.cmake ## @@ -0,0 +1,214 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [arrow] nealrichardson commented on a change in pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

nealrichardson commented on a change in pull request #9610: URL: https://github.com/apache/arrow/pull/9610#discussion_r587897840 ## File path: dev/tasks/r/azure.linux.yml ## @@ -47,6 +47,9 @@ jobs: export R_ORG={{ r_org }} export R_IMAGE={{ r_image }}

[GitHub] [arrow] ianmcook commented on a change in pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

ianmcook commented on a change in pull request #9553: URL: https://github.com/apache/arrow/pull/9553#discussion_r587898227 ## File path: cpp/cmake_modules/Usevcpkg.cmake ## @@ -0,0 +1,214 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [arrow] martinblostein commented on pull request #9442: ARROW-6818: [DOC] Remove reference to Apache Drill design docs

martinblostein commented on pull request #9442: URL: https://github.com/apache/arrow/pull/9442#issuecomment-791042920 Is there anything I can do here? Seems like low-hanging fruit. This is an automated message from the

[GitHub] [arrow] martinblostein edited a comment on pull request #9442: ARROW-6818: [DOC] Remove reference to Apache Drill design docs

martinblostein edited a comment on pull request #9442: URL: https://github.com/apache/arrow/pull/9442#issuecomment-791042920 Is there anything I can do here? Seems like a straightforward change. This is an automated message

[GitHub] [arrow] alamb commented on a change in pull request #9625: ARROW-11653: [Rust][DataFusion] Postgres String Functions: ascii, chr, initcap, repeat, reverse, to_hex

alamb commented on a change in pull request #9625: URL: https://github.com/apache/arrow/pull/9625#discussion_r587742457 ## File path: rust/datafusion/tests/sql.rs ## @@ -2051,13 +2054,19 @@ async fn test_string_expressions() -> Result<()> {

[GitHub] [arrow] ericwburden closed pull request #9624: ARROW-11845: [Rust] Implement to_isize() for ArrowNativeTypes

ericwburden closed pull request #9624: URL: https://github.com/apache/arrow/pull/9624 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] ovr commented on a change in pull request #9232: ARROW-10818: [Rust] Implement DecimalType

ovr commented on a change in pull request #9232: URL: https://github.com/apache/arrow/pull/9232#discussion_r587848244 ## File path: rust/datafusion/src/physical_plan/group_scalar.rs ## @@ -22,10 +22,12 @@ use std::convert::{From, TryFrom}; use

[GitHub] [arrow] yordan-pavlov edited a comment on pull request #9588: ARROW-11799: [Rust] fix len of string and binary arrays created from unbound iterator

yordan-pavlov edited a comment on pull request #9588: URL: https://github.com/apache/arrow/pull/9588#issuecomment-790979386 @Dandandan I would be happy to collaborate on this; I have been using MS Visual Studio for profiling DataFusion and Arrow, and most of the time it works fairly

[GitHub] [arrow] ianmcook commented on a change in pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

ianmcook commented on a change in pull request #9553: URL: https://github.com/apache/arrow/pull/9553#discussion_r587896214 ## File path: cpp/cmake_modules/Usevcpkg.cmake ## @@ -0,0 +1,214 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [arrow] github-actions[bot] commented on pull request #9579: ARROW-11774: [R] macos one line install

github-actions[bot] commented on pull request #9579: URL: https://github.com/apache/arrow/pull/9579#issuecomment-791031621 Revision: d1f7611e496c99c7c8d9f32c4b0d35fe4fee0b38 Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] ianmcook commented on a change in pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on a change in pull request #9610: URL: https://github.com/apache/arrow/pull/9610#discussion_r587917624 ## File path: dev/tasks/r/azure.linux.yml ## @@ -47,6 +47,9 @@ jobs: export R_ORG={{ r_org }} export R_IMAGE={{ r_image }}

[GitHub] [arrow] ianmcook commented on a change in pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on a change in pull request #9610: URL: https://github.com/apache/arrow/pull/9610#discussion_r587917115 ## File path: dev/tasks/r/azure.linux.yml ## @@ -47,6 +47,9 @@ jobs: export R_ORG={{ r_org }} export R_IMAGE={{ r_image }}

[GitHub] [arrow] jonkeane commented on pull request #9579: ARROW-11774: [R] macos one line install

jonkeane commented on pull request #9579: URL: https://github.com/apache/arrow/pull/9579#issuecomment-791044239 @github-actions crossbow submit test-r-install-macos This is an automated message from the Apache Git Service.

[GitHub] [arrow] ianmcook commented on a change in pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on a change in pull request #9610: URL: https://github.com/apache/arrow/pull/9610#discussion_r587761603 ## File path: r/R/dataset-partition.R ## @@ -76,7 +76,9 @@ HivePartitioning$create <- dataset___HivePartitioning #' calling `hive_partition()` with no

[GitHub] [arrow] ianmcook commented on a change in pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on a change in pull request #9610: URL: https://github.com/apache/arrow/pull/9610#discussion_r587812949 ## File path: dev/tasks/tasks.yml ## @@ -1789,6 +1789,18 @@ tasks: r_image: r-base r_tag: 3.6-opensuse42 not_cran: "TRUE" + +

[GitHub] [arrow] jorgecarleitao commented on pull request #9588: ARROW-11799: [Rust] fix len of string and binary arrays created from unbound iterator

jorgecarleitao commented on pull request #9588: URL: https://github.com/apache/arrow/pull/9588#issuecomment-790980785 fwiw, I strongly agree with you, @yordan-pavlov on _all_ those marks. I recently went through the `arrow/` module of the parquet crate and concluded exactly the same

[GitHub] [arrow] nealrichardson commented on pull request #9621: ARROW-11591: [C++][Compute] Grouped aggregation

nealrichardson commented on pull request #9621: URL: https://github.com/apache/arrow/pull/9621#issuecomment-790998553 With an assist from @bkietz, I've written a very basic R wrapper that exercises this in https://github.com/apache/arrow/commit/aa530cb586462bee98390d129575fe1622ffb222.

[GitHub] [arrow] jonkeane commented on pull request #9579: ARROW-11774: [R] macos one line install

jonkeane commented on pull request #9579: URL: https://github.com/apache/arrow/pull/9579#issuecomment-791031149 @github-actions crossbow submit test-r-install-macos This is an automated message from the Apache Git Service.

[GitHub] [arrow] github-actions[bot] commented on pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

github-actions[bot] commented on pull request #9610: URL: https://github.com/apache/arrow/pull/9610#issuecomment-791036468 Revision: 318371fbaa07f1b6fcdf71f58d7d5460a931da13 Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] lidavidm opened a new pull request #9633: ARROW-11560: [C++][FlightRPC] fix mutex error on SIGINT

lidavidm opened a new pull request #9633: URL: https://github.com/apache/arrow/pull/9633 Recently, interrupting a Python Flight server started aborting the process instead, because gRPC on Linux started using some code which is not signal-safe. This PR fixes that by spawning a separate

[GitHub] [arrow] github-actions[bot] commented on pull request #9633: ARROW-11560: [C++][FlightRPC] fix mutex error on SIGINT

github-actions[bot] commented on pull request #9633: URL: https://github.com/apache/arrow/pull/9633#issuecomment-790919414 https://issues.apache.org/jira/browse/ARROW-11560 This is an automated message from the Apache Git

[GitHub] [arrow] yordan-pavlov commented on pull request #9588: ARROW-11799: [Rust] fix len of string and binary arrays created from unbound iterator

yordan-pavlov commented on pull request #9588: URL: https://github.com/apache/arrow/pull/9588#issuecomment-790979386 @Dandandan I would be happy to collaborate on this; I have been using MS Visual Studio for profiling DataFusion and Arrow, and most of the time it works fairly well and

[GitHub] [arrow] ianmcook commented on pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on pull request #9610: URL: https://github.com/apache/arrow/pull/9610#issuecomment-790887608 @github-actions crossbow submit -g r This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] rok commented on a change in pull request #9606: ARROW-10405: [C++] IsIn kernel should be able to lookup dictionary in string

rok commented on a change in pull request #9606: URL: https://github.com/apache/arrow/pull/9606#discussion_r587790806 ## File path: cpp/src/arrow/compute/kernels/scalar_set_lookup_test.cc ## @@ -231,6 +252,25 @@ TEST_F(TestIsInKernel, Decimal) {

[GitHub] [arrow] rok commented on a change in pull request #9606: ARROW-10405: [C++] IsIn kernel should be able to lookup dictionary in string

rok commented on a change in pull request #9606: URL: https://github.com/apache/arrow/pull/9606#discussion_r587790691 ## File path: cpp/src/arrow/compute/kernels/scalar_set_lookup_test.cc ## @@ -72,6 +72,27 @@ void CheckIsInChunked(const std::shared_ptr& input,

[GitHub] [arrow] msummersgill opened a new pull request #9634: Update R Package Arrow.Rmd vignette to document option(arrow.int64_downcast)

msummersgill opened a new pull request #9634: URL: https://github.com/apache/arrow/pull/9634 Per discussion on https://issues.apache.org/jira/browse/ARROW-9083 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] ianmcook commented on pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on pull request #9610: URL: https://github.com/apache/arrow/pull/9610#issuecomment-790929111 @nealrichardson do you want `LIBARROW_MINIMAL` to toggle Dataset and Parquet? I assume no. This is an automated

[GitHub] [arrow] ianmcook commented on a change in pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

ianmcook commented on a change in pull request #9553: URL: https://github.com/apache/arrow/pull/9553#discussion_r587870368 ## File path: cpp/cmake_modules/Usevcpkg.cmake ## @@ -0,0 +1,214 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [arrow] ianmcook commented on a change in pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

ianmcook commented on a change in pull request #9553: URL: https://github.com/apache/arrow/pull/9553#discussion_r587889678 ## File path: cpp/cmake_modules/Usevcpkg.cmake ## @@ -0,0 +1,214 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [arrow] jonkeane commented on pull request #9579: ARROW-11774: [R] macos one line install

jonkeane commented on pull request #9579: URL: https://github.com/apache/arrow/pull/9579#issuecomment-791014063 @github-actions crossbow submit test-r-install-macos This is an automated message from the Apache Git Service.

[GitHub] [arrow] nealrichardson commented on a change in pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

nealrichardson commented on a change in pull request #9610: URL: https://github.com/apache/arrow/pull/9610#discussion_r587897840 ## File path: dev/tasks/r/azure.linux.yml ## @@ -47,6 +47,9 @@ jobs: export R_ORG={{ r_org }} export R_IMAGE={{ r_image }}

[GitHub] [arrow] jonkeane commented on pull request #9579: ARROW-11774: [R] macos one line install

jonkeane commented on pull request #9579: URL: https://github.com/apache/arrow/pull/9579#issuecomment-791027678 @github-actions crossbow submit test-r-install-macos This is an automated message from the Apache Git Service.

[GitHub] [arrow] nealrichardson commented on pull request #9586: ARROW-11704: [R] Wire up dplyr::mutate() for datasets

nealrichardson commented on pull request #9586: URL: https://github.com/apache/arrow/pull/9586#issuecomment-791039254 I'll add a couple more tests, particularly around error handling, but I'd like to move on to other issues and get this merged so that others can test it out more widely.

[GitHub] [arrow] alamb commented on a change in pull request #9494: ARROW-11626: [Rust][DataFusion] Move [DataFusion] examples to own project

alamb commented on a change in pull request #9494: URL: https://github.com/apache/arrow/pull/9494#discussion_r58078 ## File path: rust/datafusion-examples/Cargo.toml ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [arrow] alamb commented on a change in pull request #9232: ARROW-10818: [Rust] Implement DecimalType

alamb commented on a change in pull request #9232: URL: https://github.com/apache/arrow/pull/9232#discussion_r587851545 ## File path: rust/datafusion/src/physical_plan/group_scalar.rs ## @@ -22,10 +22,12 @@ use std::convert::{From, TryFrom}; use

[GitHub] [arrow] ianmcook commented on a change in pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

ianmcook commented on a change in pull request #9553: URL: https://github.com/apache/arrow/pull/9553#discussion_r587884449 ## File path: cpp/cmake_modules/Usevcpkg.cmake ## @@ -0,0 +1,214 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [arrow] github-actions[bot] commented on pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

github-actions[bot] commented on pull request #9553: URL: https://github.com/apache/arrow/pull/9553#issuecomment-791037231 Revision: d7f0e2236b55ce0ecd2815ccd07e7235288f385b Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] github-actions[bot] commented on pull request #9630: ARROW-11860: [Rust] [DataFusion] Add DataFusion logos

github-actions[bot] commented on pull request #9630: URL: https://github.com/apache/arrow/pull/9630#issuecomment-790895297 https://issues.apache.org/jira/browse/ARROW-11860 This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson commented on a change in pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

nealrichardson commented on a change in pull request #9610: URL: https://github.com/apache/arrow/pull/9610#discussion_r587841807 ## File path: dev/tasks/tasks.yml ## @@ -1789,6 +1789,18 @@ tasks: r_image: r-base r_tag: 3.6-opensuse42 not_cran: "TRUE" + +

[GitHub] [arrow] Dandandan edited a comment on pull request #9588: ARROW-11799: [Rust] fix len of string and binary arrays created from unbound iterator

Dandandan edited a comment on pull request #9588: URL: https://github.com/apache/arrow/pull/9588#issuecomment-790962611 @yordan-pavlov Would be very interested in a faster parquet reader. Was doing some benchmarking with some queries in DataFusion with Parquet, looks like there is a

[GitHub] [arrow] ianmcook commented on pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

ianmcook commented on pull request #9553: URL: https://github.com/apache/arrow/pull/9553#issuecomment-791036882 @github-actions crossbow submit test-build-vcpkg-win wheel-manylinux2010-cp36m wheel-windows-cp36m This is an

[GitHub] [arrow] nealrichardson commented on a change in pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

nealrichardson commented on a change in pull request #9610: URL: https://github.com/apache/arrow/pull/9610#discussion_r587918983 ## File path: dev/tasks/r/azure.linux.yml ## @@ -47,6 +47,9 @@ jobs: export R_ORG={{ r_org }} export R_IMAGE={{ r_image }}

[GitHub] [arrow] pitrou commented on a change in pull request #9633: ARROW-11560: [C++][FlightRPC] fix mutex error on SIGINT

pitrou commented on a change in pull request #9633: URL: https://github.com/apache/arrow/pull/9633#discussion_r587752941 ## File path: cpp/src/arrow/flight/server.cc ## @@ -899,6 +921,13 @@ Status FlightServerBase::Serve() { ARROW_ASSIGN_OR_RAISE(old_handler,

[GitHub] [arrow] alamb commented on a change in pull request #9588: ARROW-11799: [Rust] fix len of string and binary arrays created from unbound iterator

alamb commented on a change in pull request #9588: URL: https://github.com/apache/arrow/pull/9588#discussion_r587764593 ## File path: rust/arrow/src/array/array_binary.rs ## @@ -258,6 +258,8 @@ where } } +// calculate actual data_len, which may

[GitHub] [arrow] alamb commented on a change in pull request #9588: ARROW-11799: [Rust] fix len of string and binary arrays created from unbound iterator

alamb commented on a change in pull request #9588: URL: https://github.com/apache/arrow/pull/9588#discussion_r587764593 ## File path: rust/arrow/src/array/array_binary.rs ## @@ -258,6 +258,8 @@ where } } +// calculate actual data_len, which may

[GitHub] [arrow] ericwburden commented on pull request #9624: ARROW-11845: [Rust] Implement to_isize() for ArrowNativeTypes

ericwburden commented on pull request #9624: URL: https://github.com/apache/arrow/pull/9624#issuecomment-790893609 Sorry, just learned that the "Close" button on my phone didn't mean the window... This is an automated

[GitHub] [arrow] ianmcook commented on pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on pull request #9610: URL: https://github.com/apache/arrow/pull/9610#issuecomment-790925316 @github-actions crossbow submit test-r-minimal-build This is an automated message from the Apache Git Service.

[GitHub] [arrow] trucnguyenlam commented on pull request #9489: ARROW-11497: [Python] Provide parquet enable compliant nested type flag for python binding

trucnguyenlam commented on pull request #9489: URL: https://github.com/apache/arrow/pull/9489#issuecomment-790932818 @jorisvandenbossche could you please have a look at the PR? cheers This is an automated message from the

[GitHub] [arrow] github-actions[bot] commented on pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

github-actions[bot] commented on pull request #9610: URL: https://github.com/apache/arrow/pull/9610#issuecomment-790966208 Revision: 6f70c9911262d5d956c7f4ded49647269af848d9 Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] github-actions[bot] commented on pull request #9634: ARROW-11864: [R] Document arrow.int64_downcast option

github-actions[bot] commented on pull request #9634: URL: https://github.com/apache/arrow/pull/9634#issuecomment-790966162 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then

[GitHub] [arrow] alamb commented on a change in pull request #9232: ARROW-10818: [Rust] Implement DecimalType

alamb commented on a change in pull request #9232: URL: https://github.com/apache/arrow/pull/9232#discussion_r587847557 ## File path: rust/datafusion/src/physical_plan/group_scalar.rs ## @@ -22,10 +22,12 @@ use std::convert::{From, TryFrom}; use

[GitHub] [arrow] ianmcook commented on pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on pull request #9610: URL: https://github.com/apache/arrow/pull/9610#issuecomment-791036107 @github-actions crossbow submit test-r-minimal-build This is an automated message from the Apache Git Service.

[GitHub] [arrow] kou commented on a change in pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

kou commented on a change in pull request #9553: URL: https://github.com/apache/arrow/pull/9553#discussion_r587924707 ## File path: cpp/cmake_modules/Usevcpkg.cmake ## @@ -0,0 +1,214 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [arrow] kou commented on a change in pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

kou commented on a change in pull request #9553: URL: https://github.com/apache/arrow/pull/9553#discussion_r587924544 ## File path: cpp/cmake_modules/Usevcpkg.cmake ## @@ -0,0 +1,214 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [arrow] nealrichardson commented on pull request #9442: ARROW-6818: [DOC] Remove reference to Apache Drill design docs

nealrichardson commented on pull request #9442: URL: https://github.com/apache/arrow/pull/9442#issuecomment-791043943 @pitrou can you give this a review/merge please? This is an automated message from the Apache Git Service.

[GitHub] [arrow] nealrichardson commented on pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

nealrichardson commented on pull request #9610: URL: https://github.com/apache/arrow/pull/9610#issuecomment-790954184 > @nealrichardson do you want `LIBARROW_MINIMAL` to toggle Dataset and Parquet? I assume no. Correct, we don't want to change that meaning (yet).

[GitHub] [arrow] kou commented on a change in pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

kou commented on a change in pull request #9553: URL: https://github.com/apache/arrow/pull/9553#discussion_r584365689 ## File path: cpp/cmake_modules/Usevcpkg.cmake ## @@ -0,0 +1,214 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [arrow] kou commented on pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

kou commented on pull request #9553: URL: https://github.com/apache/arrow/pull/9553#issuecomment-790965856 Oh, sorry for my late review... This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] Dandandan edited a comment on pull request #9588: ARROW-11799: [Rust] fix len of string and binary arrays created from unbound iterator

Dandandan edited a comment on pull request #9588: URL: https://github.com/apache/arrow/pull/9588#issuecomment-790962611 @yordan-pavlov Would be very interested in a faster parquet reader. Was doing some benchmarking with some queries in DataFusion with Parquet, looks like there is a

[GitHub] [arrow] jorgecarleitao commented on pull request #9624: ARROW-11845: [Rust] Implement to_isize() for ArrowNativeTypes

jorgecarleitao commented on pull request #9624: URL: https://github.com/apache/arrow/pull/9624#issuecomment-790976766 fwiw, I think that there is a different way of approaching this. The only reason we are implementing to_isize/to_usize on NativeTpe is because we have a function to

[GitHub] [arrow] yordan-pavlov edited a comment on pull request #9588: ARROW-11799: [Rust] fix len of string and binary arrays created from unbound iterator

yordan-pavlov edited a comment on pull request #9588: URL: https://github.com/apache/arrow/pull/9588#issuecomment-790979386 @Dandandan I would be happy to collaborate on this; I have been using MS Visual Studio for profiling DataFusion and Arrow, and most of the time it works fairly

[GitHub] [arrow] ianmcook commented on a change in pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

ianmcook commented on a change in pull request #9553: URL: https://github.com/apache/arrow/pull/9553#discussion_r587872742 ## File path: cpp/cmake_modules/Usevcpkg.cmake ## @@ -0,0 +1,214 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [arrow] jonkeane commented on pull request #9579: ARROW-11774: [R] macos one line install

jonkeane commented on pull request #9579: URL: https://github.com/apache/arrow/pull/9579#issuecomment-791019223 @github-actions crossbow submit test-r-install-macos This is an automated message from the Apache Git Service.

[GitHub] [arrow] ianmcook commented on a change in pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

ianmcook commented on a change in pull request #9553: URL: https://github.com/apache/arrow/pull/9553#discussion_r587899030 ## File path: run-cmake-format.py ## @@ -52,6 +52,7 @@ 'cpp/cmake_modules/FindRapidJSONAlt.cmake', 'cpp/cmake_modules/FindSnappyAlt.cmake',

[GitHub] [arrow] cyb70289 commented on pull request #9633: ARROW-11560: [C++][FlightRPC] fix mutex error on SIGINT

cyb70289 commented on pull request #9633: URL: https://github.com/apache/arrow/pull/9633#issuecomment-791150699 Also update PR comment to match latest code? `semaphore` -> `pipe` This is an automated message from the Apache

[GitHub] [arrow] mathyingzhou commented on pull request #8648: ARROW-7906: [C++] [Python] Add ORC write support

mathyingzhou commented on pull request #8648: URL: https://github.com/apache/arrow/pull/8648#issuecomment-791209166 @pitrou Yup I found your changes to Random 6 days ago in Arrow-11662. Things did break after that. Now I’m trying to figure out whether it is my ORC writer or Decimal128

[GitHub] [arrow] nealrichardson commented on a change in pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

nealrichardson commented on a change in pull request #9610: URL: https://github.com/apache/arrow/pull/9610#discussion_r587961901 ## File path: dev/tasks/r/azure.linux.yml ## @@ -47,6 +47,9 @@ jobs: export R_ORG={{ r_org }} export R_IMAGE={{ r_image }}

[GitHub] [arrow] github-actions[bot] commented on pull request #9579: ARROW-11774: [R] macos one line install

github-actions[bot] commented on pull request #9579: URL: https://github.com/apache/arrow/pull/9579#issuecomment-791110809 Revision: 4068f471efc55584dbfea5df454af19dfcb1492d Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] github-actions[bot] commented on pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

github-actions[bot] commented on pull request #9610: URL: https://github.com/apache/arrow/pull/9610#issuecomment-791104150 Revision: a810b3fce373c7f5090e367e5a6afc70db60414a Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] ianmcook commented on pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on pull request #9610: URL: https://github.com/apache/arrow/pull/9610#issuecomment-791103746 @github-actions crossbow submit test-r-minimal-build This is an automated message from the Apache Git Service.

[GitHub] [arrow] kou closed pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

kou closed pull request #9553: URL: https://github.com/apache/arrow/pull/9553 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] michalursa commented on pull request #9621: ARROW-11591: [C++][Compute] Grouped aggregation

michalursa commented on pull request #9621: URL: https://github.com/apache/arrow/pull/9621#issuecomment-791153213 > Before digging into the details too much, my main issue with what I see is that I don't agree with making hash aggregation a callable function through `CallFunction`. >

[GitHub] [arrow] xuanqing94 commented on issue #9325: [arrow c++]When I read parquet file and get a arrow::Table, how can I convert it to std::vector?

xuanqing94 commented on issue #9325: URL: https://github.com/apache/arrow/issues/9325#issuecomment-791152745 @joeyac Sorry to bring it up again... but I am deeply confused about this line of code: `auto column_struct =

[GitHub] [arrow] liyafan82 commented on pull request #8949: ARROW-10880: [Java] Support compressing RecordBatch IPC buffers by LZ4

liyafan82 commented on pull request #8949: URL: https://github.com/apache/arrow/pull/8949#issuecomment-791193697 > @liyafan82 nice work. Left a few comments about API and structure let me know what you think. @emkornfield Thanks a lot for your comments. I will resolve them one by

[GitHub] [arrow] ianmcook commented on a change in pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on a change in pull request #9610: URL: https://github.com/apache/arrow/pull/9610#discussion_r587956206 ## File path: dev/tasks/r/azure.linux.yml ## @@ -47,6 +47,9 @@ jobs: export R_ORG={{ r_org }} export R_IMAGE={{ r_image }}

[GitHub] [arrow] github-actions[bot] commented on pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

github-actions[bot] commented on pull request #9610: URL: https://github.com/apache/arrow/pull/9610#issuecomment-791117825 Revision: 9479c6ce079c7230b0e290dcb5658436d1d62fde Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] ianmcook commented on pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on pull request #9610: URL: https://github.com/apache/arrow/pull/9610#issuecomment-791154662 @github-actions crossbow submit -g r This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] emkornfield commented on a change in pull request #8949: ARROW-10880: [Java] Support compressing RecordBatch IPC buffers by LZ4

emkornfield commented on a change in pull request #8949: URL: https://github.com/apache/arrow/pull/8949#discussion_r588044636 ## File path: java/compression/src/main/java/org/apache/arrow/compression/CommonsCompressionFactory.java ## @@ -0,0 +1,43 @@ +/* + * Licensed to the

[GitHub] [arrow] github-actions[bot] commented on pull request #9579: ARROW-11774: [R] macos one line install

github-actions[bot] commented on pull request #9579: URL: https://github.com/apache/arrow/pull/9579#issuecomment-791061098 Revision: 9856d8aa91f4f334897e00333b560150fbe54296 Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] ianmcook commented on a change in pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

ianmcook commented on a change in pull request #9553: URL: https://github.com/apache/arrow/pull/9553#discussion_r587952686 ## File path: cpp/cmake_modules/Usevcpkg.cmake ## @@ -0,0 +1,214 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [arrow] github-actions[bot] commented on pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

github-actions[bot] commented on pull request #9553: URL: https://github.com/apache/arrow/pull/9553#issuecomment-791077751 Revision: 2e6905a7262a6139c52c4007fd95f58b378e71ca Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] ianmcook removed a comment on pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook removed a comment on pull request #9610: URL: https://github.com/apache/arrow/pull/9610#issuecomment-791139873 @github-actions crossbow submit -g r This is an automated message from the Apache Git Service. To

[GitHub] [arrow] ianmcook commented on pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on pull request #9610: URL: https://github.com/apache/arrow/pull/9610#issuecomment-791154080 @github-actions crossbow submit test-r-minimal-build This is an automated message from the Apache Git Service.

[GitHub] [arrow] ianmcook commented on pull request #9553: ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG

ianmcook commented on pull request #9553: URL: https://github.com/apache/arrow/pull/9553#issuecomment-791072177 @github-actions crossbow submit test-build-vcpkg-win wheel-manylinux2010-cp36m wheel-windows-cp36m This is an

[GitHub] [arrow] nealrichardson closed pull request #9442: ARROW-6818: [DOC] Remove reference to Apache Drill design docs

nealrichardson closed pull request #9442: URL: https://github.com/apache/arrow/pull/9442 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] ianmcook commented on a change in pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on a change in pull request #9610: URL: https://github.com/apache/arrow/pull/9610#discussion_r587998671 ## File path: dev/tasks/r/azure.linux.yml ## @@ -47,6 +47,9 @@ jobs: export R_ORG={{ r_org }} export R_IMAGE={{ r_image }}

[GitHub] [arrow] ianmcook commented on a change in pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on a change in pull request #9610: URL: https://github.com/apache/arrow/pull/9610#discussion_r588021512 ## File path: dev/tasks/r/azure.linux.yml ## @@ -47,6 +47,9 @@ jobs: export R_ORG={{ r_org }} export R_IMAGE={{ r_image }}

[GitHub] [arrow] ianmcook commented on pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on pull request #9610: URL: https://github.com/apache/arrow/pull/9610#issuecomment-791139873 @github-actions crossbow submit -g r This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] ianmcook commented on pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

ianmcook commented on pull request #9610: URL: https://github.com/apache/arrow/pull/9610#issuecomment-791155609 @github-actions crossbow submit test-r-without-dataset-parquet-s3 This is an automated message from the Apache

[GitHub] [arrow] emkornfield commented on issue #9628: write_feather incorrectly deletes files

emkornfield commented on issue #9628: URL: https://github.com/apache/arrow/issues/9628#issuecomment-791183396 First one seems reasonable to me. Second one, I'm not sure about it. This seems intentional: https://github.com/apache/arrow/commit/96f3d6176d8c95717f4ff45e4226161de3168b05

[GitHub] [arrow] pitrou commented on pull request #9528: ARROW-8732: [C++] Add basic cancellation API

pitrou commented on pull request #9528: URL: https://github.com/apache/arrow/pull/9528#issuecomment-790509864 @westonpace @bkietz Feel free to review. This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] westonpace commented on pull request #9626: ARROW-11855: [C++][Python] Memory leak in to_pandas when converting chunked struct array

westonpace commented on pull request #9626: URL: https://github.com/apache/arrow/pull/9626#issuecomment-790458923 Failing check appears to be ARROW-11717 / unrelated to PR. Please rerun or ignore. This is an automated

[GitHub] [arrow] pitrou commented on a change in pull request #9626: ARROW-11855: [C++][Python] Memory leak in to_pandas when converting chunked struct array

pitrou commented on a change in pull request #9626: URL: https://github.com/apache/arrow/pull/9626#discussion_r587322650 ## File path: python/pyarrow/tests/test_pandas.py ## @@ -2272,6 +2272,30 @@ def test_to_pandas(self): series = pd.Series(arr.to_pandas())

  1   2   >