codecov-commenter commented on pull request #506:
URL: https://github.com/apache/arrow-datafusion/pull/506#issuecomment-855193814
#
github-actions[bot] commented on pull request #10455:
URL: https://github.com/apache/arrow/pull/10455#issuecomment-855206376
Revision: 20a67dd39a946ae27b5a820a2b82d8522fcb67c0
Submitted crossbow builds: [ursacomputing/crossbow @
thisisnic commented on pull request #10455:
URL: https://github.com/apache/arrow/pull/10455#issuecomment-855206313
@github-actions crossbow submit test-r-without-arrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Dandandan commented on pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#issuecomment-855220573
> @alamb is it enough to add the `like` and `not like` where I added them?
Not sure of where else I need to change.
>
> @Dandandan I'm unable to configure the
alippai commented on a change in pull request #406:
URL: https://github.com/apache/arrow-rs/pull/406#discussion_r645975298
##
File path: arrow/src/csv/writer.rs
##
@@ -242,6 +245,14 @@ impl Writer {
};
format!("{}",
drauschenbach commented on issue #46:
URL: https://github.com/apache/arrow-datafusion/issues/46#issuecomment-855250829
I've investigated Python and JavaScript notebooks for Ballista, and think
that Rust notebooks would be the low-hanging fruit and natural starting point:
github-actions[bot] commented on pull request #10455:
URL: https://github.com/apache/arrow/pull/10455#issuecomment-855213583
Revision: 28657ec4aa2dd6becb5646f7a6544d488ed009af
Submitted crossbow builds: [ursacomputing/crossbow @
alippai commented on a change in pull request #406:
URL: https://github.com/apache/arrow-rs/pull/406#discussion_r645969016
##
File path: arrow/src/array/array_binary.rs
##
@@ -728,8 +730,11 @@ impl From for DecimalArray {
impl fmt::Debug for DecimalArray {
fn fmt(, f:
codecov-commenter edited a comment on pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#issuecomment-855220055
#
codecov-commenter commented on pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#issuecomment-855220055
#
Dandandan commented on a change in pull request #383:
URL: https://github.com/apache/arrow-rs/pull/383#discussion_r645988558
##
File path: arrow/src/array/builder.rs
##
@@ -302,6 +302,15 @@ impl BooleanBufferBuilder {
self.len
}
+#[inline]
+pub fn
andygrove commented on pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-855238255
The change in this PR looks like a good start and probably necessary, but
yet, the goal is to update DataFrame::collect
--
This is an automated message from the
andygrove edited a comment on pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-855238255
The change in this PR looks like a good start and probably necessary, but
yes, the goal is to update DataFrame::collect
--
This is an automated message from
alamb merged pull request #401:
URL: https://github.com/apache/arrow-rs/pull/401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
andygrove commented on issue #509:
URL:
https://github.com/apache/arrow-datafusion/issues/509#issuecomment-855243972
@alamb @jorgecarleitao fyi would be good to get your input on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
alamb commented on pull request #510:
URL: https://github.com/apache/arrow-datafusion/pull/510#issuecomment-855257509
Thank you for your contribution @gangliao !
> @alamb Is that possible to let datafusion use the latest code from
arrow-rs?
As of now, we are only using
thisisnic commented on pull request #10455:
URL: https://github.com/apache/arrow/pull/10455#issuecomment-855213501
@github-actions crossbow submit test-r-without-arrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
nevi-me opened a new issue #507:
URL: https://github.com/apache/arrow-datafusion/issues/507
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
From looking at the pruning logic, it appears that we can prune inputs based
on `col
nevi-me opened a new pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508
# Which issue does this PR close?
Closes #507.
# Rationale for this change
Extending pruning to include string columns with `LIKE`
# What changes are included in
Dandandan commented on a change in pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#discussion_r645975980
##
File path: datafusion/src/physical_optimizer/pruning.rs
##
@@ -586,8 +587,45 @@ fn build_predicate_expression(
alamb commented on a change in pull request #505:
URL: https://github.com/apache/arrow-datafusion/pull/505#discussion_r645975983
##
File path: datafusion/tests/sql.rs
##
@@ -3437,3 +3437,14 @@ async fn
test_physical_plan_display_indent_multi_children() {
expected,
andygrove closed issue #72:
URL: https://github.com/apache/arrow-datafusion/issues/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
nevi-me commented on pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#issuecomment-855247835
> However we don't support query 14/16/20 yet:
Aw :( it would have been great to see what impact the small change has.
Maybe @alamb will see better results
Dandandan commented on a change in pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#discussion_r646003565
##
File path: datafusion/src/physical_optimizer/pruning.rs
##
@@ -586,8 +587,45 @@ fn build_predicate_expression(
ritchie46 edited a comment on pull request #411:
URL: https://github.com/apache/arrow-rs/pull/411#issuecomment-855208571
> @ritchie46 / @jorgecarleitao should we backport this one? there appears to
be an outstanding question: [#348
github-actions[bot] commented on pull request #10455:
URL: https://github.com/apache/arrow/pull/10455#issuecomment-855204978
Revision: c7cd1357e878ffd04063872f79fc31a8ff05b705
Submitted crossbow builds: [ursacomputing/crossbow @
thisisnic commented on pull request #10455:
URL: https://github.com/apache/arrow/pull/10455#issuecomment-855204894
@github-actions crossbow submit test-r-without-arrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
codecov-commenter edited a comment on pull request #501:
URL: https://github.com/apache/arrow-datafusion/pull/501#issuecomment-854535739
#
Dandandan commented on a change in pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#discussion_r645991369
##
File path: datafusion/src/physical_optimizer/pruning.rs
##
@@ -586,8 +587,45 @@ fn build_predicate_expression(
nevi-me commented on a change in pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#discussion_r645996852
##
File path: datafusion/src/physical_optimizer/pruning.rs
##
@@ -586,8 +587,45 @@ fn build_predicate_expression(
gangliao commented on pull request #510:
URL: https://github.com/apache/arrow-datafusion/pull/510#issuecomment-855254966
@alamb Is that possible to let `datafusion` use the latest code from
`arrow-rs`?
--
This is an automated message from the Apache Git Service.
To respond to the
boaz-codota edited a comment on pull request #383:
URL: https://github.com/apache/arrow-rs/pull/383#issuecomment-855236871
Fix the tests, could you review? @Dandandan @alamb ?
Also, @alamb I noticed that in
boaz-codota commented on pull request #383:
URL: https://github.com/apache/arrow-rs/pull/383#issuecomment-855236871
Fix the tests, could you review? @Dandandan @alamb ?
Also, @alamb I noticed that in
https://github.com/influxdata/influxdb_iox/blob/main/arrow_util/src/bitset.rs#L87
alamb merged pull request #407:
URL: https://github.com/apache/arrow-rs/pull/407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
alamb merged pull request #408:
URL: https://github.com/apache/arrow-rs/pull/408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
alamb merged pull request #403:
URL: https://github.com/apache/arrow-rs/pull/403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
alamb merged pull request #410:
URL: https://github.com/apache/arrow-rs/pull/410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
alamb merged pull request #402:
URL: https://github.com/apache/arrow-rs/pull/402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
alamb merged pull request #404:
URL: https://github.com/apache/arrow-rs/pull/404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
alamb merged pull request #412:
URL: https://github.com/apache/arrow-rs/pull/412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
andygrove opened a new issue #509:
URL: https://github.com/apache/arrow-datafusion/issues/509
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
It is currently not possible to publish the Ballista crates to crates.io
from a
alamb commented on pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#issuecomment-855257881
Thanks @nevi-me -- this looks great. I agree iOX may very well benefit from
this as regex are common in our query workload. I will try and review this PR
carefully
nevi-me commented on pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#issuecomment-855218249
@alamb is it enough to add the `like` and `not like` where I added them? Not
sure of where else I need to change.
@Dandandan I'm unable to configure the TPC
alippai commented on a change in pull request #406:
URL: https://github.com/apache/arrow-rs/pull/406#discussion_r645975856
##
File path: arrow/src/array/array_binary.rs
##
@@ -728,8 +730,11 @@ impl From for DecimalArray {
impl fmt::Debug for DecimalArray {
fn fmt(, f:
andygrove commented on a change in pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#discussion_r645988035
##
File path: datafusion/src/physical_optimizer/pruning.rs
##
@@ -586,8 +587,45 @@ fn build_predicate_expression(
alamb merged pull request #409:
URL: https://github.com/apache/arrow-rs/pull/409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
gangliao opened a new pull request #510:
URL: https://github.com/apache/arrow-datafusion/pull/510
# Which issue does this PR close?
https://github.com/apache/arrow-rs/pull/317
# Rationale for this change
# What changes are included in this PR?
#
Dandandan commented on a change in pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#discussion_r646003565
##
File path: datafusion/src/physical_optimizer/pruning.rs
##
@@ -586,8 +587,45 @@ fn build_predicate_expression(
Dandandan commented on a change in pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#discussion_r646003565
##
File path: datafusion/src/physical_optimizer/pruning.rs
##
@@ -586,8 +587,45 @@ fn build_predicate_expression(
ritchie46 commented on pull request #411:
URL: https://github.com/apache/arrow-rs/pull/411#issuecomment-855208571
> @ritchie46 / @jorgecarleitao should we backport this one? there appears to
be an outstanding question: [#348
alamb commented on issue #394:
URL: https://github.com/apache/arrow-rs/issues/394#issuecomment-855223298
> I keep wait 4.3 release.
Thank you
> Can you change release tag page?
> https://github.com/apache/arrow-rs/releases/tag/4.2.0
> this shows 33 commits to master
codecov-commenter edited a comment on pull request #409:
URL: https://github.com/apache/arrow-rs/pull/409#issuecomment-854991123
#
alamb commented on pull request #400:
URL: https://github.com/apache/arrow-rs/pull/400#issuecomment-855229745
@alippai I am not sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
boaz-codota commented on a change in pull request #383:
URL: https://github.com/apache/arrow-rs/pull/383#discussion_r645988790
##
File path: arrow/src/array/builder.rs
##
@@ -302,6 +302,15 @@ impl BooleanBufferBuilder {
self.len
}
+#[inline]
+pub fn
alamb commented on issue #509:
URL:
https://github.com/apache/arrow-datafusion/issues/509#issuecomment-855257755
Sounds reasonable to me.
At some point, we should probably figure out a more regular release cadence
for DataFusion (right now, my project is just using the head
Dandandan opened a new issue #511:
URL: https://github.com/apache/arrow-datafusion/issues/511
**Describe the bug**
Because the `Instant::now()` is created after executing the actual
evaluation it always prints "Query took 0 seconds"
**To Reproduce**
Run any query in
Dandandan edited a comment on pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#issuecomment-855260595
@nevi-me
I did some checking with data from TPC-H:
Before:
```
CREATE EXTERNAL TABLE T STORED AS PARQUET LOCATION
Dandandan commented on pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#issuecomment-855260595
@nevi-me
I did some checking with data from TPC-H:
Before:
```
CREATE EXTERNAL TABLE T STORED AS PARQUET LOCATION
cyb70289 commented on a change in pull request #10364:
URL: https://github.com/apache/arrow/pull/10364#discussion_r645953547
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -428,12 +524,69 @@ ArrayKernelExec ArithmeticExecFromOp(detail::GetTypeId
alippai commented on pull request #400:
URL: https://github.com/apache/arrow-rs/pull/400#issuecomment-855204594
@alamb did you mean `parquet="^4.0.0"` or `parquet="^4.1.0"`? `parquet="^4"`
means `>=4.0.0, <5.0.0` which we want to promote I believe (always resolves to
the latest 4.x
Dandandan commented on pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#issuecomment-855245221
> @alamb is it enough to add the `like` and `not like` where I added them?
Not sure of where else I need to change.
>
> @Dandandan I'm unable to configure the
gangliao commented on pull request #510:
URL: https://github.com/apache/arrow-datafusion/pull/510#issuecomment-855258995
Got it! Thank you for the clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Dandandan opened a new pull request #514:
URL: https://github.com/apache/arrow-datafusion/pull/514
# Which issue does this PR close?
Closes #511
# Rationale for this change
# What changes are included in this PR?
Before this change, starting time
houqp commented on a change in pull request #506:
URL: https://github.com/apache/arrow-datafusion/pull/506#discussion_r646050062
##
File path: datafusion/src/physical_plan/window_frames.rs
##
@@ -0,0 +1,337 @@
+// Licensed to the Apache Software Foundation (ASF) under one
codecov-commenter commented on pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-855311829
#
nevi-me commented on pull request #389:
URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-855295792
@jhorstmann I'm still looking into this. Nested list slices currently don't
work in the main branch; that's what made me come back to this issue. The
primitive in `>` only sees
codecov-commenter commented on pull request #514:
URL: https://github.com/apache/arrow-datafusion/pull/514#issuecomment-855301888
#
alippai opened a new issue #413:
URL: https://github.com/apache/arrow-rs/issues/413
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
I'm trying to use Rust from python, but I get error message of Decimal not
supported /
houqp opened a new issue #512:
URL: https://github.com/apache/arrow-datafusion/issues/512
**Describe the bug**
passing float arrays to `create_hashes` results in panics with a message
"not implemented" when built with nightly rustc.
**To Reproduce**
Rustc:
```
codecov-commenter commented on pull request #383:
URL: https://github.com/apache/arrow-rs/pull/383#issuecomment-855284362
#
jorgecarleitao closed issue #417:
URL: https://github.com/apache/arrow-datafusion/issues/417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
jorgecarleitao merged pull request #513:
URL: https://github.com/apache/arrow-datafusion/pull/513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
codecov-commenter edited a comment on pull request #515:
URL: https://github.com/apache/arrow-datafusion/pull/515#issuecomment-855328652
#
msathis opened a new pull request #513:
URL: https://github.com/apache/arrow-datafusion/pull/513
# Which issue does this PR close?
Closes #417.
# Rationale for this change
Optimize cast function during planning stage
# What changes are included in this PR?
Optimize
Dandandan commented on a change in pull request #513:
URL: https://github.com/apache/arrow-datafusion/pull/513#discussion_r646036515
##
File path: datafusion/src/optimizer/constant_folding.rs
##
@@ -247,6 +248,25 @@ impl<'a> ExprRewriter for ConstantRewriter<'a> {
Jimexist opened a new pull request #515:
URL: https://github.com/apache/arrow-datafusion/pull/515
# Which issue does this PR close?
Closes #.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing changes?
codecov-commenter commented on pull request #515:
URL: https://github.com/apache/arrow-datafusion/pull/515#issuecomment-855328652
#
77 matches
Mail list logo
