jorgecarleitao commented on a change in pull request #68:
URL: https://github.com/apache/arrow-datafusion/pull/68#discussion_r646083187
##
File path: datafusion/src/physical_plan/hash_aggregate.rs
##
@@ -339,6 +325,36 @@ pin_project! {
}
}
+fn hash_(group_values:
jorgecarleitao commented on issue #512:
URL:
https://github.com/apache/arrow-datafusion/issues/512#issuecomment-855371497
This is probably related to Rust's unability to support hash for f32 and
f64, as `Eq` is still not stabilized for them (and Hash and Eq must be
consistent).
--
Dandandan edited a comment on issue #512:
URL:
https://github.com/apache/arrow-datafusion/issues/512#issuecomment-855371911
> This is probably related to Rust's unability to support hash for f32 and
f64, as `Eq` is still not stabilized for them (and Hash and Eq must be
consistent).
jorgecarleitao commented on a change in pull request #487:
URL: https://github.com/apache/arrow-datafusion/pull/487#discussion_r646110025
##
File path: datafusion/src/physical_plan/json.rs
##
@@ -202,16 +202,11 @@ impl NdJsonExec {
max_records: Option,
) ->
alamb commented on a change in pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#discussion_r646112932
##
File path: datafusion/src/physical_optimizer/pruning.rs
##
@@ -1095,6 +1133,60 @@ mod tests {
Ok(())
}
+#[test]
+fn
Dandandan opened a new issue #415:
URL: https://github.com/apache/arrow-rs/issues/415
**Describe the bug**
`like_utf8` and `nlike_utf8` and scalar variants don't take care of
escaping the wildcard character.
```
test_utf8_scalar!(
test_utf8_scalar_escape,
alamb commented on a change in pull request #406:
URL: https://github.com/apache/arrow-rs/pull/406#discussion_r646114701
##
File path: arrow/src/util/display.rs
##
@@ -192,18 +194,34 @@ macro_rules! make_string_from_list {
}};
}
-macro_rules! make_string_from_decimal {
Jimexist commented on a change in pull request #506:
URL: https://github.com/apache/arrow-datafusion/pull/506#discussion_r646119730
##
File path: datafusion/src/logical_plan/expr.rs
##
@@ -1283,8 +1284,23 @@ impl fmt::Debug for Expr {
Expr::ScalarUDF { fun, ref
github-actions[bot] commented on pull request #10459:
URL: https://github.com/apache/arrow/pull/10459#issuecomment-855386506
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes).
Could you
Crystrix opened a new pull request #10459:
URL: https://github.com/apache/arrow/pull/10459
The options parameter of `Count` function is passed by value, it's better to
be passed by reference like other aggregation functions.
--
This is an automated message from the Apache Git Service.
novemberkilo commented on a change in pull request #414:
URL: https://github.com/apache/arrow-rs/pull/414#discussion_r646126995
##
File path: arrow/src/array/array_binary.rs
##
@@ -613,6 +613,32 @@ impl Array for FixedSizeBinaryArray {
}
/// A type of `DecimalArray` whose
jhorstmann opened a new pull request #418:
URL: https://github.com/apache/arrow-rs/pull/418
# Which issue does this PR close?
Closes #417.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing
Jimexist opened a new pull request #518:
URL: https://github.com/apache/arrow-datafusion/pull/518
# Which issue does this PR close?
Closes #517.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing changes?
Jimexist opened a new pull request #516:
URL: https://github.com/apache/arrow-datafusion/pull/516
# Which issue does this PR close?
Closes #.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing changes?
jorgecarleitao edited a comment on pull request #389:
URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-855365462
Isn't it possible to not offset the child data, and instead only offset the
`offsets`, or do we have some logic around that assumes that offsets always
start from
jorgecarleitao commented on pull request #389:
URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-855365462
Isn't it possible to not offset the child data, and instead only offset the
`offsets`, or do we have some logic around that assumes that offsets always
start from 0?
alippai commented on a change in pull request #406:
URL: https://github.com/apache/arrow-rs/pull/406#discussion_r646116301
##
File path: arrow/src/util/display.rs
##
@@ -192,18 +194,34 @@ macro_rules! make_string_from_list {
}};
}
-macro_rules! make_string_from_decimal
alippai commented on a change in pull request #406:
URL: https://github.com/apache/arrow-rs/pull/406#discussion_r646117049
##
File path: arrow/benches/csv_writer.rs
##
@@ -28,14 +28,14 @@ use arrow::record_batch::RecordBatch;
use std::fs::File;
use std::sync::Arc;
-fn
yordan-pavlov commented on a change in pull request #384:
URL: https://github.com/apache/arrow-rs/pull/384#discussion_r646118604
##
File path: arrow/src/compute/kernels/filter.rs
##
@@ -59,19 +59,14 @@ pub(crate) struct SlicesIterator<'a> {
}
impl<'a> SlicesIterator<'a> {
Jimexist commented on a change in pull request #506:
URL: https://github.com/apache/arrow-datafusion/pull/506#discussion_r646120472
##
File path: datafusion/src/physical_plan/window_frames.rs
##
@@ -0,0 +1,337 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Jimexist opened a new issue #517:
URL: https://github.com/apache/arrow-datafusion/issues/517
I agree it would make more sense for this module to be in `logical_plan` (I
think it would also be fine to do as a follow on PR)
__Originally posted by @alamb in
Jimexist commented on a change in pull request #506:
URL: https://github.com/apache/arrow-datafusion/pull/506#discussion_r646120588
##
File path: datafusion/src/physical_plan/window_frames.rs
##
@@ -0,0 +1,337 @@
+// Licensed to the Apache Software Foundation (ASF) under one
djKooks commented on pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-855390967
@alamb @andygrove thanks for review. Will fix soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
alippai commented on a change in pull request #414:
URL: https://github.com/apache/arrow-rs/pull/414#discussion_r646127829
##
File path: arrow/src/array/array_binary.rs
##
@@ -613,6 +613,32 @@ impl Array for FixedSizeBinaryArray {
}
/// A type of `DecimalArray` whose
codecov-commenter commented on pull request #414:
URL: https://github.com/apache/arrow-rs/pull/414#issuecomment-855393423
#
Jimexist commented on a change in pull request #515:
URL: https://github.com/apache/arrow-datafusion/pull/515#discussion_r646132592
##
File path: datafusion/src/physical_plan/sort.rs
##
@@ -277,9 +250,14 @@ impl SortStream {
jhorstmann commented on a change in pull request #416:
URL: https://github.com/apache/arrow-rs/pull/416#discussion_r646137904
##
File path: arrow/src/util/bit_chunk_iterator.rs
##
@@ -137,14 +137,16 @@ impl Iterator for BitChunkIterator<'_> {
// so when reading as u64
jhorstmann opened a new issue #417:
URL: https://github.com/apache/arrow-rs/issues/417
**Describe the bug**
The boolean not kernel does use `null_buffer.bits.slice(offset)` which takes
a byte offset. This leads to wrong results and possible panics if the offset is
not equal to 0.
andersonm-ibm commented on pull request #9631:
URL: https://github.com/apache/arrow/pull/9631#issuecomment-855354813
Hi @GPSnoopy and @itamarst ,
We've opened a PR https://github.com/apache/arrow/pull/10450 with file-level
parquet encryption.
Your feedback is welcome.
--
This
alamb commented on a change in pull request #513:
URL: https://github.com/apache/arrow-datafusion/pull/513#discussion_r646110743
##
File path: datafusion/src/optimizer/constant_folding.rs
##
@@ -724,6 +744,44 @@ mod tests {
assert_eq!(expected, actual);
}
+
alamb commented on a change in pull request #406:
URL: https://github.com/apache/arrow-rs/pull/406#discussion_r646114701
##
File path: arrow/src/util/display.rs
##
@@ -192,18 +194,34 @@ macro_rules! make_string_from_list {
}};
}
-macro_rules! make_string_from_decimal {
alamb commented on pull request #383:
URL: https://github.com/apache/arrow-rs/pull/383#issuecomment-855380675
> which I haven't tested but might have performance implications (?)
Hopefully the compiler can figure it out -- I think the way you have it is
fine until we get some sort
alamb commented on a change in pull request #506:
URL: https://github.com/apache/arrow-datafusion/pull/506#discussion_r646116862
##
File path: datafusion/src/physical_plan/window_frames.rs
##
@@ -0,0 +1,337 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Dandandan closed issue #511:
URL: https://github.com/apache/arrow-datafusion/issues/511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
Dandandan merged pull request #514:
URL: https://github.com/apache/arrow-datafusion/pull/514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
jhorstmann commented on pull request #389:
URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-855363485
@nevi-me can you point me to a testcase and does this only involve arrow or
the parquet roundtrip? I'd be happy to take a look. My thoughts are that a
`List` is basically the
alamb commented on a change in pull request #414:
URL: https://github.com/apache/arrow-rs/pull/414#discussion_r646115328
##
File path: arrow/src/array/array_binary.rs
##
@@ -613,6 +613,32 @@ impl Array for FixedSizeBinaryArray {
}
/// A type of `DecimalArray` whose
alamb commented on a change in pull request #406:
URL: https://github.com/apache/arrow-rs/pull/406#discussion_r646117403
##
File path: arrow/benches/csv_writer.rs
##
@@ -28,14 +28,14 @@ use arrow::record_batch::RecordBatch;
use std::fs::File;
use std::sync::Arc;
-fn
alippai commented on a change in pull request #406:
URL: https://github.com/apache/arrow-rs/pull/406#discussion_r646117707
##
File path: arrow/benches/csv_writer.rs
##
@@ -28,14 +28,14 @@ use arrow::record_batch::RecordBatch;
use std::fs::File;
use std::sync::Arc;
-fn
yordan-pavlov commented on a change in pull request #384:
URL: https://github.com/apache/arrow-rs/pull/384#discussion_r646118805
##
File path: parquet/benches/arrow_array_reader.rs
##
@@ -0,0 +1,499 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
yordan-pavlov commented on a change in pull request #384:
URL: https://github.com/apache/arrow-rs/pull/384#discussion_r646118671
##
File path: parquet/src/arrow/arrow_array_reader.rs
##
@@ -0,0 +1,1394 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
codecov-commenter edited a comment on pull request #384:
URL: https://github.com/apache/arrow-rs/pull/384#issuecomment-851063613
#
github-actions[bot] commented on pull request #10459:
URL: https://github.com/apache/arrow/pull/10459#issuecomment-855386970
https://issues.apache.org/jira/browse/ARROW-12984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
rok commented on pull request #10457:
URL: https://github.com/apache/arrow/pull/10457#issuecomment-855387981
Errors appear to be due to windows builds not finding tz database.
[See.](https://github.com/HowardHinnant/date/issues/641)
--
This is an automated message from the Apache Git
djKooks edited a comment on pull request #442:
URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-855390967
@alamb @andygrove thanks for review. Will fix soon
As far as I review from now, seems it needs to fix return format of
`collect` inside `dataframe_impl`.
jhorstmann opened a new pull request #416:
URL: https://github.com/apache/arrow-rs/pull/416
# Which issue does this PR close?
Closes #198.
# Rationale for this change
The previous code could read a few bytes out of bounds. I could not cause
this to trigger a
codecov-commenter commented on pull request #418:
URL: https://github.com/apache/arrow-rs/pull/418#issuecomment-855409084
#
novemberkilo commented on pull request #414:
URL: https://github.com/apache/arrow-rs/pull/414#issuecomment-855350519
cc/ @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
novemberkilo opened a new pull request #414:
URL: https://github.com/apache/arrow-rs/pull/414
# Which issue does this PR close?
re #301
# What changes are included in this PR?
Doctests only
# Are there any user-facing changes?
No
--
This is an automated
Dandandan commented on issue #512:
URL:
https://github.com/apache/arrow-datafusion/issues/512#issuecomment-855370906
Interesting find @houqp . I think this needs to be fixed upstream, by e.g.
casting to .
Any idea why it's using the fallback code of aHash at your end, what kind of
cpu
Dandandan commented on issue #512:
URL:
https://github.com/apache/arrow-datafusion/issues/512#issuecomment-855371911
> This is probably related to Rust's unability to support hash for f32 and
f64, as `Eq` is still not stabilized for them (and Hash and Eq must be
consistent).
Dandandan commented on a change in pull request #487:
URL: https://github.com/apache/arrow-datafusion/pull/487#discussion_r646110346
##
File path: datafusion/src/physical_plan/json.rs
##
@@ -202,16 +202,11 @@ impl NdJsonExec {
max_records: Option,
) -> Result {
Dandandan commented on a change in pull request #487:
URL: https://github.com/apache/arrow-datafusion/pull/487#discussion_r646110346
##
File path: datafusion/src/physical_plan/json.rs
##
@@ -202,16 +202,11 @@ impl NdJsonExec {
max_records: Option,
) -> Result {
Jimexist commented on a change in pull request #506:
URL: https://github.com/apache/arrow-datafusion/pull/506#discussion_r646141389
##
File path: datafusion/src/physical_plan/window_frames.rs
##
@@ -0,0 +1,337 @@
+// Licensed to the Apache Software Foundation (ASF) under one
boaz-codota commented on pull request #383:
URL: https://github.com/apache/arrow-rs/pull/383#issuecomment-855430342
@alamb fixed clippy failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
projjal commented on a change in pull request #10385:
URL: https://github.com/apache/arrow/pull/10385#discussion_r646145879
##
File path: cpp/src/gandiva/function_registry_math_ops.cc
##
@@ -84,6 +84,17 @@ std::vector GetMathOpsFunctionRegistry() {
jhorstmann commented on a change in pull request #419:
URL: https://github.com/apache/arrow-rs/pull/419#discussion_r646147652
##
File path: arrow/src/compute/kernels/cast.rs
##
@@ -1450,7 +1451,8 @@ where
cast_with_options(_array.values(), to_type, cast_options)?;
jhorstmann opened a new pull request #419:
URL: https://github.com/apache/arrow-rs/pull/419
# Which issue does this PR close?
Closes #391.
# Rationale for this change
The `keys_array` can be a performance problem if used in inner loops and
most usages
codecov-commenter commented on pull request #419:
URL: https://github.com/apache/arrow-rs/pull/419#issuecomment-855417915
#
nealrichardson closed pull request #10455:
URL: https://github.com/apache/arrow/pull/10455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
codecov-commenter commented on pull request #519:
URL: https://github.com/apache/arrow-datafusion/pull/519#issuecomment-855425840
#
Dandandan commented on a change in pull request #519:
URL: https://github.com/apache/arrow-datafusion/pull/519#discussion_r646165300
##
File path: datafusion/src/sql/utils.rs
##
@@ -390,6 +390,42 @@ pub(crate) fn extract_aliases(exprs: &[Expr]) ->
HashMap {
Dandandan commented on a change in pull request #519:
URL: https://github.com/apache/arrow-datafusion/pull/519#discussion_r646164764
##
File path: datafusion/src/sql/utils.rs
##
@@ -390,6 +390,42 @@ pub(crate) fn extract_aliases(exprs: &[Expr]) ->
HashMap {
jychen7 opened a new pull request #519:
URL: https://github.com/apache/arrow-datafusion/pull/519
# Which issue does this PR close?
Closes #110
# What changes are included in this PR?
similar to extract and resolve alias, we create new functions to extract and
resolve
Dandandan commented on a change in pull request #519:
URL: https://github.com/apache/arrow-datafusion/pull/519#discussion_r646165300
##
File path: datafusion/src/sql/utils.rs
##
@@ -390,6 +390,42 @@ pub(crate) fn extract_aliases(exprs: &[Expr]) ->
HashMap {
Dandandan commented on a change in pull request #519:
URL: https://github.com/apache/arrow-datafusion/pull/519#discussion_r646165045
##
File path: datafusion/src/sql/utils.rs
##
@@ -390,6 +390,42 @@ pub(crate) fn extract_aliases(exprs: &[Expr]) ->
HashMap {
houqp commented on a change in pull request #487:
URL: https://github.com/apache/arrow-datafusion/pull/487#discussion_r646175372
##
File path: datafusion/src/physical_plan/json.rs
##
@@ -202,16 +202,11 @@ impl NdJsonExec {
max_records: Option,
) -> Result {
houqp commented on issue #512:
URL:
https://github.com/apache/arrow-datafusion/issues/512#issuecomment-855449964
My CPU is Intel i7.
I think i found what's causing the difference between stable and nightly:
https://github.com/tkaitchuck/aHash/issues/93#issuecomment-855449239. This
jychen7 commented on a change in pull request #519:
URL: https://github.com/apache/arrow-datafusion/pull/519#discussion_r646195579
##
File path: datafusion/src/sql/utils.rs
##
@@ -390,6 +391,30 @@ pub(crate) fn extract_aliases(exprs: &[Expr]) ->
HashMap {
nevi-me commented on a change in pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#discussion_r646248751
##
File path: datafusion/src/physical_optimizer/pruning.rs
##
@@ -1095,6 +1133,60 @@ mod tests {
Ok(())
}
+#[test]
+fn
kazuk closed issue #394:
URL: https://github.com/apache/arrow-rs/issues/394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
kazuk commented on issue #394:
URL: https://github.com/apache/arrow-rs/issues/394#issuecomment-855513674
I check repository setting page on github.
that link depends default base branch setting. and not fits this repo.
I close this issue . Thank you.
--
This is an
cyb70289 commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855547438
@kou , anyway to trigger related crossbow build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
codecov-commenter edited a comment on pull request #519:
URL: https://github.com/apache/arrow-datafusion/pull/519#issuecomment-855425840
#
github-actions[bot] commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855547032
https://issues.apache.org/jira/browse/ARROW-12972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
cyb70289 opened a new pull request #10460:
URL: https://github.com/apache/arrow/pull/10460
Install libarchive to fix cmake error on centos-8.
cmake: undefined symbol: archive_write_add_filter_zstd
--
This is an automated message from the Apache Git Service.
To respond to the
kou commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855565630
@github-actions crossbow submit centos-8-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855565928
Revision: 826f4a9cbea47a650a29a20a8891ede08f50b169
Submitted crossbow builds: [ursacomputing/crossbow @
jychen7 commented on a change in pull request #519:
URL: https://github.com/apache/arrow-datafusion/pull/519#discussion_r646195188
##
File path: datafusion/src/sql/utils.rs
##
@@ -390,6 +390,42 @@ pub(crate) fn extract_aliases(exprs: &[Expr]) ->
HashMap {
nevi-me commented on a change in pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#discussion_r646248560
##
File path: datafusion/src/physical_optimizer/pruning.rs
##
@@ -586,8 +587,45 @@ fn build_predicate_expression(
codecov-commenter commented on pull request #518:
URL: https://github.com/apache/arrow-datafusion/pull/518#issuecomment-82867
#
codecov-commenter edited a comment on pull request #508:
URL: https://github.com/apache/arrow-datafusion/pull/508#issuecomment-855220055
#
cyb70289 commented on pull request #10459:
URL: https://github.com/apache/arrow/pull/10459#issuecomment-855565488
Thanks @Crystrix !
Will you also update `Index` function?
https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/api_aggregate.cc#L80
--
This is an
Crystrix commented on pull request #10459:
URL: https://github.com/apache/arrow/pull/10459#issuecomment-855601219
@cyb70289 Sure, `Index` function has also been updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Dandandan commented on a change in pull request #519:
URL: https://github.com/apache/arrow-datafusion/pull/519#discussion_r646209257
##
File path: datafusion/src/sql/utils.rs
##
@@ -390,6 +391,30 @@ pub(crate) fn extract_aliases(exprs: &[Expr]) ->
HashMap {
jorgecarleitao commented on issue #351:
URL:
https://github.com/apache/arrow-datafusion/issues/351#issuecomment-855574159
@andygrove , I was trying to address this in ballista, but I am struggling
to encapsulate a ScalarValue that depends on an Array; how are we declaring
arrow arrays in
86 matches
Mail list logo
