bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r417342700
##
File path: cpp/src/arrow/dataset/filter.cc
##
@@ -1261,7 +1264,212 @@ Result>
TreeEvaluator::Filter(
return batch->Slice(0, 0);
}
-std::shared_ptr
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r417375378
##
File path: cpp/src/arrow/scalar.cc
##
@@ -252,6 +270,100 @@ Result> Scalar::Parse(const
std::shared_ptr& t
return ScalarParseImpl{type, s}.Finish();
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r417341608
##
File path: cpp/src/arrow/scalar.cc
##
@@ -252,6 +270,100 @@ Result> Scalar::Parse(const
std::shared_ptr& t
return ScalarParseImpl{type, s}.Finish();
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r417364778
##
File path: cpp/src/arrow/dataset/filter.h
##
@@ -191,6 +197,10 @@ class ARROW_DS_EXPORT Expression {
/// returns a debug string representing this
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r417358718
##
File path: cpp/src/arrow/util/iterator.h
##
@@ -138,11 +139,11 @@ class Iterator : public
util::EqualityComparable> {
value_ =
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r417347149
##
File path: python/pyarrow/_dataset.pyx
##
@@ -270,19 +425,20 @@ cdef class FileSystemDataset(Dataset):
CFileSystemDataset* filesystem_dataset
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r417342700
##
File path: cpp/src/arrow/dataset/filter.cc
##
@@ -1261,7 +1264,212 @@ Result>
TreeEvaluator::Filter(
return batch->Slice(0, 0);
}
-std::shared_ptr
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r417342047
##
File path: cpp/src/arrow/dataset/filter.cc
##
@@ -1261,7 +1264,212 @@ Result>
TreeEvaluator::Filter(
return batch->Slice(0, 0);
}
-std::shared_ptr
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r417341608
##
File path: cpp/src/arrow/scalar.cc
##
@@ -252,6 +270,100 @@ Result> Scalar::Parse(const
std::shared_ptr& t
return ScalarParseImpl{type, s}.Finish();
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r417341382
##
File path: cpp/src/arrow/scalar.cc
##
@@ -252,6 +270,100 @@ Result> Scalar::Parse(const
std::shared_ptr& t
return ScalarParseImpl{type, s}.Finish();
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r417340605
##
File path: cpp/src/arrow/type.cc
##
@@ -43,6 +43,49 @@
#include "arrow/visitor_inline.h"
namespace arrow {
+
+constexpr Type::type NullType::type_id;
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r417340926
##
File path: cpp/src/arrow/scalar.h
##
@@ -78,6 +78,8 @@ struct ARROW_EXPORT Scalar : public
util::EqualityComparable {
// TODO(bkietz) add
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r416795870
##
File path: python/pyarrow/tests/test_dataset.py
##
@@ -373,125 +354,51 @@ def test_partitioning():
assert expr.equals(expected)
-def
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r416761725
##
File path: python/pyarrow/tests/test_dataset.py
##
@@ -218,33 +216,21 @@ def test_filesystem_dataset(mockfs):
# validation of required arguments
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r416760152
##
File path: python/pyarrow/_dataset.pyx
##
@@ -118,21 +280,15 @@ cdef class Dataset:
---
fragments : iterator of Fragment
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r416758776
##
File path: python/pyarrow/_dataset.pyx
##
@@ -41,6 +42,167 @@ def _forbid_instantiation(klass, subclasses_instead=True):
raise TypeError(msg)
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r416746022
##
File path: python/pyarrow/_dataset.pyx
##
@@ -41,6 +42,167 @@ def _forbid_instantiation(klass, subclasses_instead=True):
raise TypeError(msg)
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r416092830
##
File path: python/pyarrow/_dataset.pyx
##
@@ -269,20 +454,21 @@ cdef class FileSystemDataset(Dataset):
cdef:
CFileSystemDataset*
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r414184803
##
File path: r/src/expression.cpp
##
@@ -21,99 +21,97 @@
// [[arrow::export]]
std::shared_ptr dataset___expr__field_ref(std::string name) {
- return
bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r414184803
##
File path: r/src/expression.cpp
##
@@ -21,99 +21,97 @@
// [[arrow::export]]
std::shared_ptr dataset___expr__field_ref(std::string name) {
- return
20 matches
Mail list logo
