lidavidm merged PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kou commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580662482
##
dev/release/utils-prepare.sh:
##
@@ -86,20 +106,20 @@ update_versions() {
git add "${desc_file}"
done
- sed -i.bak -E "s/^version = \".+\"/version =
lidavidm commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078699433
Looks like it passed. That was quicker than I expected. Thanks for the help
@kou!
02-sign.sh worked:
kou commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078651444
Ah, we will use `RELEASE` as package version because `.deb`/`.rpm` uses
source archive's version (`apache-arrow-adbc-${RELEASE}.tar.gz`) as its package
version.
--
This is an automated
lidavidm commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078650743
https://github.com/lidavidm/arrow-adbc/actions/runs/8843504428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
lidavidm commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078651710
Ok, sounds good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
lidavidm commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078650086
I'll give it a shot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
kou commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078649346
```diff
diff --git a/dev/release/utils-prepare.sh b/dev/release/utils-prepare.sh
index dbbc531e5..acd5b7732 100644
--- a/dev/release/utils-prepare.sh
+++
lidavidm commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078648918
Don't we want 1.0.0 as the actual version number of the package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kou commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078648319
It should be `12-1` not `1.0.0-1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lidavidm commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078647416
Hmm, no luck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
lidavidm commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078636498
Trying again: https://github.com/lidavidm/arrow-adbc/actions/runs/8843345685
It looks like debian/changelog was updated:
lidavidm commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078633447
Hmm, I did run 01-prepare.sh. I'll try again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
kou commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078631278
Here:
https://github.com/lidavidm/arrow-adbc/blob/ab50f798307221e854ac0611dece70e814e3cebe/dev/release/utils-prepare.sh#L115-L118
Could you run `dev/release/01-prepare.sh` before
kou commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078629215
https://github.com/lidavidm/arrow-adbc/blob/ab50f798307221e854ac0611dece70e814e3cebe/.github/workflows/packaging.yml#L300-L302
This is related.
This workflow assumes that we
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580478111
##
dev/release/versions.env:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
kou commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580477119
##
dev/release/versions.env:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
kou commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078625474
Hmm. "1.0.0" not "12.0.0" as the version:
https://github.com/lidavidm/arrow-adbc/actions/runs/8842860533/job/24282184256#step:9:2483
```text
(expected one of
lidavidm commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078617216
It appears the Debian build is still having issues?
https://github.com/lidavidm/arrow-adbc/actions/runs/8842860533/job/24282183949
--
This is an automated message from the
kou commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580468216
##
dev/release/versions.env:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
lidavidm commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2078585268
Giving it a test here:
https://github.com/lidavidm/arrow-adbc/actions/runs/8842860533
Assuming it builds successfully I'll validate that the expected version
numbers made it
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580448972
##
dev/release/versions.env:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580448220
##
dev/release/versions.env:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580445825
##
dev/release/versions.env:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580440439
##
dev/release/versions.env:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580439828
##
dev/release/versions.env:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
kou commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580296606
##
dev/release/versions.env:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580238210
##
dev/release/versions.env:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
kou commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580126841
##
.github/workflows/packaging.yml:
##
@@ -302,8 +302,14 @@ jobs:
- name: Extract source archive
run: |
tar xf apache-arrow-adbc-${{
kou commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580093034
##
dev/release/versions.env:
##
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
kou commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580075954
##
.github/workflows/packaging.yml:
##
@@ -302,8 +302,14 @@ jobs:
- name: Extract source archive
run: |
tar xf apache-arrow-adbc-${{
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1579236301
##
.github/workflows/packaging.yml:
##
@@ -302,8 +302,14 @@ jobs:
- name: Extract source archive
run: |
tar xf apache-arrow-adbc-${{
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1579184296
##
dev/release/utils-prepare.sh:
##
@@ -16,32 +16,53 @@
# under the License.
ADBC_DIR="${SOURCE_DIR}/../.."
+source "${SOURCE_DIR}/versions.env"
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1579183791
##
.github/workflows/packaging.yml:
##
@@ -302,8 +302,14 @@ jobs:
- name: Extract source archive
run: |
tar xf apache-arrow-adbc-${{
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1579179915
##
.github/workflows/packaging.yml:
##
@@ -302,8 +302,14 @@ jobs:
- name: Extract source archive
run: |
tar xf apache-arrow-adbc-${{
lidavidm commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1579179277
##
.github/workflows/packaging.yml:
##
@@ -302,8 +302,14 @@ jobs:
- name: Extract source archive
run: |
tar xf apache-arrow-adbc-${{
kou commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1579143808
##
.github/workflows/packaging.yml:
##
@@ -302,8 +302,14 @@ jobs:
- name: Extract source archive
run: |
tar xf apache-arrow-adbc-${{
lidavidm commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2076685740
@kou I did an initial pass over the release scripts...the main thing now
will be having to bump all the versions by hand post-release but I think that's
OK for now
--
This is an
lidavidm commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2076499712
It appears our milestone assigner should still work
```
lidavidm@debian ~/C/arrow-adbc (versioning)> printf
"maint-2024.05\nmaint-0.11.0" | grep -o '[0-9.]*$' | sort
lidavidm commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2076490213
Linux packages look right, let's see about Python...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lidavidm commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2076472350
- Python used the wrong version number.
- Need to validate what version number the Linux packages used.
--
This is an automated message from the Apache Git Service.
To respond
lidavidm commented on PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#issuecomment-2076471507
Demo release:
https://github.com/lidavidm/arrow-adbc/releases/tag/apache-arrow-adbc-2024.05-rc0
--
This is an automated message from the Apache Git Service.
To respond to the
kou commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1578811942
##
dev/release/versions.env:
##
@@ -0,0 +1,32 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
43 matches
Mail list logo
