[GitHub] [beam] mxm commented on issue #11200: [BEAM-9573] Correct computing of watermark hold for timer output timestamp

2020-03-25 Thread GitBox
mxm commented on issue #11200: [BEAM-9573] Correct computing of watermark hold for timer output timestamp URL: https://github.com/apache/beam/pull/11200#issuecomment-603704355 Java PreCommit is flaky due to https://issues.apache.org/jira/browse/BEAM-9578 --

[GitHub] [beam] mxm merged pull request #11200: [BEAM-9573] Correct computing of watermark hold for timer output timestamp

2020-03-25 Thread GitBox
mxm merged pull request #11200: [BEAM-9573] Correct computing of watermark hold for timer output timestamp URL: https://github.com/apache/beam/pull/11200 This is an automated message from the Apache Git Service. To respond t

[GitHub] [beam] echauchot commented on issue #11055: [BEAM-9436] Improve GBK in spark structured streaming runner

2020-03-25 Thread GitBox
echauchot commented on issue #11055: [BEAM-9436] Improve GBK in spark structured streaming runner URL: https://github.com/apache/beam/pull/11055#issuecomment-603725379 > > I think you missed this comment 8 days ago: #11055 (comment) > > Once again, I saw your results (and even mentio

[GitHub] [beam] mwalenia commented on issue #10949: [BEAM-9371] Add SideInputLoadTest to Java SDK

2020-03-25 Thread GitBox
mwalenia commented on issue #10949: [BEAM-9371] Add SideInputLoadTest to Java SDK URL: https://github.com/apache/beam/pull/10949#issuecomment-603726033 @Ardagan Pinging again :) This is an automated message from the Apache Gi

[GitHub] [beam] alexvanboxel opened a new pull request #11217: [BEAM-9416] BIP-1: Convert Avro metadata to Schema options

2020-03-25 Thread GitBox
alexvanboxel opened a new pull request #11217: [BEAM-9416] BIP-1: Convert Avro metadata to Schema options URL: https://github.com/apache/beam/pull/11217 Convert Avro properties to Typed Beam Schema Options. The avro implementation of the schema options Post-Commit Tests Status

[GitHub] [beam] echauchot commented on a change in pull request #11055: [BEAM-9436] Improve GBK in spark structured streaming runner

2020-03-25 Thread GitBox
echauchot commented on a change in pull request #11055: [BEAM-9436] Improve GBK in spark structured streaming runner URL: https://github.com/apache/beam/pull/11055#discussion_r397716574 ## File path: runners/spark/src/main/java/org/apache/beam/runners/spark/structuredstreaming/tran

[GitHub] [beam] iemejia commented on issue #11028: BEAM-2546 Beam IO for InfluxDB

2020-03-25 Thread GitBox
iemejia commented on issue #11028: BEAM-2546 Beam IO for InfluxDB URL: https://github.com/apache/beam/pull/11028#issuecomment-603750036 Sorry for the delay and thanks for your patience @bipinupd , my review queue at least is finally advancing. I added @mwalenia so he can help me verfify tha

[GitHub] [beam] kamilwu commented on issue #11206: [BEAM-9598] Ensuring _CustomBigQuerySource ValueProvider is only checked when strictly needed

2020-03-25 Thread GitBox
kamilwu commented on issue #11206: [BEAM-9598] Ensuring _CustomBigQuerySource ValueProvider is only checked when strictly needed URL: https://github.com/apache/beam/pull/11206#issuecomment-603751295 @pabloem Thanks for the fix :) ---

[GitHub] [beam] alexvanboxel commented on a change in pull request #10529: [BEAM-9044] Protobuf options to Schema options

2020-03-25 Thread GitBox
alexvanboxel commented on a change in pull request #10529: [BEAM-9044] Protobuf options to Schema options URL: https://github.com/apache/beam/pull/10529#discussion_r397748991 ## File path: sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoSche

[GitHub] [beam] mwalenia commented on a change in pull request #11028: BEAM-2546 Beam IO for InfluxDB

2020-03-25 Thread GitBox
mwalenia commented on a change in pull request #11028: BEAM-2546 Beam IO for InfluxDB URL: https://github.com/apache/beam/pull/11028#discussion_r397759342 ## File path: .test-infra/jenkins/job_PerformanceTests_InfluxDBIO_IT.groovy ## @@ -0,0 +1,54 @@ +/* + * Licensed to th

[GitHub] [beam] EDjur commented on issue #11206: [BEAM-9598] Ensuring _CustomBigQuerySource ValueProvider is only checked when strictly needed

2020-03-25 Thread GitBox
EDjur commented on issue #11206: [BEAM-9598] Ensuring _CustomBigQuerySource ValueProvider is only checked when strictly needed URL: https://github.com/apache/beam/pull/11206#issuecomment-603780062 Cheers for the quick fix @pabloem --

[GitHub] [beam] alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options

2020-03-25 Thread GitBox
alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options URL: https://github.com/apache/beam/pull/10529#issuecomment-603781120 Run Java PreCommit This is an automated message from the Apache Git

[GitHub] [beam] kamilwu commented on issue #11213: [BEAM-9214] Add missing argument to GetJobMetrics.

2020-03-25 Thread GitBox
kamilwu commented on issue #11213: [BEAM-9214] Add missing argument to GetJobMetrics. URL: https://github.com/apache/beam/pull/11213#issuecomment-603783082 Could you elaborate on why this change is needed? I see that proto representation of `GetJobMetricsRequest` hasn't changed recently:

[GitHub] [beam] aromanenko-dev commented on issue #11099: [BEAM-9420] Configurable timeout for blocking kafka API call(s)

2020-03-25 Thread GitBox
aromanenko-dev commented on issue #11099: [BEAM-9420] Configurable timeout for blocking kafka API call(s) URL: https://github.com/apache/beam/pull/11099#issuecomment-603786407 Run Java PreCommit This is an automated message f

[GitHub] [beam] kamilwu commented on issue #11193: [BEAM-9550] Increase JVM Metaspace size for the TaskExecutors.

2020-03-25 Thread GitBox
kamilwu commented on issue #11193: [BEAM-9550] Increase JVM Metaspace size for the TaskExecutors. URL: https://github.com/apache/beam/pull/11193#issuecomment-603808862 Run Chicago Taxi on Flink This is an automated message fr

[GitHub] [beam] alexvanboxel opened a new pull request #11218: [BEAM-9605] BIP-1: Rename setRowOption to setOption on Option builder

2020-03-25 Thread GitBox
alexvanboxel opened a new pull request #11218: [BEAM-9605] BIP-1: Rename setRowOption to setOption on Option builder URL: https://github.com/apache/beam/pull/11218 Rename setRowOption to setOption on Option builder as setRowOption name is too confusing. It sets an option as a Row,

[GitHub] [beam] kamilwu commented on issue #11193: [BEAM-9550] Increase JVM Metaspace size for the TaskExecutors.

2020-03-25 Thread GitBox
kamilwu commented on issue #11193: [BEAM-9550] Increase JVM Metaspace size for the TaskExecutors. URL: https://github.com/apache/beam/pull/11193#issuecomment-603841123 Run Load Tests Python GBK Flink Batch This is an automate

[GitHub] [beam] kamilwu commented on issue #11193: [BEAM-9550] Increase JVM Metaspace size for the TaskExecutors.

2020-03-25 Thread GitBox
kamilwu commented on issue #11193: [BEAM-9550] Increase JVM Metaspace size for the TaskExecutors. URL: https://github.com/apache/beam/pull/11193#issuecomment-603840955 Run Load Tests Python CoGBK Flink Batch This is an automa

[GitHub] [beam] kamilwu commented on issue #11193: [BEAM-9550] Increase JVM Metaspace size for the TaskExecutors.

2020-03-25 Thread GitBox
kamilwu commented on issue #11193: [BEAM-9550] Increase JVM Metaspace size for the TaskExecutors. URL: https://github.com/apache/beam/pull/11193#issuecomment-603841228 Run Python Load Tests ParDo Flink Batch This is an automa

[GitHub] [beam] aromanenko-dev merged pull request #11099: [BEAM-9420] Configurable timeout for blocking kafka API call(s)

2020-03-25 Thread GitBox
aromanenko-dev merged pull request #11099: [BEAM-9420] Configurable timeout for blocking kafka API call(s) URL: https://github.com/apache/beam/pull/11099 This is an automated message from the Apache Git Service. To respond t

[GitHub] [beam] piotr-szuberski opened a new pull request #11219: [BEAM-9606] Add missing parameters in combine_test.py gradle example

2020-03-25 Thread GitBox
piotr-szuberski opened a new pull request #11219: [BEAM-9606] Add missing parameters in combine_test.py gradle example URL: https://github.com/apache/beam/pull/11219 @kamilwu Thank you for your contribution! Follow this checklist to help us incorpora

[GitHub] [beam] iemejia commented on issue #11210: [WIP] [BEAM-8949] SpannerIO Read integration tests

2020-03-25 Thread GitBox
iemejia commented on issue #11210: [WIP] [BEAM-8949] SpannerIO Read integration tests URL: https://github.com/apache/beam/pull/11210#issuecomment-603904530 retest this please This is an automated message from the Apache Git S

[GitHub] [beam] iemejia commented on issue #11210: [WIP] [BEAM-8949] SpannerIO Read integration tests

2020-03-25 Thread GitBox
iemejia commented on issue #11210: [WIP] [BEAM-8949] SpannerIO Read integration tests URL: https://github.com/apache/beam/pull/11210#issuecomment-603904688 retest this please This is an automated message from the Apache Git S

[GitHub] [beam] iemejia removed a comment on issue #11210: [WIP] [BEAM-8949] SpannerIO Read integration tests

2020-03-25 Thread GitBox
iemejia removed a comment on issue #11210: [WIP] [BEAM-8949] SpannerIO Read integration tests URL: https://github.com/apache/beam/pull/11210#issuecomment-603904688 retest this please This is an automated message from the Apac

[GitHub] [beam] lukecwik commented on a change in pull request #11216: [BEAM-9562] Remove TimerSpec from ParDoPayload

2020-03-25 Thread GitBox
lukecwik commented on a change in pull request #11216: [BEAM-9562] Remove TimerSpec from ParDoPayload URL: https://github.com/apache/beam/pull/11216#discussion_r397940099 ## File path: model/pipeline/src/main/proto/beam_runner_api.proto ## @@ -442,35 +442,30 @@ message Par

[GitHub] [beam] lukecwik commented on a change in pull request #11216: [BEAM-9562] Remove TimerSpec from ParDoPayload

2020-03-25 Thread GitBox
lukecwik commented on a change in pull request #11216: [BEAM-9562] Remove TimerSpec from ParDoPayload URL: https://github.com/apache/beam/pull/11216#discussion_r397943829 ## File path: sdks/python/apache_beam/transforms/userstate.py ## @@ -149,6 +158,26 @@ def to_runner_ap

[GitHub] [beam] lukecwik commented on a change in pull request #11216: [BEAM-9562] Remove TimerSpec from ParDoPayload

2020-03-25 Thread GitBox
lukecwik commented on a change in pull request #11216: [BEAM-9562] Remove TimerSpec from ParDoPayload URL: https://github.com/apache/beam/pull/11216#discussion_r397942726 ## File path: sdks/python/apache_beam/transforms/userstate.py ## @@ -141,6 +143,13 @@ def __init__(sel

[GitHub] [beam] brucearctor opened a new pull request #11209: update/remove LTS policy

2020-03-25 Thread GitBox
brucearctor opened a new pull request #11209: update/remove LTS policy URL: https://github.com/apache/beam/pull/11209 @iemejia Removed LTS bit, and condensed rest of info. Thank you for your contribution! Follow this checklist to help us inco

[GitHub] [beam] iemejia commented on a change in pull request #11028: BEAM-2546 Beam IO for InfluxDB

2020-03-25 Thread GitBox
iemejia commented on a change in pull request #11028: BEAM-2546 Beam IO for InfluxDB URL: https://github.com/apache/beam/pull/11028#discussion_r397962741 ## File path: .test-infra/jenkins/job_PerformanceTests_InfluxDBIO_IT.groovy ## @@ -0,0 +1,54 @@ +/* + * Licensed to the

[GitHub] [beam] kamilwu commented on issue #11219: [BEAM-9606] Add missing parameters in combine_test.py gradle example

2020-03-25 Thread GitBox
kamilwu commented on issue #11219: [BEAM-9606] Add missing parameters in combine_test.py gradle example URL: https://github.com/apache/beam/pull/11219#issuecomment-603927193 Retest this please This is an automated message fro

[GitHub] [beam] lostluck merged pull request #11211: Go changes for model updates.

2020-03-25 Thread GitBox
lostluck merged pull request #11211: Go changes for model updates. URL: https://github.com/apache/beam/pull/11211 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [beam] udim commented on issue #11212: [BEAM-8280] Type hints via annotations snippets

2020-03-25 Thread GitBox
udim commented on issue #11212: [BEAM-8280] Type hints via annotations snippets URL: https://github.com/apache/beam/pull/11212#issuecomment-603933281 Run Python PreCommit This is an automated message from the Apache Git Servic

[GitHub] [beam] lukecwik commented on issue #11211: Go changes for model updates.

2020-03-25 Thread GitBox
lukecwik commented on issue #11211: Go changes for model updates. URL: https://github.com/apache/beam/pull/11211#issuecomment-603944053 thanks for finding this This is an automated message from the Apache Git Service. To respo

[GitHub] [beam] lukecwik commented on a change in pull request #11211: Go changes for model updates.

2020-03-25 Thread GitBox
lukecwik commented on a change in pull request #11211: Go changes for model updates. URL: https://github.com/apache/beam/pull/11211#discussion_r397995619 ## File path: sdks/go/pkg/beam/core/runtime/pipelinex/clone.go ## @@ -64,10 +64,8 @@ func ShallowCloneParDoPayload(p *p

[GitHub] [beam] kamilwu commented on issue #11219: [BEAM-9606] Add missing parameters in combine_test.py gradle example

2020-03-25 Thread GitBox
kamilwu commented on issue #11219: [BEAM-9606] Add missing parameters in combine_test.py gradle example URL: https://github.com/apache/beam/pull/11219#issuecomment-603955446 Looks good, thanks This is an automated message fro

[GitHub] [beam] kamilwu merged pull request #11219: [BEAM-9606] Add missing parameters in combine_test.py gradle example

2020-03-25 Thread GitBox
kamilwu merged pull request #11219: [BEAM-9606] Add missing parameters in combine_test.py gradle example URL: https://github.com/apache/beam/pull/11219 This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] boyuanzz commented on a change in pull request #11216: [BEAM-9562] Remove TimerSpec from ParDoPayload

2020-03-25 Thread GitBox
boyuanzz commented on a change in pull request #11216: [BEAM-9562] Remove TimerSpec from ParDoPayload URL: https://github.com/apache/beam/pull/11216#discussion_r398011965 ## File path: sdks/python/apache_beam/transforms/userstate.py ## @@ -141,6 +143,13 @@ def __init__(sel

[GitHub] [beam] udim merged pull request #11110: [BEAM-9398] runtime_type_check: support setup

2020-03-25 Thread GitBox
udim merged pull request #0: [BEAM-9398] runtime_type_check: support setup URL: https://github.com/apache/beam/pull/0 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] robertwb commented on issue #11165: [BEAM-9340] Populate requirements for Java.

2020-03-25 Thread GitBox
robertwb commented on issue #11165: [BEAM-9340] Populate requirements for Java. URL: https://github.com/apache/beam/pull/11165#issuecomment-603962869 Now org.apache.beam.sdk.io.cassandra.CassandraIOTest.classMethod is failing. These are unrelated and didn't fail before. Merging. -

[GitHub] [beam] robertwb merged pull request #11165: [BEAM-9340] Populate requirements for Java.

2020-03-25 Thread GitBox
robertwb merged pull request #11165: [BEAM-9340] Populate requirements for Java. URL: https://github.com/apache/beam/pull/11165 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [beam] udim merged pull request #11212: [BEAM-8280] Type hints via annotations snippets

2020-03-25 Thread GitBox
udim merged pull request #11212: [BEAM-8280] Type hints via annotations snippets URL: https://github.com/apache/beam/pull/11212 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [beam] mxm opened a new pull request #11220: [BEAM-9573][release-2.0] Correct computing of watermark hold for timer output timestamp

2020-03-25 Thread GitBox
mxm opened a new pull request #11220: [BEAM-9573][release-2.0] Correct computing of watermark hold for timer output timestamp URL: https://github.com/apache/beam/pull/11220 ### Backport of #11200. With the introduction of timer output timestamps, a new watermark hold had been add

[GitHub] [beam] alexvanboxel commented on issue #11217: [BEAM-9416] BIP-1: Convert Avro metadata to Schema options

2020-03-25 Thread GitBox
alexvanboxel commented on issue #11217: [BEAM-9416] BIP-1: Convert Avro metadata to Schema options URL: https://github.com/apache/beam/pull/11217#issuecomment-603976975 Run Python PreCommit This is an automated message from t

[GitHub] [beam] alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options

2020-03-25 Thread GitBox
alexvanboxel commented on issue #10529: [BEAM-9044] Protobuf options to Schema options URL: https://github.com/apache/beam/pull/10529#issuecomment-603977599 Run Java PreCommit This is an automated message from the Apache Git

[GitHub] [beam] jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-03-25 Thread GitBox
jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-603980265 Open Questions: 1. Should we remove adaptive throttling? - Seems that we're using retries in the client request initializer and right now a "bad record" wi

[GitHub] [beam] robertwb opened a new pull request #11221: Add base SDK version to environment capabilities for Python and Java.

2020-03-25 Thread GitBox
robertwb opened a new pull request #11221: Add base SDK version to environment capabilities for Python and Java. URL: https://github.com/apache/beam/pull/11221 Go doesn't seem to meaningfully provide this information yet (always using latest unless manually specified). ---

[GitHub] [beam] robertwb commented on issue #11221: Add base SDK version to environment capabilities for Python and Java.

2020-03-25 Thread GitBox
robertwb commented on issue #11221: Add base SDK version to environment capabilities for Python and Java. URL: https://github.com/apache/beam/pull/11221#issuecomment-603983689 R: @ananvay This is an automated message from the

[GitHub] [beam] amaliujia commented on issue #11220: [BEAM-9573][release-2.20] Correct computing of watermark hold for timer output timestamp

2020-03-25 Thread GitBox
amaliujia commented on issue #11220: [BEAM-9573][release-2.20] Correct computing of watermark hold for timer output timestamp URL: https://github.com/apache/beam/pull/11220#issuecomment-603985830 LGTM after necessary tests pass --

[GitHub] [beam] robertwb opened a new pull request #11222: [BEAM-4150] Don't window PCollection coders.

2020-03-25 Thread GitBox
robertwb opened a new pull request #11222: [BEAM-4150] Don't window PCollection coders. URL: https://github.com/apache/beam/pull/11222 Now that no SDKs require it. Thank you for your contribution! Follow this checklist to help us incorporate your cont

[GitHub] [beam] suztomo commented on issue #11208: [BEAM-8751] google-api-client 1.30.9

2020-03-25 Thread GitBox
suztomo commented on issue #11208: [BEAM-8751] google-api-client 1.30.9 URL: https://github.com/apache/beam/pull/11208#issuecomment-603992166 Java Precommit failed but it seem irrelevant: ``` Error Message org.junit.runners.model.TestTimedOutException: test timed out after 3

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-03-25 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-603992173 retest this please This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-03-25 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-603993805 retest this please This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-03-25 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-603993940 retest this please This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-03-25 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-603996758 retest this please This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [beam] suztomo edited a comment on issue #11208: [BEAM-8751] google-api-client 1.30.9

2020-03-25 Thread GitBox
suztomo edited a comment on issue #11208: [BEAM-8751] google-api-client 1.30.9 URL: https://github.com/apache/beam/pull/11208#issuecomment-603992166 Java Precommit failed but it seem irrelevant: ``` Error Message org.junit.runners.model.TestTimedOutException: test timed out afte

[GitHub] [beam] alanmyrvold commented on issue #11067: [BEAM-9136]Add licenses for dependencies

2020-03-25 Thread GitBox
alanmyrvold commented on issue #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#issuecomment-60356 > I'll second the comment that we should not include the list of license files in the beam repository itself, but just add the script to the

[GitHub] [beam] jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-03-25 Thread GitBox
jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-604001261 Future improvements: - Currently this uses the alpha API because the motivating use case of HL7v2 -> FHIR mapping which requires the `schematizedData` field (not

[GitHub] [beam] apilloud opened a new pull request #11223: [BEAM-9609] Upgrade to ZetaSQL 2020.03.2

2020-03-25 Thread GitBox
apilloud opened a new pull request #11223: [BEAM-9609] Upgrade to ZetaSQL 2020.03.2 URL: https://github.com/apache/beam/pull/11223 Upgrade to ZetaSQL 2020.03.2 for better mac support. DNM: until the release is out. Thank you for your contributio

[GitHub] [beam] TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform

2020-03-25 Thread GitBox
TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform URL: https://github.com/apache/beam/pull/10055#issuecomment-604009131 Run XVR_Spark PostCommit This is an automated message from the Apache Git Servic

[GitHub] [beam] robertwb opened a new pull request #11224: [BEAM-9340] Validate pipeline requirements in PipelineValidator.

2020-03-25 Thread GitBox
robertwb opened a new pull request #11224: [BEAM-9340] Validate pipeline requirements in PipelineValidator. URL: https://github.com/apache/beam/pull/11224 Thank you for your contribution! Follow this checklist to help us incorporate your contribution qui

[GitHub] [beam] alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies

2020-03-25 Thread GitBox
alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#discussion_r398073526 ## File path: sdks/java/container/build.gradle ## @@ -82,3 +87,4 @@ docker { // Ensure that we build the

[GitHub] [beam] alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies

2020-03-25 Thread GitBox
alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#discussion_r398077003 ## File path: sdks/python/container/py37/build.gradle ## @@ -51,6 +51,11 @@ task copyLauncherDependencies

[GitHub] [beam] alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies

2020-03-25 Thread GitBox
alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#discussion_r398073171 ## File path: sdks/java/container/build.gradle ## @@ -68,6 +68,11 @@ golang { } } +task copyDepende

[GitHub] [beam] alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies

2020-03-25 Thread GitBox
alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#discussion_r398076913 ## File path: sdks/python/container/py36/build.gradle ## @@ -51,6 +51,11 @@ task copyLauncherDependencies

[GitHub] [beam] alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies

2020-03-25 Thread GitBox
alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#discussion_r398076198 ## File path: licenses/java/index.html ## @@ -0,0 +1,6290 @@ + Review comment: Does this file need

[GitHub] [beam] alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies

2020-03-25 Thread GitBox
alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#discussion_r398076695 ## File path: sdks/python/container/py2/build.gradle ## @@ -51,6 +51,11 @@ task copyLauncherDependencies(

[GitHub] [beam] alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies

2020-03-25 Thread GitBox
alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#discussion_r398071329 ## File path: sdks/go/container/license_scripts/pull_licenses_go.py ## @@ -0,0 +1,132 @@ +# +# Licensed t

[GitHub] [beam] alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies

2020-03-25 Thread GitBox
alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#discussion_r398067882 ## File path: sdks/go/container/build.gradle ## @@ -45,6 +45,11 @@ golang { } } +task copyDependenc

[GitHub] [beam] alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies

2020-03-25 Thread GitBox
alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#discussion_r398076817 ## File path: sdks/python/container/py35/build.gradle ## @@ -51,6 +51,11 @@ task copyLauncherDependencies

[GitHub] [beam] alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies

2020-03-25 Thread GitBox
alanmyrvold commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#discussion_r398065394 ## File path: licenses/go/bufio/LICENSE ## @@ -0,0 +1,27 @@ +Copyright (c) 2009 The Go Authors. All right

[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11202: [BEAM-9608] Refactoring FnApiRunner to have more context managers

2020-03-25 Thread GitBox
Hannah-Jiang commented on a change in pull request #11202: [BEAM-9608] Refactoring FnApiRunner to have more context managers URL: https://github.com/apache/beam/pull/11202#discussion_r398079535 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py ##

[GitHub] [beam] robertwb commented on issue #11224: [BEAM-9340] Validate pipeline requirements in PipelineValidator.

2020-03-25 Thread GitBox
robertwb commented on issue #11224: [BEAM-9340] Validate pipeline requirements in PipelineValidator. URL: https://github.com/apache/beam/pull/11224#issuecomment-604014835 Follow-up to https://github.com/apache/beam/pull/11165

[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies

2020-03-25 Thread GitBox
Hannah-Jiang commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#discussion_r39803 ## File path: licenses/go/bufio/LICENSE ## @@ -0,0 +1,27 @@ +Copyright (c) 2009 The Go Authors. All righ

[GitHub] [beam] rehmanmuradali commented on a change in pull request #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-03-25 Thread GitBox
rehmanmuradali commented on a change in pull request #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#discussion_r397529536 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnSignatures

[GitHub] [beam] ananvay commented on issue #11221: Add base SDK version to environment capabilities for Python and Java.

2020-03-25 Thread GitBox
ananvay commented on issue #11221: Add base SDK version to environment capabilities for Python and Java. URL: https://github.com/apache/beam/pull/11221#issuecomment-604022464 /cc: @lostluck for tracking the addition of this to Go SDK later. LGTM. Thanks Robert! -

[GitHub] [beam] pabloem commented on a change in pull request #11202: [BEAM-9608] Refactoring FnApiRunner to have more context managers

2020-03-25 Thread GitBox
pabloem commented on a change in pull request #11202: [BEAM-9608] Refactoring FnApiRunner to have more context managers URL: https://github.com/apache/beam/pull/11202#discussion_r398094737 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py ###

[GitHub] [beam] Ardagan commented on issue #10949: [BEAM-9371] Add SideInputLoadTest to Java SDK

2020-03-25 Thread GitBox
Ardagan commented on issue #10949: [BEAM-9371] Add SideInputLoadTest to Java SDK URL: https://github.com/apache/beam/pull/10949#issuecomment-604026937 retest this please This is an automated message from the Apache Git Service

[GitHub] [beam] TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform

2020-03-25 Thread GitBox
TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform URL: https://github.com/apache/beam/pull/10055#issuecomment-604027617 R: @robertwb could you review this? This is an automated message from the Apache

[GitHub] [beam] ihji commented on issue #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java

2020-03-25 Thread GitBox
ihji commented on issue #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java URL: https://github.com/apache/beam/pull/11205#issuecomment-604028675 directory type and unzip_to role added. didn't create a interface for resolving artifacts since we only have one (resolving direc

[GitHub] [beam] aaltay commented on issue #11208: [BEAM-8751] google-api-client 1.30.9

2020-03-25 Thread GitBox
aaltay commented on issue #11208: [BEAM-8751] google-api-client 1.30.9 URL: https://github.com/apache/beam/pull/11208#issuecomment-604032702 Run Java PreCommit This is an automated message from the Apache Git Service. To respo

[GitHub] [beam] youngoli opened a new pull request #11225: [BEAM-3301] Fix another bug in DoFn validation, in exec.

2020-03-25 Thread GitBox
youngoli opened a new pull request #11225: [BEAM-3301] Fix another bug in DoFn validation, in exec. URL: https://github.com/apache/beam/pull/11225 This was the same error from the previous bugfix, but I missed it in the exec package since I only checked locally. Instead of fixing it the

[GitHub] [beam] youngoli commented on issue #11225: [BEAM-3301] Fix another bug in DoFn validation, in exec.

2020-03-25 Thread GitBox
youngoli commented on issue #11225: [BEAM-3301] Fix another bug in DoFn validation, in exec. URL: https://github.com/apache/beam/pull/11225#issuecomment-604033853 R: @lostluck As a note for the future, does it seem valuable to add an integration test that catches this case? It just

[GitHub] [beam] apilloud commented on issue #11223: [BEAM-9609] Upgrade to ZetaSQL 2020.03.2

2020-03-25 Thread GitBox
apilloud commented on issue #11223: [BEAM-9609] Upgrade to ZetaSQL 2020.03.2 URL: https://github.com/apache/beam/pull/11223#issuecomment-604034756 run sql postcommit This is an automated message from the Apache Git Service. To

[GitHub] [beam] reuvenlax opened a new pull request #11226: [BEAM-9557] Fix timer window boundary checking

2020-03-25 Thread GitBox
reuvenlax opened a new pull request #11226: [BEAM-9557] Fix timer window boundary checking URL: https://github.com/apache/beam/pull/11226 R: @steveniemitz This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] steveniemitz commented on issue #11226: [BEAM-9557] Fix timer window boundary checking

2020-03-25 Thread GitBox
steveniemitz commented on issue #11226: [BEAM-9557] Fix timer window boundary checking URL: https://github.com/apache/beam/pull/11226#issuecomment-604042702 can we add a unit test to validate this behavior as well? This is

[GitHub] [beam] rohdesamuel opened a new pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature

2020-03-25 Thread GitBox
rohdesamuel opened a new pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227 Change-Id: I9caaf395fd0fc58565e54a8458e8289af761815f The InteractiveRunner requires Python3.5.3+. We have

[GitHub] [beam] pabloem commented on a change in pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature

2020-03-25 Thread GitBox
pabloem commented on a change in pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227#discussion_r398120887 ## File path: sdks/python/apache_beam/runners/interactive/interactive_runn

[GitHub] [beam] pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature

2020-03-25 Thread GitBox
pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227#issuecomment-604045227 retest this please This is an autom

[GitHub] [beam] udim commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test

2020-03-25 Thread GitBox
udim commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test URL: https://github.com/apache/beam/pull/10914#issuecomment-604051436 Opened https://issues.apache.org/jira/browse/BEAM-9610 for the flaky postcommit test ---

[GitHub] [beam] TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform

2020-03-25 Thread GitBox
TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform URL: https://github.com/apache/beam/pull/10055#issuecomment-604052011 Run XVR_Flink PostCommit This is an automated message from the Apache Git Servic

[GitHub] [beam] udim merged pull request #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test

2020-03-25 Thread GitBox
udim merged pull request #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test URL: https://github.com/apache/beam/pull/10914 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-03-25 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-604060180 retest this please This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [beam] lostluck commented on issue #11211: Go changes for model updates.

2020-03-25 Thread GitBox
lostluck commented on issue #11211: Go changes for model updates. URL: https://github.com/apache/beam/pull/11211#issuecomment-604071322 Not yet. @youngoli can handle that when im the execution later is submitted. Currently just the validation is in, without any way to execute.

[GitHub] [beam] amaliujia commented on a change in pull request #11204: [BEAM-9579] Fix numpy logic operators

2020-03-25 Thread GitBox
amaliujia commented on a change in pull request #11204: [BEAM-9579] Fix numpy logic operators URL: https://github.com/apache/beam/pull/11204#discussion_r398151570 ## File path: CHANGES.md ## @@ -116,6 +116,7 @@ ## Bugfixes +* Fixed numpy operators in ApproximateQuanti

[GitHub] [beam] chamikaramj commented on issue #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-03-25 Thread GitBox
chamikaramj commented on issue #11039: [BEAM-9383] Staging Dataflow artifacts from environment URL: https://github.com/apache/beam/pull/11039#issuecomment-604072538 Retest this please This is an automated message from the Apa

[GitHub] [beam] amaliujia commented on a change in pull request #11204: [BEAM-9579] Fix numpy logic operators

2020-03-25 Thread GitBox
amaliujia commented on a change in pull request #11204: [BEAM-9579] Fix numpy logic operators URL: https://github.com/apache/beam/pull/11204#discussion_r398151570 ## File path: CHANGES.md ## @@ -116,6 +116,7 @@ ## Bugfixes +* Fixed numpy operators in ApproximateQuanti

[GitHub] [beam] amaliujia commented on a change in pull request #11204: [BEAM-9579] Fix numpy logic operators

2020-03-25 Thread GitBox
amaliujia commented on a change in pull request #11204: [BEAM-9579] Fix numpy logic operators URL: https://github.com/apache/beam/pull/11204#discussion_r398151570 ## File path: CHANGES.md ## @@ -116,6 +116,7 @@ ## Bugfixes +* Fixed numpy operators in ApproximateQuanti

[GitHub] [beam] lostluck edited a comment on issue #11211: Go changes for model updates.

2020-03-25 Thread GitBox
lostluck edited a comment on issue #11211: Go changes for model updates. URL: https://github.com/apache/beam/pull/11211#issuecomment-604071322 Not yet. @youngoli can handle that when the execution layer is submitted. Currently just the validation is in, without any way to execute.

[GitHub] [beam] apilloud commented on issue #11223: [BEAM-9609] Upgrade to ZetaSQL 2020.03.2

2020-03-25 Thread GitBox
apilloud commented on issue #11223: [BEAM-9609] Upgrade to ZetaSQL 2020.03.2 URL: https://github.com/apache/beam/pull/11223#issuecomment-604080851 run sql postcommit This is an automated message from the Apache Git Service. To

[GitHub] [beam] apilloud commented on issue #11223: [BEAM-9609] Upgrade to ZetaSQL 2020.03.2

2020-03-25 Thread GitBox
apilloud commented on issue #11223: [BEAM-9609] Upgrade to ZetaSQL 2020.03.2 URL: https://github.com/apache/beam/pull/11223#issuecomment-604080895 run java precommit This is an automated message from the Apache Git Service. To

  1   2   >