[GitHub] [beam] iindyk commented on pull request #12420: Extending ApproximateQuantiles functionality to deal with non-uniform weights.

iindyk commented on pull request #12420: URL: https://github.com/apache/beam/pull/12420#issuecomment-671376299 Friendly ping @pabloem This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] mxm commented on a change in pull request #12499: [BEAM-10602] Fix load test metrics in Grafana dashboard

mxm commented on a change in pull request #12499: URL: https://github.com/apache/beam/pull/12499#discussion_r467943622 ## File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy ## @@ -161,12 +164,13 @@ def streamingScenarios = { datasetName -> test

[GitHub] [beam] lazylynx commented on a change in pull request #12239: [BEAM-9980] tests tied with Python versions configurable

lazylynx commented on a change in pull request #12239: URL: https://github.com/apache/beam/pull/12239#discussion_r467879685 ## File path: sdks/python/test-suites/gradle.properties ## @@ -0,0 +1,38 @@

[GitHub] [beam] rezarokni commented on a change in pull request #12490: [BEAM-10124] Add ContextualTextIO

rezarokni commented on a change in pull request #12490: URL: https://github.com/apache/beam/pull/12490#discussion_r467801851 ## File path: sdks/java/io/contextual-text-io/src/main/java/org/apache/beam/sdk/io/ContextualTextIO/ContextualTextIO.java ## @@ -0,0 +1,554 @@ +/* + *

[GitHub] [beam] piotr-szuberski commented on pull request #12297: [BEAM-10137] Add KinesisIO for cross-language usage with python wrapper

piotr-szuberski commented on pull request #12297: URL: https://github.com/apache/beam/pull/12297#issuecomment-671271227 @TheNeuralBit Ping This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] kamilwu commented on pull request #11856: [BEAM-7505] SideInput Python Load Test job

kamilwu commented on pull request #11856: URL: https://github.com/apache/beam/pull/11856#issuecomment-671297872 bump This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] TobKed commented on pull request #12452: [BEAM-10623] Add workflow to run Beam python tests on Linux/Windows/Mac platforms

TobKed commented on pull request #12452: URL: https://github.com/apache/beam/pull/12452#issuecomment-671384857 > > @tvalentyn answering your question: > > > Also, all actions workflow run in parallel, right? so it takes roughly the same time as running a regular precommit? In such case

[GitHub] [beam] aromanenko-dev commented on pull request #12422: [BEAM-601] Run KinesisIOIT with localstack

aromanenko-dev commented on pull request #12422: URL: https://github.com/apache/beam/pull/12422#issuecomment-671385520 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] aromanenko-dev commented on pull request #12422: [BEAM-601] Run KinesisIOIT with localstack

aromanenko-dev commented on pull request #12422: URL: https://github.com/apache/beam/pull/12422#issuecomment-671385731 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] mxm commented on a change in pull request #12499: [BEAM-10602] Fix load test metrics in Grafana dashboard

mxm commented on a change in pull request #12499: URL: https://github.com/apache/beam/pull/12499#discussion_r467943622 ## File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy ## @@ -161,12 +164,13 @@ def streamingScenarios = { datasetName -> test

[GitHub] [beam] mxm commented on a change in pull request #12499: [BEAM-10602] Fix load test metrics in Grafana dashboard

mxm commented on a change in pull request #12499: URL: https://github.com/apache/beam/pull/12499#discussion_r467948430 ## File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy ## @@ -161,12 +164,13 @@ def streamingScenarios = { datasetName -> test

[GitHub] [beam] echauchot opened a new pull request #12510: [BEAM-10471] change the test condition for testEstimatedSizeBytes to greater than 0 to ensure that the dataset is a least split.

echauchot opened a new pull request #12510: URL: https://github.com/apache/beam/pull/12510 As discussed in the ticket Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ]

[GitHub] [beam] kennknowles commented on pull request #12366: [BEAM-10572] Eliminate nullability errors from :sdks:java:extensions:sql:datacatalog

kennknowles commented on pull request #12366: URL: https://github.com/apache/beam/pull/12366#issuecomment-671362622 Here: https://github.com/apache/beam/blob/de8ff705145cbbc41bea7750a0a5d3553924ab3a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L763 This

[GitHub] [beam] jayendra13 commented on pull request #12366: [BEAM-10572] Eliminate nullability errors from :sdks:java:extensions:sql:datacatalog

jayendra13 commented on pull request #12366: URL: https://github.com/apache/beam/pull/12366#issuecomment-671367166 Run SQL_Java11 PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] aromanenko-dev commented on pull request #12422: [BEAM-601] Run KinesisIOIT with localstack

aromanenko-dev commented on pull request #12422: URL: https://github.com/apache/beam/pull/12422#issuecomment-671386509 @piotr-szuberski Thanks, almost LGTM, just a minor question above. This is an automated message from the

[GitHub] [beam] kennknowles commented on pull request #12366: [BEAM-10572] Eliminate nullability errors from :sdks:java:extensions:sql:datacatalog

kennknowles commented on pull request #12366: URL: https://github.com/apache/beam/pull/12366#issuecomment-671363224 It also looks like `-PskipCheckerFramework` is supported by kelloggm/checkerframework-gradle-plugin so you can just add that flag to the Jenkins job. That is probably best.

[GitHub] [beam] mxm commented on a change in pull request #12499: [BEAM-10602] Fix load test metrics in Grafana dashboard

mxm commented on a change in pull request #12499: URL: https://github.com/apache/beam/pull/12499#discussion_r467944914 ## File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy ## @@ -161,12 +164,13 @@ def streamingScenarios = { datasetName -> test

[GitHub] [beam] abhiy13 commented on a change in pull request #12490: [BEAM-10124] Add ContextualTextIO

abhiy13 commented on a change in pull request #12490: URL: https://github.com/apache/beam/pull/12490#discussion_r467845547 ## File path: sdks/java/io/contextual-text-io/src/main/java/org/apache/beam/sdk/io/ContextualTextIO/ContextualTextIO.java ## @@ -0,0 +1,554 @@ +/* + *

[GitHub] [beam] rezarokni commented on a change in pull request #12490: [BEAM-10124] Add ContextualTextIO

rezarokni commented on a change in pull request #12490: URL: https://github.com/apache/beam/pull/12490#discussion_r467899935 ## File path: sdks/java/io/contextual-text-io/src/main/java/org/apache/beam/sdk/io/ContextualTextIO/ContextualTextIO.java ## @@ -0,0 +1,554 @@ +/* + *

[GitHub] [beam] kamilwu commented on a change in pull request #12499: [BEAM-10602] Fix load test metrics in Grafana dashboard

kamilwu commented on a change in pull request #12499: URL: https://github.com/apache/beam/pull/12499#discussion_r467907301 ## File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy ## @@ -161,12 +164,13 @@ def streamingScenarios = { datasetName -> test

[GitHub] [beam] jayendra13 commented on a change in pull request #12366: [BEAM-10572] Eliminate nullability errors from :sdks:java:extensions:sql:datacatalog

jayendra13 commented on a change in pull request #12366: URL: https://github.com/apache/beam/pull/12366#discussion_r467930130 ## File path: sdks/java/extensions/sql/datacatalog/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/datacatalog/DataCatalogBigQueryIT.java

[GitHub] [beam] jayendra13 commented on pull request #12366: [BEAM-10572] Eliminate nullability errors from :sdks:java:extensions:sql:datacatalog

jayendra13 commented on pull request #12366: URL: https://github.com/apache/beam/pull/12366#issuecomment-671378392 > It also looks like `-PskipCheckerFramework` is supported by kelloggm/checkerframework-gradle-plugin so you can just add that flag to the Jenkins job. That is probably best.

[GitHub] [beam] aromanenko-dev commented on a change in pull request #12422: [BEAM-601] Run KinesisIOIT with localstack

aromanenko-dev commented on a change in pull request #12422: URL: https://github.com/apache/beam/pull/12422#discussion_r467936493 ## File path: sdks/java/io/kinesis/src/test/java/org/apache/beam/sdk/io/kinesis/KinesisIOIT.java ## @@ -35,33 +42,51 @@ import

[GitHub] [beam] piotr-szuberski commented on pull request #12297: [BEAM-10137] Add KinesisIO for cross-language usage with python wrapper

piotr-szuberski commented on pull request #12297: URL: https://github.com/apache/beam/pull/12297#issuecomment-671293518 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] piotr-szuberski removed a comment on pull request #12297: [BEAM-10137] Add KinesisIO for cross-language usage with python wrapper

piotr-szuberski removed a comment on pull request #12297: URL: https://github.com/apache/beam/pull/12297#issuecomment-667100096 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] mxm commented on pull request #12499: [BEAM-10602] Fix load test metrics in Grafana dashboard

mxm commented on pull request #12499: URL: https://github.com/apache/beam/pull/12499#issuecomment-671392502 @tysonjh You should be able to run this locally with the backup data which is automatically retrieved from the GCS bucket when you run `docker-compose up`. Basically, the changes

[GitHub] [beam] pabloem commented on pull request #12485: [BEAM-6064] Improvements to BQ streaming insert performance

pabloem commented on pull request #12485: URL: https://github.com/apache/beam/pull/12485#issuecomment-671474393 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] aaltay commented on pull request #12513: [BEAM-BEAM-10667] Make gh-actions wheels bucket name stored as a secret

aaltay commented on pull request #12513: URL: https://github.com/apache/beam/pull/12513#issuecomment-671479553 LGTM. Not merging, because I do not know how to setup the related secret. This is an automated message from the

[GitHub] [beam] robertwb commented on pull request #12491: Avoid re-encoding row types.

robertwb commented on pull request #12491: URL: https://github.com/apache/beam/pull/12491#issuecomment-671496654 Run PythonLint PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] saavannanavati commented on a change in pull request #12242: [BEAM-10427] Benchmark runtime typechecking for the Python SDK

saavannanavati commented on a change in pull request #12242: URL: https://github.com/apache/beam/pull/12242#discussion_r468089367 ## File path: sdks/python/apache_beam/testing/load_tests/runtime_type_check_off_test_py3.py ## @@ -0,0 +1,58 @@ +# +# Licensed to the Apache

[GitHub] [beam] robertwb commented on a change in pull request #12352: [BEAM-10549] Improve runtime type checking performance for the Python SDK

robertwb commented on a change in pull request #12352: URL: https://github.com/apache/beam/pull/12352#discussion_r468090981 ## File path: sdks/python/apache_beam/typehints/typecheck.py ## @@ -265,3 +269,95 @@ def visit_transform(self, applied_transform):

[GitHub] [beam] kamilwu commented on a change in pull request #12499: [BEAM-10602] Fix load test metrics in Grafana dashboard

kamilwu commented on a change in pull request #12499: URL: https://github.com/apache/beam/pull/12499#discussion_r467985468 ## File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy ## @@ -161,12 +164,13 @@ def streamingScenarios = { datasetName -> test

[GitHub] [beam] TobKed commented on a change in pull request #12452: [BEAM-10623] Add workflow to run Beam python tests on Linux/Windows/Mac platforms

TobKed commented on a change in pull request #12452: URL: https://github.com/apache/beam/pull/12452#discussion_r467985225 ## File path: sdks/python/apache_beam/io/parquetio_test.py ## @@ -296,8 +296,10 @@ def test_sink_transform_int96(self): path, self.SCHEMA96,

[GitHub] [beam] mxm commented on a change in pull request #12499: [BEAM-10602] Fix load test metrics in Grafana dashboard

mxm commented on a change in pull request #12499: URL: https://github.com/apache/beam/pull/12499#discussion_r467997322 ## File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy ## @@ -161,12 +164,13 @@ def streamingScenarios = { datasetName -> test

[GitHub] [beam] mxm commented on a change in pull request #12499: [BEAM-10602] Fix load test metrics in Grafana dashboard

mxm commented on a change in pull request #12499: URL: https://github.com/apache/beam/pull/12499#discussion_r467976680 ## File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy ## @@ -161,12 +164,13 @@ def streamingScenarios = { datasetName -> test

[GitHub] [beam] aromanenko-dev merged pull request #12512: [BEAM-10668] Replace toLowerCase().equals() with equalsIgnoreCase

aromanenko-dev merged pull request #12512: URL: https://github.com/apache/beam/pull/12512 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] robertwb commented on a change in pull request #12242: [BEAM-10427] Benchmark runtime typechecking for the Python SDK

robertwb commented on a change in pull request #12242: URL: https://github.com/apache/beam/pull/12242#discussion_r468083210 ## File path: .test-infra/jenkins/job_LoadTests_RuntimeTypeChecking_Python.groovy ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [beam] saavannanavati commented on a change in pull request #12242: [BEAM-10427] Benchmark runtime typechecking for the Python SDK

saavannanavati commented on a change in pull request #12242: URL: https://github.com/apache/beam/pull/12242#discussion_r468091611 ## File path: .test-infra/jenkins/job_LoadTests_RuntimeTypeChecking_Python.groovy ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] mxm commented on a change in pull request #12499: [BEAM-10602] Fix load test metrics in Grafana dashboard

mxm commented on a change in pull request #12499: URL: https://github.com/apache/beam/pull/12499#discussion_r467976680 ## File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy ## @@ -161,12 +164,13 @@ def streamingScenarios = { datasetName -> test

[GitHub] [beam] piotr-szuberski commented on pull request #12423: [BEAM-10135][BEAM-10136] Refactor jdbc external transform registrar

piotr-szuberski commented on pull request #12423: URL: https://github.com/apache/beam/pull/12423#issuecomment-671417576 @chamikaramj I'll try to run it again this week just to be sure. If I'm not successful then of course I'll create an issue.

[GitHub] [beam] tvalentyn commented on a change in pull request #12490: [BEAM-10124] Add ContextualTextIO

tvalentyn commented on a change in pull request #12490: URL: https://github.com/apache/beam/pull/12490#discussion_r467700933 ## File path: sdks/java/io/contextual-text-io/src/main/java/org/apache/beam/sdk/io/ContextualTextIO/ContextualTextIO.java ## @@ -0,0 +1,554 @@ +/* + *

[GitHub] [beam] aromanenko-dev commented on pull request #12422: [BEAM-601] Run KinesisIOIT with localstack

aromanenko-dev commented on pull request #12422: URL: https://github.com/apache/beam/pull/12422#issuecomment-671462800 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] boyuanzz commented on pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

boyuanzz commented on pull request #11749: URL: https://github.com/apache/beam/pull/11749#issuecomment-671463121 > @boyuanzz This change has broken python postcommits that run kafka cross-language it tests. > > Could you take a look on that? I tried to fix it but it seems it would

[GitHub] [beam] apilloud commented on a change in pull request #12507: [BEAM-9179] Move value conversion logic out of ExpressionConverter

apilloud commented on a change in pull request #12507: URL: https://github.com/apache/beam/pull/12507#discussion_r468087411 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlCalciteTranslationUtils.java ## @@

[GitHub] [beam] coheigea opened a new pull request #12512: BEAM-10668 - Replace toLowerCase().equals() with equalsIgnoreCase

coheigea opened a new pull request #12512: URL: https://github.com/apache/beam/pull/12512 There are a couple of instances in the code where toLowerCase().equals() is used, when equalsIgnoreCase() would suffice. The latter is more concise + also doesn't involve the default Locale that's

[GitHub] [beam] kamilwu commented on a change in pull request #12499: [BEAM-10602] Fix load test metrics in Grafana dashboard

kamilwu commented on a change in pull request #12499: URL: https://github.com/apache/beam/pull/12499#discussion_r467975137 ## File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy ## @@ -161,12 +164,13 @@ def streamingScenarios = { datasetName -> test

[GitHub] [beam] TobKed commented on a change in pull request #12452: [BEAM-10623] Add workflow to run Beam python tests on Linux/Windows/Mac platforms

TobKed commented on a change in pull request #12452: URL: https://github.com/apache/beam/pull/12452#discussion_r467987053 ## File path: sdks/python/apache_beam/runners/worker/log_handler_test.py ## @@ -87,7 +87,8 @@ def _verify_fn_log_handler(self, num_log_entries):

[GitHub] [beam] TheNeuralBit commented on pull request #12497: [BEAM-10361] upgrade Kotlin version in example

TheNeuralBit commented on pull request #12497: URL: https://github.com/apache/beam/pull/12497#issuecomment-671437003 Looks like the failure was due to a known flake tracked in BEAM-10300 This is an automated message from the

[GitHub] [beam] kamilwu commented on a change in pull request #12499: [BEAM-10602] Fix load test metrics in Grafana dashboard

kamilwu commented on a change in pull request #12499: URL: https://github.com/apache/beam/pull/12499#discussion_r467981012 ## File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy ## @@ -161,12 +164,13 @@ def streamingScenarios = { datasetName -> test

[GitHub] [beam] TheNeuralBit commented on pull request #12497: [BEAM-10361] upgrade Kotlin version in example

TheNeuralBit commented on pull request #12497: URL: https://github.com/apache/beam/pull/12497#issuecomment-671434888 Yeah I'm sure it's not related.. let me just try one more time to get a green run. This is an automated

[GitHub] [beam] TheNeuralBit commented on pull request #12497: [BEAM-10361] upgrade Kotlin version in example

TheNeuralBit commented on pull request #12497: URL: https://github.com/apache/beam/pull/12497#issuecomment-671434702 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] aaltay merged pull request #12510: [BEAM-10471] change the test condition for testEstimatedSizeBytes to greater than 0 to ensure that the dataset is a least split.

aaltay merged pull request #12510: URL: https://github.com/apache/beam/pull/12510 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] saavannanavati commented on a change in pull request #12242: [BEAM-10427] Benchmark runtime typechecking for the Python SDK

saavannanavati commented on a change in pull request #12242: URL: https://github.com/apache/beam/pull/12242#discussion_r468089367 ## File path: sdks/python/apache_beam/testing/load_tests/runtime_type_check_off_test_py3.py ## @@ -0,0 +1,58 @@ +# +# Licensed to the Apache

[GitHub] [beam] amaliujia commented on pull request #12502: [BEAM-9891] Added ZetaSQL planner support and uploaded 100G data

amaliujia commented on pull request #12502: URL: https://github.com/apache/beam/pull/12502#issuecomment-671521057 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] piotr-szuberski commented on a change in pull request #12422: [BEAM-601] Run KinesisIOIT with localstack

piotr-szuberski commented on a change in pull request #12422: URL: https://github.com/apache/beam/pull/12422#discussion_r467962690 ## File path: sdks/java/io/kinesis/src/test/java/org/apache/beam/sdk/io/kinesis/KinesisIOIT.java ## @@ -35,33 +42,51 @@ import

[GitHub] [beam] kamilwu commented on a change in pull request #12499: [BEAM-10602] Fix load test metrics in Grafana dashboard

kamilwu commented on a change in pull request #12499: URL: https://github.com/apache/beam/pull/12499#discussion_r467970537 ## File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy ## @@ -161,12 +164,13 @@ def streamingScenarios = { datasetName -> test

[GitHub] [beam] TheNeuralBit merged pull request #12497: [BEAM-10361] upgrade Kotlin version in example

TheNeuralBit merged pull request #12497: URL: https://github.com/apache/beam/pull/12497 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] robertwb commented on pull request #12491: Avoid re-encoding row types.

robertwb commented on pull request #12491: URL: https://github.com/apache/beam/pull/12491#issuecomment-671495589 I can wait 'till the Go code is fixed up, let me know when that is checked in. This is an automated message

[GitHub] [beam] TobKed commented on pull request #12513: [BEAM-BEAM-10667] Make gh-actions wheels bucket name stored as a secret

TobKed commented on pull request #12513: URL: https://github.com/apache/beam/pull/12513#issuecomment-671505973 @aaltay thanks for review. I created Jira for setting up secrets: https://issues.apache.org/jira/browse/INFRA-20665 . I will let you know when it is resolved.

[GitHub] [beam] saavannanavati commented on a change in pull request #12242: [BEAM-10427] Benchmark runtime typechecking for the Python SDK

saavannanavati commented on a change in pull request #12242: URL: https://github.com/apache/beam/pull/12242#discussion_r468089367 ## File path: sdks/python/apache_beam/testing/load_tests/runtime_type_check_off_test_py3.py ## @@ -0,0 +1,58 @@ +# +# Licensed to the Apache

[GitHub] [beam] robinyqiu commented on a change in pull request #12507: [BEAM-9179] Move value conversion logic out of ExpressionConverter

robinyqiu commented on a change in pull request #12507: URL: https://github.com/apache/beam/pull/12507#discussion_r468095301 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlCalciteTranslationUtils.java ## @@

[GitHub] [beam] robinyqiu commented on a change in pull request #12507: [BEAM-9179] Move value conversion logic out of ExpressionConverter

robinyqiu commented on a change in pull request #12507: URL: https://github.com/apache/beam/pull/12507#discussion_r468095301 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlCalciteTranslationUtils.java ## @@

[GitHub] [beam] coheigea commented on pull request #12512: BEAM-10668 - Replace toLowerCase().equals() with equalsIgnoreCase

coheigea commented on pull request #12512: URL: https://github.com/apache/beam/pull/12512#issuecomment-671407269 @aromanenko-dev This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] chamikaramj commented on pull request #12423: [BEAM-10135][BEAM-10136] Refactor jdbc external transform registrar

chamikaramj commented on pull request #12423: URL: https://github.com/apache/beam/pull/12423#issuecomment-671416413 Was there an error ? Could you file a JIRA ? This is an automated message from the Apache Git Service. To

[GitHub] [beam] kamilwu commented on a change in pull request #12499: [BEAM-10602] Fix load test metrics in Grafana dashboard

kamilwu commented on a change in pull request #12499: URL: https://github.com/apache/beam/pull/12499#discussion_r468011092 ## File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy ## @@ -161,12 +164,13 @@ def streamingScenarios = { datasetName -> test

[GitHub] [beam] pabloem commented on pull request #12420: Extending ApproximateQuantiles functionality to deal with non-uniform weights.

pabloem commented on pull request #12420: URL: https://github.com/apache/beam/pull/12420#issuecomment-671485307 Ah yes, I had started doing the review. I'll wrap it up today. This is an automated message from the Apache Git

[GitHub] [beam] tvalentyn commented on pull request #12263: [BEAM-10492] Add missing sideinput handling to DLP transforms

tvalentyn commented on pull request #12263: URL: https://github.com/apache/beam/pull/12263#issuecomment-671495214 @mwalenia 2.24.0 branch cut is in a couple of days - are you still working on this change? This is an

[GitHub] [beam] robertwb commented on pull request #12352: [BEAM-10549] Improve runtime type checking performance for the Python SDK

robertwb commented on pull request #12352: URL: https://github.com/apache/beam/pull/12352#issuecomment-671512461 > > As discussed in person, let's push the construction of a `{source_str: TypeConstraint}` all the way up to the visitor. > > Just pushed these changes - PTAL > >

[GitHub] [beam] robinyqiu merged pull request #12507: [BEAM-9179] Move value conversion logic out of ExpressionConverter

robinyqiu merged pull request #12507: URL: https://github.com/apache/beam/pull/12507 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] TobKed opened a new pull request #12513: [BEAM-BEAM-10667] Make gh-actions wheels bucket name stored as a secret

TobKed opened a new pull request #12513: URL: https://github.com/apache/beam/pull/12513 It will allow to test full workflow by the user and distinguish better between buckets (different bucket for tests using dataflow may be used) # Before merging it is required to setup related

[GitHub] [beam] TobKed commented on pull request #12513: [BEAM-BEAM-10667] Make gh-actions wheels bucket name stored as a secret

TobKed commented on pull request #12513: URL: https://github.com/apache/beam/pull/12513#issuecomment-671423020 R: @damgad @aaltay @tvalentyn @kamilwu This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] aromanenko-dev commented on pull request #12512: BEAM-10668 - Replace toLowerCase().equals() with equalsIgnoreCase

aromanenko-dev commented on pull request #12512: URL: https://github.com/apache/beam/pull/12512#issuecomment-671439244 Run Spotless PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on pull request #12492: [BEAM-6807] Implement an Azure blobstore filesystem for Python SDK

pabloem commented on pull request #12492: URL: https://github.com/apache/beam/pull/12492#issuecomment-671501174 (the previous comment was to start running automated tests) This is an automated message from the Apache Git

[GitHub] [beam] pabloem commented on pull request #12492: [BEAM-6807] Implement an Azure blobstore filesystem for Python SDK

pabloem commented on pull request #12492: URL: https://github.com/apache/beam/pull/12492#issuecomment-671501004 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] rehmanmuradali opened a new pull request #12514: [BEAM-9850] Key should be available in @OnTimer methods (Spark Runner)

rehmanmuradali opened a new pull request #12514: URL: https://github.com/apache/beam/pull/12514 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] piotr-szuberski removed a comment on pull request #12509: [BEAM-9898][BEAM-9899] SnowflakeIO.Write for cross-language with python wrapper and integration test

piotr-szuberski removed a comment on pull request #12509: URL: https://github.com/apache/beam/pull/12509#issuecomment-671534409 Run Portable_Python PreCommit This is an automated message from the Apache Git Service. To

[GitHub] [beam] piotr-szuberski commented on pull request #12509: [BEAM-9898][BEAM-9899] SnowflakeIO.Write for cross-language with python wrapper and integration test

piotr-szuberski commented on pull request #12509: URL: https://github.com/apache/beam/pull/12509#issuecomment-671534409 Run Portable_Python PreCommit This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] robinyqiu commented on pull request #12515: Upgrade to ZetaSQL 2020.08.1

robinyqiu commented on pull request #12515: URL: https://github.com/apache/beam/pull/12515#issuecomment-671534538 Actually simply upgrading does not work because there is a public API change in this version. @ibzib It seems to be your recent changes?

[GitHub] [beam] TobKed commented on pull request #12452: [BEAM-10623] Add workflow to run Beam python tests on Linux/Windows/Mac platforms

TobKed commented on pull request #12452: URL: https://github.com/apache/beam/pull/12452#issuecomment-671549585 I rebased on the latest master, added documentation and badges, applied `TemporaryDirectory` context manager for python2.7 backward tests compatibility.

[GitHub] [beam] TheNeuralBit commented on pull request #12518: [BEAM-10663] Workaround of AutoValueSchema doesn't work with SchemaFieldName

TheNeuralBit commented on pull request #12518: URL: https://github.com/apache/beam/pull/12518#issuecomment-671625347 I think the Schema-inferrence issue should be resolved by https://github.com/apache/beam/pull/12520 This

[GitHub] [beam] TheNeuralBit edited a comment on pull request #12518: [BEAM-10663] Workaround of AutoValueSchema doesn't work with SchemaFieldName

TheNeuralBit edited a comment on pull request #12518: URL: https://github.com/apache/beam/pull/12518#issuecomment-671625347 I think the Schema-inference issue should be resolved by https://github.com/apache/beam/pull/12520

[GitHub] [beam] pabloem commented on a change in pull request #12420: Extending ApproximateQuantiles functionality to deal with non-uniform weights.

pabloem commented on a change in pull request #12420: URL: https://github.com/apache/beam/pull/12420#discussion_r468063036 ## File path: sdks/python/apache_beam/transforms/stats.py ## @@ -263,30 +265,38 @@ class Globally(PTransform): Args: num_quantiles: number

[GitHub] [beam] robinyqiu opened a new pull request #12515: Upgrade to ZetaSQL 2020.08.1

robinyqiu opened a new pull request #12515: URL: https://github.com/apache/beam/pull/12515 r: @apilloud @ibzib See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process

[GitHub] [beam] rehmanmuradali commented on pull request #12514: [BEAM-9850] Key should be available in @OnTimer methods (Spark Runner)

rehmanmuradali commented on pull request #12514: URL: https://github.com/apache/beam/pull/12514#issuecomment-671540260 R: @reuvenlax This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] boyuanzz opened a new pull request #12518: [BEAM-10663] Workaround of AutoValueSchema doesn't work with SchemaFieldName

boyuanzz opened a new pull request #12518: URL: https://github.com/apache/beam/pull/12518 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] ZijieSong946 commented on pull request #12507: [BEAM-9179] Move value conversion logic out of ExpressionConverter

ZijieSong946 commented on pull request #12507: URL: https://github.com/apache/beam/pull/12507#issuecomment-671554849 > cc: @ZijieSong946 This recent refactor caused a merge conflict for your WIP TIMESTAMP PR. Ack.

[GitHub] [beam] lukecwik opened a new pull request #12519: [BEAM-10670] Make Read execute as a splittable DoFn by default for the Java DirectRunner.

lukecwik opened a new pull request #12519: URL: https://github.com/apache/beam/pull/12519 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] iindyk commented on pull request #12420: Extending ApproximateQuantiles functionality to deal with non-uniform weights.

iindyk commented on pull request #12420: URL: https://github.com/apache/beam/pull/12420#issuecomment-671634231 Great, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] amaliujia commented on pull request #12502: [BEAM-9891] Added ZetaSQL planner support and uploaded 100G data

amaliujia commented on pull request #12502: URL: https://github.com/apache/beam/pull/12502#issuecomment-671618481 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik commented on pull request #12519: [BEAM-10670] Make Read execute as a splittable DoFn by default for the Java DirectRunner.

lukecwik commented on pull request #12519: URL: https://github.com/apache/beam/pull/12519#issuecomment-671623363 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] emilymye commented on pull request #12505: [WIP][BEAM-8106] Add version to java container image name

emilymye commented on pull request #12505: URL: https://github.com/apache/beam/pull/12505#issuecomment-671632378 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] amaliujia merged pull request #12502: [BEAM-9891] Added ZetaSQL planner support and uploaded 100G data

amaliujia merged pull request #12502: URL: https://github.com/apache/beam/pull/12502 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] TheNeuralBit commented on pull request #12517: [BEAM-10300] Improve JdbcIOTest.testFluentBackOffConfiguration stability

TheNeuralBit commented on pull request #12517: URL: https://github.com/apache/beam/pull/12517#issuecomment-671644199 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] robinyqiu closed pull request #12515: Upgrade to ZetaSQL 2020.08.1

robinyqiu closed pull request #12515: URL: https://github.com/apache/beam/pull/12515 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] robinyqiu commented on pull request #12515: Upgrade to ZetaSQL 2020.08.1

robinyqiu commented on pull request #12515: URL: https://github.com/apache/beam/pull/12515#issuecomment-671537759 > Sorry, its more work than that! There are breaking API changes that need to be fixed. Yeah. It seems Rui's TVF code is broken. I will close this PR for now and let

[GitHub] [beam] TheNeuralBit opened a new pull request #12517: [BEAM-10300] Improve JdbcIOTest.testFluentBackOffConfiguration stability

TheNeuralBit opened a new pull request #12517: URL: https://github.com/apache/beam/pull/12517 Makes some adjustments to JdbcIOTest.testFluentBackOffConfiguration to fix the flakes observed recently. The problem seems to be because the initial `connection` is held open for 10s to

[GitHub] [beam] robertwb commented on pull request #12516: [BEAM-9547] Implement dataframes top, join, merge.

robertwb commented on pull request #12516: URL: https://github.com/apache/beam/pull/12516#issuecomment-671550524 R: @tysonjh This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] pabloem commented on pull request #12489: [BEAM-6064] Add an option to avoid insert_ids on BQ in exchange for faster insertions

pabloem commented on pull request #12489: URL: https://github.com/apache/beam/pull/12489#issuecomment-671584339 postcommit failure only in x-lang tests happy to add an integration test for this functionality if you think that's a good idea @chamikaramj

[GitHub] [beam] pabloem commented on pull request #12485: [BEAM-6064] Improvements to BQ streaming insert performance

pabloem commented on pull request #12485: URL: https://github.com/apache/beam/pull/12485#issuecomment-671584014 postcommit failures in x-lang tests This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem edited a comment on pull request #12485: [BEAM-6064] Improvements to BQ streaming insert performance

pabloem edited a comment on pull request #12485: URL: https://github.com/apache/beam/pull/12485#issuecomment-671584385 r: @chamikaramj This is an automated message from the Apache Git Service. To respond to the message,

  1   2   >