ngompa closed without merging a pull-request against the project:
`go-rpm-macros` that you
are following.
Closed pull-request:
``
macros: Accept options for %gotest
``
https://pagure.io/go-rpm-macros/pull-request/23
___
golang mailing list --
larsu commented on the pull-request: `macros: Accept options for %gotest` that
you are following:
``
I agree that we shouldn't add `-c` to this macro, because it's really meant to
execute test only. I've found a different solution for osbuild-composer, which
uses `go test -c` directly in the
nim commented on the pull-request: `macros: Accept options for %gotest` that
you are following:
``
@atodorov It seems there are all too many of us in your case:(. Let’s try to
figure it a bit better before pushing changes that others will expect to be
perfectly baked.
Right now, our build
atodorov commented on the pull-request: `macros: Accept options for %gotest`
that you are following:
``
@nim I'm not sure what I actually need TBH. This whole area is rather new to me
and I'm trying to figure it out and make it work as I go along. Not necessarily
in this order.
From what `go
nim commented on the pull-request: `macros: Accept options for %gotest` that
you are following:
``
So what you really want, is better automation of the build stage, except the
testing module also requires you to use `go test` instead of `go build` as
build command?
I suppose I could revisit
atodorov commented on the pull-request: `macros: Accept options for %gotest`
that you are following:
``
@nim you can see the changes I'd like to have here:
https://github.com/osbuild/osbuild-composer/pull/282/files#diff-e9f97a745edf48c066fbf93e4aa115c2
The backgroud is that the mentioned
nim commented on the pull-request: `macros: Accept options for %gotest` that
you are following:
``
I’m a bit wary of adding flags to such a low level macro: it sets an API in
stone, that will be quite hard to evolve later given how primitive and
constraining the rpm options parser is. Generic
atodorov opened a new pull-request against the project: `go-rpm-macros` that
you are following:
``
macros: Accept options for %gotest
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/23
___
