Re: Server side equivalent of RpcRequestBuilder

2012-06-13 Thread Jens
Use a Servlet Filter. It sits in front of servlets and you can do stuff before a servlet executes and after it has done its work. http://www.jsptutorial.org/content/filter -- J. Am Mittwoch, 13. Juni 2012 01:53:18 UTC+2 schrieb Carlos Silva: Hi, I'm using an RpcRequestBuilder to add a

StackLayoutPanel and CellPanel

2012-06-13 Thread Metronome
I'm trying to use a CellTable within a StackLayoutPanel The CellTable does'nt show Items , probably because the size is unkown The specs on StackLayoutPanel seem obsolete . Is there an example somewhere ? thanks Patrick -- You received this message because you are subscribed to the Google

Explain difference between using g:Image or a div (in UI Binder) when using GWT sprite ?

2012-06-13 Thread regnoult axel
Hello, I have the css properties of the header's top left element (the logo's place) which has a logo sprite in background : *@sprite* .*topHeaderLeftAlign* { gwt-image: sprites_MS; width: 154px; height: 60px; background-position: -1101px -973px; /* logo */ } I have a different result when I

Re: Designing for testability with MVP and Activities and Places

2012-06-13 Thread Thomas Broyer
On Wednesday, June 13, 2012 2:59:33 AM UTC+2, Mike Dee wrote: A couple of questions regarding a test I'd like to perform. Let's assume that testing occurs with a live database (and GWT-RPC). I know that contest of the database and what should be returned for certain queries. I'd like

Re: Explain difference between using g:Image or a div (in UI Binder) when using GWT sprite ?

2012-06-13 Thread Thomas Broyer
If your 'sprite_MS' is already sprited, then don't use an ImageResource; use a DataResource instead, and use either Image#setUrlAndVisibleRect() or a normal CSS class (not @sprite) to display it. If you use an ImageResource with an Image widget, then use g:Image resource={sprites_MS}/ rather

Error with custom TextField indicator

2012-06-13 Thread arian
Hi there I am trying to create a Custom TextField with a label and replace an existing ui:TextBox in the main ui.xml file with it but get error Unable to load module entry point class com.equillore.mcmexternal.client.Mcmexternal . public class IndicatorTextField extends Composite implements

Re: Error with custom TextField indicator

2012-06-13 Thread Thomas Broyer
Start by looking at the logs, it must print more info than just Unable to load module entry point, there should be some deferred binding failed of some kind with additional info. Try increasing the -logLevel, but the default (INFO) is generally enough to diagnose your own mistakes. On

Re: UiBinder as Cell widget

2012-06-13 Thread Cristian Rinaldi
I'm using UiRenderer for cells, but I'm getting this error at compile time. (I'm using the trunk) com.google.gwt.dev.jjs.InternalCompilerException: Unexpected error during visit. at com.google.gwt.dev.jjs.ast.JVisitor.translateException(JVisitor.java:109) at

Re: UiBinder as Cell widget

2012-06-13 Thread Thomas Broyer
On Wednesday, June 13, 2012 2:53:50 PM UTC+2, Cristian Rinaldi wrote: I'm using UiRenderer for cells, but I'm getting this error at compile time. (I'm using the trunk) com.google.gwt.dev.jjs.InternalCompilerException: Unexpected error during visit. at

Re: Error with custom TextField indicator

2012-06-13 Thread arian
I added event handelers to my custom textbox and was wondering if this may be the reason for the errors. Here are the related error logs. Any further advice perhaps on where the errors could come from.? at com.google.gwt.event.shared.HandlerManager.fireEvent(HandlerManager.java:129) at

Re: Generate URL to image stored on server

2012-06-13 Thread Gary
I've been away from my work for a few days but today I got around to solving this issue. As the images were only temporarily needed, I decided on using the working directory to store and retrieve. To serve the images correctly, I wrote a simple image reading servlet that copies the input

Re: Explain difference between using g:Image or a div (in UI Binder) when using GWT sprite ?

2012-06-13 Thread regnoult axel
Hello Tomas, I am trying this solution (but no image is displayed ) : //uibinder.xml *g:Image* ui:field=eventoImg / //view.java (in the constructor, just after widget = binder.createAndBindUi(this) ) : eventoImg.*setUrlAndVisibleRect*(./common/sprites_MS.png, 0, 0, 64, 64); //css -

Re: Explain difference between using g:Image or a div (in UI Binder) when using GWT sprite ?

2012-06-13 Thread regnoult axel
I forgott to precize that I used the DATA RESOURCE declaration : * @Source(./common/sprites_MS.png)* * @ImageOptions(preventInlining = true)* * ImageResource sprites_MS();* -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view

Re: how to check whether the email or website is real website or email

2012-06-13 Thread Joseph Lust
http://stackoverflow.com/search?q=verify+email+domain Joe -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/E9K1e8Ucd4UJ. To post to this group,

column width

2012-06-13 Thread arian
Is it possible to set the column width of g:cell in the ui.xml file? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/36yrordUcd4J. To post to

Re: IE8 memory leak

2012-06-13 Thread Daniel Kurka
Since non of them is doing any nasty JSNI event binding its very likely that you are causing the leak within your own code. How did you find the leak? How did you test for it? Am 26.05.2012 um 10:39 schrieb sylvanco: No 3rd pary libraries, just the frameworks listed. On May 17, 10:41 pm,

Re: UiBinder as Cell widget

2012-06-13 Thread Cristian Rinaldi
I updated my local copy, I compiled and it worked! It's weird because I had done, something must have been wrong. A.U.S Cristian Rinaldi Logikas - Conectando Ideas www.logikas.com 2012/6/13 Thomas Broyer t.bro...@gmail.com On Wednesday, June 13, 2012 2:53:50 PM UTC+2, Cristian Rinaldi

Re: GWT Spring Security

2012-06-13 Thread Joseph Lust
I'm sure other folks' examples will differ, but we did the following: 1. Entitlements set as an Enum like *enum UserEntitlement { VIEW_HOME, VIEW_ITEM, ADD_ITEM, DELETE_ITEM }* 2. On user login, *UserEntitlement[] *fetch sent from backend to client 3. Restricted UI elements are

Re: setVisible issues with Firefox, then display: none !important

2012-06-13 Thread Joseph Lust
If that is causing so much trouble, how about just use a CSS class like * visibleIcon*. Leave the visibility/display property changing to the browser by adding/removing a class name. Joseph -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group.

Re: GWT Spring Security

2012-06-13 Thread Juan Pablo Gardella
Thanks Joseph for sharing your experiences. I have a question regards this, for example you have a button that is enabled to *ADD_ITEM. *Do you extends GWT compents for show for some 'actions' or make some if statements? Is a simple question, but is nice to know how deal with this. The extend of

Re: SuperDevMode and APT

2012-06-13 Thread Andrea Boscolo
I can confirm that copying the CodeServer's .gwt.rpc files in the local war dir, works but it's a pain: every time they change, they need to be copied. Using a -workDir under the war didn't work for me. The CodeServer output directory structure does not help. In

Re: SuperDevMode and APT

2012-06-13 Thread Thomas Broyer
On Wednesday, June 13, 2012 7:53:35 PM UTC+2, Andrea Boscolo wrote: I can confirm that copying the CodeServer's .gwt.rpc files in the local war dir, works but it's a pain: every time they change, they need to be copied. Using a -workDir under the war didn't work for me. The CodeServer

adding eventhandler to custon textbox field

2012-06-13 Thread arian
I have a custom TextBox that has a IndicatorTextBox.ui.xml file as well as IndicatorTextBox.java file. Ussually adding an evenhadler to a textbox is simple. @UiHandler(txtFirstName) void onTxtFirstNameKeyUp(KeyUpEvent event) { validateFields(); } How would I add the handler if the

Re: Designing for testability with MVP and Activities and Places

2012-06-13 Thread Mike Dee
I got this HyperlinkCell class somewhere and it works pretty good. public class HyperlinkCell extends AbstractCellHyperlink { @Override public void render( com.google.gwt.cell.client.Cell.Context context, Hyperlink h, SafeHtmlBuilder sb ) { sb.append( SafeHtmlUtils.fromTrustedString(

Re: GWT Spring Security

2012-06-13 Thread Joseph Lust
Jaun, Our application is nearly 100% custom components. We did not use many of the default GWT widgets. We also used UiBinder for everything and thus most screens are a bundle of widgets stitched together with UiBinder. If there was a custom panel/button/widget, it would have a

Re: GWT Spring Security

2012-06-13 Thread Juan Pablo Gardella
Thanks Joseph for sharing your experiences on this!! You are really helpful at the group Juan 2012/6/13 Joseph Lust lifeofl...@gmail.com Jaun, Our application is nearly 100% custom components. We did not use many of the default GWT widgets. We also used UiBinder for everything and thus most

Re: adding eventhandler to custon textbox field

2012-06-13 Thread Jens
Implement the HasXYZHandlers interfaces you need in your IndicatorTextField, e.g.: public class IndicatorTextField extends Composite implements HasText, HasKeyUpHandlers, ...other handlers you need... { public HandlerRegistration addKeyUpHandler(KeyUpHandler handler) { return

Re: Designing for testability with MVP and Activities and Places

2012-06-13 Thread Thomas Broyer
On Wednesday, June 13, 2012 11:48:22 PM UTC+2, Mike Dee wrote: I got this HyperlinkCell class somewhere and it works pretty good. public class HyperlinkCell extends AbstractCellHyperlink { @Override public void render( com.google.gwt.cell.client.Cell.Context context, Hyperlink h,

Re: UiBinder as Cell widget

2012-06-13 Thread Deepak Singh
Then i will wait for 2.5. On Wed, Jun 13, 2012 at 8:18 PM, Cristian Rinaldi csrina...@gmail.comwrote: I updated my local copy, I compiled and it worked! It's weird because I had done, something must have been wrong. A.U.S Cristian Rinaldi Logikas - Conectando Ideas www.logikas.com

panel that implements RequiresResize

2012-06-13 Thread tong123123
if a panel that implements RequiresResizehttp://google-web-toolkit.googlecode.com/svn/javadoc/2.4/com/google/gwt/user/client/ui/RequiresResize.htmladd a widget, the panel always cannot be visible. is it a necessary that a panel implements

Re: Designing for testability with MVP and Activities and Places

2012-06-13 Thread Mike Dee
Have a look at http://www.google.com/events/io/2010/sessions/gwt-continuous-build-testing.html The Wave guys came up with a model where the presenter controls the view, so there's no getter; the view calls the presenter back with the values when needed (i.e. your find() method would have

[gwt-contrib] Re: Fix SimpleViolation so that ConstraintViolations with paths that don't map to any editors are st... (issue1727807)

2012-06-13 Thread t . broyer
I'll leave the final word to Brian. Some minor comments below, but otherwise looks good. http://gwt-code-reviews.appspot.com/1727807/diff/14001/user/src/com/google/gwt/editor/client/impl/SimpleViolation.java File user/src/com/google/gwt/editor/client/impl/SimpleViolation.java (right):

[gwt-contrib] Re: Fix SimpleViolation so that ConstraintViolations with paths that don't map to any editors are st... (issue1727807)

2012-06-13 Thread t . broyer
Sorry for not having spotted it in the previous patch set: the new 'private static' methods are not ordered alphabetically (yes, they're in logical order, but the coding style for GWT mandates alphabetical ordering...) Otherwise good (I'd still have splitted the for() loop with the if/else

Re: [gwt-contrib] tests

2012-06-13 Thread Stephen Haberman
[junit] Exception in thread pool-1-thread-569 java.lang.NullPointerException [junit] at com.google.gwt.dev.util.DiskCache.transferToStream(DiskCache.java:187) [junit] at com.google.gwt.dev.util.DiskCacheToken.writeObject(DiskCacheToken.java:91) At the very

[gwt-contrib] Re: Elemental + build scripts initial import. (issue1728806)

2012-06-13 Thread t . broyer
Only looked at elemental.json.* so far. Looks like the Js implementations haven't been used much in DevMode (which is not really surprising given the super-source implementation of element.json.Json, which is @GwtScriptOnly, so only an explicit 'new JsJsonFactory()', or casting a JSO to a

[gwt-contrib] MeniItem should use ScheduledCommand instead of Command (issue1726805)

2012-06-13 Thread rchandia
Reviewers: rdayal, Description: MeniItem should use ScheduledCommand instead of Command Repost of 1698803 Thanks Patrick! Patch by: tucker...@gmail.com Please review this at http://gwt-code-reviews.appspot.com/1726805/ Affected files: M tools/api-checker/config/gwt24_25userApi.conf M

[gwt-contrib] Re: Use UiRenderer (Uibinder for cells) in MobileWebApp sample. (issue1733805)

2012-06-13 Thread rchandia
Great change, but UiRenderer is not a part of GWT 2.4.0 release while project's pom file depend on it. Any comments? That'd be a bug. I guess it should be 2.5.0, but that version has not been released yet. What is the Maven way to do this? http://gwt-code-reviews.appspot.com/1733805/ --

[gwt-contrib] Integrate Elemental to the build and deploy as Maven artifact (issue1727808)

2012-06-13 Thread t . broyer
Reviewers: skybrian, cromwellian, https://gwt-code-reviews.appspot.com/1727808/diff/1/build.xml File build.xml (left): https://gwt-code-reviews.appspot.com/1727808/diff/1/build.xml#oldcode57 build.xml:57: gwt.ant dir=dev/codeserver / See

[gwt-contrib] Re: Use UiRenderer (Uibinder for cells) in MobileWebApp sample. (issue1733805)

2012-06-13 Thread rchandia
On 2012/06/13 16:23:11, kromanovs wrote: Well, you can add dependency to 2.5.0-SNAPSHOT if it's available in the maven central repo. If it's not - then I think it's not yet a time to push this change out. GWT 2.5 is in the process of being released. I rather think it is time to update the

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-13 Thread t . broyer
I've removed the changes concerning javax.validation, so it's still distributed as a separate JAR. org.json is now bundled in gwt-dev, no longer bundled into requestfactory-* JARs, and distributed as a separate JAR in the SDK (so that requestfactory users have the choice to user

[gwt-contrib] Re: MeniItem should use ScheduledCommand instead of Command (issue1726805)

2012-06-13 Thread rchandia
Submitted as r11052 http://gwt-code-reviews.appspot.com/1726805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: ExternalTextResourceGenerator is locale/machine-dependent. (issue1716804)

2012-06-13 Thread rdayal
On 2012/05/25 23:01:27, jat wrote: LGTM Committed as r11044. https://gwt-code-reviews.appspot.com/1716804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Revert GWT support for Chrome Frame (issue1713803)

2012-06-13 Thread rdayal
On 2012/06/08 19:39:13, rdayal wrote: On 2012/05/22 16:11:49, tbroyer wrote: LGTM. Committed a r11045. https://gwt-code-reviews.appspot.com/1713803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Figuring out Maven and GWT versions

2012-06-13 Thread Rodrigo Chandia
We have a few POMs through GWT which need its versions updated for the release. The question is what to use for version string. We have no process or infrastructure in place for snapshots so I'd like to keep that out of this picture. I propose to use 2.5.0.RCx while we publish release

[gwt-contrib] Re: Figuring out Maven and GWT versions

2012-06-13 Thread Thomas Broyer
On Wednesday, June 13, 2012 8:19:52 PM UTC+2, Rodrigo Chandia wrote: We have a few POMs through GWT which need its versions updated for the release. The question is what to use for version string. We have no process or infrastructure in place for snapshots so I'd like to keep that out of

[gwt-contrib] Re: Make CodeSplitter2 outputs a reasonable SOYC. (issue1726803)

2012-06-13 Thread Alan Leung
I forgot the mention. The only real change between this and the CL Ray reviewed was that I added a no-op dependency recorder in the unit test. On Mon, Jun 11, 2012 at 5:23 PM, skybr...@google.com wrote: I don't understand this code, but I wonder if there is any way to write a smoke test for

[gwt-contrib] Re: Use Node.contains in IE9/Webkit for isOrHasChild (issue1725808)

2012-06-13 Thread jlabanca
At this point, the new code is more complicated than the old code. Is it worth switching anymore? Did you performance test to see if element.contains() is faster than the old impl code? http://gwt-code-reviews.appspot.com/1725808/ --

[gwt-contrib] Update POM versions to 2.5.0-rc1 (issue1734804)

2012-06-13 Thread rchandia
Reviewers: rdayal, tbroyer, Description: Update POM versions to 2.5.0-rc1 Please review this at http://gwt-code-reviews.appspot.com/1734804/ Affected files: M samples/dynatablerf/pom.xml M samples/expenses/pom.xml M samples/mobilewebapp/pom.xml M samples/validation/pom.xml Index:

[gwt-contrib] Re: Figuring out Maven and GWT versions

2012-06-13 Thread Rodrigo Chandia
Review at http://gwt-code-reviews.appspot.com/1734804 On Wednesday, June 13, 2012 2:32:28 PM UTC-4, Thomas Broyer wrote: On Wednesday, June 13, 2012 8:19:52 PM UTC+2, Rodrigo Chandia wrote: We have a few POMs through GWT which need its versions updated for the release. The question is what

[gwt-contrib] Re: Use Node.contains in IE9/Webkit for isOrHasChild (issue1725808)

2012-06-13 Thread stephen . haberman
Did you performance test to see if element.contains() is faster than the old impl code? No, no perf tests. The old code in DOMImplStandardBase walked the DOM, so I thought it was a pretty safe assumption that Webkit's .contains would be faster (either from being a single JS call vs. many or,

[gwt-contrib] Re: Update POM versions to 2.5.0-rc1 (issue1734804)

2012-06-13 Thread rdayal
LGTM. http://gwt-code-reviews.appspot.com/1734804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Elemental + build scripts initial import. (issue1728806)

2012-06-13 Thread skybrian
I mostly looked over the build process. (Since this is experimental, I suppose it can all be done later.) http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/META-INF/MANIFEST.MF File elemental/META-INF/MANIFEST.MF (right):

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-13 Thread Brian Slesinsky
I don't think we support Java 1.5 anymore? http://code.google.com/p/google-web-toolkit/issues/detail?id=6790 https://groups.google.com/forum/#!msg/google-web-toolkit/fATw0rL8lSE/xbxX5Hf8ozUJ I'm totally fine with dropping support for 1.5 altogether. - Brian On Wed, Jun 13, 2012 at 9:47 AM,

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-13 Thread Rajeev Dayal
On Wed, Jun 13, 2012 at 5:04 PM, Brian Slesinsky skybr...@google.comwrote: I don't think we support Java 1.5 anymore? http://code.google.com/p/google-web-toolkit/issues/detail?id=6790 https://groups.google.com/forum/#!msg/google-web-toolkit/fATw0rL8lSE/xbxX5Hf8ozUJ I'm totally fine with

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-13 Thread skybrian
Okay, seems fine for now. I'm going to commit this. https://gwt-code-reviews.appspot.com/1731804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove unused symbols in SymbolMaps. (fixed build breakage, it was delete some symbols that are ... (issue1731805)

2012-06-13 Thread cromwellian
LGTM http://gwt-code-reviews.appspot.com/1731805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Elemental + build scripts initial import. (issue1728806)

2012-06-13 Thread cromwellian
Thomas, I'm a little knee deep in I/O slide stuff at the moment, so maybe you can sanity check my thinking here. Let me describe what used to be happening in the Json stuff and what I was trying to change it to before 2.5, but probably didn't finish. Essentially, in ProdMode I wanted to run

[gwt-contrib] Re: Update POM versions to 2.5.0-rc1 (issue1734804)

2012-06-13 Thread t . broyer
LGTM http://gwt-code-reviews.appspot.com/1734804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix SimpleViolation so that ConstraintViolations with paths that don't map to any editors are st... (issue1727807)

2012-06-13 Thread skybrian
LGTM. I can understand the code now and I'm basically okay with it; the rest is nitpicks. http://gwt-code-reviews.appspot.com/1727807/diff/15003/user/src/com/google/gwt/editor/client/impl/SimpleViolation.java File user/src/com/google/gwt/editor/client/impl/SimpleViolation.java (right):

[gwt-contrib] Re: Elemental + build scripts initial import. (issue1728806)

2012-06-13 Thread t . broyer
On 2012/06/13 23:33:46, cromwellian wrote: Thomas, I'm a little knee deep in I/O slide stuff at the moment, so maybe you can sanity check my thinking here. Let me describe what used to be happening in the Json stuff and what I was trying to change it to before 2.5, but probably didn't

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-13 Thread t . broyer
On 2012/06/13 21:45:00, skybrian wrote: Okay, seems fine for now. I'm going to commit this. FYI, I just removed all occurrences of json-1.5.jar, so we consistently use json.jar everywhere. https://gwt-code-reviews.appspot.com/1731804/ --

[gwt-contrib] Introduce -XfragmentCount to replace -XfragmentMerge (issue1739804)

2012-06-13 Thread acleung
Reviewers: cromwellian, Description: Introduce -XfragmentCount to replace -XfragmentMerge Please review this at http://gwt-code-reviews.appspot.com/1739804/ Affected files: M dev/core/src/com/google/gwt/dev/PrecompileTaskOptionsImpl.java M

[gwt-contrib] Re: Introduce -XfragmentCount to replace -XfragmentMerge (issue1739804)

2012-06-13 Thread cromwellian
LGTM http://gwt-code-reviews.appspot.com/1739804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Comment out an invalid test in TreeMapTest. (issue1735805)

2012-06-13 Thread acleung
Reviewers: skybrian, Description: Comment out an invalid test in TreeMapTest. Please review this at http://gwt-code-reviews.appspot.com/1735805/ Affected files: M user/test/com/google/gwt/emultest/java/util/TreeMapTest.java Index:

[gwt-contrib] Re: Bundle org.json in gwt-dev and javax.validation into gwt-user, unbundle from requestfactory-* (issue1731804)

2012-06-13 Thread skybrian
I'm getting failing tests because JSON is gone from gwt-user.jar and the requestfactory jars. I could add the dependency internal to google, but I think we might still be trying to do too much at once - this is looking more like churn than an actual improvement. To fix the compiler and close

[gwt-contrib] Re: Comment out an invalid test in TreeMapTest. (issue1735805)

2012-06-13 Thread jat
On 2012/06/14 01:33:21, skybrian wrote: LGTM It seems like we should also change the web implementation to behave like JDK 7. But that can wait. Unless we are going to upgrade the rest of the JRE to match JDK 7, I disagree. More likely, this behavior should be considered undefined and

[gwt-contrib] Include json-1.5.jar in gwt-dev.jar. JSON is needed by the Closure (issue1732804)

2012-06-13 Thread skybrian
Reviewers: cromwellian, Description: Include json-1.5.jar in gwt-dev.jar. JSON is needed by the Closure compiler and also to generate source maps. Fixes issue 7397 Please review this at http://gwt-code-reviews.appspot.com/1732804/ Affected files: M dev/build.xml M

[gwt-contrib] Re: Extracted constant strings to the constructor, that allow translation to be provided from the ou... (issue1739803)

2012-06-13 Thread jlabanca
http://gwt-code-reviews.appspot.com/1739803/diff/8001/user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java File user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java (right):

[gwt-contrib] Re: Use Node.contains in IE9/Webkit for isOrHasChild (issue1725808)

2012-06-13 Thread jlabanca
I missed the changes to the other files. This makes the standard impl simpler and makes all versions of IE use the fixed IE-version. I'll review it closely and submit tomorrow. Thanks for the patch. http://gwt-code-reviews.appspot.com/1725808/ --

[gwt-contrib] Re: Extracted constant strings to the constructor, that allow translation to be provided from the ou... (issue1739803)

2012-06-13 Thread jat
http://gwt-code-reviews.appspot.com/1739803/diff/8001/user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java File user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java (right):