[gwt-contrib] First change for GWT end-to-end testing framework. (issue1408803)

2011-04-10 Thread kjin
Reviewers: jat, skybrian, rjrjr, bobv, Description: First change for GWT end-to-end testing framework. Please review this at http://gwt-code-reviews.appspot.com/1408803/ Affected files: A user/src/com/google/gwt/testing/Testing.gwt.xml A user/src/com/google/gwt/testing/client/After.java

[gwt-contrib] Re: Extend GWTTestCase to support HTTP requests to remote server and moduleBaseURL mismatch (issue1043801)

2011-01-10 Thread kjin
/src/com/google/gwt/junit/JUnitShell.java:1536: // TODO: figure out if it is possible to allow multiple modules. Modified ProxyFilter to support multiple modules. On 2011/01/01 03:03:44, jat wrote: On 2010/11/09 19:31:37, kjin wrote: I'm not sure about it -- E2E tests run for the whole application

[gwt-contrib] Re: Extend GWTTestCase to support HTTP requests to remote server and moduleBaseURL mismatch (issue1043801)

2011-01-10 Thread kjin
http://gwt-code-reviews.appspot.com/1043801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Extend GWTTestCase to support HTTP requests to remote server and moduleBaseURL mismatch (issue1043801)

2011-01-10 Thread kjin
patch set 4: sync to latest and convert tabs http://gwt-code-reviews.appspot.com/1043801/diff/44001/45006 File user/src/com/google/gwt/junit/JUnitShell.java (right): http://gwt-code-reviews.appspot.com/1043801/diff/44001/45006#newcode195 user/src/com/google/gwt/junit/JUnitShell.java:195:

[gwt-contrib] Re: First pass of E2eGWTTestCase, an experimental feature for end-to-end testing GWT applications (issue1043801)

2010-11-19 Thread kjin
http://gwt-code-reviews.appspot.com/1043801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: First pass of E2eGWTTestCase, an experimental feature for end-to-end testing GWT applications (issue1043801)

2010-11-09 Thread kjin
will create RFC in Wave soon. http://gwt-code-reviews.appspot.com/1043801/diff/1/4 File dev/core/src/com/google/gwt/dev/cfg/SyntheticModuleDef.java (right): http://gwt-code-reviews.appspot.com/1043801/diff/1/4#newcode50 dev/core/src/com/google/gwt/dev/cfg/SyntheticModuleDef.java:50: public

[gwt-contrib] Re: First pass of E2eGWTTestCase, an experimental feature for end-to-end testing GWT applications (issue1043801)

2010-10-27 Thread kjin
The new E2eGWTTestCase enables application developers to write end-to-end tests in a way that is similar to GWTTestCase, instead of relying on tools written for JS, e.g. Selenium or WebDriver. Why is GWTTestCase insufficient for end-to-end testing? The main reasons are: a) GWTTestCase does not

[gwt-contrib] First pass of E2eGWTTestCase, an experimental feature for end-to-end testing GWT applications (issue1043801)

2010-10-21 Thread kjin
Reviewers: jat, scottb, Description: First pass of E2eGWTTestCase, an experimental feature for end-to-end testing GWT applications Please review this at http://gwt-code-reviews.appspot.com/1043801/show Affected files: M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M

[gwt-contrib] Disable LayoutTest#testAnimationTransitions_* because they are flaky (issue933801)

2010-09-29 Thread kjin
Reviewers: jgw, jat, Description: Disable LayoutTest#testAnimationTransitions_* because they are flaky Please review this at http://gwt-code-reviews.appspot.com/933801/show Affected files: M user/test/com/google/gwt/layout/client/LayoutTest.java --

[gwt-contrib] Re: JUnit ought to just serialize exceptions (issue870802)

2010-09-15 Thread kjin
IIUC, ExceptionWrapper can be removed now after removing the last references in JUnitResult. http://gwt-code-reviews.appspot.com/870802/diff/1/3 File user/src/com/google/gwt/junit/client/impl/ExceptionWrapper.java (right): http://gwt-code-reviews.appspot.com/870802/diff/1/3#newcode26

[gwt-contrib] Re: JUnit ought to just serialize exceptions (issue870802)

2010-09-15 Thread kjin
LGTM http://gwt-code-reviews.appspot.com/870802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Converts two new files from dos EOL format to unix EOL format. (issue854801)

2010-09-09 Thread kjin
LGTM http://gwt-code-reviews.appspot.com/854801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds source infos in the test AST nodes in ConstantsAssumptionTest. (issue831804)

2010-09-08 Thread kjin
LGTM On 2010/09/08 15:26:06, Lex wrote: Can you review this tiny patch, Mike? Without this patch, there are assertion failures. http://gwt-code-reviews.appspot.com/831804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add -ea to JVM and GWT args for tests (issue818802)

2010-08-31 Thread kjin
Reviewers: fabbott, scottb, Description: Add -ea to JVM and GWT args for tests Please review this at http://gwt-code-reviews.appspot.com/818802/show Affected files: M common.ant.xml M dev/build.xml M user/build.xml -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add -ea to JVM and GWT args for tests (issue818802)

2010-08-31 Thread kjin
http://gwt-code-reviews.appspot.com/818802/diff/1/2 File common.ant.xml (right): http://gwt-code-reviews.appspot.com/818802/diff/1/2#newcode163 common.ant.xml:163: attribute name=test.jvmargs default= / On 2010/08/31 22:13:58, scottb wrote: indentation Done.

[gwt-contrib] convert CR-LF to LF using dos2unix (issue813801)

2010-08-30 Thread kjin
Reviewers: fabbott, Description: convert CR-LF to LF using dos2unix Review by: psima...@google.com Please review this at http://gwt-code-reviews.appspot.com/813801/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/ast/JConstructor.java M

[gwt-contrib] fix ExpenseTree for ant -f samples/expenses/build.xml build (issue781802)

2010-08-20 Thread kjin
Reviewers: amitmanjhi, Description: fix ExpenseTree for ant -f samples/expenses/build.xml build Please review this at http://gwt-code-reviews.appspot.com/781802/show Affected files: M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseTree.java --

[gwt-contrib] ant test needs these jars (issue785801)

2010-08-19 Thread kjin
Reviewers: Nick Chalko, Description: ant test needs these jars Review by: ncha...@google.com Please review this at http://gwt-code-reviews.appspot.com/785801/show Affected files: M user/build.xml Index: user/build.xml === ---

[gwt-contrib] Add debugging information to CssResource. (issue770801)

2010-08-16 Thread kjin
http://gwt-code-reviews.appspot.com/770801/diff/1/5 File user/src/com/google/gwt/resources/client/impl/CssResourceObserver.java (right): http://gwt-code-reviews.appspot.com/770801/diff/1/5#newcode32 user/src/com/google/gwt/resources/client/impl/CssResourceObserver.java:32: private static final

[gwt-contrib] Re: Add debugging information to CssResource. (issue770801)

2010-08-16 Thread kjin
On 2010/08/16 18:03:23, bobv wrote: Kevin, thanks for looking at this. Are there any other CSS testing use-cases that you can think of that the DebugInfo API should support? http://gwt-code-reviews.appspot.com/770801/diff/1/5 File

[gwt-contrib] Do not infer startup URLs in JUnitShell (issue612801)

2010-06-17 Thread kjin
Reviewers: scottb, jat, Description: Do not infer startup URLs in JUnitShell Please review this at http://gwt-code-reviews.appspot.com/612801/show Affected files: M user/src/com/google/gwt/junit/JUnitShell.java Index: user/src/com/google/gwt/junit/JUnitShell.java

[gwt-contrib] Re: Fix flaxy MessageTransport test.

2010-03-18 Thread kjin
LGTM http://gwt-code-reviews.appspot.com/234801 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors