[gwt-contrib] Re: Code Review: gwt-google-apis gears Worker Pool Demo

2008-10-08 Thread Miguel Méndez
On Mon, Oct 6, 2008 at 2:48 PM, Eric Ayers [EMAIL PROTECTED] wrote: Hello Miguel Attached is a demo for the WorkerPool class that I would like for you to review. The demo is a bit more rich than the demos for the other Gears features. I intend to add documentation for a simple worker pool

[gwt-contrib] Re: Code Review: gwt-google-apis gears fix typo in method name.

2008-10-08 Thread Miguel Méndez
LGTM On Tue, Oct 7, 2008 at 3:27 PM, Eric Ayers [EMAIL PROTECTED] wrote: Hi Miguel, This patch addresses issue 183, a typo in a method name: http://code.google.com/p/gwt-google-apis/issues/detail?id=183 I renamed the method in the library class and updated the test. M

[gwt-contrib] Re: Code Review: gwt-google-apis gears Worker Pool Demo

2008-10-08 Thread Eric Ayers
Attached file that belongs in samples/Showcase/src/com/google/gwt/sample/showcase/client/gwtLogoThumb.png On Wed, Oct 8, 2008 at 10:02 AM, Miguel Méndez [EMAIL PROTECTED] wrote: On Mon, Oct 6, 2008 at 2:48 PM, Eric Ayers [EMAIL PROTECTED] wrote: Hello Miguel Attached is a demo for the

[gwt-contrib] Flurry of Data binding threads

2008-10-08 Thread Ray Ryan
We all seem to be talking about data binding and validation a lot, and some of us are even implementing code about it. We on the GWT team hear the need and feel it ourselves. We have some notions of how we'd like to tackle this in a way that blends seamlessly with the rest of GWT, and are looking

[gwt-contrib] Re: Code Review: gwt-google-apis gears Worker Pool Demo

2008-10-08 Thread Miguel Méndez
Thanks for sending the image. I think that you meant to say that the file belongs in: samples/workerpool/src/com/google/gwt/gears/sample/workerpool/public/gwtLogoThumb.png? You should add more text to the sample to call out that you can interact with the animation only when using a worker thread

[gwt-contrib] Re: Code Review: gwt-google-apis maps Status Code not translated - issue 189

2008-10-08 Thread Eric Ayers
Committed as r873. On Wed, Oct 8, 2008 at 10:06 AM, Miguel Méndez [EMAIL PROTECTED] wrote: LGTM On Tue, Oct 7, 2008 at 9:20 AM, Eric Ayers [EMAIL PROTECTED] wrote: Hello Miguel, Here is another patch I'd like for you to review. It addresses issue 189 in the issue tracker:

[gwt-contrib] Re: data binding framework for GWT

2008-10-08 Thread Arthur Kalmenson
Hi Ian, I *think* validation could be tied into the data binding framework in a pretty straightforward way by extending EditorT and ViewerT to be validation-aware. I agree, it shouldn't be too hard to tie validation into data binding, but... I think data binding and validation probably

[gwt-contrib] Re: GWT Issue 343 and the JSR-303 Draft (Implementing in GWT)

2008-10-08 Thread chris.ruffalo
Yes it is, consider: public class Parent { @NotNull private String parentString = null; @NotNull @Valid private Child child = null; /* GETTER AND SETTER METHODS GO HERE */ } public class Child { @NotEmpty @NotNull private String childString = null;

[gwt-contrib] Re: GWT Issue 343 and the JSR-303 Draft (Implementing in GWT)

2008-10-08 Thread chris.ruffalo
In the above Example the Parent field should also have an @Valid annotation. Also, instead of updating in the GWT issue 343 thread I'm updating here: http://code.google.com/p/gwt-validation/ It also has the Java5 release for download. On Oct 8, 12:51 pm, chris.ruffalo [EMAIL PROTECTED] wrote:

[gwt-contrib] Re: GWT Issue 343 and the JSR-303 Draft (Implementing in GWT)

2008-10-08 Thread rb
Excellent...thanks! I was missing the @Valid on the parent. On Oct 8, 12:52 pm, chris.ruffalo [EMAIL PROTECTED] wrote: In the above Example the Parent field should also have an @Valid annotation. Also, instead of updating in the GWT issue 343 thread I'm updating here:

[gwt-contrib] Re: RR: visibility logic management

2008-10-08 Thread Ray Cromwell
There now appears to be a lot of activity in this area. Data binding, Validation, and now visibility has been raised so far. We've also seen inter-field dependent calculations (Ian's @Calculate) I would strongly urge contributors on this list to take a good look at XForms before reinventing the

[gwt-contrib] Re: data binding framework for GWT

2008-10-08 Thread Ian Petersen
Hi Ray, I can't answer you fully right now because I'm supposed to be leaving, but I'll think about your suggestion and get back to you. As it is, BoundFieldImpl constructs its editor lazily so perhaps a BoundField could be given an editor rather than constructing one itself. Also, regarding