[gwt-contrib] Re: HandlerManager throws NPE if last handler is removed twice

2009-04-21 Thread rjrjr
http://gwt-code-reviews.appspot.com/25801/diff/1/3 File user/src/com/google/gwt/event/shared/HandlerManager.java (right): http://gwt-code-reviews.appspot.com/25801/diff/1/3#newcode101 Line 101: } Could be a little simpler--you don't really need an else case: boolean result = false; if (l !=

[gwt-contrib] subtree logging for problems

2009-04-21 Thread Freeland Abbott
Here's the promised follow-on to my earlier, fixing the subtype logging to be a subtree logger. I'm still bothered by the multiple entries for E extends java.lang.Object, but I'm not sure which is the better way to fix it... I think I would like to change JType constructors and/or .equals, to

[gwt-contrib] HandlerManager throws NPE if last handler is removed twice

2009-04-21 Thread jlabanca
Reviewers: rjrjr, Description: See http://gwt-code-reviews.appspot.com/25801/show Please review this at http://gwt-code-reviews.appspot.com/25803 Affected files: user/src/com/google/gwt/event/shared/HandlerManager.java user/test/com/google/gwt/event/shared/HandlerManagerTest.java

[gwt-contrib] Re: HandlerManager throws NPE if last handler is removed twice

2009-04-21 Thread jlabanca
See http://gwt-code-reviews.appspot.com/25803 for updated patch. On 2009/04/21 16:49:12, rjrjr wrote: http://gwt-code-reviews.appspot.com/25801/diff/1/3 File user/src/com/google/gwt/event/shared/HandlerManager.java (right): http://gwt-code-reviews.appspot.com/25801/diff/1/3#newcode101 Line

[gwt-contrib] [google-web-toolkit commit] r5266 - Fixed a bug in HandlerManager where removing the last handler of a given EventType twice ...

2009-04-21 Thread codesite-noreply
Author: jlaba...@google.com Date: Tue Apr 21 10:27:39 2009 New Revision: 5266 Modified: trunk/user/src/com/google/gwt/event/shared/HandlerManager.java trunk/user/test/com/google/gwt/event/shared/HandlerManagerTest.java Log: Fixed a bug in HandlerManager where removing the last handler

[gwt-contrib] Re: Java source transformation

2009-04-21 Thread Bruce Johnson
On Tue, Apr 21, 2009 at 12:38 PM, nicolas de loof nicolas.del...@gmail.comwrote: The only critism I'd have is the requirement to use GWT.create() to get code from a generator. This is a requirement when the generated code doesn't extend the source type (for example for Async interfaces) but

[gwt-contrib] Re: Java source transformation

2009-04-21 Thread nicolas de loof
A simple example : databinding Lets consider I want to bind some Label text to some model Bean value. Gwt Label widget text can be accessed as a javaBean property, so this sound a typical java.beans.binding use-case This requires my model bean to support PropertyChangeListeners. As I'm lazy I'd

[gwt-contrib] [google-web-toolkit commit] r5267 - When AsyncFragmentLoader checks for the success of an XHR download,

2009-04-21 Thread codesite-noreply
Author: sp...@google.com Date: Tue Apr 21 11:13:46 2009 New Revision: 5267 Modified: trunk/user/src/com/google/gwt/core/client/AsyncFragmentLoader.java Log: When AsyncFragmentLoader checks for the success of an XHR download, it now requires that xhr.responseText is non-null and non-empty.

[gwt-contrib] Re: Java source transformation

2009-04-21 Thread Ray Cromwell
I really think Guice-style dependency injection is the way to go to solve this problem, rather than trying to emulate Java Proxies/Classloader in the compiler. If you use Guice/Gin, then in Gin you can inject GWT.create-d versions, and in JUnit-mode, you can use regular Guice injection. The code

[gwt-contrib] Re: Java source transformation

2009-04-21 Thread nicolas de loof
Sounds a good solution.How would this solve the use case data returned by RPC call ? 2009/4/21 Ray Cromwell cromwell...@gmail.com I really think Guice-style dependency injection is the way to go to solve this problem, rather than trying to emulate Java Proxies/Classloader in the compiler. If

[gwt-contrib] Re: Java source transformation

2009-04-21 Thread Ray Cromwell
Interesting question. Gin auto-creates RPC interfaces as well, for example, if you have: public interface MyFoo extends Ginjector { MyServiceAsync getService(); } then Gin implicitly looks for MyService.class and invokes GWT.create(MyService.class) when calling getService(). Since Gin is

[gwt-contrib] Re: cross site RPC through iframes

2009-04-21 Thread Ray Cromwell
It wouldn't be hard to do it using this: http://timepedia.blogspot.com/2008/07/cross-domain-formpanel-submissions-in.html http://development.lombardi.com/?p=611 -Ray 2009/4/21 Piotr JaroszyƄski p.jaroszyn...@gmail.com: Hello, I have seen discussion and implementation of XS RPC via script

[gwt-contrib] Re: subtree logging for problems

2009-04-21 Thread Lex Spoon
LGTM. There's a typo in ProblemReport: accessir. -Lex On 4/21/09, Freeland Abbott fabb...@google.com wrote: Here's the promised follow-on to my earlier, fixing the subtype logging to be a subtree logger. I'm still bothered by the multiple entries for E extends java.lang.Object, but I'm

[gwt-contrib] Re: Java source transformation

2009-04-21 Thread Ray Cromwell
On Tue, Apr 21, 2009 at 7:11 PM, Arthur Kalmenson arthur.k...@gmail.com wrote: Hmm, but don't you normally send some kind of Model or domain object over the wire and not something that would need to be injected with dependencies by Gin? I think what he's saying is that he might have an RPC