Reviewers: jlabanca,
Description:
This is the simplest possible fix for issue 3973: ensure that hookEvents
and unhookEvents are called even when not using a synthesized iframe
(FormPanelImpl and FormPanelImplIE6 already handle the case where
'iframe' is null)
A better fix IMO would be to also
Revision: 5978
Author: b...@google.com
Date: Thu Aug 20 05:44:21 2009
Log: Formalize how default extensions are provided by ClientBundle resource
types.
Patch by: bobv
Review by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=5978
Added:
Revision: 5979
Author: b...@google.com
Date: Thu Aug 20 05:47:14 2009
Log: Add a stack trace collector for Chrome.
This is mapped into the webkit user.agent, but will fall back to the
standard collector when running on Safari.
Patch by: schuck
Review by: bobv
Revision: 5980
Author: b...@google.com
Date: Thu Aug 20 05:48:36 2009
Log: Fix potential error scenario where the web-mode backref ident can be
determined incorrectly.
Patch by: bobv
Review by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=5980
Modified:
Comment by lypanov:
Is there a good reason for using a static final as in:
public static final Resources INSTANCE = GWT.create(Resources.class)
rather than eg.
public static Resources resources() { return (Resources)
GWT.create(Resources.class); }
in a helper utils class?
The first
lgtm, w/ just one random comment.
http://gwt-code-reviews.appspot.com/61805/diff/1/2
File dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
(right):
http://gwt-code-reviews.appspot.com/61805/diff/1/2#newcode276
Line 276: // look for the old query parameter if we don't find the new
Revision: 5981
Author: j...@google.com
Date: Thu Aug 20 10:42:37 2009
Log: Correct a problem with showing the troubleshooting iframe, add support
for
renamed query parameter (while retaining backwards compatibility for now).
Patch by: jat
Review by: knorton
LGTM
On Tue, Aug 18, 2009 at 9:47 AM, codesite-nore...@google.com wrote:
Revision: 5974
Author: b...@google.com
Date: Tue Aug 18 06:46:44 2009
Log: Make Condition and Conditions Serializable so that they may work with
multiple-worker builds.
Patch by: bobv
Review by: kprobst (TBR)
Committed at r5982.
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 5982
Author: sp...@google.com
Date: Thu Aug 20 11:23:01 2009
Log: Fixes a bug in SerializableTypeOracleBuilder where multi-dimensional
array types might not also pull in array types with lower rank.
A fast path was not computing complete information.
Review by: fabbott
Brett,
You should be able to use the already-checked-in LayoutPanel to do anything
you could have done with AbsolutePanel before. And it should be the case
that you can get rid of all of your manual resize code (that's the
intention, anyway). Also, if you run into any problems embedding other
Revision: 5983
Author: sp...@google.com
Date: Thu Aug 20 11:38:19 2009
Log: Fixes two bugs in the lightweight events for runAsync,
and adds test cases for them.
Review by: bobv
http://code.google.com/p/google-web-toolkit/source/detail?r=5983
Added:
Thanks for these patches, Thomas. I am actually responsible (guilty?) for
most of the code in FormPanel, Document, and other files affected by them.
We're in the midst of upgrading our internal build and test infrastructure,
so it might be a couple of days until I can get to them, but rest assured
LGTM
http://gwt-code-reviews.appspot.com/62801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Thanks for the patches. Looks like there is some auto-format cruft, but
it LGTM overall.
http://gwt-code-reviews.appspot.com/61809/diff/1/6
File user/src/com/google/gwt/dom/client/DOMImplTrident.java (right):
http://gwt-code-reviews.appspot.com/61809/diff/1/6#newcode220
Line 220: return
Ok, so John beat me to that one. I'll assume you'll commit this and update
the issue as soon as the build stuff is done.
On Thu, Aug 20, 2009 at 2:54 PM, jlaba...@google.com wrote:
LGTM
http://gwt-code-reviews.appspot.com/62801
--~--~-~--~~~---~--~~
Yeah
Thanks,
John LaBanca
jlaba...@google.com
On Thu, Aug 20, 2009 at 3:01 PM, Joel Webber j...@google.com wrote:
Ok, so John beat me to that one. I'll assume you'll commit this and update
the issue as soon as the build stuff is done.
On Thu, Aug 20, 2009 at 2:54 PM, jlaba...@google.com
Alright, settle down. You're doing my work too fast. Oh, wait -- that's a
good thing :)
On Thu, Aug 20, 2009 at 3:00 PM, jlaba...@google.com wrote:
Thanks for the patches. Looks like there is some auto-format cruft, but
it LGTM overall.
http://gwt-code-reviews.appspot.com/61809/diff/1/6
Reviewers: kathrin,
Description:
Call webClient.closeAllWindows() in htmlunit code when there are no
remaining JS tasks. We do not have to worry about infinite loop because
the test timeout will kill the process eventually.
Please review this at http://gwt-code-reviews.appspot.com/62802
Hi Amit,
I think this is the right direction! But I do think there's still a
problem here, if I read the HtmlUnit documentation correctly. It says:
-
waitForBackgroundJavaScriptStartingBefore
This method blocks until all background JavaScript tasks scheduled
to start executing
Revision: 5984
Author: kpro...@google.com
Date: Thu Aug 20 13:57:35 2009
Log: Updates XML escaping for SOYC. Previously, some UTF-8 characters
slipped through that are not allowed in XML, which caused the dashboard to
crash. This fixes the problem.
On 20 août, 21:00, jlaba...@google.com wrote:
Thanks for the patches. Looks like there is some auto-format cruft,
I noticed the changes on Document but I had previously checked my
Java Code Style preferences...
but
it LGTM overall.
Does it mean I should resubmit an updated patch? or you
Revision: 5985
Author: b...@google.com
Date: Thu Aug 20 14:01:00 2009
Log: Created wiki page through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=5985
Added:
/wiki/ConditionalProperties.wiki
===
--- /dev/null
+++
In a discussion with Amit and Joel, we've determined that the tests that
this will apply to do not use History tokens, so the repeated timeout
won't apply. We couldn't think of any other cases where there would be
lingering JavaScript jobs. TODO - we should revisit this issue at some
point and
Comment by sco...@google.com:
This is totally sweet.
For more information:
http://code.google.com/p/google-web-toolkit/wiki/ConditionalProperties
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 5986
Author: b...@google.com
Date: Thu Aug 20 14:18:33 2009
Log: Edited wiki page through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=5986
Modified:
/wiki/WebModeExceptions.wiki
===
---
Revision: 5988
Author: amitman...@google.com
Date: Thu Aug 20 14:57:31 2009
Log: The xercesImpl-NoMetaInf.jar does not contain the META-INF/services
directory
that interacts poorly with AppEngine.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Revision: 5987
Author: b...@google.com
Date: Thu Aug 20 14:43:16 2009
Log: Edited wiki page through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=5987
Modified:
/wiki/ConditionalProperties.wiki
===
---
Revision: 5989
Author: amitman...@google.com
Date: Thu Aug 20 15:05:36 2009
Log: This patch removes the META-INF/services dir from xercesImpl.jar that
was causing conflicts with AppEngine and internal Tomcat. Also, rolls
back the changes made by now unnecessary c5916.
Patch by: amitmanjhi
Review
Does JUnit's GWTRunner keep pinging the server on a timer to see if more
tests are wanted?
On Thu, Aug 20, 2009 at 5:04 PM, kpro...@google.com wrote:
In a discussion with Amit and Joel, we've determined that the tests that
this will apply to do not use History tokens, so the repeated timeout
Not while a test is running. Only when a test or a block of test ends does
the GWTRunner ping again.
On Thu, Aug 20, 2009 at 3:38 PM, Scott Blum sco...@google.com wrote:
Does JUnit's GWTRunner keep pinging the server on a timer to see if more
tests are wanted?
On Thu, Aug 20, 2009 at 5:04
Brett,
We did code splitting across the four major sections of our applications.
Assume we have section A-D, each with their own mediator. We then have an
ApplicationMediator, which is responsible for loading / unloading the four
major sections and sticking them into the viewport. When
32 matches
Mail list logo
