Reviewers: jlabanca, jat,
Description:
Calling new Date(...) with a time that falls in the 'missing hour' of a
daylight savings time transition currently behaves differently in java
versus javascript. In java, the time is moved forward by an hour, while
in javascript it is moved backward, which
We should have unit tests for all of these cases, testing DST going in
both directions (spring and fall).
LGTM pending unit tests
http://gwt-code-reviews.appspot.com/90802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM - please run ant checkstyle before committing. Also, cherrypick
into the 2.0 branch.
On 2009/10/30 16:23:34, rdayal wrote:
http://gwt-code-reviews.appspot.com/89809
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I'm not sure how to so this -- my testing involved manually setting the
machine's time zone. Ultimately the bug is in the fact that the native
Javascript Date functions deal with the missing hour differently that Java's
Date class, and I don't know that I can coerce the Javascript functions
If you're confident in the fix, Dan, instead of adding a test right now,
please just add an issue instead to remind us to review in the future what
kind of testing mechanism we would have needed to make a unit test easy to
create for this case. I want to make sure we revisit this at some point to
Revision: 6558
Author: fabb...@google.com
Date: Fri Oct 30 10:59:29 2009
Log: Merge of trunk 6458:6459, fix for CssProperty space bug on IE
http://code.google.com/p/google-web-toolkit/source/detail?r=6558
Modified:
Thobias,
Since this doesn't involve changes to GWT proper, have you thought
about creating a google code project. I'm sure there are others
who would like to use what you have created. And who knows, one day
it might be included in GWT proper.
Thanks,
Chris
On Oct 21, 5:14 pm, Thoka
Revision: 6560
Author: fabb...@google.com
Date: Fri Oct 30 11:05:12 2009
Log: Svn prop changes from merge, to get them out of my face.
http://code.google.com/p/google-web-toolkit/source/detail?r=6560
Modified:
/branches/snapshot-2009.10.23-r6446
Thanks.
http://gwt-code-reviews.appspot.com/89809
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Thanks.
http://gwt-code-reviews.appspot.com/89809
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
On 2009/10/30 18:09:39, rdayal wrote:
Thanks.
Checkstyle/build run without a problem.
Committed as r6559.
Cherry-picked into 2.0 at r6561.
http://gwt-code-reviews.appspot.com/89809
--~--~-~--~~~---~--~~
Revision: 6562
Author: rda...@google.com
Date: Fri Oct 30 11:09:22 2009
Log: Updated branch info to reflect the merge at r6561.
http://code.google.com/p/google-web-toolkit/source/detail?r=6562
Modified:
/releases/2.0/branch-info.txt
===
---
Revision: 6563
Author: fabb...@google.com
Date: Fri Oct 30 11:26:38 2009
Log: Merge r6470, Fix for issue 3374. This patch adds overloads of
encodeComponent and decodeComponent to deal differently with spaces
(keeping them as %20 rather than replacing them with +) and therefore
allow their use for
On Fri, Oct 30, 2009 at 1:31 PM, Bruce Johnson br...@google.com wrote:
If you're confident in the fix, Dan, instead of adding a test right now,
please just add an issue instead to remind us to review in the future what
kind of testing mechanism we would have needed to make a unit test easy to
Revision: 6564
Author: fabb...@google.com
Date: Fri Oct 30 12:00:05 2009
Log: Fixes script permissions, see
http://gwt-code-reviews.appspot.com/89805.
Review by: scottb
Issue: 4718
http://code.google.com/p/google-web-toolkit/source/detail?r=6564
Modified:
/trunk/distro-source/build.xml
Revision: 6565
Author: fabb...@google.com
Date: Fri Oct 30 12:02:11 2009
Log: Merge r6470, This allows multiple source files to be specified for a
ui:style, just like any other CssResource.
It also allows you to put body text on a ui:style that has
sources. The body becomes just one more source
Revision: 6566
Author: r...@google.com
Date: Fri Oct 30 12:10:56 2009
Log: Improve the error message for 'GWT.create(UiBInder.class)'
(as opposed to a subclass of UiBinder).
Review by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=6566
Modified:
Revision: 6567
Author: fabb...@google.com
Date: Fri Oct 30 13:01:57 2009
Log: Merged r6564, fix script permissions for *Creator and benchmarkViewer
http://code.google.com/p/google-web-toolkit/source/detail?r=6567
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/distro-source/build.xml
Revision: 6568
Author: fabb...@google.com
Date: Fri Oct 30 13:26:53 2009
Log: Merge 6481, Just remembered that MenuItemParser has support for the old
phantom MenuItemHTML child, which I killed off like a year ago. Getting
rid of that support drastically simplifies the class.
It also revealed a
Revision: 6569
Author: cromwellian
Date: Fri Oct 30 14:23:53 2009
Log: Adds patch to JsStaticEval to simplify literal1 + literal2 operations.
(where literal can be one of: null, boolean, number, string)
Patch by: cromwellian
Review by: bobv
Revision: 6570
Author: jlaba...@google.com
Date: Fri Oct 30 14:27:25 2009
Log: Reverting r6456 because it was causing JUnitShell to wait indefinitely
for tests to finish. Since BrowserManagerServer can run tests in parallel
(which it does by default), there is no need for this option.
Patch
Revision: 6571
Author: jlaba...@google.com
Date: Fri Oct 30 14:33:17 2009
Log: tr...@6570 was merged into this branch
Revert r6456 because it was causing JUnitShell to wait indefinitely.
svn merge --ignore-ancestry -c 6570
http://google-web-toolkit.googlecode.com/svn/trunk/ .
Patch by:
Revision: 6572
Author: rj...@google.com
Date: Fri Oct 30 15:47:46 2009
Log: Fixing the UiBinderTestApp. The tests don't use the app itself,
just its constituent modules, so I didn't notice that you could
no longer actually run the thing.
Desk review by amitmanjhi
Revision: 6573
Author: rj...@google.com
Date: Fri Oct 30 16:12:45 2009
Log: tr...@6570 was merged into this branch
Fixing the UiBinderTestApp
svn merge --ignore-ancestry -c 6572
https://google-web-toolkit.googlecode.com/svn/trunk .
Reviewers: hermes_google.com, rdamazio_google.com,
Message:
Review requested. Hermes, if you won't actually be able to get to this
please let me know as quickly as you can. Our deadline is very near.
Description:
Moving AttributeParsers to XMLElement, where they belong.
This is a pretty major
Reviewers: scottb, Lex, bobv,
Description:
Changes normal GWT vtable setup from
function foo() { ... }
_.foo = foo;
to
_.foo = function foo() { ... }
This reduces gzip'ed size on Showcase by 2%. Independent testing of
programs with 100% polymorphism shows that this can improve module
Very cool find.
On Fri, Oct 30, 2009 at 8:00 PM, cromwell...@gmail.com wrote:
Note, that if you don't desire correct stack traces, you can use the
following construct:
_.foo = function() { ... }
This results in a 6% post-gzip size reduction on Showcase. It might be
useful to introduce a
On Fri, Oct 30, 2009 at 8:24 PM, Bruce Johnson br...@google.com wrote:
In terms of design, I think this would actually be best as a
permutation-specific conditional deferred binding property that the compiler
is sensitive to (that was a mouthful), so that it would be possible to let
app
I wish we could wrap that all up in a simpler-to-understand package.
But a good article would make it at least bearable.
On Saturday, October 31, 2009, Ray Cromwell cromwell...@gmail.com wrote:
On Fri, Oct 30, 2009 at 8:24 PM, Bruce Johnson br...@google.com wrote:
In terms of design, I
Maybe it would make sense to move properties which the compiler relies on
into a special CompilerFlags.gwt.xml module, then if you want to change
class meta data, class cast checking, aggressive optimization, or stack
info, there'd be one centralized place to look at and document all the
flags.?
yep, and all of them should be per-perm
On Saturday, October 31, 2009, Ray Cromwell cromwell...@gmail.com wrote:
Maybe it would make sense to move properties which the compiler relies on
into a special CompilerFlags.gwt.xml module, then if you want to change class
meta data, class cast
I ran tests on iPhone and Android 2.0 SDK with Showcase and I didn't see any
significant different in startup times over wifi (3g/3dge may be a different
story), so the latency improvement really only shows up in degenerate test
cases where all functions are polymorphic, small and/or empty, so
32 matches
Mail list logo
