http://gwt-code-reviews.appspot.com/646803/diff/1/15
File user/src/com/google/gwt/dom/client/WebSocket.java (right):
http://gwt-code-reviews.appspot.com/646803/diff/1/15#newcode48
user/src/com/google/gwt/dom/client/WebSocket.java:48: };
Is it really necessary to remove all the listeners once
http://gwt-code-reviews.appspot.com/646803/diff/1/10
File user/src/com/google/gwt/dom/client/Event.java (right):
http://gwt-code-reviews.appspot.com/646803/diff/1/10#newcode23
user/src/com/google/gwt/dom/client/Event.java:23: public class Event
extends JavaScriptObject {
Could somebody verify
http://gwt-code-reviews.appspot.com/646803/diff/1/15
File user/src/com/google/gwt/dom/client/WebSocket.java (right):
http://gwt-code-reviews.appspot.com/646803/diff/1/15#newcode48
user/src/com/google/gwt/dom/client/WebSocket.java:48: };
Just forget my last comment :) I misinterpreted the code
On 2010/06/30 15:31:29, jlabanca wrote:
LGTM
Thanks, committed at r8339.
http://gwt-code-reviews.appspot.com/628802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
What does WBP stand for?
On Wed, Jun 23, 2010 at 6:40 AM, Konstantin.Scheglov
konstantin.scheg...@gmail.com wrote:
To support UiBinder in GWT Designer we need to have several changes
in UiBinder generators, writer and parsers.
I will describe below these changes as they are done now.
In
http://gwt-code-reviews.appspot.com/646803/diff/1/12
File user/src/com/google/gwt/dom/client/MessageEvent.java (right):
http://gwt-code-reviews.appspot.com/646803/diff/1/12#newcode30
user/src/com/google/gwt/dom/client/MessageEvent.java:30: public final
String getData() {
On 2010/07/01 11:20:05,
Hi there,
Actually the open events might look broken but after looking carefully into
W3C's spec, I have the feeling they aren't.
At point 5 of the WebSocket constructor it says Return a new
WebSockethttp://dev.w3.org/html5/websockets/#websocket object,
and continue these steps in the background
LGTM
On Wed, Jun 30, 2010 at 4:45 PM, unn...@google.com wrote:
Reviewers: fredsa,
Description:
Update sample to use the latest features
Please review this at http://gwt-code-reviews.appspot.com/672801/show
Affected files:
M
In a few words: everything's in c.g.g.dom, bringing a dependency from
c.g.g.dom to c.g.g.event and breaking the assumption that an
EventHandler is coupled with a GwtEvent (rather than a JSO-derivative),
and it starts to refactor event handling at the low-level, while Joel is
working on it (see
http://gwt-code-reviews.appspot.com/646803/diff/1/16
File user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java
(right):
http://gwt-code-reviews.appspot.com/646803/diff/1/16#newcode22
user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java:22: void
onClose(CloseEvent event);
I
http://gwt-code-reviews.appspot.com/646803/diff/1/16
File user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java
(right):
http://gwt-code-reviews.appspot.com/646803/diff/1/16#newcode22
user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java:22: void
onClose(CloseEvent event);
I
http://gwt-code-reviews.appspot.com/646803/diff/1/15
File user/src/com/google/gwt/dom/client/WebSocket.java (right):
http://gwt-code-reviews.appspot.com/646803/diff/1/15#newcode16
user/src/com/google/gwt/dom/client/WebSocket.java:16: package
com.google.gwt.dom.client;
+1
Echoing a conversation that should have happened on contrib:
jlabanca: This will probably break
The original request was just to have this method on RootPanel, and then I
opened my mouth and broadened its scope. Perhaps that was a mistake? Should
we just ask Marko to define RootPanel#clear(boolean) and declare victory?
On Thu, Jul 1, 2010 at 1:55 PM, Ray Ryan rj...@google.com wrote:
http://gwt-code-reviews.appspot.com/646803/diff/1/16
File user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java
(right):
http://gwt-code-reviews.appspot.com/646803/diff/1/16#newcode22
user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java:22: void
onClose(CloseEvent event);
I
http://gwt-code-reviews.appspot.com/646803/diff/1/16
File user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java
(right):
http://gwt-code-reviews.appspot.com/646803/diff/1/16#newcode18
user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java:18: import
I could do that easily tomorrow...
On Thu, Jul 1, 2010 at 7:56 PM, Ray Ryan rj...@google.com wrote:
The original request was just to have this method on RootPanel, and then I
opened my mouth and broadened its scope. Perhaps that was a mistake? Should
we just ask Marko to define
://www.instantiations.com/gwtdesigner/ is tool for
WYSIWYG building of GWT UI, which development I lead at Instantiations.
Its latest release works only with Java source for GWT, but now I work on
UiBinder support too and many things already
workhttp://dl.dropbox.com/u/76691/Eclipse/images/Screenshot-20100701
http://gwt-code-reviews.appspot.com/646803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8346
Author: unn...@google.com
Date: Thu Jul 1 14:10:00 2010
Log: Update sample to use the latest features
Review at http://gwt-code-reviews.appspot.com/672801
Review by: fre...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8346
Deleted:
20 matches
Mail list logo
