[gwt-contrib] ImageResource to html

2010-08-13 Thread stuckagain
Hi, Is there an officially supported way to create a IMG tag as HTML text from an ImageResource ? Right now the only solution that I see is to create an Image( ImageResource ) and do a toString() on it. Many widgets from GWT support the user of setHTML, and in many cases I need this to put an

[gwt-contrib] Re: ImageResource to html

2010-08-13 Thread Thomas Broyer
On 13 août, 10:14, stuckagain david.no...@gmail.com wrote: Hi, Is there an officially supported way to create a IMG tag as HTML text from an ImageResource ? AbstractImagePrototype.create(myImageResource).getHTML() I don't know if it is officially supported, but it's using public,

Re: [gwt-contrib] ImageResource to html

2010-08-13 Thread Miroslav Pokorny
Hi David What do you mean by IMG tag, do you mean IMG with a src=/somefile on the server ? -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] ImageResource to html

2010-08-13 Thread David
Miroslav, Thomas already gave me a workable solution. I want to use ImageResources in widgets that expose a setHTML(...) method to put something more complex in there (for example in the ComplexButton/ToggleButton). They do not support widgets in thos locations so I can not put an Image widget.

Re: [gwt-contrib] Re: ImageResource to html

2010-08-13 Thread BobV
On Fri, Aug 13, 2010 at 6:31 AM, Thomas Broyer t.bro...@gmail.com wrote: AbstractImagePrototype.create(myImageResource).getHTML() Yes. There is no getHTML() method on the ImageResource interface because the choice of how to render the data is ultimately part of the UI toolkit. -- Bob Vawter

[gwt-contrib] Re: HasEnabled (issue757801)

2010-08-13 Thread jlabanca
@johan - Can you sign a Contributor License Agreement so we can include your code: http://code.google.com/legal/individual-cla-v1.0.html If you scroll to the bottom, you can sign it electronically. - John http://gwt-code-reviews.appspot.com/757801/show --

[gwt-contrib] Re: Add mouse position information to ClickEvent and DoubleClickEvent. Manually verified that this (issue763801)

2010-08-13 Thread jgw
On 2010/08/12 22:32:53, fredsa wrote: LGTM. http://gwt-code-reviews.appspot.com/763801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HasEnabled (issue757801)

2010-08-13 Thread Johan Rydberg
Done! On Fri, Aug 13, 2010 at 4:00 PM, jlaba...@google.com wrote: @johan - Can you sign a Contributor License Agreement so we can include your code: http://code.google.com/legal/individual-cla-v1.0.html If you scroll to the bottom, you can sign it electronically. - John

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

2010-08-13 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/750801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

2010-08-13 Thread jbrosenberg
Ok, I've addressed Bob's minor nits there (thanks Bob for catching)... I shall proceed to submit this puppy. Thanks for the great review guys Jason http://gwt-code-reviews.appspot.com/750801/diff/10002/45012 File user/src/com/google/gwt/rpc/linker/CastableTypeDataImpl.java (right):

[gwt-contrib] Re: Fix the equals method for RecordKey. Forgot to make this change in the just (issue766801)

2010-08-13 Thread rjrjr
http://gwt-code-reviews.appspot.com/766801/diff/1/4 File user/test/com/google/gwt/requestfactory/RequestFactoryJreSuite.java (right): http://gwt-code-reviews.appspot.com/766801/diff/1/4#newcode26 user/test/com/google/gwt/requestfactory/RequestFactoryJreSuite.java:26: * Suite of UiBinder tests

[gwt-contrib] Re: Removed use of a global table (typeIdArray) for testing castability between types. This informa... (issue750801)

2010-08-13 Thread Jason Rosenberg
Appears I spoke too soon, getting a submit-queue test failure On Fri, Aug 13, 2010 at 12:06 PM, jbrosenb...@google.com wrote: Ok, I've addressed Bob's minor nits there (thanks Bob for catching)... I shall proceed to submit this puppy. Thanks for the great review guys Jason

[gwt-contrib] [google-web-toolkit] r8536 committed - Public: Fix gwt compile errors in javax.validation....

2010-08-13 Thread codesite-noreply
Revision: 8536 Author: ncha...@google.com Date: Fri Aug 13 06:36:43 2010 Log: Public: Fix gwt compile errors in javax.validation. I changed InputStreams to Strings and Local to GwtLocale. For the Validation class, I completely gutted it, bootstraping validation in GWT will not use this class.

[gwt-contrib] Incorporated Ray's feedback on http://code.google.com/p/google-web-toolkit/source/detail?r=8533 (issue768801)

2010-08-13 Thread amitmanjhi
Reviewers: Ray Ryan, Description: Incorporated Ray's feedback on http://code.google.com/p/google-web-toolkit/source/detail?r=8533 Fixed the comment in RequestFactoryJreSuite and added a test to RecordKeyTest. Patch by: amitmanjhi Review by: rjrjr Please review this at

[gwt-contrib] Re: Hard coded History integration for the Scaffold app. This is step zero (issue717801)

2010-08-13 Thread rjrjr
http://gwt-code-reviews.appspot.com/717801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: History integration for the RequestFactory apps. (issue717801)

2010-08-13 Thread rjrjr
Okay, Rayc, this is ready for review. On 2010/08/13 17:43:18, Ray Ryan wrote: http://gwt-code-reviews.appspot.com/717801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8537 committed - Override annotation and formatting...

2010-08-13 Thread codesite-noreply
Revision: 8537 Author: amitman...@google.com Date: Fri Aug 13 07:48:52 2010 Log: Override annotation and formatting Patch by: amitmanjhi Review by: rjrjr (tbr) http://code.google.com/p/google-web-toolkit/source/detail?r=8537 Modified:

[gwt-contrib] Re: Public: Fix gwt compile errors in javax.validation. (issue764801)

2010-08-13 Thread Ray Ryan
LGTM On Thu, Aug 12, 2010 at 4:17 PM, ncha...@google.com wrote: Reviewers: Ray Ryan, Description: Public: Fix gwt compile errors in javax.validation. I changed InputStreams to Strings and Local to GwtLocale. For the Validation class, I completely gutted it, bootstraping validation in GWT

[gwt-contrib] Re: Incorporated Ray's feedback on http://code.google.com/p/google-web-toolkit/source/detail?r=8533 (issue768801)

2010-08-13 Thread amitmanjhi
http://gwt-code-reviews.appspot.com/768801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Incorporated Ray's feedback on http://code.google.com/p/google-web-toolkit/source/detail?r=8533 (issue768801)

2010-08-13 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/768801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8538 committed - Removes vestiges of TypeOracle support for local types....

2010-08-13 Thread codesite-noreply
Revision: 8538 Author: gwt.mirror...@gmail.com Date: Fri Aug 13 13:25:52 2010 Log: Removes vestiges of TypeOracle support for local types. TypeOracle hasn't supported local types for a while, this change removes traces of it. http://gwt-code-reviews.appspot.com/761801/show Review by: jat

[gwt-contrib] [google-web-toolkit] r8539 committed - Incorporated Ray's feedback on http://code.google.com/p/google-web-too...

2010-08-13 Thread codesite-noreply
Revision: 8539 Author: amitman...@google.com Date: Fri Aug 13 10:45:41 2010 Log: Incorporated Ray's feedback on http://code.google.com/p/google-web-toolkit/source/detail?r=8533 Fixed the comment in RequestFactoryJreSuite and added a test to RecordKeyTest. Patch by: amitmanjhi Review by:

[gwt-contrib] Re: History integration for the RequestFactory apps. (issue717801)

2010-08-13 Thread Ray Ryan
Nothing has changed in the ui area since John last looked, so we're good there. On Fri, Aug 13, 2010 at 2:25 PM, cromwell...@google.com wrote: On 2010/08/13 17:50:40, Ray Ryan wrote: Okay, Rayc, this is ready for review. On 2010/08/13 17:43:18, Ray Ryan wrote: LGTM, but John might

[gwt-contrib] Public: Support classes for a future generating GWT validators. (issue766802)

2010-08-13 Thread nchalko
Reviewers: Ray Ryan, Description: Public: Support classes for a future generating GWT validators. This classes are incomplete with plenty of TODO's. Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/766802/show Affected files: A

[gwt-contrib] [google-web-toolkit] r8540 committed - Split BigDecimal/BigInteger tests out of EmulSuite....

2010-08-13 Thread codesite-noreply
Revision: 8540 Author: j...@google.com Date: Fri Aug 13 12:36:25 2010 Log: Split BigDecimal/BigInteger tests out of EmulSuite. Suggested by: scottb Review by: scottb http://code.google.com/p/google-web-toolkit/source/detail?r=8540 Added:

[gwt-contrib] Re: Adds partial support for related fields to RequestFactory. Right now, getters of such fields alw... (issue741801)

2010-08-13 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/741801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Change to CompilationStateBuilder to prevent recursive invalidation on changed units. (issue756802)

2010-08-13 Thread scottb
Reviewers: Keith, Description: Change to CompilationStateBuilder to prevent recursive invalidation on changed units. Previously, changing any unit would not only force that unit to be recompiled, but we would then transitively invalidate any units depending on that unit. So changing one file

[gwt-contrib] Re: History integration for the RequestFactory apps. (issue717801)

2010-08-13 Thread t . broyer
I only quickly read through the list of added files and some of the files' content, but I can say I really like it the way it is (with PlaceTokenizer instead of the static fromToken method described in the Wave) There's a nit though, which should be probably fixed rather sooner than later ;-)

[gwt-contrib] Re: History integration for the RequestFactory apps. (issue717801)

2010-08-13 Thread Ray Ryan
Oui, requeste. Merci On Aug 13, 2010 5:38 PM, t.bro...@gmail.com wrote: I only quickly read through the list of added files and some of the files' content, but I can say I really like it the way it is (with PlaceTokenizer instead of the static fromToken method described in the Wave)

[gwt-contrib] [google-web-toolkit] r8542 committed - Add mouse position information to ClickEvent and DoubleClickEvent. Man...

2010-08-13 Thread codesite-noreply
Revision: 8542 Author: fre...@google.com Date: Fri Aug 13 16:13:23 2010 Log: Add mouse position information to ClickEvent and DoubleClickEvent. Manually verified that this information is indeed available on some older and some more modern browsers, sampling Mac/Linux/Win where possible: -