[gwt-contrib] Re: Test timeout in JUnitShell ? (GWT 2.0.0)

2010-10-20 Thread Ed
I couldn't hold back investigating a bit more. Like described in my last post, the timeout always occurred/started in a GWTTestCase class that contained two test cases that involve RPC calls. I did split up these test cases such that they have their own GWTTestCase class, and the timeout

Re: [gwt-contrib] Re: Test timeout in JUnitShell ? (GWT 2.0.0)

2010-10-20 Thread John Tamplin
On Wed, Oct 20, 2010 at 9:22 AM, Ed post2edb...@gmail.com wrote: I couldn't hold back investigating a bit more. Like described in my last post, the timeout always occurred/started in a GWTTestCase class that contained two test cases that involve RPC calls. I did split up these test cases

[gwt-contrib] Re: GWT 2.1 MVP with GIN

2010-10-20 Thread Aigeec
Hey Guys, I am also interested in an implementation of GWT 2.1 MVP using GIN. I have made some head way with it. This has been done mostly by extending the ActivityManager, PlaceController and PlaceHistoryHandler classes and overriding their constructors to use GIN injection. I don't know if

[gwt-contrib] Re: Add a ControllerBinder in UiBinder so that UiHandlers can be bound on both the (issue923801)

2010-10-20 Thread Jeff Larsen
This is something I'm really interested in as well Stephen. - How do you test these things? How does the next guy know whether his event handler belongs in the view or the controller? - If the event doesn't change the view state, it doesn't belong in the view. I would argue that clicking

[gwt-contrib] Re: Enum Ordinalization Optimization (issue1015801)

2010-10-20 Thread zundel
Some comments on style http://gwt-code-reviews.appspot.com/1015801/diff/6001/7001 File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right): http://gwt-code-reviews.appspot.com/1015801/diff/6001/7001#newcode771

[gwt-contrib] [google-web-toolkit] r9125 committed - Cherry picking bugs from trunk into release branch: 1032801, 1035801, ...

2010-10-20 Thread codesite-noreply
Revision: 9125 Author: gwt.mirror...@gmail.com Date: Wed Oct 20 04:18:31 2010 Log: Cherry picking bugs from trunk into release branch: 1032801, 1035801, 1031801 http://code.google.com/p/google-web-toolkit/source/detail?r=9125 Modified: /releases/2.1/samples/expenses/README-MAVEN.txt

[gwt-contrib] [google-web-toolkit] r9126 committed - Removing 2.1.0 tag (will re-add)

2010-10-20 Thread codesite-noreply
Revision: 9126 Author: p...@google.com Date: Wed Oct 20 07:53:40 2010 Log: Removing 2.1.0 tag (will re-add) http://code.google.com/p/google-web-toolkit/source/detail?r=9126 Deleted: /tags/2.1.0 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9127 committed - Adding 2.1.0 tag

2010-10-20 Thread codesite-noreply
Revision: 9127 Author: p...@google.com Date: Wed Oct 20 07:54:16 2010 Log: Adding 2.1.0 tag http://code.google.com/p/google-web-toolkit/source/detail?r=9127 Added: /tags/2.1.0 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Add a ControllerBinder in UiBinder so that UiHandlers can be bound on both the (issue923801)

2010-10-20 Thread Stephen Haberman
How do you test these things? This gwt-hack example project is horribly unmaintained, but the idea is: http://github.com/stephenh/gwt-hack/blob/master/src/test/java/com/bizo/gwthack/client/presenters/ClientPresenterTest.java When GwtFooView is generated, so is StubFooView, which has fields

Re: [gwt-contrib] Re: GWT 2.1 MVP with GIN

2010-10-20 Thread David Chandler
Hmmm, I see my comments about GIN in the ActivityMapper have caught up with me. I haven't worked this out fully yet, but was thinking of something along the lines of gwt-presenter's a

Re: [gwt-contrib] Re: Not using dvsDataMap on child entities

2010-10-20 Thread Tim Murison
Any updates on this issue? It seems very much like a bug as opposed to a purposeful design choice. All the editors work with object graphs and it makes sense to persist changes by sending object graph. On Fri, Oct 15, 2010 at 11:05 AM, Patrick Julien pjul...@gmail.com wrote: Not to mention that

Re: [gwt-contrib] Re: Not using dvsDataMap on child entities

2010-10-20 Thread Tim Murison
More notes on this: Say I have the following relationship, a User has a list of OfficeHours. Using the editor framework, I can create OfficeHours proxies, add them to User and persist() and get the whole graph, including new OfficeHours, on the server. If I add a new OfficeHours proxy and update

Re: [gwt-contrib] Re: Not using dvsDataMap on child entities

2010-10-20 Thread BobV
On Wed, Oct 20, 2010 at 11:34 AM, Tim Murison tim.muri...@gmail.com wrote: Any updates on this issue? I am burning down the server code this week. -- Bob Vawter Google Web Toolkit Team -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Not using dvsDataMap on child entities

2010-10-20 Thread Tim Murison
On Wed, Oct 20, 2010 at 12:02 PM, BobV b...@google.com wrote: On Wed, Oct 20, 2010 at 11:34 AM, Tim Murison tim.muri...@gmail.com wrote: Any updates on this issue? I am burning down the server code this week. Will it be replaced with some shiny new server code? --

[gwt-contrib] Update the npapi plugin to support OSX. (issue1036801)

2010-10-20 Thread conroy
Reviewers: jat, fabiomfv, Description: Update the npapi plugin to support OSX. Please review this at http://gwt-code-reviews.appspot.com/1036801/show Affected files: M plugins/npapi/Makefile M plugins/npapi/manifest-template.json A

[gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)

2010-10-20 Thread jat
LGTM if you have verified it works with the Linux .so's in the CRX and a couple of nits. http://gwt-code-reviews.appspot.com/1036801/diff/1/3 File plugins/npapi/manifest-template.json (right): http://gwt-code-reviews.appspot.com/1036801/diff/1/3#newcode24

[gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)

2010-10-20 Thread conroy
http://gwt-code-reviews.appspot.com/1036801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)

2010-10-20 Thread conroy
http://gwt-code-reviews.appspot.com/1036801/diff/1/3 File plugins/npapi/manifest-template.json (right): http://gwt-code-reviews.appspot.com/1036801/diff/1/3#newcode24 plugins/npapi/manifest-template.json:24: { path: Darwin-gcc3/gwtDev.plugin, public: true } On 2010/10/20 17:24:20, jat wrote:

Re: [gwt-contrib] Re: GWT 2.1 MVP with GIN

2010-10-20 Thread David
Why not include Gin in GWT 2.1 ? It could maybe be useful inside the GWT codebase as well ? On Wed, Oct 20, 2010 at 5:32 PM, David Chandler drfibona...@google.com wrote: Hmmm, I see my comments about GIN in the ActivityMapper have caught up with me. I haven't worked this out fully yet, but was

[gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)

2010-10-20 Thread jat
Ok. Be sure and check in the compiled libraries in prebuilt and an updated CRX at the same time. http://gwt-code-reviews.appspot.com/1036801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)

2010-10-20 Thread knorton
LGTM2 On 2010/10/20 18:54:20, jat wrote: Ok. Be sure and check in the compiled libraries in prebuilt and an updated CRX at the same time. http://gwt-code-reviews.appspot.com/1036801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)

2010-10-20 Thread Arthur Kalmenson
Is this coming with GWT 2.1? I'm guessing this is a Chrome Extension for Mac OS X -- Arthur Kalmenson On Wed, Oct 20, 2010 at 3:10 PM, knor...@google.com wrote: LGTM2 On 2010/10/20 18:54:20, jat wrote: Ok. Be sure and check in the compiled libraries in prebuilt and an updated CRX

[gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)

2010-10-20 Thread fabiomfv
http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001 File plugins/npapi/Makefile (right): http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001#newcode47 plugins/npapi/Makefile:47: CFLAGS += -DBROWSER_NPAPI -DXP_UNIX -fshort-wchar out of curiosity, why are we defining XP_UNIX for a

Re: [gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)

2010-10-20 Thread John Tamplin
On Wed, Oct 20, 2010 at 3:25 PM, Arthur Kalmenson arthur.k...@gmail.comwrote: Is this coming with GWT 2.1? I'm guessing this is a Chrome Extension for Mac OS X The plugins are updated independently of GWT itself, and this can be used with GWT 2.0 as well. Note that Chrome on both Mac and

[gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)

2010-10-20 Thread conroy
http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001 File plugins/npapi/Makefile (right): http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001#newcode47 plugins/npapi/Makefile:47: CFLAGS += -DBROWSER_NPAPI -DXP_UNIX -fshort-wchar On 2010/10/20 19:31:06, fabiomfv wrote: out of

[gwt-contrib] Reformulate RPC generated TypeHandlers to create fewer classes. (issue1037801)

2010-10-20 Thread scottb
Reviewers: zundel, bobv, Description: This is a reformulation of the TypeHandler change, which causes the generated serializer class to serve as the TypeHandler interface implementor. The current implementation uses an inner class, which causes twice as many types to get generated. Please

[gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)

2010-10-20 Thread conroy
http://gwt-code-reviews.appspot.com/1036801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)

2010-10-20 Thread fabiomfv
On 2010/10/20 19:44:12, conroy wrote: http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001 File plugins/npapi/Makefile (right): http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001#newcode47 plugins/npapi/Makefile:47: CFLAGS += -DBROWSER_NPAPI -DXP_UNIX -fshort-wchar On

[gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)

2010-10-20 Thread Chris Conroy
I'm glad you mention this: In the latest version of the patch I'm nuking Makefile.mac (amongst other cruft) since unused bits like this laying around just cause confusion. XP_MACOSX is set higher up in the Makefile on the OS==mac check. I set XP_UNIX there so that linux and mac can share it. On

[gwt-contrib] Re: Update the npapi plugin to support OSX. (issue1036801)

2010-10-20 Thread fabiomfv
On 2010/10/20 20:06:42, conroy wrote: I'm glad you mention this: In the latest version of the patch I'm nuking Makefile.mac (amongst other cruft) since unused bits like this laying around just cause confusion. XP_MACOSX is set higher up in the Makefile on the OS==mac check. I set XP_UNIX

[gwt-contrib] Re: Exposes the built-in year-month-weekday-day format in PredefinedFormat. (issue1039801)

2010-10-20 Thread jat
LGTM, thanks. http://gwt-code-reviews.appspot.com/1039801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] GWT 2.1 MVP with Code Splitting

2010-10-20 Thread Tolga Tarhan
All, Somewhat similar to my previous email about GIN with MVP, I also have a concern regarding using Code Splitting with the MVP framework as it sits today. Specifically, it would appear that ActivityMapper can't use runAsync because it has to return the matching activity synchronously.

[gwt-contrib] [google-web-toolkit] r9129 committed - Exposes the built-in year-month-weekday-day format in PredefinedFormat...

2010-10-20 Thread codesite-noreply
Revision: 9129 Author: gry...@google.com Date: Wed Oct 20 12:39:18 2010 Log: Exposes the built-in year-month-weekday-day format in PredefinedFormat. Review at http://gwt-code-reviews.appspot.com/1039801 Patch by: guillaume.ryder Review by: jat

[gwt-contrib] Re: Make the following method public in StackTraceDeobfuscator, for reuse by user server side code: (issue1040801)

2010-10-20 Thread fredsa
http://gwt-code-reviews.appspot.com/1040801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make the following method public in StackTraceDeobfuscator, for reuse by user server side code: (issue1040801)

2010-10-20 Thread fredsa
http://gwt-code-reviews.appspot.com/1040801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors