Hi David,
thanks for your reply! I'm eagerly waiting for the 2.1.1 :-)
Regards
Alexei
On Nov 3, 10:35 pm, David Chandler drfibona...@google.com wrote:
Hi Alexei, sorry for the slow response. I confirmed this with bobv and
was working on a reply but got sidetracked.
The behavior you're
http://gwt-code-reviews.appspot.com/1076801/diff/1/2
File dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java
(right):
http://gwt-code-reviews.appspot.com/1076801/diff/1/2#newcode676
dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:676: //
TODO(jgw): Not sure if
http://gwt-code-reviews.appspot.com/1077801/diff/3001/4002
File user/src/com/google/gwt/dom/client/DOMImplIE8.java (right):
http://gwt-code-reviews.appspot.com/1077801/diff/3001/4002#newcode77
user/src/com/google/gwt/dom/client/DOMImplIE8.java:77:
cssSetOpacityPirorToIe9(style, value);
Comment by stephen.haberman:
Hurray for structural typing. :-)
That being said, I think you're coupling benefits of a concrete base
class with cannot use interfaces for widgets--to me, they're separate
concerns because you can:
* Enforce a concrete class internally within the widget impls
[+rjrjr]
I haven't put much thought into widget interfaces recently (I've been busy
wrestling low-level stuff on other fronts), but clearly Ray and others have
been thinking about this problem (based upon the appearance of IsWidget,
which seems to have worked out well). Thoughts?
--
http://gwt-code-reviews.appspot.com/1076801/diff/1/2
File dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java
(right):
http://gwt-code-reviews.appspot.com/1076801/diff/1/2#newcode687
dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:687:
JMethod found =
Panel basically already is a set of interfaces, like HasWidgets,
HasOneWidget, IndexedPanel and InsertPanel. In 2.1 we've added the IsWidget
interface that Joel alluded to, and retrofitted the panel apis to accept
IsWidget wherever it also accepts Widget. (Unfortunately backward
compatibility
http://gwt-code-reviews.appspot.com/867801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
We need to provide at least some support for @UiField(provided) and
@UiFactory in GWT Designer. At design time we pass null as owner, so
we need to use special design time hooks to create instances of widgets.
Please review this at
Thanks for the feedback guys. I'll take another look at this, and do some
more thorough testing, probably after my trip (Nov 6-17th) though.
On Thu, Nov 4, 2010 at 7:53 AM, jlaba...@google.com wrote:
http://gwt-code-reviews.appspot.com/1077801/diff/3001/4002
File
We've also introduced ValueBoxBase, a new superclass refactored out of
TextBoxBase.
I'd briefly seen that, but didn't realize it came out of TextBoxBase.
Thanks for pointing it out.
Suppose we added something like IsWidget IsFocusWidget
IsTextWidget. Would that clean things up for you?
Eric, I got halfway through this, and decided to hold off pending some
high level feedback.
Precompile is starting to get really unwieldy, there are now essentially
4 different code paths, and I'm not even sure all the options make sense
together. What happens if you -XdisableGeneratingOnShards
A second entry point for compile makes a lot of sense - and maybe for
CompilePerms too. Keep looking and tell me what you think.
I'm thinking of these names:
PrecompileOnePerm for the new precompile entry point.
CompileOnePerm for the new compile perms entry point
With those names we can
Additional comments.
http://gwt-code-reviews.appspot.com/1074801/diff/7001/8004
File dev/core/src/com/google/gwt/dev/CompilePerms.java (right):
http://gwt-code-reviews.appspot.com/1074801/diff/7001/8004#newcode228
dev/core/src/com/google/gwt/dev/CompilePerms.java:228: PrecompileOptions
Reviewers: sbrubaker,
Description:
Refactoring HasDataPresenter to save pending changes in a PendingState,
pushing them to the view in a finally command at the end of the event
loop. This change reduces the number of times that the view is updated
in the same event loop and eliminates some
http://gwt-code-reviews.appspot.com/1074801/diff/7001/8004
File dev/core/src/com/google/gwt/dev/CompilePerms.java (right):
http://gwt-code-reviews.appspot.com/1074801/diff/7001/8004#newcode228
dev/core/src/com/google/gwt/dev/CompilePerms.java:228: PrecompileOptions
precompilationOptions =
On
Hi.
I'm using the GWT 2 code splitting functionality.
My application is very big, actually its size is about 9 MB when
compiled with obfuscated style.
I achieved to split the application in several parts and reduce the
initial download to half of the full size.
The code splitting works well and
Reviewers: sbrubaker,
Description:
Adding a new method AbstractHasData#setRowData(List) to make CellList
and CellTable easier to use without a data provider. Currently, users
must call setRowCount() any time the row count changes in order to hide
truncated rows. That makes sense in a
Revision: 9177
Author: amitman...@google.com
Date: Fri Oct 29 12:56:11 2010
Log: Updated the script to install the artifacts to the correct maven
location
Patch by: amitmanjhi
Review by: rdayal
http://code.google.com/p/google-web-toolkit/source/detail?r=9177
Modified:
Revision: 9178
Author: gwt.mirror...@gmail.com
Date: Thu Nov 4 19:21:08 2010
Log: Adding a public method AbstractHasData#getRowContainer() to give users
access to the element that contains all rendered row values. The new public
methods delegates to the abstract method getChildContainer().
Revision: 9179
Author: jlaba...@google.com
Date: Mon Nov 1 09:38:30 2010
Log: Fixing a bug in CellTree where we always pass null as the key for the
rendered object instead of passing the key.
Review at http://gwt-code-reviews.appspot.com/1070801
Review by: p...@google.com
Revision: 9181
Author: fabio...@google.com
Date: Tue Nov 2 04:47:58 2010
Log: The proposed fix will disambiguate setter overloads by ranking them
according
to the 'cost' of conversion. Fewer arguments will be preferred over many
arguments (e.g. setValue(boolean) will be preferred over
Revision: 9183
Author: j...@google.com
Date: Thu Nov 4 05:27:15 2010
Log: Loosens up JSO restrictions in the TypeOracle to allow multiple JSO
implementations of an interface if the implementations share a common base
class that fully implements the interface.
Review at
Revision: 9186
Author: fre...@google.com
Date: Thu Nov 4 11:42:25 2010
Log: Remove stray javadoc character.
Review at http://gwt-code-reviews.appspot.com/1075801
Review by: ahume...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9186
Modified:
Revision: 9180
Author: unn...@google.com
Date: Mon Nov 1 10:01:11 2010
Log: Ensure that all base URL's are absolut-ify-ed, no matter where we get
them from.
Also refactor the compute script base code to be easier to read
Review at http://gwt-code-reviews.appspot.com/1066801
Review by:
25 matches
Mail list logo
