Sorry for being so prescriptive in my first email about interfaces and
mocking and starting a bit of a side discussion about interfaces Vs
abstract classes. It smells a little like a no-one-right-answer
discussion that has probably been debated in every API forum.
I think most people could live
Personally, I'm a fan of having both. The default implementation can
be an abstract class but have that abstract class implement the
Activity interface. Developers will be making a conscious choice to
use the interface only knowing that they can introduce bugs.
--
LGTM
http://gwt-code-reviews.appspot.com/1184801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9357
Author: rchan...@google.com
Date: Fri Dec 3 08:29:14 2010
Log: Cherry picking r9353 into release branch for Issues 5563 and 5460
http://code.google.com/p/google-web-toolkit/source/detail?r=9357
Modified:
/releases/2.1/user/src/com/google/gwt/text/client/DoubleParser.java
Revision: 9358
Author: gwt.mirror...@gmail.com
Date: Mon Dec 6 07:53:26 2010
Log: Undeprecate HandlerManager and TabPanel, neither of which is quite
ready to die yet.
Review at http://gwt-code-reviews.appspot.com/1187801
Review by: jlaba...@google.com
Revision: 9359
Author: gwt.mirror...@gmail.com
Date: Mon Dec 6 07:55:08 2010
Log: Rolling back r9354 due to some GWTTestCase breakages
Review at http://gwt-code-reviews.appspot.com/1188801
http://code.google.com/p/google-web-toolkit/source/detail?r=9359
Modified:
Revision: 9360
Author: gwt.mirror...@gmail.com
Date: Mon Dec 6 07:57:35 2010
Log: Update MissingPlugin.html to reflect new Chrome platform support
Review at http://gwt-code-reviews.appspot.com/1184801
http://code.google.com/p/google-web-toolkit/source/detail?r=9360
Modified:
http://gwt-code-reviews.appspot.com/1189801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jbrosenberg, scottb, tobyr,
Description:
Isolates the portion of TypeOracleMediator that
deals with JDT derived classes such as CompilationUnit
and Compiled Class. This sets up TypeOracleMediator
so that the TypeOracle can potentially be built without
referencing JDT output.
Please
This change is not all the way ready for review, but I wanted some
feedback on the testing portion.
The overall aim of this change is to isolate the part of building the
type oracle that relies on running the JDT compiler from the part that
builds the type oracle from bytecode.
The idea is to
http://gwt-code-reviews.appspot.com/1188802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9361
Author: fre...@google.com
Date: Mon Dec 6 09:48:07 2010
Log: Modifications to StackTraceDeobfuscator:
- Introduces a new protected method, getSymbolMapInputStream(), to obtain a
symbol map InputStream for a given permutation strong name, to be
overridden by subclasses.
-
Committed as r9361
http://gwt-code-reviews.appspot.com/1189801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9362
Author: gwt.mirror...@gmail.com
Date: Mon Dec 6 14:51:53 2010
Log: Partial fix for
http://code.google.com/p/google-web-toolkit/issues/detail?id=5707
Modify JsInliner to avoid propagating expressions incorrectly.
in EvaluationOrderVisitor, two changes were made. First of all,
I forgot to edit the log description before I submitted, this isn't a
partial fix, it's a complete fix, although it is more conservative
than it needs to be (an inliner could substitute and propagate
expressions if it did better dataflow analysis). It can be made more
optimal later.
-Ray
On Mon,
Looks like this is heading in a good direction. Idea for the test code.
Another high level idea is that you a single test case superclass with
the bulk of the code, then you have to two subclasses that only differ
in how typeOracle is built. We use this pattern in other places.
Hi,
I was trying to execute the test but I got this error:
...
...
...
-filter.props:
build:
compile.emma.if.enabled:
-compile.emma.if.enabled:
compile.tests:
compile.emma.if.enabled:
-compile.emma.if.enabled:
compile.tests:
[mkdir] Created dir: /Users/Luis/Documents/workspace-gwt/gwt/build/
PTAL
http://gwt-code-reviews.appspot.com/1185801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
18 matches
Mail list logo
