On 2011/01/25 00:24:52, jhollenbach wrote:
LGTM
http://gwt-code-reviews.appspot.com/1322801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rchandia,
Description:
If some unrecoverable failure happens during validation, a
ValidationException is raised.
[JSR 303 TCK Result] 66 of 257 (25.68%) Pass with 25 Failures and 3
Errors.
Please review this at http://gwt-code-reviews.appspot.com/1295803/show
Affected files:
M
Ready for another look. The moves in the autobean.server package don't
have any interesting diffs except to change visibilities.
http://gwt-code-reviews.appspot.com/1320801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jlabanca,
Description:
Handle deferred layout updates gracefully in SplitLayoutPanel resize
logic.
Resubmitting with fixes for the CellViewSuite test breakage.
Please review this at http://gwt-code-reviews.appspot.com/1295804/show
Affected files:
M
LGTM
http://gwt-code-reviews.appspot.com/1295804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Remove experimental warning from Canvas and clean up javadoc.
Please review this at http://gwt-code-reviews.appspot.com/1286802/show
Affected files:
M user/src/com/google/gwt/canvas/client/Canvas.java
M
Revision: 9605
Author: con...@google.com
Date: Tue Jan 25 04:39:49 2011
Log: Update MissingPlugin.html for FF4 support
Review at http://gwt-code-reviews.appspot.com/1322802
http://code.google.com/p/google-web-toolkit/source/detail?r=9605
Modified:
http://gwt-code-reviews.appspot.com/1299801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1299801/diff/1/2
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/PersonEditor.java
(right):
http://gwt-code-reviews.appspot.com/1299801/diff/1/2#newcode59
Revision: 9606
Author: fmal...@google.com
Date: Tue Jan 25 05:06:56 2011
Log: Handle deferred layout updates gracefully in SplitLayoutPanel resize
logic.
Resubmitting with fixes for the CellViewSuite test breakage.
Review at http://gwt-code-reviews.appspot.com/1295804
Review by:
LGTM. With nits.
http://gwt-code-reviews.appspot.com/1287802/diff/1/2
File
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
(right):
http://gwt-code-reviews.appspot.com/1287802/diff/1/2#newcode91
LGTM
On 2011/01/25 14:21:45, Nick Chalko wrote:
http://gwt-code-reviews.appspot.com/1295803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9607
Author: gwt.mirror...@gmail.com
Date: Tue Jan 25 08:47:13 2011
Log: Allow Editor framework to handle primitive types.
Issue 5864.
Patch by: bobv
Review by: rjrjr
Review at http://gwt-code-reviews.appspot.com/1312802
http://code.google.com/p/google-web-toolkit/source/detail?r=9607
LGTM
http://gwt-code-reviews.appspot.com/1299801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Oops, PlaceHistoryGeneratorContextTest is failing:
java.lang.NullPointerException
at
com.google.gwt.place.rebind.PlaceHistoryGeneratorContext.getPrefixForTokenizerType(PlaceHistoryGeneratorContext.java:269)
at
One nit and one question about redundant getters.
http://gwt-code-reviews.appspot.com/1320801/diff/3001/4005
File user/src/com/google/gwt/autobean/rebind/model/JBeanMethod.java
(right):
http://gwt-code-reviews.appspot.com/1320801/diff/3001/4005#newcode30
Reviewers: knorton,
Description:
- Use z-index to layer multiple notifications in hosted.html
- ModuleSpace.java produces well formed HTML, replacing /pre with
/div
Please review this at http://gwt-code-reviews.appspot.com/1323801/show
Affected files:
M
LGTM
http://gwt-code-reviews.appspot.com/1286802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1299801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9608
Author: ncha...@google.com
Date: Tue Jan 25 07:30:57 2011
Log: Throw an IllegalErgumentException if the property name is invalid.
[JSR 303 TCK Result] 66 of 257 (25.68%) Pass with 25 Failures and 3 Errors.
Review at http://gwt-code-reviews.appspot.com/1287802
Review by:
http://gwt-code-reviews.appspot.com/1310801/diff/1/3
File user/src/com/google/gwt/jsonp/client/JsonpRequest.java (right):
http://gwt-code-reviews.appspot.com/1310801/diff/1/3#newcode70
user/src/com/google/gwt/jsonp/client/JsonpRequest.java:70: }
On 2011/01/24 14:31:26, bobv wrote:
Extra
http://gwt-code-reviews.appspot.com/1323801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9609
Author: rchan...@google.com
Date: Tue Jan 25 08:05:30 2011
Log: Updates DTRF to show the use of ServiceLocators and Locators.
- Added editors to modify person schedules
- Schedule is now a RF Entity and TimeSlot is now a VO
- ScheduleLocator interfaces with non standard getKey and
Submitted as of r9609
On 2011/01/25 18:39:13, rchandia wrote:
http://gwt-code-reviews.appspot.com/1299801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9610
Author: gwt.mirror...@gmail.com
Date: Tue Jan 25 11:30:28 2011
Log: Adding jscpucfg.h for the windows build
http://code.google.com/p/google-web-toolkit/source/detail?r=9610
Added:
/plugin-sdks/gecko-sdks/gecko-2.0.0/WINNT_x86-msvc/include/jscpucfg.h
http://gwt-code-reviews.appspot.com/1310801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: conroy, tobyr,
Description:
Add SSL support to DevMode.
Issue: 1806
Patch by: jat
Review by: conroy, tobyr
Please review this at http://gwt-code-reviews.appspot.com/1324801/show
Affected files:
A dev/core/src/com/google/gwt/core/ext/SecureServletContainerLauncher.java
M
Reviewers: rjrjr,
Description:
Fixing a bug in DynaTableRf where multiple stale responses can push data
into the CellTable, creating an infinite loop where each stale response
changes the table range, triggering another request. Also abstracting
the ImageButtons used in SimplePager, and fixing
LGTM, nits.
Once the JSONP stuff is shown to work in production, can you swing back
around and remove the XHR?
http://gwt-code-reviews.appspot.com/1310801/diff/24001/25002
File user/src/com/google/gwt/jsonp/client/JsonpRequest.java (right):
http://gwt-code-reviews.appspot.com/1310801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1310801/diff/24001/25002
File user/src/com/google/gwt/jsonp/client/JsonpRequest.java (right):
http://gwt-code-reviews.appspot.com/1310801/diff/24001/25002#newcode39
user/src/com/google/gwt/jsonp/client/JsonpRequest.java:39:
On 2011/01/25 19:49:32, bobv wrote:
LGTM
Nice cleanup.
http://gwt-code-reviews.appspot.com/1325801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1310801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9611
Author: rchan...@google.com
Date: Tue Jan 25 08:46:02 2011
Log: Cherry picking r9609 into releases/2.2
http://code.google.com/p/google-web-toolkit/source/detail?r=9611
Added:
Revision: 9612
Author: p...@google.com
Date: Tue Jan 25 08:49:05 2011
Log: Cherry picking r9602 into releases/2.2
http://code.google.com/p/google-web-toolkit/source/detail?r=9612
Added:
/releases/2.2/user/src/com/google/gwt/dom/client/PartialSupport.java
Deleted:
Revision: 9614
Author: gwt.mirror...@gmail.com
Date: Tue Jan 25 09:52:49 2011
Log: Fixing a bug in DynaTableRf where multiple stale responses can push
data into the CellTable, creating an infinite loop where each stale
response changes the table range, triggering another request. Also
http://gwt-code-reviews.appspot.com/1310801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
committed as r9614
http://gwt-code-reviews.appspot.com/1325801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1324801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rchandia,
Description:
Fixing a bug in CellBrowser where the user must click on an element
twice to focus on it and enable keyboard support. The problem is that
Element.getTabIndex() returns 0 for non-focusable divs, which causes us
to assume that the div is focusable. Other
LGTM + readme nits
http://gwt-code-reviews.appspot.com/1324801/diff/17001/18007
File dev/core/src/com/google/gwt/dev/shell/jetty/README-SSL.txt (right):
http://gwt-code-reviews.appspot.com/1324801/diff/17001/18007#newcode17
dev/core/src/com/google/gwt/dev/shell/jetty/README-SSL.txt:17: -server
Revision: 9615
Author: ncha...@google.com
Date: Tue Jan 25 11:20:03 2011
Log: If some unrecoverable failure happens during validation, a
ValidationException is raised.
[JSR 303 TCK Result] 66 of 257 (25.68%) Pass with 25 Failures and 3 Errors.
Review at
http://gwt-code-reviews.appspot.com/1324801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1320801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1320801/diff/3001/4005
File user/src/com/google/gwt/autobean/rebind/model/JBeanMethod.java
(right):
http://gwt-code-reviews.appspot.com/1320801/diff/3001/4005#newcode30
user/src/com/google/gwt/autobean/rebind/model/JBeanMethod.java:30:
public enum JBeanMethod
LGTM
One more nit, your call, no need for re-review.
http://gwt-code-reviews.appspot.com/1320801/diff/10001/11023
File
user/src/com/google/gwt/requestfactory/rebind/model/RequestFactoryModel.java
(right):
http://gwt-code-reviews.appspot.com/1320801/diff/10001/11023#newcode240
LGTM
http://gwt-code-reviews.appspot.com/1327801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9616
Author: con...@google.com
Date: Tue Jan 25 12:47:44 2011
Log: In the LoadModuleMessage, send the application supplied URL rather
than the plugin's view of the URL.
This fixes the devmode tab title to display 'NewWebApp' or equivalent
instead of 'hosted'.
http://gwt-code-reviews.appspot.com/1324801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9618
Author: j...@google.com
Date: Tue Jan 25 13:08:09 2011
Log: Fix missing line in Javadoc.
Issue: 5615
Suggested by: xerces9
Patch by: jat
Review by: conroy
http://code.google.com/p/google-web-toolkit/source/detail?r=9618
Modified:
LGTM given changes to ServletContainerLaunch and removal of
SecureServletContainerLauncher.
http://gwt-code-reviews.appspot.com/1324801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1326801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rchandia,
Description:
Add more TCK tests
[JSR 303 TCK Result] 90 of 257 (35.02%) Pass with 29 Failures and 12
Errors.
Please review this at http://gwt-code-reviews.appspot.com/1298802/show
Affected files:
M user/test/com/google/gwt/validation/tck/MetadataGwtSuite.java
M
http://gwt-code-reviews.appspot.com/1298802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
56 matches
Mail list logo
