Reviewers: bobv,
Message:
We've been running with this patch for 6 weeks or so and it's highly
misleading to have it logged as an error with a full stack-trace.
I'll update the patch to log a warning instead (or maybe only an info?)
and only include the exception's getLocalizedMessage (or
[+scottb, jbrosenberg]
Jason or Scott, can you take a look at this? You have been working in
this area more recently than I.
Please review this at http://gwt-code-reviews.appspot.com/1357804/
--
Bob Vawter
Google Web Toolkit Team
--
Revision: 9925
Author: jlaba...@google.com
Date: Fri Apr 1 04:44:18 2011
Log: Adding table rendering tests to micro benchmarks. Table rendering
tests are multiple orders of magnitude slower than the existing basic
tests, so I seperated them into a seperate mirco benchmark. I
+zundel
Adding in Eric also...
Jason
On Fri, Apr 1, 2011 at 11:11 AM, BobV b...@google.com wrote:
[+scottb, jbrosenberg]
Jason or Scott, can you take a look at this? You have been working in
this area more recently than I.
Please review this at
I replaced patch set 4 by having the default fetching of
CompilationState log errors like it always has. In terms of number of
call sites, suppressing errors is in the minority, thus less code churn.
http://gwt-code-reviews.appspot.com/1385810/
--
http://gwt-code-reviews.appspot.com/1385810/diff/4002/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
File
dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
(right):
We want to be able to experiment with non-GWT clients of web services,
particularly via RequestFactory. But I have to put emphasis on the word
experiment. Non-GWT won't be a supported path soon, if ever.
On Thu, Mar 31, 2011 at 8:06 AM, Andrés Testi andres.a.te...@gmail.comwrote:
Why bindery
We want to be able to experiment with non-GWT clients of web services,
particularly via RequestFactory. But I have to put emphasis on the word
experiment. Non-GWT won't be a supported path soon, if ever.
Is it worth moving packages at the current time then? You could tease
out a non-GWT jar
I don't think Andrés was asking why they weren't in the gwt package. He's
sking why they are in the com.google.web package if they are usable outside
of the web domain. It seems like we are moving from a very limited package
scope to a slightly less limited package scope.
I'm sure you've
On Fri, Apr 1, 2011 at 11:16 AM, John LaBanca jlaba...@google.com wrote:
On Fri, Apr 1, 2011 at 2:13 PM, Ray Ryan rj...@google.com wrote:
On Fri, Apr 1, 2011 at 10:38 AM, John LaBanca jlaba...@google.comwrote:
I don't think Andrés was asking why they weren't in the gwt package.
He's
On Fri, Apr 1, 2011 at 10:38 AM, John LaBanca jlaba...@google.com wrote:
I don't think Andrés was asking why they weren't in the gwt package. He's
sking why they are in the com.google.web package if they are usable outside
of the web domain. It seems like we are moving from a very limited
On Fri, Apr 1, 2011 at 2:13 PM, Ray Ryan rj...@google.com wrote:
On Fri, Apr 1, 2011 at 10:38 AM, John LaBanca jlaba...@google.com wrote:
I don't think Andrés was asking why they weren't in the gwt package. He's
sking why they are in the com.google.web package if they are usable outside
ping
On Thu, Mar 31, 2011 at 1:41 PM, rj...@google.com wrote:
Reviewers: fabbott,
Description:
Adds a no-op emulation of TestSuite, to prevent error spam (or outright
failure under -strict mode) in web mode tests that accidentally pick
the things up in their class path.
Please review
LGTM with nits about which comments are helpful.
http://gwt-code-reviews.appspot.com/1399803/diff/1/user/super/com/google/gwt/junit/translatable/junit/framework/TestSuite.java
File
user/super/com/google/gwt/junit/translatable/junit/framework/TestSuite.java
(right):
You're reading web to mean HTML. I'm reading it as app that talks to a
web service, regardless of what it's written in.
I really like the GWT event model and want to use it in Guice
applications to raise bussiness rules, dispatch entity lifecycle
events, etc.. I think this events API is useful
Revision: 9926
Author: skybr...@google.com
Date: Fri Apr 1 09:08:51 2011
Log: Fix checkstyle error
Review by: p...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9926
Modified:
http://gwt-code-reviews.appspot.com/1394803/diff/1/user/src/com/google/gwt/activity/shared/Activity.java
File user/src/com/google/gwt/activity/shared/Activity.java (right):
http://gwt-code-reviews.appspot.com/1394803/diff/1/user/src/com/google/gwt/activity/shared/Activity.java#newcode19
Revision: 9927
Author: sbruba...@google.com
Date: Fri Apr 1 10:25:12 2011
Log: Image Resource Test for UiBinderTest
Review at http://gwt-code-reviews.appspot.com/1380804
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9927
Modified:
Revision: 9928
Author: akito.noz...@gmail.com
Date: Fri Apr 1 10:39:59 2011
Log: Plug memory leak in ResettableEventBus, fix for
http://code.google.com/p/google-web-toolkit/issues/detail?id=5700
Review by rjrjr at http://gwt-code-reviews.appspot.com/1388804/
Review by:
LGTM once the comments below are addressed.
http://gwt-code-reviews.appspot.com/1386803/diff/3007/user/test/com/google/gwt/uibinder/test/client/ClassLookupTest.ui.xml
File
user/test/com/google/gwt/uibinder/test/client/ClassLookupTest.ui.xml
(right):
http://gwt-code-reviews.appspot.com/1399803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1399803/diff/1/user/super/com/google/gwt/junit/translatable/junit/framework/TestSuite.java
File
user/super/com/google/gwt/junit/translatable/junit/framework/TestSuite.java
(right):
LGTM, now without nits.
http://gwt-code-reviews.appspot.com/1399803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9929
Author: scheg...@google.com
Date: Fri Apr 1 11:16:55 2011
Log: Cherry picking r1382801 into releases/2.3
http://code.google.com/p/google-web-toolkit/source/detail?r=9929
Added:
/releases/2.3/dev/core/test/com/google/gwt/dev/resource/impl/ResourceTests.java
My question on this is, why does the Editor create such long filenames?
Could we address that in the Editor generator? If you turn on -gen, you
want to see files and even after this patch, you won't have a way to get
them.
On 2011/04/01 15:35:12, jbrosenberg wrote:
+zundel
Adding in Eric
Revision: 9931
Author: fabio...@google.com
Date: Fri Apr 1 11:46:10 2011
Log: cherry picking r9894 for GWT 2.3m1
http://code.google.com/p/google-web-toolkit/source/detail?r=9931
Modified:
/releases/2.3/user/src/com/google/gwt/user/client/ui/impl/RichTextAreaImplIE6.java
Reviewers: jbrosenberg,
Description:
An empty for statement can generate an ICE.
for (Integer xyzzy : new ArrayListInteger())
; // TODO
Please review this at http://gwt-code-reviews.appspot.com/1400801/
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
Note that AutoBeanUtils uses WeakMapping which lives in
com.google.gwt.core.client (yes, this is a client class used in shared,
and thus server code; WeakMapping is also directly referenced through
server code, namely in ProxyAutoBean)
--
On 2011/04/01 21:31:53, zundel wrote:
My question on this is, why does the Editor create such long
filenames? Could
we address that in the Editor generator? If you turn on -gen, you
want to see
files and even after this patch, you won't have a way to get them.
I agree that a proper fix
LGTM
http://gwt-code-reviews.appspot.com/1400801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9932
Author: sco...@google.com
Date: Fri Apr 1 12:57:25 2011
Log: Fix ICE in GenerateJavaAST
An empty for statement can generate an ICE.
for (Integer xyzzy : new ArrayListInteger())
; // TODO
http://gwt-code-reviews.appspot.com/1400801/
Review by: zun...@google.com
http://gwt-code-reviews.appspot.com/1385810/diff/4002/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
File
dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
(right):
Sorry, it took me some time but I went read the StreamHtmlParser code to
better understand how it works, and how it's used here in the generator.
I thus found that there's a special-case for meta refresh that this
patch doesn't handle (see comments below), and that the ATTR_TYPE.URI is
based on
On 2011/04/01 21:31:53, zundel wrote:
My question on this is, why does the Editor create such long
filenames?
Have a look at
http://code.google.com/p/google-web-toolkit/issues/detail?id=6016 which
calls for even longer names (that's how the patch at
http://gwt-code-reviews.appspot.com/1352806
Reviewers: rchandia,
Description:
Handle more literal types for anntation values, including Enums.
Please review this at http://gwt-code-reviews.appspot.com/1401801/
Affected files:
M
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
M
LGTM w/ nits. No need to re-review.
http://gwt-code-reviews.appspot.com/1385810/diff/18035/dev/core/src/com/google/gwt/dev/javac/Dependencies.java
File dev/core/src/com/google/gwt/dev/javac/Dependencies.java (right):
Reviewers: jlabanca, sbrubaker,
Description:
Issues 6206 and 6216: CellWidget's getValue is never updated by the Cell
Issue 6206: CellWidget should be IsEditorTakesValueEditorC
http://code.google.com/p/google-web-toolkit/issues/detail?id=6206
I made it a IsEditorLeafValueEditorC instead (backed
Reviewers: rjrjr, bobv,
Description:
Issue 6193: Fix memory-leak in WeakMapping when the value holds a
reference on the key
http://code.google.com/p/google-web-toolkit/issues/detail?id=6193
Fix memory-leak in WeakMapping when the value holds a reference on the
key, which prevents the entry
@Bob, Could we just generate a strong name seeded from the fully
parameterized type name instead to solve both issues?
If this is going to have a good chance of affecting generators other
than the Editor Framework, I think we should make the file creation
non-fatal.
On Fri, Apr 1, 2011 at 8:00
39 matches
Mail list logo
