LGTM once the comments below are addressed.
http://gwt-code-reviews.appspot.com/1386803/diff/3007/user/test/com/google/gwt/uibinder/test/client/ClassLookupTest.ui.xml File user/test/com/google/gwt/uibinder/test/client/ClassLookupTest.ui.xml (right): http://gwt-code-reviews.appspot.com/1386803/diff/3007/user/test/com/google/gwt/uibinder/test/client/ClassLookupTest.ui.xml#newcode12 user/test/com/google/gwt/uibinder/test/client/ClassLookupTest.ui.xml:12: Please add the following to WidgetBasedUi.ui.xml: In the ui:UiBinder tag xmlns:gwt2='urn:import:com.google.gwt.user.client' xmlns:gwt3='urn:import:com' Update the end of the XML to use the new functionality: <gwt2:ui.NumberLabel ui:field='myNumberLabel2' format='{MY_NUMBER_FORMAT}' /> <gwt3:google.gwt.user.client.ui.ValueLabel ui:field='myValueLabel' renderer='{doubleRenderer}' /> You should then be able to remove ClassLookupTest.ui.xml. http://gwt-code-reviews.appspot.com/1386803/diff/3007/user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java File user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java (right): http://gwt-code-reviews.appspot.com/1386803/diff/3007/user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java#newcode636 user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java:636: } Shouldn't need to modify UiBinderTest.java if you move your ui declaration into WidgetBasedUi.ui.xml. The existing test coverage will test the new functionality, so after you make that update please test via the GWT SQ and you'll be good to go. http://gwt-code-reviews.appspot.com/1386803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
