There's no expected net change in behavior, it's just code cleanup.
http://gwt-code-reviews.appspot.com/1436801/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
(right):
http://gwt-code-reviews
On Sat, May 7, 2011 at 6:12 PM, Kenneth Jorgensen wrote:
> I've been writing a cryptographic library for GWT (available at
> https://bitbucket.org/kennethjor/tovikov) and I ran into a few strange
> problems when dealing with integers. I will not be able to post code
> to reproduce the errors, simp
http://gwt-code-reviews.appspot.com/1436801/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
(right):
http://gwt-code-reviews.appspot.com/1436801/diff/2001/dev/core/src/com/google/gwt/dev/jjs/im
I'm almost ready to sign off on this (things do look cleaner and more
concise).
But I'm not sure, is there a net effect here, other than code
cleanup/refactoring? What's the expected change/improvement?
Is tracking of overrides being removed from soyc?
http://gwt-code-reviews.appspot.com/1436801
Cool beans.
On Mon, May 16, 2011 at 8:14 PM, Ray Cromwell wrote:
> I've done a quick scan of this and it looks ok, but I'd like to take
> some time tonight to review it in more detail. I like the
> 'membersLiveExceptForInstantiability' change, I was going the suggest
> something like that when I
Thanks, Jason.
http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java
(right):
http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/C
http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java
(right):
http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.ja
I've done a quick scan of this and it looks ok, but I'd like to take
some time tonight to review it in more detail. I like the
'membersLiveExceptForInstantiability' change, I was going the suggest
something like that when I was doing the JSO CFA overhaul last time.
Also the checks in Pruner are sim
http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java
File
dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java
(left):
http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/i
LGTM
http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java
File
dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java
(left):
http://gwt-code-reviews.appspot.com/1449801/diff/1/dev/core/src/com/google/gwt/de
Comment by javierfe...@gmail.com:
I meant if validation works if the bean to validate is an overlay type that
extends JavaScriptObject:
public class MyClass extends JavaScriptObject {
@Size(min=10)
public final native String getTitle() /*-{
return this["title"];
}-*/;
}
On May 16, 2011 11:06 AM, "BobV" wrote:
>
> On Sun, May 8, 2011 at 10:08 AM, Patrick Julien wrote:
> > Here is what I am planning to do to fix issue 6068
> >
> > http://code.google.com/p/google-web-toolkit/issues/detail?id=6068
> >
> > 1. Add to BeanMethod.java (package
> > com.google.web.bindery
I'm developing an expandable row for our website and it's an ugly mix
of the celltable functionality and HMTL modifications ...
I managed to make the expansion work with content showing/hiding but
the columns don't line-up properly and I can't figure out how to
display asynchronous content in the e
Hi,
I've been writing a cryptographic library for GWT (available at
https://bitbucket.org/kennethjor/tovikov) and I ran into a few strange
problems when dealing with integers. I will not be able to post code
to reproduce the errors, simply because I wasn't able to do it with
stand-alone code, yet
http://gwt-code-reviews.appspot.com/1442804/diff/7001/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):
http://gwt-code-reviews.appspot.com/1442804/diff/7001/user/src/com/google/gwt/uibinder/rebind/Abst
Reviewers: fabbott,
Description:
Adds support for Beans.isDesignTime() for better support in GWT
Designer.
Please review this at http://gwt-code-reviews.appspot.com/1443802/
Affected files:
A user/super/com/google/gwt/emul/java/beans/Beans.java
Index: user/super/com/google/gwt/emul/java/be
Revision: 10188
Author: jlaba...@google.com
Date: Mon May 16 08:38:11 2011
Log: SelectionChangeEvent currently is tightly coupled with
SelectionModel. There is no way to fire a SelectionChangeEvent outside of
something that implements SelectionModel. This patch fixes that and resuse
Revision: 10187
Author: scheg...@google.com
Date: Mon May 16 05:56:39 2011
Log: Prepares SAXParserFactory one time, so avoids expensive
ClassLoader lokups.
Review at http://gwt-code-reviews.appspot.com/1442806
Review by: sco...@google.com
http://code.google.com/p/google-web-toolkit
Revision: 10186
Author: zun...@google.com
Date: Sat May 14 03:39:11 2011
Log: This change works around a problem found in GWT Designer testing.
The compilation unit rescue was really only intended for old cached
compilation units, not files that change after you first start running t
Revision: 10185
Author: rj...@google.com
Date: Fri May 13 12:07:34 2011
Log: First example of a View that kicks off its own presenter as
needed. Part way toward separating presenters from activities, and
making all views self inject their presenters. When we're done, we'll
have proper
On 2011/05/16 14:00:37, jlabanca wrote:
LGTM if it works. I thought I tried this and it didn't work, or only
worked in
dev mode but not when deployed.
You are right it only works for DevMode. More thinking needed.
http://gwt-code-reviews.appspot.com/1447805/
--
http://groups.google.com/gro
Comment by ncha...@google.com:
Javier
* Does bean validation works if beans are JavaScriptObject?
It should at least in the since of
MyClass {
@MyConstraint
JavaScritObject myField
}
For more information:
http://code.google.com/p/google-web-toolkit/wiki/BeanValidation
--
http://groups.goog
LGTM
http://gwt-code-reviews.appspot.com/1442806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Sun, May 8, 2011 at 10:08 AM, Patrick Julien wrote:
> Here is what I am planning to do to fix issue 6068
>
> http://code.google.com/p/google-web-toolkit/issues/detail?id=6068
>
> 1. Add to BeanMethod.java (package
> com.google.web.bindery.autobean.vm.impl;) an TO_ARRAY value
>
> 2. Add to JBean
Comment by javierfe...@gmail.com:
Does bean validation works if beans are JavaScriptObject?
For more information:
http://code.google.com/p/google-web-toolkit/wiki/BeanValidation
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: scottb,
Description:
Prepares SAXParserFactory one time, so avoids expensive ClassLoader
lokups.
Please review this at http://gwt-code-reviews.appspot.com/1442806/
Affected files:
M dev/core/src/com/google/gwt/dev/util/xml/ReflectiveParser.java
Index: dev/core/src/com/google/gwt
LGTM if it works. I thought I tried this and it didn't work, or only
worked in dev mode but not when deployed.
http://gwt-code-reviews.appspot.com/1447805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
27 matches
Mail list logo
