http://gwt-code-reviews.appspot.com/1465803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/06/19 18:17:05, rdcastro wrote:
LGTM
http://gwt-code-reviews.appspot.com/1463804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Frank, tobyr,
Description:
Disabling test for null on getBrowserById for DOM elements without DTD
when running on Chrome 11 and beyond
Please review this at http://gwt-code-reviews.appspot.com/1462805/
Affected files:
M user/test/com/google/gwt/xml/client/XMLTest.java
Index:
Clicked through @googledevtools' tweet and found this nit reading the
javadoc.
http://gwt-code-reviews.appspot.com/1451818/diff/5001/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
Reviewers: dconnelly,
Description:
Fixing a bug in CellTree where refreshing an empty list of children
causes an AssertionError that is not captured by the console.
CellTreeNodeView#loadChildState() accesses the first child element of
the current node in preparation of a loop, but we didn't
Revision: 10352
Author: gwt.mirror...@gmail.com
Date: Mon Jun 20 08:50:41 2011
Log: Finalizing IsRenderable API step 1: renaming wrapElement() and
performDetachedInitialization().
Review at http://gwt-code-reviews.appspot.com/1463804
Review by: rchan...@google.com
Hi,
It appears there is a typo in the
com.google.gwt.mobile.client.Scroller on line 399 which breaks
horizontal scrolling:
http://code.google.com/p/google-web-toolkit/source/browse/trunk/samples/expenses/src/main/java/com/google/gwt/mobile/client/Scroller.java#399
private boolean
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1451818/diff/5001/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
http://gwt-code-reviews.appspot.com/1454808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1454808/diff/4001/user/src/com/google/gwt/safecss/shared/SafeStylesBuilder.java
File user/src/com/google/gwt/safecss/shared/SafeStylesBuilder.java
(right):
LGTM
http://gwt-code-reviews.appspot.com/1463805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jlabanca,
Description:
Use the provided key in all decisions about whether the selections have
changed.
Review by: jlaba...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1465802/
Affected files:
M user/src/com/google/gwt/view/client/MultiSelectionModel.java
Hey there,
to be able to individually set stylenames for cells in a CellTable I
would like to add the following method to the CellTable class:
public void setCellStyles(CellStylesT cellStyles) {
this.cellStyles = cellStyles;
}
The interface CellStyles only defines a single
On Monday, June 20, 2011 5:29:03 PM UTC+2, ag0ny wrote:
Hey there,
to be able to individually set stylenames for cells in a CellTable
Too late ;-)
http://code.google.com/p/google-web-toolkit/source/detail?r=10309
What is the process to get this added in the common GWT.
See
http://gwt-code-reviews.appspot.com/1465803/diff/8/build-tools/customchecks/src/com/google/gwt/checkstyle/GwtHeaderCheck.java
File
build-tools/customchecks/src/com/google/gwt/checkstyle/GwtHeaderCheck.java
(right):
On 2011/06/19 08:22:56, stephenh wrote:
http://gwt-code-reviews.appspot.com/1466802/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
File
dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
(left):
LGTM
http://gwt-code-reviews.appspot.com/1461801/diff/4007/dev/core/src/com/google/gwt/dev/ArchivePreloader.java
File dev/core/src/com/google/gwt/dev/ArchivePreloader.java (right):
LGTM
http://gwt-code-reviews.appspot.com/1462805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1454808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks for the review! Looks like we might get this to land once and for
all :)
http://gwt-code-reviews.appspot.com/1465803/diff/8/build-tools/customchecks/src/com/google/gwt/checkstyle/GwtHeaderCheck.java
File
build-tools/customchecks/src/com/google/gwt/checkstyle/GwtHeaderCheck.java
(right):
Reviewers: tilmansp_google.com,
Description:
Fixing a bug in CellTree where pushing new data that renders to the same
content results in an invalid state where child are still attached to a
stale parent. For example, consider a tree contains IDs that represent
objects, but renders the ID using
LGTM,
just show me in principle it isn't much work moving to checkstyle 5
http://gwt-code-reviews.appspot.com/1465803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1451818/diff/5001/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
http://gwt-code-reviews.appspot.com/1451818/diff/8002/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
Committed in r10350
http://gwt-code-reviews.appspot.com/1466801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Follow up to r10350. Allow collapse-all-properties in .gwt.xml module
files
Fixes issues: 5694
Please review this at http://gwt-code-reviews.appspot.com/1463806/
Affected files:
M distro-source/core/src/gwt-module.dtd
Index:
Reviewers: tobyr,
Description:
Add a new 'SERVER' level to TreeLogger, which is to be used by the App
Engine
DevAppServer to log all server messages to the GWT TreeLogger,
regardless
of the current GWT log_level.
Issues: http://code.google.com/p/googleappengine/issues/detail?id=4591
Review by:
http://gwt-code-reviews.appspot.com/1451818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Updated patch with suggestions.
http://gwt-code-reviews.appspot.com/1451818/diff/5001/user/src/com/google/gwt/core/client/ScriptInjector.java
File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
Reviewers: aizatsky, scottb, zundel,
Description:
Don't allow DataflowOptimizer to perform constant transformation on
expressions with side-effects.
Please review this at http://gwt-code-reviews.appspot.com/1467801/
Affected files:
M
http://gwt-code-reviews.appspot.com/1461801/diff/4007/dev/core/src/com/google/gwt/dev/ArchivePreloader.java
File dev/core/src/com/google/gwt/dev/ArchivePreloader.java (right):
http://gwt-code-reviews.appspot.com/1461801/diff/4007/dev/core/src/com/google/gwt/dev/ArchivePreloader.java#newcode59
http://gwt-code-reviews.appspot.com/1464802/diff/2002/user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java
File user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java (right):
Revision: 10353
Author: jlaba...@google.com
Date: Mon Jun 20 07:33:26 2011
Log: Fixing a bug in CellTree where refreshing an empty list of
children causes an AssertionError that is not captured by the console.
CellTreeNodeView#loadChildState() accesses the first child element of
Revision: 10354
Author: rchan...@google.com
Date: Mon Jun 20 09:21:01 2011
Log: Disabling test for null on getBrowserById for DOM elements
without DTD when running on Chrome 11 and beyond
Review at http://gwt-code-reviews.appspot.com/1462805
Revision: 10355
Author: zun...@google.com
Date: Mon Jun 20 09:36:25 2011
Log: Turns on reading from archives by default.
Adds an optimization to CompileModule to not load multiple files.
Lowers the priority of some error messages so they don't fill
the screen with useless output when
36 matches
Mail list logo
