On 2011/09/14 17:45:17, zhuyi wrote:
Ray, John and others:
I and Stephen have been working on this for a while to make the option
of
serializing final fields in RPC be a non-static variable to eliminate
flakiness,
and pass this option to server side by serialization policy file.
Please
http://gwt-code-reviews.appspot.com/1380807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1380807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Ray, John and others:
I and Stephen have been working on this for a while to make the option
of serializing final fields in RPC be a non-static variable to eliminate
flakiness, and pass this option to server side by serialization policy
file. Please let us know if the change is in good shape and
http://gwt-code-reviews.appspot.com/1380807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/09/07 18:00:10, zhuyi wrote:
I test this through the entire test suite. It still broke one case
(testEnumArray):
http://code.google.com/p/google-web-toolkit/source/browse/trunk/user/test/com/google/gwt/user/client/rpc/CollectionsTest.java?r=8394#268
It seems that something
http://gwt-code-reviews.appspot.com/1380807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1380807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1380807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/09/03 01:04:50, zhuyi wrote:
Integrated Stephen's change on SerializationPolicy. Individual test
cases works fine, but test cases were broken when they were put together
(e.g. run RPCSuite.java). That is caused by the caches in
SerializabilityUtil.java. I've temporary disabled two caches
http://gwt-code-reviews.appspot.com/1380807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1380807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/09/01 00:10:12, zhuyi wrote:
Hi Stephen,
I've integrated your changes, also synced the changes. Sorry for the
delay. Could you please review it?
Thanks.
Yi
http://gwt-code-reviews.appspot.com/1380807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/07/06 14:05:05, stephenh wrote:
That would be great. Could you please upload the patch? Thanks!
Sure--I can't upload a new patchset to this issue because I'm not the
owner. Is
it possible to add me? Or would you prefer for me to create a new
issue?
Could you please create a new
On 2011/07/06 06:22:38, stephenh wrote:
According to the current code structure, if we want to make the
variable non-static, we may need to pass the propertyOracle
parameter to many
methods
I downloaded the patch and was able to kill the flaky static
variable by
changing various
On 2011/07/06 13:51:57, zhuyi wrote:
On 2011/07/06 06:22:38, stephenh wrote:
According to the current code structure, if we want to make the
variable non-static, we may need to pass the propertyOracle
parameter to
many
methods
I downloaded the patch and was able to kill the flaky
On 2011/07/05 19:51:52, stephenh wrote:
Is this going to be submitted? Sounds like everything was fine, except
for
changing the test object back to IsSerializable?
Hi Bob and Ray,
Any comments about my response below?
I don't have the full context, but adding flakiness is not a good
I don't have the full context, but adding flakiness is not a good
idea.
According to the current code structure, if we want to make the variable
non-static, we may need to pass the propertyOracle parameter to many
methods, because shouldConsiderFieldsForSerialization method in
http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/src/com/google/gwt/user/rebind/rpc/Shared.java
File user/src/com/google/gwt/user/rebind/rpc/Shared.java (right):
http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/src/com/google/gwt/user/rebind/rpc/Shared.java#newcode56
http://gwt-code-reviews.appspot.com/1380807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1380807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1380807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1380807/diff/1001/user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java
File user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java
(right):
Reviewers: scottb, mmendez,
Description:
Issue 5582
Please review this at http://gwt-code-reviews.appspot.com/1257801/show
Affected files:
M user/src/com/google/gwt/user/rebind/rpc/TypeConstrainer.java
A user/test/com/google/gwt/rpc/client/RpcRecursiveClassTest.java
M
Reviewers: jlabanca,
Description:
A patch for clientHeight returns 0 on FF36 on Win XP
Please review this at http://gwt-code-reviews.appspot.com/891801/show
Affected files:
M dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java
M user/src/com/google/gwt/dom/client/Document.java
M
Please ignore the change in ModuleSpace.java. I forgot to clean the
previous change.
http://gwt-code-reviews.appspot.com/891801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2010/09/15 18:44:44, zhuyi wrote:
I have tried to separated these two cases and give different error
messages
http://gwt-code-reviews.appspot.com/876801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/876801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/876801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Changed the code according to Scott's comments
http://gwt-code-reviews.appspot.com/876801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/876801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rice,
Description:
Fix bug 2822942 Remove calls to System.currentTimeMillis in tests
Review by: r...@google.com
Please review this at http://gwt-code-reviews.appspot.com/849801/show
Affected files:
M user/test/com/google/gwt/emultest/java/sql/SqlDateTest.java
M
32 matches
Mail list logo
