http://gwt-code-reviews.appspot.com/1727803/diff/4003/user/src/com/google/gwt/resources/css/RtlVisitor.java
File user/src/com/google/gwt/resources/css/RtlVisitor.java (right):
http://gwt-code-reviews.appspot.com/1727803/diff/4003/user/src/com/google/gwt/resources/css/RtlVisitor.java#newcode46
LGTM
http://gwt-code-reviews.appspot.com/1727803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
This is ready for re-review, BTW.
http://gwt-code-reviews.appspot.com/1727803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/06/07 07:39:38, ehwang wrote:
Thanks for the review!
For the vendor prefixes, I ended up creating a separate helper class,
VendorPrefixes. It doesn't keep a master list of prefixes. I decided
that was
more future-proof, and the -foo- syntax is specifically reserved by
the W3C
for
http://gwt-code-reviews.appspot.com/1727803/diff/1/user/src/com/google/gwt/resources/css/RtlVisitor.java
File user/src/com/google/gwt/resources/css/RtlVisitor.java (right):
http://gwt-code-reviews.appspot.com/1727803/diff/1/user/src/com/google/gwt/resources/css/RtlVisitor.java#newcode370
Thanks for the review!
For the vendor prefixes, I ended up creating a separate helper class,
VendorPrefixes. It doesn't keep a master list of prefixes. I decided
that was more future-proof, and the -foo- syntax is specifically
reserved by the W3C for vendor prefixes:
http://gwt-code-reviews.appspot.com/1727803/diff/1/user/src/com/google/gwt/resources/css/RtlVisitor.java
File user/src/com/google/gwt/resources/css/RtlVisitor.java (right):
http://gwt-code-reviews.appspot.com/1727803/diff/1/user/src/com/google/gwt/resources/css/RtlVisitor.java#newcode43
