LGTM too. I'll repost and submit this with a test.
http://gwt-code-reviews.appspot.com/1604803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM too. I'll repost and submit this with a test.
http://gwt-code-reviews.appspot.com/1604803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM too. I'll repost and submit this with a test.
http://gwt-code-reviews.appspot.com/1604803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
See http://gwt-code-reviews.appspot.com/1602805
http://gwt-code-reviews.appspot.com/1604803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1604803/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):
I'm afraid that won't work as expected if ownerField actually is a
getter
(getterCount 1).
I like your suggested change, but can you elaborate on this? I thought
getterCount only affected whether the Widgets class gets a field, and
that for provided=true purposes, the ownerField really is
On 2011/11/29 15:23:20, stephenh wrote:
I'm afraid that won't work as expected if ownerField actually is a
getter
(getterCount 1).
I like your suggested change, but can you elaborate on this? I thought
getterCount only affected whether the Widgets class gets a field,
You're right. I
should !designTime.isDesignTime() be added to the test?
Dunno, good question; I added Konstantin as a reviewer.
Konstantin, do you think the assertion in this patch should be skipped
during design time (the assertion is supposed to warn the user when
they've marked fields as provided=true but
On 2011/11/29 20:47:56, stephenh wrote:
should !designTime.isDesignTime() be added to the test?
Dunno, good question; I added Konstantin as a reviewer.
Konstantin, do you think the assertion in this patch should be skipped
during
design time (the assertion is supposed to warn the user
