Overall, looks good. Thanks for the patch Fred. Minor refactoring
suggestions below.
Instead of making checkContentType and checkCharacterEncoding public and
deprecated, would it be better to add another option of
expectedContentType to readContentAsUtf8, and just do everything there?
(the
http://gwt-code-reviews.appspot.com/674804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
How's this?
http://gwt-code-reviews.appspot.com/674804
On Mon, Aug 2, 2010 at 5:46 PM, fre...@google.com wrote:
http://gwt-code-reviews.appspot.com/674804/show
--
Fred Sauer
Developer Advocate
Google Inc.
1600 Amphitheatre Parkway
Mountain View, CA 94043
fre...@google.com
--
I like the refactoring. Some more nits below. Please feel free to submit
after fixing them. LGTM
http://gwt-code-reviews.appspot.com/674804/diff/9001/10002
File
user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java
(right):
http://gwt-code-reviews.appspot.com/674804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/674804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/674804/diff/9001/10002
File
user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java
(right):
http://gwt-code-reviews.appspot.com/674804/diff/9001/10002#newcode96
http://gwt-code-reviews.appspot.com/674804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/674804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
