LGTM
http://gwt-code-reviews.appspot.com/1373805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Updated patch which includes a new test. Pre-seeded with some
explanation.
http://gwt-code-reviews.appspot.com/1373805/diff/9001/dev/core/src/com/google/gwt/dev/CompileModule.java
File dev/core/src/com/google/gwt/dev/CompileModule.java (right):
LGTM, I have no substantive comments, go forth and code some more.
I was asking myself if the stack approach might increase memory
requirements, but the entire tree must already be in memory, so I
stopped worrying about it.
Okay.. so should I submit this? That way, future reviews will be vs.
trunk.
Maybe I should add a basic unit test to make sure that this at least
doesn't crash, and maybe even that the output is the same as the web
mode compiler for some test file.
On Tue, Mar 8, 2011 at 9:36 PM, sco...@google.com wrote:
Okay.. so should I submit this? That way, future reviews will be vs.
trunk.
Maybe I should add a basic unit test to make sure that this at least
doesn't crash, and maybe even that the output is the same as the web
mode compiler for
http://gwt-code-reviews.appspot.com/1373805/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java
File dev/core/src/com/google/gwt/dev/CompileModule.java (right):
http://gwt-code-reviews.appspot.com/1373805/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode2
http://gwt-code-reviews.appspot.com/1373805/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java
File dev/core/src/com/google/gwt/dev/CompileModule.java (right):
http://gwt-code-reviews.appspot.com/1373805/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode2
