OK, I don't get how exit() being private works. If we think about the
scenario where we have child resources to create after we get the
real id from the server, how are we suppose to save those child
resources? Not to mention that I don't really care for showing the
details place in every case.
Same for Abstract list, yeah, providing a default for showDetails is
nice, making it private is not so much
On Tue, Aug 17, 2010 at 12:30 PM, Pascal Patry i...@invalidip.com wrote:
On Tuesday, August 17, 2010 11:50:13 Patrick Julien wrote:
OK, I don't get how exit() being private works. If we
On Tuesday, August 17, 2010 12:34:29 Patrick Julien wrote:
Same for Abstract list, yeah, providing a default for showDetails is
nice, making it private is not so much
That's right... you can always create a new SelectionModel to have
something else than showDetails() that is being called, but
Thanks for all the feedback.
I'm definitely not suggesting that this mechanism is done, it's just a step
along the way. And yes, the hard coded exit points are particularly bad.
Rather than having these activities drive the place controller directly, I'd
like them to emit events like save worked,
RequestFactory issues an event on record change but does it issue an
event on creation?
On Tue, Aug 17, 2010 at 1:04 PM, Ray Ryan rj...@google.com wrote:
Thanks for all the feedback.
I'm definitely not suggesting that this mechanism is done, it's just a step
along the way. And yes, the hard
I don't know what your schedule looks like but before this patch.
This was still pretty usable and it was less expensive to track
changes in head than it was to use GWT 2.0. Now, the abstract
activities are pretty much broken.
I understand, and take responsibility, for using GWT head, but at the
There are a lot of features and schedules driving M3, this is just one. I
can't make a drastic change at this point, and I can't roll the patch back,
but are there a quick fixes I can make to unbreak you? Make exit() public or
protected? Or can you whip up a patch?
On Tue, Aug 17, 2010 at 10:57
On Tue, Aug 17, 2010 at 2:02 PM, Ray Ryan rj...@google.com wrote:
There are a lot of features and schedules driving M3, this is just one. I
can't make a drastic change at this point, and I can't roll the patch back,
but are there a quick fixes I can make to unbreak you? Make exit() public or
On Tue, Aug 17, 2010 at 11:05 AM, Patrick Julien pjul...@gmail.com wrote:
On Tue, Aug 17, 2010 at 2:02 PM, Ray Ryan rj...@google.com wrote:
There are a lot of features and schedules driving M3, this is just one. I
can't make a drastic change at this point, and I can't roll the patch
back,
On Tue, Aug 17, 2010 at 11:09 AM, Ray Ryan rj...@google.com wrote:
On Tue, Aug 17, 2010 at 11:05 AM, Patrick Julien pjul...@gmail.comwrote:
On Tue, Aug 17, 2010 at 2:02 PM, Ray Ryan rj...@google.com wrote:
There are a lot of features and schedules driving M3, this is just one.
I
can't
Why isn't edit.getRecord().getId() enough?
Ah. It doesn't exist. Will add it.
thanks, here are the issues I reported in roo:
ROO-1225 Hard coded exit points for AbstractRecordEditActivity
ROO-1226 Hard coded exit points for AbstractRecordListActivity
ROO-1227 Can't create child resources
http://gwt-code-reviews.appspot.com/771802
On Tue, Aug 17, 2010 at 11:14 AM, Patrick Julien pjul...@gmail.com wrote:
Why isn't edit.getRecord().getId() enough?
Ah. It doesn't exist. Will add it.
thanks, here are the issues I reported in roo:
ROO-1225 Hard coded exit points for
On Tue, Aug 17, 2010 at 3:50 PM, Ray Ryan rj...@google.com wrote:
http://gwt-code-reviews.appspot.com/771802
this would satisfy my current needs
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
r8558
On Tue, Aug 17, 2010 at 12:56 PM, Patrick Julien pjul...@gmail.com wrote:
On Tue, Aug 17, 2010 at 3:50 PM, Ray Ryan rj...@google.com wrote:
http://gwt-code-reviews.appspot.com/771802
this would satisfy my current needs
--
You're right, I didn't notice a record was being passed into the
constructor, just that the id was not longer being passed in.
For create, we would inject everything into the constructor and pass
0L to super.
For create, injection is still possible because we pass in an newly
created record to
On 15 août, 03:38, Patrick Julien pjul...@gmail.com wrote:
I would like to point out that this patch addresses the following issues
http://code.google.com/p/google-web-toolkit/issues/detail?id=5106
http://code.google.com/p/google-web-toolkit/issues/detail?id=5115
It sure addresses issue
On Sun, Aug 15, 2010 at 11:04 AM, Thomas Broyer t.bro...@gmail.com wrote:
On 15 août, 03:38, Patrick Julien pjul...@gmail.com wrote:
I would like to point out that this patch addresses the following issues
http://code.google.com/p/google-web-toolkit/issues/detail?id=5106
On 15 août, 19:47, Patrick Julien pjul...@gmail.com wrote:
On Sun, Aug 15, 2010 at 11:04 AM, Thomas Broyer t.bro...@gmail.com wrote:
On 15 août, 03:38, Patrick Julien pjul...@gmail.com wrote:
I would like to point out that this patch addresses the following issues
I would like to point out that this patch addresses the following issues
http://code.google.com/p/google-web-toolkit/issues/detail?id=5106
http://code.google.com/p/google-web-toolkit/issues/detail?id=5115
On Fri, Aug 13, 2010 at 1:50 PM, rj...@google.com wrote:
Okay, Rayc, this is ready for
Okay, Rayc, this is ready for review.
On 2010/08/13 17:43:18, Ray Ryan wrote:
http://gwt-code-reviews.appspot.com/717801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Nothing has changed in the ui area since John last looked, so we're good
there.
On Fri, Aug 13, 2010 at 2:25 PM, cromwell...@google.com wrote:
On 2010/08/13 17:50:40, Ray Ryan wrote:
Okay, Rayc, this is ready for review.
On 2010/08/13 17:43:18, Ray Ryan wrote:
LGTM, but John might
I only quickly read through the list of added files and some of the
files' content, but I can say I really like it the way it is (with
PlaceTokenizer instead of the static fromToken method described in the
Wave)
There's a nit though, which should be probably fixed rather sooner than
later ;-)
Oui, requeste.
Merci
On Aug 13, 2010 5:38 PM, t.bro...@gmail.com wrote:
I only quickly read through the list of added files and some of the
files' content, but I can say I really like it the way it is (with
PlaceTokenizer instead of the static fromToken method described in the
Wave)
23 matches
Mail list logo
