[gwt-contrib] Re: Isolates the portion of TypeOracleMediator that (issue1188802)

2010-12-15 Thread zundel
This review is dead. See http://gwt-code-reviews.appspot.com/1217801/show http://gwt-code-reviews.appspot.com/1188802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Isolates the portion of TypeOracleMediator that (issue1188802)

2010-12-08 Thread alexander . mitin
You cannot build the TypeOracle using the class bytes using the classpath only, because of the re-rooted resources which have no compiled classes near the source file. So, as part of the GWT Designer I implemented disk caching of the compiled CompilationUnits. The CU caught after compiling and

[gwt-contrib] Re: Isolates the portion of TypeOracleMediator that (issue1188802)

2010-12-07 Thread zundel
On 2010/12/07 13:53:13, alexander.mitin wrote: You cannot build the TypeOracle using the class bytes using the classpath only, because of the re-rooted resources which have no compiled classes near the source file. Good point. I'm using this method of getting byteCode just for the

Re: [gwt-contrib] Re: Isolates the portion of TypeOracleMediator that (issue1188802)

2010-12-07 Thread John Tamplin
On Tue, Dec 7, 2010 at 3:11 PM, zun...@google.com wrote: On 2010/12/07 13:53:13, alexander.mitin wrote: You cannot build the TypeOracle using the class bytes using the classpath only, because of the re-rooted resources which have no compiled classes near the source file. Good point.  

[gwt-contrib] Re: Isolates the portion of TypeOracleMediator that (issue1188802)

2010-12-06 Thread zundel
This change is not all the way ready for review, but I wanted some feedback on the testing portion. The overall aim of this change is to isolate the part of building the type oracle that relies on running the JDT compiler from the part that builds the type oracle from bytecode. The idea is to

[gwt-contrib] Re: Isolates the portion of TypeOracleMediator that (issue1188802)

2010-12-06 Thread zundel
http://gwt-code-reviews.appspot.com/1188802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Isolates the portion of TypeOracleMediator that (issue1188802)

2010-12-06 Thread scottb
Looks like this is heading in a good direction. Idea for the test code. Another high level idea is that you a single test case superclass with the bulk of the code, then you have to two subclasses that only differ in how typeOracle is built. We use this pattern in other places.