@Scott
If you patch this in and follow the arcane directions, you can get the
incremental compile support in blaze.
https://mondrian.corp.google.com/changelist/21809612
-Eric.
On Thu, Jun 9, 2011 at 5:46 PM, cromwell...@google.com wrote:
Overall LGTM. I had to update CFA in my recent CL on
LGTM w/nitlets
http://gwt-code-reviews.appspot.com/1453810/diff/3001/dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java
File dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java (right):
Eric, Ray, did you guys want to weigh in also?
http://gwt-code-reviews.appspot.com/1453810/diff/3001/dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java
File dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java (right):
http://gwt-code-reviews.appspot.com/1453810/diff/3001/dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java
File dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java (right):
http://gwt-code-reviews.appspot.com/1453810/diff/3001/dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java
File dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java (right):
lgtm 2
http://gwt-code-reviews.appspot.com/1453810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Overall LGTM. I had to update CFA in my recent CL on class literal
optimization to treat an invocation of Object.getClass() as rescuing the
class literals of any instantiated types as well as to handle the new
Immortal CodeGenTypes.
We may have to revisit the UnifyAstVisitor, since it may need
General question: I'm curious why this couldn't be simpler, that is, why
does unification depend on control flow? Couldn't you unify everything
without respect to control flow, and then run a pruning pass afterwards
reusing the existing CFA code, or is doing it in an integrated pass an
attempt to
On Wed, Jun 8, 2011 at 8:40 PM, cromwell...@google.com wrote:
General question: I'm curious why this couldn't be simpler, that is, why
does unification depend on control flow? Couldn't you unify everything
without respect to control flow, and then run a pruning pass afterwards
reusing the
What Eric said. I haven't nailed down all the error reporting yet (although
it's closer now), but the idea is that we really can avoid reporting errors
on unreachable types. And not reaching code means fewer deserialized types,
which is better for memory and takes less time. But there's an even
10 matches
Mail list logo
