On Tue, Feb 10, 2009 at 7:38 PM, Ray Cromwell wrote:
> Bob, you are awesome. I'm excited this went from design to
> implementation so quickly, since it solves a lot of headache in my
> current codebase. I only wish it made it into 1.6. :)
s/Bob/GWT team/
Thanks Ray. I'm sure you'll have a high
Bob, you are awesome. I'm excited this went from design to
implementation so quickly, since it solves a lot of headache in my
current codebase. I only wish it made it into 1.6. :)
-Ray
On Tue, Feb 10, 2009 at 4:31 PM, BobV wrote:
>
> I have committed the SingleJsoImpl branch to trunk at r4689.
I have committed the SingleJsoImpl branch to trunk at r4689.
Further comments from Lex's review:
- Fixed JSORestrictionsChecker to actually implement what's in the design doc.
- Updated jsoRestrictions.html and changed JavaDoc in JSORC to point
to the design doc so that there's one canonical
Let's also be sure that the appropriate optimizers can statically resolve
type checks on SingleJsoImpl interfaces.
On Thu, Jan 15, 2009 at 1:02 PM, BobV wrote:
> > That's the flag I asked about. In general it makes perfect sense to
> > update the AST to hold any information that is needed. In
> That's the flag I asked about. In general it makes perfect sense to
> update the AST to hold any information that is needed. In this case,
> though, if I understand correctly, the information is soley determined
> by the target type of the cast.
I put the flag in there so that JsoNormalizer
On Thu, Jan 15, 2009 at 12:01 PM, Scott Blum wrote:
> This sounds great. My only comment involves this statement: "
>
> Casts and instanceof checks are accomplished by adding a flag
> to JCastOperation and JInstanceOf to allow a non-null, non-Java-derived
> (i.e.o.typeMarker$ != nullMethod) obje
On Thu, Jan 15, 2009 at 12:01 PM, Scott Blum wrote:
> Casts and instanceof checks are accomplished by adding a flag
> to JCastOperation and JInstanceOf to allow a non-null, non-Java-derived
> (i.e.o.typeMarker$ != nullMethod) object to pass the type checks. Additional
> methods are added to the C
This sounds great. My only comment involves this statement: "
Casts and instanceof checks are accomplished by adding a flag to
JCastOperation and JInstanceOf to allow a non-null, non-Java-derived
(i.e.o.typeMarker$
!= nullMethod) object to pass the type checks. Additional methods are added
to the
I have reviewed the JJS parts and the JSORestrictionsChecker part.
That leaves hosted mode (dev/shell).
I like the new rules that allow Java implementations to also exist,
albeit at a performance penalty.
I have one question about the new checking rules: is the check at
JSORestrictionsChecker li
On Tue, Jan 13, 2009 at 10:49 AM, BobV wrote:
> On Tue, Jan 13, 2009 at 10:41 AM, Scott Blum wrote:
>> Sure, is there a design doc for this so that I know what I'm looking at?
I've added a section at the bottom of
http://code.google.com/p/google-web-toolkit/wiki/OverlayTypes that
describes the
On Tue, Jan 13, 2009 at 10:41 AM, Scott Blum wrote:
> Sure, is there a design doc for this so that I know what I'm looking at?
Not at present, it's pretty much as we discussed. Methods on
SingleJsoImpl are renamed so that JSO$ can unambiguously implement
them as trampoline dispatches to static
Sure, is there a design doc for this so that I know what I'm looking at?
On Mon, Jan 12, 2009 at 9:14 PM, BobV wrote:
> The first round of coding is done.
>
> Follow-up from
> http://groups.google.com/group/Google-Web-Toolkit-Contributors/browse_thread/thread/5e180695145892d5
>
>
> @Scott,
> Ca
12 matches
Mail list logo
