http://gwt-code-reviews.appspot.com/892802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks for the feedback. The new patch incorporates the feedback.
On Sun, Sep 26, 2010 at 2:41 PM, rj...@google.com wrote:
http://gwt-code-reviews.appspot.com/892802/diff/1/2
File fixWriteOperationEnum.diff (right):
http://gwt-code-reviews.appspot.com/892802/diff/1/2#newcode1
http://gwt-code-reviews.appspot.com/925801/diff/1/2
File user/src/com/google/gwt/app/place/AbstractProxyListActivity.java
(right):
http://gwt-code-reviews.appspot.com/925801/diff/1/2#newcode256
user/src/com/google/gwt/app/place/AbstractProxyListActivity.java:256: if
(view == null) {
Isn't the
http://gwt-code-reviews.appspot.com/925801/diff/1/2
File user/src/com/google/gwt/app/place/AbstractProxyListActivity.java
(right):
http://gwt-code-reviews.appspot.com/925801/diff/1/2#newcode256
user/src/com/google/gwt/app/place/AbstractProxyListActivity.java:256: if
(view == null) {
TBH - I
Revision: 8870
Author: amitman...@google.com
Date: Sun Sep 26 19:46:41 2010
Log: The formatting was showing checkstyle errors in eclipse. Minor fixes
in formatting.
Patch by: amitmanjhi
Review by: cromwell...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8870
Revision: 8871
Author: rj...@google.com
Date: Sun Sep 26 20:02:00 2010
Log: getLastPage no longer issues request with negative start range if
table is empty
http://code.google.com/p/google-web-toolkit/source/detail?r=8871
Modified:
I posted this over on the normal group but hopefully I can get some
useful responses here. I am attempting to use the new GWT
LayoutPanels and unfortunately they are causing me some grief. We are
using the layout panels (RootLayoutPanel, DockLayoutPanel,
LayoutPanel, etc) to arrange the overall
getOffsetWidth/Height() always read the current state of the widget's
backing element, which won't be updated until the layout panels are done
laying themselves out. All the layout panels have the potential to be
animated, and defer actually laying things out until the end of the current
event (in
http://gwt-code-reviews.appspot.com/875803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2010/09/20 13:06:07, jgw wrote:
Sorry about that. Will look at it this afternoon (US/EST).
And apparently this afternoon means several days later... Sorry
about that.
The patch seems fine overall, but if you have a moment to add a test of
the enabled/disabled state, that would be helpful
http://gwt-code-reviews.appspot.com/875803/diff/1/2
File samples/hello/war/Hello.html (right):
http://gwt-code-reviews.appspot.com/875803/diff/1/2#newcode1
samples/hello/war/Hello.html:1: !DOCTYPE HTML PUBLIC -//W3C//DTD HTML
4.01 Transitional//EN
Don't forget to revert.
On Sep 27, 10:29 am, Joel Webber j...@google.com wrote:
getOffsetWidth/Height() always read the current state of the widget's
backing element, which won't be updated until the layout panels are done
laying themselves out. All the layout panels have the potential to be
animated, and defer
Revision: 8874
Author: rchan...@google.com
Date: Tue Jul 20 09:29:15 2010
Log: Moved Test suites and benchmarks to separate packages to prevent
spammy errors
http://code.google.com/p/google-web-toolkit/source/detail?r=8874
Added:
Mostly LG.
http://gwt-code-reviews.appspot.com/915802/diff/1/4
File dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java (right):
http://gwt-code-reviews.appspot.com/915802/diff/1/4#newcode119
dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java:119: public void
setDraftCompile(boolean
http://gwt-code-reviews.appspot.com/925801/diff/1/3
File user/src/com/google/gwt/app/place/AbstractProxyListView.java
(right):
http://gwt-code-reviews.appspot.com/925801/diff/1/3#newcode84
user/src/com/google/gwt/app/place/AbstractProxyListView.java:84:
protected void init(Widget root,
http://gwt-code-reviews.appspot.com/926801/diff/1/12
File
user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java
(right):
http://gwt-code-reviews.appspot.com/926801/diff/1/12#newcode241
user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java:241:
if
http://gwt-code-reviews.appspot.com/925801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8876
Author: rchan...@google.com
Date: Fri Aug 20 11:05:58 2010
Log: Removed unnecessary sample applications coming from merge from trunk
operation
http://code.google.com/p/google-web-toolkit/source/detail?r=8876
Deleted:
Reviewers: rjrjr,
Description:
Fixed stale error messages. DataTransferObject has been renamed to
ProxyFor annotation.
Patch by: amitmanjhi
Review by: rj...@google.com
Please review this at http://gwt-code-reviews.appspot.com/927801/show
Affected files:
M
http://gwt-code-reviews.appspot.com/875803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
comments addressed - although I'm having a couple of issues with the
includes - I'll come and find you to ask in person
http://gwt-code-reviews.appspot.com/875803/diff/1/3
File user/src/com/google/gwt/core/client/impl/SerializableThrowable.java
(right):
http://gwt-code-reviews.appspot.com/875803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/915802/diff/1/4
File dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java (right):
http://gwt-code-reviews.appspot.com/915802/diff/1/4#newcode119
dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java:119: public void
setDraftCompile(boolean draft) {
On
http://gwt-code-reviews.appspot.com/915802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Or at least consider allowing extensions to the build in support...
see comment:
http://code.google.com/p/gwt-html5-media/source/browse/trunk/src/main/java/com/google/code/gwt/html5/media/client/Media.java#691
On Aug 18, 11:53 am, Joel Webber j...@google.com wrote:
Le 15 août 2010 10:40,
25 matches
Mail list logo
