Reviewers: jat,
Description:
Add java.math and java.util.logging to list of packages to document
Please review this at http://gwt-code-reviews.appspot.com/1358802/show
Affected files:
M build-tools/doctool/src/com/google/doctool/custom/FindPackages.java
Index: build-tools/doctool/src/com/g
LGTM
http://gwt-code-reviews.appspot.com/1358802/diff/1/2
File build-tools/doctool/src/com/google/doctool/custom/FindPackages.java
(right):
http://gwt-code-reviews.appspot.com/1358802/diff/1/2#newcode51
build-tools/doctool/src/com/google/doctool/custom/FindPackages.java:51:
* A list of emulated
http://gwt-code-reviews.appspot.com/1358802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jat,
Description:
Clean up warnings
Please review this at http://gwt-code-reviews.appspot.com/1357807/show
Affected files:
M dev/core/src/com/google/gwt/core/ext/Linker.java
M dev/core/src/com/google/gwt/core/ext/linker/impl/PropertiesUtil.java
M
dev/core/src/com/google/gwt/
Reviewers: rjrjr,
Description:
Fixing HTMLTable#setWidget() to remove the widget or text when null is
passed as the widget. Currently, the widget is not removed.
Please review this at http://gwt-code-reviews.appspot.com/1358803/show
Affected files:
M user/src/com/google/gwt/user/client/ui/H
LGTM
http://gwt-code-reviews.appspot.com/1358803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
RequestFactoryMagic works on Android, but you'll need to do some build
hacking to get RF it to compile against the Android SDK.
Here's what I did as an experiment:
1) Extract autobean/{shared, server}/** and requestfactory{shared,
server/testing}/** from gwt-user.jar.
1a) There are a few other b
LGTM
http://gwt-code-reviews.appspot.com/1355804/diff/1/3
File user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java (right):
http://gwt-code-reviews.appspot.com/1355804/diff/1/3#newcode432
user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java:432: public
static void decodeInto(Splitt
http://gwt-code-reviews.appspot.com/1357801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
updated patch
http://gwt-code-reviews.appspot.com/1357801/diff/4002/1013
File dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java
(right):
http://gwt-code-reviews.appspot.com/1357801/diff/4002/1013#newcode41
dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java:41:
priva
Revision: 9737
Author: jlaba...@google.com
Date: Tue Feb 15 09:05:00 2011
Log: Fixing HTMLTable#setWidget() to remove the widget or text when null is
passed as the widget. Currently, the widget is not removed.
Review at http://gwt-code-reviews.appspot.com/1358803
Review by: rj...@google.com
committed as r9737
http://gwt-code-reviews.appspot.com/1358803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks for cleaning this up.
LGTM for the validation cod.e
http://gwt-code-reviews.appspot.com/1357807/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jat, fabiomfv, knorton,
Description:
Change the DevModeOptions page to use the xs linker due to recent Chrome
extension permissions changes
Please review this at http://gwt-code-reviews.appspot.com/1356803/show
Affected files:
M
plugins/npapi/DevModeOptions/src/com/google/gwt/de
lgtm and the horse I rode in on.
http://gwt-code-reviews.appspot.com/1356803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1356803/diff/1/2
File
plugins/npapi/DevModeOptions/src/com/google/gwt/devmodeoptions/DevModeOptions.gwt.xml
(right):
http://gwt-code-reviews.appspot.com/1356803/diff/1/2#newcode12
plugins/npapi/DevModeOptions/src/com/google/gwt/devmodeoptions/DevModeOptions.gw
Sorry, didn't see your comment in time for the commit. I just used the
same fix Kelly applied in SpeedTracer. I don't think it really matters
strongly either way.
On Tue, Feb 15, 2011 at 3:56 PM, wrote:
>
> http://gwt-code-reviews.appspot.com/1356803/diff/1/2
> File
> plugins/npapi/DevModeOption
On Tue, Feb 15, 2011 at 4:03 PM, Chris Conroy wrote:
> Sorry, didn't see your comment in time for the commit. I just used the
> same fix Kelly applied in SpeedTracer. I don't think it really matters
> strongly either way.
As I understand it, the xs linker will soon be deprecated since the xsifr
Revision: 9738
Author: con...@google.com
Date: Tue Feb 15 10:02:10 2011
Log: Change the DevModeOptions page to use the xs linker due to recent
Chrome extension permissions changes
Review at http://gwt-code-reviews.appspot.com/1356803
http://code.google.com/p/google-web-toolkit/source/detail?r
All google3 projects are being switched to xsiframe in a few weeks
(currently blocked by lack of a Blaze push). Deprecation/deletions of
other linkers for regular GWT will soon follow, but to be honest, will
be a GWT 3.0 thing at the very earliest.
It's not a burning issue, but I do recommend tha
Thanks Bob, do you mind if I file an issue to formally request this?
At this stage, I have it compiling but unable to parse requests on the server
On Tue, Feb 15, 2011 at 1:09 PM, BobV wrote:
> RequestFactoryMagic works on Android, but you'll need to do some build
> hacking to get RF it to compi
xsiframe is fine if it works. But you'll have to check it because these are
not the normal xs restrictions.
On Tue, Feb 15, 2011 at 4:28 PM, Unnur Gretarsdottir wrote:
> All google3 projects are being switched to xsiframe in a few weeks
> (currently blocked by lack of a Blaze push). Deprecation/
Revision: 9739
Author: gwt.mirror...@gmail.com
Date: Tue Feb 15 10:45:05 2011
Log: Scratch that, use the xsiframe linker per jat's suggestion
Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9739
Modified:
/trunk/plugins/npapi/DevModeOptions/src/com/googl
I could be wrong, but I don't think the xsiframe linker is going to work
here.
On Tue, Feb 15, 2011 at 4:46 PM, Kelly Norton wrote:
> xsiframe is fine if it works. But you'll have to check it because these are
> not the normal xs restrictions.
>
>
> On Tue, Feb 15, 2011 at 4:28 PM, Unnur Gretars
Actually, it does work.
On Tue, Feb 15, 2011 at 4:49 PM, Kelly Norton wrote:
> I could be wrong, but I don't think the xsiframe linker is going to work
> here.
>
> On Tue, Feb 15, 2011 at 4:46 PM, Kelly Norton wrote:
>>
>> xsiframe is fine if it works. But you'll have to check it because these
>
I actually don't have a really strong opinion here - if it's not easy
and you guys want to punt on it for now, that's fine with me - we can
deal with it, along with everything else, when the time comes.
I would be curious as to why it won't work though, since we do, long
term, want the xsiframe li
Awesome. good to know. I need to figure out how it manages to work.
On Tue, Feb 15, 2011 at 4:52 PM, Chris Conroy wrote:
> Actually, it does work.
>
> On Tue, Feb 15, 2011 at 4:49 PM, Kelly Norton wrote:
> > I could be wrong, but I don't think the xsiframe linker is going to work
> > here.
> >
Sweet, I think we're almost there. Mostly nits.
http://gwt-code-reviews.appspot.com/1357801/diff/4002/1014
File dev/core/src/com/google/gwt/dev/javac/CompilationUnit.java (right):
http://gwt-code-reviews.appspot.com/1357801/diff/4002/1014#newcode341
dev/core/src/com/google/gwt/dev/javac/Compil
Thanks for taking a look.
Regarding your general comments, the overall structure of the visitors
is modeled after ASM visitors. The default visitor which provides
do-nothing implementations of all the visitors is also straight from
ASM, and provides an easy way to implement just what you want an
29 matches
Mail list logo
