LGTM
On Mon, May 16, 2011 at 9:47 PM, sco...@google.com wrote:
There's no expected net change in behavior, it's just code cleanup.
http://gwt-code-reviews.appspot.com/1436801/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
File
Revision: 10190
Author: sco...@google.com
Date: Tue May 17 05:22:26 2011
Log: Salvage useful bits from overrides work.
http://gwt-code-reviews.appspot.com/1436801/
Review by: jbrosenb...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10190
Deleted:
Revision: 10191
Author: gwt.mirror...@gmail.com
Date: Tue May 17 07:35:44 2011
Log: In PRETTY and DETAILED, generate symbolic type queries for
readability.
This makes the output much nicer to read, you can actually tell what type
checks mean instead of looking at useless numbers.
Reviewers: jlabanca,
Description:
Use glass panel isntead of alert() when displaying dev mode connection
failures,
because modal dialog boxes are annoying and consume unnecessary
keystrokes or
mouse clicks before you are able to refresh the page.
Please review this at
http://gwt-code-reviews.appspot.com/1449802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hi,
With the bindery package change, I have a custom EventBus implementation
that no longer compiles. I was calling GwtEvent.setSource (and squatting
in the c.g.g.e.shared package to do so), but now setSource is defined in
the bindery package and so inaccessible.
I can move my EventBus to the
Yes please, we shouldn't have broken existing code like that.
On Tue, May 17, 2011 at 3:25 PM, Stephen Haberman
stephen.haber...@gmail.com wrote:
Hi,
With the bindery package change, I have a custom EventBus implementation
that no longer compiles. I was calling GwtEvent.setSource (and
Fred,
I can't tell you how obnoxious this has been for me. When this change makes
it into a release, I will owe you a beer or comparable gratuity.
Thank you.
On Tue, May 17, 2011 at 3:09 PM, fre...@google.com wrote:
http://gwt-code-reviews.appspot.com/1449802/
--
Sneaky. You asked for package protected. I don't want to *expand* the public
foot print.
On Tue, May 17, 2011 at 3:34 PM, stephen.haber...@gmail.com wrote:
Reviewers: rjrjr,
Description:
Redefines Event.setSource in the GwtEvent subclass to restore
c.g.g.e.shared package visibility.
On 2011/05/17 19:40:11, rjrjr wrote:
Sneaky. You asked for package protected. I don't want to *expand* the
public foot print.
Not intended. When making the patch, I just looked at Event.setSource
(which is protected) and copied that.
The thought crossed my mind while submitted the email/patch
Reviewers: rjrjr,
Description:
Redefines Event.setSource in the GwtEvent subclass to restore
c.g.g.e.shared package visibility.
Please review this at http://gwt-code-reviews.appspot.com/1450801/
Affected files:
user/src/com/google/gwt/event/shared/GwtEvent.java
Index:
+1
2011/5/17 Ray Ryan rj...@google.com
Yes please, we shouldn't have broken existing code like that.
On Tue, May 17, 2011 at 3:25 PM, Stephen Haberman
stephen.haber...@gmail.com wrote:
Hi,
With the bindery package change, I have a custom EventBus implementation
that no longer
No worries. Not having to click that popup will be payment enough :)
To be honest, I don't understand why it took me so long to realize that this
is was behavior that could in fact be changed.
On Tue, May 17, 2011 at 12:39 PM, Isaac Truett itru...@gmail.com wrote:
Fred,
I can't tell you how
http://gwt-code-reviews.appspot.com/1422816/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
This change now introduces only a Development Mode warning (to the GWT
treelogger), which an option to suppress it (for those who know what
they are doing, or to raise the severity to a runtime error, which we
can do in a later release
Dear GWT team,
Once again I feel this unbearable need to complain about your API
design choices. I have been trying to implement a custom CellTree,
delving into your sources and man I am left astonished with the level
of over-engineering and IMHO horrible code organization! I think you
often make
16 matches
Mail list logo
