Author: br...@google.com
Date: Mon Jun 22 23:40:46 2009
New Revision: 5604
Modified:
wiki/LightweightCollections.wiki
Log:
Modified: wiki/LightweightCollections.wiki
==
--- wiki/LightweightCollections.wiki
Comment by cromwellian:
In cases where a concrete collection models a non-sparse non-immutable
random-access list backed by a native array, we can potentially preserve
Java for-each by using the reinterpretCast trick to return a native array
E[] since for-each works for both arrays and
Comment by cromwellian:
Are there any other reserved properties besides 'prototype', 'constructor',
and '__proto__'? I'm wondering what the performance impact would be of
using a static regular expression to check during a put() operation. Reads
tend to be higher than writes for maps, so
I have to agree with Evan's interpretation, to the extent that this spec
makes much sense at all. And google.com's behavior
is as good an arbiter as any. I'm going to go back to splitting on the ''
and move the decodeURIComponent() back
to the sub-component (i.e. our gwt.hosted=...). If anyone
On 2009/06/22 22:50:38, jat wrote:
LGTM pending resolution of Evan's comment in the GWTC thread.
http://gwt-code-reviews.appspot.com/44801/diff/1002/8
File dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
(right):
http://gwt-code-reviews.appspot.com/44801/diff/1002/8#newcode254
On 2009/06/23 13:07:18, jgw wrote:
On 2009/06/22 22:50:38, jat wrote:
LGTM pending resolution of Evan's comment in the GWTC thread.
http://gwt-code-reviews.appspot.com/44801/diff/1002/8
File dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
(right):
Reviewers: bobv,
Message:
From IM:
Bob: Why can't you put the public method on HistoryImplIE6?
Joel: Because it's package-protected.
Bob: Oh I see.
http://gwt-code-reviews.appspot.com/44804/diff/1/3
File user/src/com/google/gwt/user/client/impl/HistoryImplIE6.java
(right):
Comment by jat+awco...@google.com:
`__proto__` and `watch` were issues, and `toString` caused problems on some
browsers if you ever tried to convert the map object to a string. If I
remember correctly, `__proto__` was the one that there was no way around.
However, you still need the
Comment by tamplinjohn:
You could return the array in the immutable case if the compiler knew it
wasn't going to get modified in this particular case. Taking the idea from
the other thread, the default implementation could be the safe one and a
method call generator could generate a
Previously, it failed in the checkstyle rule, and didn't even reach the
helpfully explanatory echo. This changes the echo to a fail, and
delays failure a bit, so that we only get the output if there is an error,
but we do get it.
--~--~-~--~~~---~--~~
Hi all,
I've succesfully compiled GWT trunk by using Ant,
now I want to debug it inside eclipse.
I followed instructions on
http://code.google.com/p/google-web-toolkit/source/browse/trunk/eclipse/README.txt,
with the exception that I'm using Eclipse 3.4 and I've left compiler
compliance level
Hi there,
Like many others I'm looking forward to see what you guys come up with
in the databinding area. But I miss some of the PresentationModel/
ValueModel style frameworks I've come to like in Swing and thought I'd
put in my 2c worth on a basic approach/API that would make me a happy
Apologies that I'm wy late to this party, but the whole template
search/replace thing doesn't seem ideal in that something like a typo in the
template name could cause some seriously hard-to-debug code.
Did you consider the case that if a property provider returns null, then the
fallback
On Mon, Jun 22, 2009 at 7:33 PM, Ian Petersenispet...@gmail.com wrote:
Here's what I mean:
// ... surrounding code ...
GWT.runAsync(new AsyncCallback() {
public void onFailure(Throwable caught) {
// deal with failure
}
@SplitPointName(I like Bruce's idea)
I like the general idea, yes.
A complication is that one of the changes John asked for, specific for the
i18n provider, was to return */*-FALLBACK-*/ || default*, with the idea
that a null/undefined fallback should be gracefully handled, since an
invalid locale return is going to break the
Author: j...@google.com
Date: Tue Jun 23 06:05:16 2009
New Revision: 5605
Modified:
trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
Log:
Fixes hosted.html to decode the gwt.hosted part of the url.
Review: http://gwt-code-reviews.appspot.com/44801
Modified:
LGTM
On Tue, Jun 23, 2009 at 12:10 PM, Freeland Abbottfabb...@google.com wrote:
Substitute with this version, having discovered structural errors with
samples (${project.build} is lowercase, but output is uppercase) and some
comments from Eric regarding the presubmit target (which are
Author: b...@google.com
Date: Tue Jun 23 06:59:40 2009
New Revision: 5607
Modified:
branches/snapshot-2009.06.16-r5570/ (props changed)
branches/snapshot-2009.06.16-r5570/dev/core/src/com/google/gwt/core/ext/ServletContainer.java
(props changed)
Thanks. Submitted at r5612.
On Tue, Jun 23, 2009 at 12:15 PM, Eric Ayers zun...@google.com wrote:
LGTM
On Tue, Jun 23, 2009 at 12:10 PM, Freeland Abbottfabb...@google.com
wrote:
Substitute with this version, having discovered structural errors with
samples (${project.build} is
Author: br...@google.com
Date: Tue Jun 23 09:07:00 2009
New Revision: 5609
Modified:
wiki/LightweightCollections.wiki
Log:
Added first draft of Collections and Array types.
Modified: wiki/LightweightCollections.wiki
Author: b...@google.com
Date: Tue Jun 23 07:58:04 2009
New Revision: 5608
Modified:
branches/snapshot-2009.06.16-r5570/branch-info.txt
Log:
Update branch-info.txt to record merge of r5606 from trunk.
Modified: branches/snapshot-2009.06.16-r5570/branch-info.txt
Author: fabb...@google.com
Date: Tue Jun 23 09:12:15 2009
New Revision: 5610
Modified:
trunk/user/src/com/google/gwt/core/client/JavaScriptObject.java
trunk/user/src/com/google/gwt/i18n/client/TimeZone.java
trunk/user/src/com/google/gwt/i18n/server/GwtLocaleImpl.java
Author: br...@google.com
Date: Tue Jun 23 09:18:01 2009
New Revision: 5611
Modified:
wiki/LightweightCollections.wiki
Log:
Suppressed wiki words in headings, added a little example code for arrays.
Modified: wiki/LightweightCollections.wiki
Author: fabb...@google.com
Date: Tue Jun 23 09:20:54 2009
New Revision: 5612
Modified:
trunk/build.xml
trunk/common.ant.xml
trunk/samples/common.ant.xml
Log:
Fixing the checkstyle and presubmit rules. Checkstyle never reached the
where's the log? echo, so changed checkstyle to
Author: j...@google.com
Date: Tue Jun 23 06:48:42 2009
New Revision: 5606
Modified:
trunk/user/src/com/google/gwt/user/client/impl/HistoryImpl.java
trunk/user/src/com/google/gwt/user/client/impl/HistoryImplIE6.java
Log:
Adds hack to HistoryImpl that allows #hash setting on IE6/7 to be
It couldn't have been that easy. Surely someone disagrees?
On Tue, Jun 23, 2009 at 11:57 AM, John Tamplin j...@google.com wrote:
On Tue, Jun 23, 2009 at 11:52 AM, Freeland Abbott fabb...@google.comwrote:
I like the general idea, yes.
A complication is that one of the changes John asked for,
Reviewers: jgw,
Description:
Summary:
=
In IE, TextArea#getCursorPos(), getSelectionLength(), and
getSelectedText() all return the wrong values, setSelectedText() selects
the wrong value. This is all due to IEs handling of newline characters.
Description:
Most browsers
Wow. Just wow. You know an API design (referring to the text-range stuff
in IE) is messed up when you have to do this much to normalize it.
LGTM (If by good one means hideous but necessary).
http://gwt-code-reviews.appspot.com/47801
--~--~-~--~~~---~--~~
Author: j...@google.com
Date: Tue Jun 23 12:43:56 2009
New Revision: 5613
Modified:
trunk/dev/oophm/src/com/google/gwt/dev/OophmHostedModeBase.java
Log:
Fix how the launch URL is built to include the gwt.hosted parameter
(previously it would build it improperly if the launch URL had a
Author: j...@google.com
Date: Tue Jun 23 12:53:37 2009
New Revision: 5614
Modified:
changes/jat/ihm/dev/core/src/com/google/gwt/core/ext/typeinfo/JParameterizedType.java
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/JavaBinaryOracleImpl.java
Author: jlaba...@google.com
Date: Tue Jun 23 13:30:29 2009
New Revision: 5615
Modified:
trunk/user/src/com/google/gwt/user/client/ui/TextBoxBase.java
trunk/user/src/com/google/gwt/user/client/ui/impl/TextBoxImplIE6.java
trunk/user/test/com/google/gwt/user/client/ui/TextAreaTest.java
Comment by benzheren:
yah, I just remove it from the Eclipse launch config.
For more information:
http://code.google.com/p/google-web-toolkit/wiki/UsingOOPHM
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I'm wondering how many hours/how much $$$ this cost Google to implement. :)
Just more evidence that a class action lawsuit is needed against Microsoft
to recover damages for lost time and money. :)
-Ray
On Tue, Jun 23, 2009 at 1:26 PM, j...@google.com wrote:
Wow. Just wow. You know an API
Reviewers: andreasst,
Description:
This patch adds support for looking up deprecated currencies and a
special iterator to include them in the iteration, so it won't affect
existing code.
There will be a small size penalty as additional currency information
will be retained in the output script.
Reviewers: scottb, amitmanjhi,
Description:
This patch treats any GWTTestCase-derived classes that return 'null'
from getModuleName() as if they were simply pure Java tests.
Why does this matter? Suppose you're writing tests for code that has
both a pure Java implementation and a super-sourced
LGTM with comments.
http://gwt-code-reviews.appspot.com/47804/diff/1/3
File user/src/com/google/gwt/junit/client/GWTTestCase.java (right):
http://gwt-code-reviews.appspot.com/47804/diff/1/3#newcode52
Line 52: * {...@link UnsupportedOperationException}.Instead, override
{...@link #gwtSetUp()}
LGTM with one inline comment and one design question Is it better to
have a special case handling of null or is it better to introduce a
default non-null value for this purpose?
http://gwt-code-reviews.appspot.com/47804/diff/1/3
File user/src/com/google/gwt/junit/client/GWTTestCase.java
Thanks, r5617.
On Tue, Jun 23, 2009 at 8:23 PM, amitman...@google.com wrote:
LGTM with one inline comment and one design question Is it better to
have a special case handling of null or is it better to introduce a
default non-null value for this purpose?
Comment by rich...@zschech.net:
I had an idea how to reduce the code required for the immutable collections
mutation methods throwing UnsupportedOperationException:
If the compiler detects that the bodies of two methods are the same then it
can use the same JavaScript method.
For example in
Comment by rich...@zschech.net:
I had an idea how to reduce the code required for the immutable collections
mutation methods throwing `UnsupportedOperationException`:
If the compiler detects that the bodies of two methods are the same then it
can use the same Java Script method. For example
Comment by rich...@zschech.net:
I had an idea how to reduce the code required for the immutable collections
mutation methods throwing `UnsupportedOperationException`:
If the compiler detects that the bodies of two methods are the same then it
can use the same Java Script method. For example
LGTM
http://gwt-code-reviews.appspot.com/47803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Author: br...@google.com
Date: Tue Jun 23 18:52:00 2009
New Revision: 5619
Modified:
trunk/user/src/com/google/gwt/junit/rebind/GWTRunnerGenerator.java
trunk/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
Log:
Retains exception cause chain
Author: br...@google.com
Date: Tue Jun 23 17:40:28 2009
New Revision: 5617
Modified:
trunk/user/src/com/google/gwt/junit/client/GWTTestCase.java
trunk/user/src/com/google/gwt/junit/tools/GWTTestSuite.java
Log:
Allows GWTTestCase#getModuleName() to return null to indicate it should be
Author: j...@google.com
Date: Tue Jun 23 16:19:42 2009
New Revision: 5616
Modified:
trunk/user/super/com/google/gwt/emul/java/sql/Date.java
trunk/user/test/com/google/gwt/emultest/java/sql/SqlDateTest.java
Log:
Fix incorrect parsing in java.sql.Date, where leading zeros triggered octal
Author: br...@google.com
Date: Tue Jun 23 17:49:16 2009
New Revision: 5618
Modified:
trunk/user/src/com/google/gwt/junit/client/GWTTestCase.java
Log:
Added exactly one space in a comment.
Suggested by: scottb
Patch by: bruce
Smallest. Change. Ever.
Modified:
46 matches
Mail list logo
