[gwt-contrib] [google-web-toolkit] r5974 committed - Make Condition and Conditions Serializable so that they may work with ...

2009-08-18 Thread codesite-noreply
Revision: 5974 Author: b...@google.com Date: Tue Aug 18 06:46:44 2009 Log: Make Condition and Conditions Serializable so that they may work with multiple-worker builds. Patch by: bobv Review by: kprobst (TBR) http://code.google.com/p/google-web-toolkit/source/detail?r=5974 Modified:

[gwt-contrib] Re: Adding a DOM com.google.gwt.dom.client.Window class?

2009-08-18 Thread Joel Webber
@mP: That would be great if you're interested in moving it into GWT proper. It's one of those things we've always known was a big can of worms, and no one's had much time to look into it. On Mon, Aug 17, 2009 at 5:30 PM, Miroslav Pokorny miroslav.poko...@gmail.com wrote: Re/ Selections I

[gwt-contrib] Re: Adding a DOM com.google.gwt.dom.client.Window class?

2009-08-18 Thread Joel Webber
One thing I didn't make clear from the beginning, btw, was that I *am* in favor of doing something about Window sooner rather than later, even if we don't resolve the rest of this stuff. More than anything, I wanted to get buy-in on the appropriate package/module, and the general approach for

[gwt-contrib] Re: Adding a DOM com.google.gwt.dom.client.Window class?

2009-08-18 Thread Joel Webber
One thing I didn't make clear from the beginning, btw, was that I *am* in favor of doing something about Window sooner rather than later, even if we don't resolve the rest of this stuff. More than anything, I wanted to get buy-in on the appropriate package/module, and the general approach for

[gwt-contrib] RR: STOB short circuit path must also compute some side information

2009-08-18 Thread Lex Spoon
I'm posting directly to the list, because I got error 500 on Reitveldt. This is a simple patch. There is a small problem in a short-circuit path in SerializableTypeOracleBuilder (STOB). The short circuit is to check if a type has already been examined and, if so, returns yes, it's

[gwt-contrib] Re: RR: STOB short circuit path must also compute some side information

2009-08-18 Thread Freeland Abbott
Looks fine... the only comments are pretty cosmetic: changing checkTypeInstantiable() (and checkArrayInstantiable() also) to return non-boolean should probably also change its name; something like computeInstantiability() may be a better name. It also may warrant more explicit javadoc. It just

[gwt-contrib] Re: RR: STOB short circuit path must also compute some side information

2009-08-18 Thread Lex Spoon
2009/8/18 Freeland Abbott fabb...@google.com: Looks fine... the only comments are pretty cosmetic: changing checkTypeInstantiable() (and checkArrayInstantiable() also) to return non-boolean should probably also change its name; something like computeInstantiability() may be a better name.  It

[gwt-contrib] Re: RR: STOB short circuit path must also compute some side information

2009-08-18 Thread Freeland Abbott
Trusting you on those two, LGTM. 2009/8/18 Lex Spoon sp...@google.com 2009/8/18 Freeland Abbott fabb...@google.com: Looks fine... the only comments are pretty cosmetic: changing checkTypeInstantiable() (and checkArrayInstantiable() also) to return non-boolean should probably also change

[gwt-contrib] JSNI warnings in OOPHM

2009-08-18 Thread Sanjiv Jivan
I'm running OOPHM using a trunk build and the FF 3.5 plugin. I'm getting a bunch of JSNI warnings like [WARN] JSNI method '__defineStatic' returned a value of type boolean but was declared void; it should not have returned a value at all [WARN] JSNI method 'fireOnModuleLoadStart' returned a

[gwt-contrib] Illegal XML characters in SOYC XML files

2009-08-18 Thread kprobst
Reviewers: Lex, Description: Hi Lex, would you review this simple patch for me? It catches the illegal XML characters that were throwing off the SAX parser. TODO: there are still some character that could theoretically sneak into our xml files, see http://www.w3.org/TR/REC-xml/#charsets.

[gwt-contrib] [google-web-toolkit] r5976 committed - Makefile changes necessary to build on MacOSX 10.4.

2009-08-18 Thread codesite-noreply
Revision: 5976 Author: j...@google.com Date: Tue Aug 18 15:58:15 2009 Log: Makefile changes necessary to build on MacOSX 10.4. http://code.google.com/p/google-web-toolkit/source/detail?r=5976 Modified: /trunk/plugins/config.mk /trunk/plugins/xpcom/Makefile

[gwt-contrib] [google-web-toolkit] r5975 committed - Missing svn:executable flag.

2009-08-18 Thread codesite-noreply
Revision: 5975 Author: j...@google.com Date: Tue Aug 18 14:45:44 2009 Log: Missing svn:executable flag. http://code.google.com/p/google-web-toolkit/source/detail?r=5975 Modified: /plugin-sdks/gecko-sdks/gecko-1.9.1/Darwin-gcc3/bin/xpidl === ---

[gwt-contrib] Re: JSNI warnings in OOPHM

2009-08-18 Thread John Tamplin
On Tue, Aug 18, 2009 at 5:05 PM, Sanjiv Jivan sanjiv.ji...@gmail.comwrote: I'm running OOPHM using a trunk build and the FF 3.5 plugin. I'm getting a bunch of JSNI warnings like [WARN] JSNI method '__defineStatic' returned a value of type boolean but was declared void; it should not have

[gwt-contrib] Re: JSNI warnings in OOPHM

2009-08-18 Thread Sanjiv Jivan
I'm pretty certain I tried oophm-xpcom-ff35.xpi and oophm-xpcom- ff3+.xpi from trunk with FF 3.5.2 but neither was able to talk to the server and complained about a missing plugin. So I tried installing oophm-xpcom-ff3.xpi and it was able to talk to the server but resulted in all those warnings.

[gwt-contrib] Re: JSNI warnings in OOPHM

2009-08-18 Thread John Tamplin
On Tue, Aug 18, 2009 at 7:58 PM, Sanjiv Jivan sanjiv.ji...@gmail.comwrote: I'm pretty certain I tried oophm-xpcom-ff35.xpi and oophm-xpcom- ff3+.xpi from trunk with FF 3.5.2 but neither was able to talk to the server and complained about a missing plugin. So I tried installing

[gwt-contrib] Re: JSNI warnings in OOPHM

2009-08-18 Thread Sanjiv Jivan
On Tue, Aug 18, 2009 at 8:40 PM, John Tamplin j...@google.com wrote: On Tue, Aug 18, 2009 at 7:58 PM, Sanjiv Jivan sanjiv.ji...@gmail.comwrote: I'm pretty certain I tried oophm-xpcom-ff35.xpi and oophm-xpcom- ff3+.xpi from trunk with FF 3.5.2 but neither was able to talk to the server and

[gwt-contrib] Comment on CodeSplitting in google-web-toolkit

2009-08-18 Thread codesite-noreply
Comment by lineman78: I have used Ray's GWT Exporter and I believe that you could use this to achieve what you want with plugability while also allowing the compiler to do it's optimizations. One thing I haven't experimented with that Ray would have to answer is if you could add the