Reviewers: Lex,
Description:
Operations like i += d where i is an int and d is a double are not
properly truncated (narrowed) to the LHS type. This patch forces i += d
to be written as i = i + d, and applies a narrowing cast as needed, e.g.
i = (int)(i + d);
Please review this at
Reviewers: Dan Rice,
Description:
This patch fixes a few problems when dealing with local classes (those
defined inside a method):
- local classes inside a static method do not have a
synthetic constructor arg passing the containing
instance, as there isn't one
-
Revision: 6869
Author: j...@google.com
Date: Thu Nov 12 05:54:31 2009
Log: Fix line endings and MIME types.
Patch by: jat
Review by: scottb (TBR)
http://code.google.com/p/google-web-toolkit/source/detail?r=6869
Deleted:
/releases/2.0/dev/core/src/com/google/gwt/dev/javac/impl
Modified:
Comment by rda...@google.com:
@mauzepeda: Thanks for providing the summary of how to make things work
with the current state of trunk and the plugin. I don't think it is
necessary that gwt-dev.jar be renamed to gwt-dev-linux.jar though.
For more information:
Revision: 6870
Author: j...@google.com
Date: Thu Nov 12 06:32:35 2009
Log: Merge r6869 from releases/2.0 into trunk. This fixes line endings and
MIME types not being set properly.
svn merge --ignore-ancestry -c6869 \
https://google-web-toolkit.googlecode.com/svn/releases/2.0 .
LGTM
http://gwt-code-reviews.appspot.com/100806
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/102811/diff/1/3
File
dev/core/src/com/google/gwt/dev/jjs/impl/CompoundAssignmentNormalizer.java
(right):
http://gwt-code-reviews.appspot.com/102811/diff/1/3#newcode409
Line 409: protected JExpression operationToReturn(JBinaryOperation op) {
Also, I think you
Thanks, Ray! A couple of things look like they should be changed, as
indicated in the line-by-lines.
Also, it should have a test. CompilerTest would be a decent place to
put it.
http://gwt-code-reviews.appspot.com/102811/diff/1/2
File
On Thu, Nov 12, 2009 at 9:47 AM, r...@google.com wrote:
LGTM
Thanks, committed to trunk at r6871, merging to releases/2.0.
--
John A. Tamplin
Software Engineer (GWT), Google
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 6871
Author: j...@google.com
Date: Thu Nov 12 06:59:32 2009
Log: This patch for a problem discussed on GWTC, fixes a problem in getting
the real
argument names.
The path through resolveMethod that uses the descriptor works fine, but the
one
that uses a generic signature does not
Ok, this should be fixed in trunk at r6871 and will be merged to
releases/2.0 shortly.
--
John A. Tamplin
Software Engineer (GWT), Google
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I noticed the svn commit message.
Thanks for your quick help, John! Much appreciated.
Cheers,
Bart Guijt
E: b...@guijt.me
T: +31 6 30408987
On 12 nov 2009, at 16:05, John Tamplin j...@google.com wrote:
Ok, this should be fixed in trunk at r6871 and will be merged to
releases/2.0 shortly.
http://gwt-code-reviews.appspot.com/102801/diff/1/43
File dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java
(right):
http://gwt-code-reviews.appspot.com/102801/diff/1/43#newcode189
Line 189: error(Multiple runASync calls are named + name);
The error reporting needs to produce
Revision: 6873
Author: j...@google.com
Date: Thu Nov 12 08:23:17 2009
Log: Merge trunk r6871 into this branch
Fix a problem getting real argument names from generic methods.
svn merge --ignore-ancestry -c6871 \
http://google-web-toolkit.googlecode.com/svn/trunk/ .
Revision: 6874
Author: j...@google.com
Date: Thu Nov 12 08:28:36 2009
Log: Merge trunk r6872 into this branch
Fix a problem with local classes.
svn merge --ignore-ancestry -c6872 \
http://google-web-toolkit.googlecode.com/svn/trunk/ .
Revision: 6872
Author: j...@google.com
Date: Thu Nov 12 08:22:02 2009
Log: Fix a problem with local static classes, plus clean up naming, comments
and formatting.
Patch by: jat
Review by: rice
http://code.google.com/p/google-web-toolkit/source/detail?r=6872
Modified:
Thanks, Bob! What do you think about the error messages and about the
isLoaded method?
I'll post an updated patch in just a minute.
http://gwt-code-reviews.appspot.com/102801/diff/1/43
File dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java
(right):
Revision: 6875
Author: br...@google.com
Date: Thu Nov 12 11:30:55 2009
Log: Changes URL in hosted.html to point to the new missing plugin page
app that lives here:
http://gwt-dev-plugin-missing.appspot.com
Change by: bruce
Review by: cramsdale (desk)
Reviewers: mmendez,
Description:
Adds a start() method to MessageTransport. The message transport threads
are no longer started in the constructor; they are only started once the
start() method is called.
Please review this at http://gwt-code-reviews.appspot.com/102813
Affected files:
M
Reviewers: jlabanca,
Description:
This fixes the ServletMappingSuite buildbreak.
The issue appears to be that a pathelement location=/ is taken, much
like a :: substring in -classpath, to mean this directory rather than
nothing: it puts gwt-root/user onto the classpath. And, when the
http://gwt-code-reviews.appspot.com/102813
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/100807
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
Make sure to run the updates against the plugin as a cross-check.
http://gwt-code-reviews.appspot.com/102813
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 6876
Author: jlaba...@google.com
Date: Thu Nov 12 12:14:16 2009
Log: Synchronizing ModuleDef#getResourceOracle(), which causes things to
break in dev mode because we sometimes create a bunch of oracles that step
on each other. Also synchronizing some generator classes that use a
Revision: 6878
Author: fabb...@google.com
Date: Thu Nov 12 12:28:34 2009
Log: Fix ServletMappingSuite, which was wrongly getting user/ on the
classpath, and thus found user/test/** as part of
test.ServletMappingTest.gwt.xml
http://code.google.com/p/google-web-toolkit/source/detail?r=6878
Revision: 6879
Author: fabb...@google.com
Date: Thu Nov 12 12:45:28 2009
Log: merge 6878, fixing ServletMappingTest by not putting user on the
classpath in lieu of emma.
http://code.google.com/p/google-web-toolkit/source/detail?r=6879
Modified:
/releases/2.0/common.ant.xml
Reviewers: fabbott,
Description:
Currently, RunStyleSelenium cannot parse a selenium target that contains
a file path, such as:
localhost:/*firefox /usr/bin/firefox
This is supported by firefox, and very useful when multiple versions of
a browser are installed on the target system.
Fix:
===
Revision: 6880
Author: rda...@google.com
Date: Thu Nov 12 13:26:49 2009
Log: Adds a start() method to MessageTransport. The message transport
threads are no longer started in the constructor; they are only started
once the start() method is called.
Review by: mmendez
Revision: 6881
Author: rda...@google.com
Date: Thu Nov 12 13:31:08 2009
Log: Merge tr...@r6880 into releases/2.0. Merge performed with the
following command:
svn merge --ignore-ancestry -c 6880
http://google-web-toolkit.googlecode.com/svn/trunk .
Thanks for the review. Ran the unit tests and updates against the
plugin, everything checked out.
Committed into trunk at r6880.
Cherry-picked into releases/2.0 at r6881.
http://gwt-code-reviews.appspot.com/102813
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 6882
Author: rda...@google.com
Date: Thu Nov 12 13:32:27 2009
Log: Update branch-info.txt to reflect merge of tr...@r6880 into this
branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=6882
Modified:
/releases/2.0/branch-info.txt
Reviewers: jat,
Description:
Ensure all calls to String.to{Lower,Upper}Case in the dev packages
specify the English locale, so that Turkish users don't experience 'I'
mapping to dotless small 'i'. We also avoid calls to
Character.to{Lower,Upper}Case since they do not specify the locale.
There's
LGTM
http://gwt-code-reviews.appspot.com/100808
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 6883
Author: j...@google.com
Date: Thu Nov 12 14:37:02 2009
Log: Fixed stupid style error in Mail's stack panel headers.
TBR: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=6883
Modified:
/trunk/samples/mail/src/com/google/gwt/sample/mail/client/Shortcuts.ui.xml
Revision: 6884
Author: jlaba...@google.com
Date: Thu Nov 12 14:37:28 2009
Log: Synchronizing OophmSessionHandler#loadModule to ensure that two
modules never load at the same time.
Patch by: jlabanca
Review by: bobv (pair)
http://code.google.com/p/google-web-toolkit/source/detail?r=6884
Revision: 6885
Author: jlaba...@google.com
Date: Thu Nov 12 14:39:43 2009
Log: tr...@6884 was merged into this branch
Synchronizing OophmSessionHandler#loadModule() to prevent multiple modules
from loading at the same time.
svn merge --ignore-ancestry -c6884
Revision: 6886
Author: j...@google.com
Date: Thu Nov 12 14:52:16 2009
Log: Merging /tr...@r6883 into /releases/2.0.
http://code.google.com/p/google-web-toolkit/source/detail?r=6886
Modified:
/releases/2.0/branch-info.txt
Thanks!
On Nov 11, 11:12 am, Ray Ryan rj...@google.com wrote:
If you're building incubator from source, you'll need to build GWT from
source as well. To work against GWT 1.7 please download the incubator
jar.http://code.google.com/p/google-web-toolkit-incubator/wiki/Downloads?...
--
Reviewers: amitmanjhi,
Please review this at http://gwt-code-reviews.appspot.com/100810
Affected files:
user/test/com/google/gwt/dom/client/ElementTest.java
user/test/com/google/gwt/dom/client/StyleInjectorTest.java
user/test/com/google/gwt/emultest/java/lang/StringTest.java
Reviewers: amitmanjhi,
Description:
We need to upgrade our html lib to the latest HtmlUnit SVN had many bug
fixes. These are the changes to the files in trunk: (Separately tools
updates had been mailed to Amit)
dev/build.xml
eclipse/dev/.classpath
eclipse/user/.classpath
Please review this at
The legacy StyleInjector should probably be gutted and made to forward
to the real StyleInjector, since the new one offers a pretty decent
performance improvement.
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 6887
Author: br...@google.com
Date: Thu Nov 12 20:20:48 2009
Log: Rolls back 6875, which accidentally included some horrid styling that
had been intended for testing only.
Original mistake by: bruce
Change by: bruce
Review by: jat (TBR)
Comment by ice.tweety:
Sorry, got it right yet:
DOM.setStyleAttribute(this.getElement(), backgroundImage, url(chili.jpg));
is it!
For more information:
http://code.google.com/p/google-web-toolkit/wiki/ImageBundleDesign
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
44 matches
Mail list logo
