http://gwt-code-reviews.appspot.com/547801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8211
Author: jlaba...@google.com
Date: Wed May 26 03:15:17 2010
Log: Added null checks to MenuItem.setSubMenu(null) so it doesn't throw an
NPE. Also made sure that the Accessibility HASPOPUP state is set to false
when the submenu is removed.
Just to let you know - as of v2.3.0, easyXDM can now offer transport/
RPC with 15ms transits with *no* server side dependencies for
IE6+,Opera 9+, Firefox 3+, Safari 4+ and Chrome 2+.
All you need is to include easyXDM in the two documents.
For GWT this could be used in the following manner
2010/5/20 oatkinson oatkin...@gmail.com
I heard some rumblings about creating a new vm language that was
basically a puddle of java called jribble. It was supposed to
allows support for making GWT work on scala code. I have not seen
much more about it. Has anyone heard anything? I would
The next GWT Developments, will have alternatives to the VerticalPanel
and HorizontalPanel, using no table tags??
http://en.wikipedia.org/wiki/Tableless_web_design
For instance, the HorizontalPanel could have a alternative named
HorizontalFlowPanel, that instead of generate this code:
table
tr
LGTM
http://gwt-code-reviews.appspot.com/547801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Lex,
Description:
Package annotations to avoid recompilation
Review by: sp...@google.com
Please review this at http://gwt-code-reviews.appspot.com/563801/show
Affected files:
M /dev/core/src/com/google/gwt/core/ext/soyc/package-info.java
M
The FlowPanel (just a simple div that leaves its children's styles
unmodified) already allows you to do this. For the vertical case, this tends
to happen naturally with block-level children.
The horizontal case is trickier, however. Using float:left captures some,
but definitely not all cases
Revision: 8212
Author: rchan...@google.com
Date: Wed May 26 04:38:31 2010
Log: Added benchmark task to ant in user/
Review at http://gwt-code-reviews.appspot.com/547801
Review by: sp...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8212
Added:
Joel, can we @Deprecate all the redundant non-flow panels yet? It's getting
harder and harder for people to discover the right thing to do.
On Wed, May 26, 2010 at 7:15 AM, Joel Webber j...@google.com wrote:
The FlowPanel (just a simple div that leaves its children's styles
unmodified)
Well... HorizontalPanel is still useful in some instances, and we have no
way of providing the same behavior in a general way because CSS layout is a
bloody mess. I'd be ok with deprecating the others (StackPanel, TabPanel,
VerticalPanel, and DockPanel) though.
Le 26 mai 2010 11:36, Ray Ryan
Reviewers: Lex,
Description:
Fixes a bug in the compile report dashboard where entries with same
sizes were
being swallowed. It also now attributes fields to the corresponding
packages,
and gives additional hints about what is broken down and what isn't.
Please review this at
Revision: 8214
Author: igork...@google.com
Date: Wed May 26 06:47:24 2010
Log: Redeclare interface method in the enum to work around a javac bug.
See http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6724345 for details.
Review at http://gwt-code-reviews.appspot.com/564801
One initial problem is that it's failing to find the right DataNucleus
libraries:
ERROR DataNucleus.Plugin - Bundle org.datanucleus.store.appengine requires
org.datanucleus version [1.0.4, 1.1.5.final) but the resolved bundle has
version 1.0.7.final which is outside the expected range.
What
LGTM with nits. No need to rereview if you like the suggested changes.
These changes will make SOYC a lot easier to understand.
http://gwt-code-reviews.appspot.com/566801/diff/1/3
File dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
(right):
Reviewers: Dan Rice,
Description:
Replacing CurrencyCell with generic NumberCell that uses NumberFormat.
Please review this at http://gwt-code-reviews.appspot.com/568801/show
Affected files:
M /bikeshed/src/com/google/gwt/sample/bikeshed/stocks/StocksCommon.gwt.xml
M
Presuming you buy into the Renderer and Parser interfaces
in trunk/bikeshed/src/com/google/gwt/input, could they be used to unify
NumberCell and DateCell?
input is still in bikeshed so we'd need to have the whole new-public-api
conversation. Maybe this CL can be the catalyst.
On Wed, May 26,
LGTM
http://gwt-code-reviews.appspot.com/568801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hmmm... are you suggesting a ValueCell/ValueInputCell that defers to a
Renderer/Parser? Assuming you mean that we would have subclasses for each
type as we do with ValueBox, I agree. But that means that we'll have a
DateCell and NumberCell anyway, so this patch can go in and we can add a
On Wed, May 26, 2010 at 12:29 PM, John LaBanca jlaba...@google.com wrote:
Hmmm... are you suggesting a ValueCell/ValueInputCell that defers to a
Renderer/Parser? Assuming you mean that we would have subclasses for each
type as we do with ValueBox, I agree. But that means that we'll have a
Do you agree that we would still have a NumberParser even with the
renderers?
Uh, what?
*NumberParser = NumberCell
Thanks,
John LaBanca
jlaba...@google.com
On Wed, May 26, 2010 at 3:39 PM, Ray Ryan rj...@google.com wrote:
On Wed, May 26, 2010 at 12:29 PM, John LaBanca
FYI - jat only reviewed the NumberCell class
Thanks,
John LaBanca
jlaba...@google.com
On Wed, May 26, 2010 at 3:41 PM, John LaBanca jlaba...@google.com wrote:
Do you agree that we would still have a NumberParser even with the
renderers?
Uh, what?
*NumberParser = NumberCell
Thanks,
Ready for another look.
By adding an actual @SingleJsoImpl annotation to act as a hint for
devmode, the impact on I18N's CurrencyData is pretty much a one-liner.
http://gwt-code-reviews.appspot.com/473801/diff/5001/6004
File dev/core/src/com/google/gwt/dev/shell/JsValueGlue.java (right):
On Wed, May 26, 2010 at 12:41 PM, John LaBanca jlaba...@google.com wrote:
Do you agree that we would still have a NumberParser even with the
renderers?
Uh, what?
*NumberParser = NumberCell
I'm not sure I do, actually. It may be easy enough to do new
ValueCellNumber(new NumberParser())
24 matches
Mail list logo
