[gwt-contrib] Re: Fixes tests broken due to mis-use of class meta data. (issue786801)

Still failing. :-( On Thu, Aug 19, 2010 at 9:09 PM, Ray Ryan wrote: > Actually, the tests are still running. I'll ping you when they pass. > > > On Thu, Aug 19, 2010 at 9:08 PM, wrote: > >> Reviewers: cromwellian, >> >> Description: >> Fixes tests broken due to mis-use of class meta data. >> >>

[gwt-contrib] Re: Fixes tests broken due to mis-use of class meta data. (issue786801)

Actually, the tests are still running. I'll ping you when they pass. On Thu, Aug 19, 2010 at 9:08 PM, wrote: > Reviewers: cromwellian, > > Description: > Fixes tests broken due to mis-use of class meta data. > > Review by: cromwell...@google.com > > Please review this at http://gwt-code-reviews.

[gwt-contrib] Fixes tests broken due to mis-use of class meta data. (issue786801)

Reviewers: cromwellian, Description: Fixes tests broken due to mis-use of class meta data. Review by: cromwell...@google.com Please review this at http://gwt-code-reviews.appspot.com/786801/show Affected files: M user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.ja

Re: [gwt-contrib] Re: chrome broken

On Thursday, August 19, 2010 23:50:44 Ray Cromwell wrote: > That's interesting, because Longs are supposed to be serialized as strings > not JSON numbers, I'll have to check the server code. Would you mind > posting the Request interface method definition? Does the class referenced > by @Service a

Re: [gwt-contrib] Re: chrome broken

That's interesting, because Longs are supposed to be serialized as strings not JSON numbers, I'll have to check the server code. Would you mind posting the Request interface method definition? Does the class referenced by @Service actually return a Long/long? -Ray On Thu, Aug 19, 2010 at 2:00 PM

[gwt-contrib] [google-web-toolkit] r8587 committed - Add support for Record types as method params in RequestFactory. Misc...

Revision: 8587 Author: rj...@google.com Date: Thu Aug 19 17:13:42 2010 Log: Add support for Record types as method params in RequestFactory. Misc bug fixes. Patch by cromwell...@google.com Review by rj...@google.com, amitman...@google.com http://gwt-code-reviews.appspot.com/767802 Review by: a

[gwt-contrib] [google-web-toolkit] r8586 committed - Remove the unnecessary suppress warning...

Revision: 8586 Author: amitman...@google.com Date: Thu Aug 19 15:11:58 2010 Log: Remove the unnecessary suppress warning Patch by: amitmanjhi Review by: rjrjr http://code.google.com/p/google-web-toolkit/source/detail?r=8586 Modified: /trunk/user/src/com/google/gwt/app/place/AbstractRecordEditA

[gwt-contrib] Re: ant test needs these jars (issue785801)

http://gwt-code-reviews.appspot.com/785801/diff/1/2 File user/build.xml (right): http://gwt-code-reviews.appspot.com/785801/diff/1/2#newcode115 user/build.xml:115: This line is probably no longer needed. http://gwt-code-reviews.appspot.com/785801/show -- http://groups.google.com/group/Google-

[gwt-contrib] ant test needs these jars (issue785801)

Reviewers: Nick Chalko, Description: ant test needs these jars Review by: ncha...@google.com Please review this at http://gwt-code-reviews.appspot.com/785801/show Affected files: M user/build.xml Index: user/build.xml === ---

[gwt-contrib] [google-web-toolkit] r8585 committed - rollback of Introduces ValueListBox, due to test failures.

Revision: 8585 Author: rj...@google.com Date: Thu Aug 19 14:57:33 2010 Log: rollback of Introduces ValueListBox, due to test failures. http://code.google.com/p/google-web-toolkit/source/detail?r=8585 Added: /trunk/user/src/com/google/gwt/app/client/ProxyBox.java /trunk/user/src/com/google/gwt/

[gwt-contrib] Re: Tightened up datanucleus paths to include only **/domain/*.class (issue776802)

LGTM http://gwt-code-reviews.appspot.com/776802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Tightened up datanucleus paths to include only **/domain/*.class (issue776802)

Reviewers: Ray Ryan, Description: Tightened up datanucleus paths to include only **/domain/*.class Merged over a few remaining changes from bikeshed Please review this at http://gwt-code-reviews.appspot.com/776802/show Affected files: M samples/expenses/pom.xml M samples/expenses/src/ma

[gwt-contrib] [google-web-toolkit] r8584 committed - Doing an important TODO in RecordEditActivity....

Revision: 8584 Author: amitman...@google.com Date: Thu Aug 19 14:35:19 2010 Log: Doing an important TODO in RecordEditActivity. Patch by: amitmanjhi Review by: rjrjr http://code.google.com/p/google-web-toolkit/source/detail?r=8584 Modified: /trunk/user/src/com/google/gwt/app/place/AbstractReco

[gwt-contrib] Make xsiframe linker use a .js file for hosted mode so that cross site hosted mode will work (issue784801)

Reviewers: Lex, Description: Make xsiframe linker use a .js file for hosted mode so that cross site hosted mode will work Please review this at http://gwt-code-reviews.appspot.com/784801/show Affected files: A dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.js D dev/core/src/com/go

[gwt-contrib] [google-web-toolkit] r8583 committed - Introduces ValueListBox, and uses it in Scaffold to pick...

Revision: 8583 Author: rj...@google.com Date: Thu Aug 19 14:03:46 2010 Log: Introduces ValueListBox, and uses it in Scaffold to pick employees. Review at http://gwt-code-reviews.appspot.com/780802 Review by: jlaba...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8583 Ad

[gwt-contrib] [google-web-toolkit] r8581 committed - Removes superClass field from JReferenceType in favor of pushing down ...

Revision: 8581 Author: sco...@google.com Date: Thu Aug 19 13:25:39 2010 Log: Removes superClass field from JReferenceType in favor of pushing down to some subclasses. This fixes duplication between JReferenceType and JDeclaredType. Suggested by: grek Review by: spoon http://code.google.com/p

[gwt-contrib] [google-web-toolkit] r8580 committed - Irrespective of the return type, all RF methods now go through the val...

Revision: 8580 Author: amitman...@google.com Date: Thu Aug 19 13:24:10 2010 Log: Irrespective of the return type, all RF methods now go through the valueStore. Added a bunch of missing @Override annotations, removed an unused method in DeltaValueStoreJsonImpl, Confirmed that instance methods wo

[gwt-contrib] [google-web-toolkit] r8582 committed - Fixes the issue that the DVS does not send an object to the server if ...

Revision: 8582 Author: amitman...@google.com Date: Thu Aug 19 13:59:07 2010 Log: Fixes the issue that the DVS does not send an object to the server if no setters have been called on it. Added tests for the issue. Finally, removed the unnecessary operations.size() restriction in DeltaValueStor

[gwt-contrib] Re: Enables test of relationship persistence. (issue783801)

LGTM http://gwt-code-reviews.appspot.com/783801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Support for Record types as method params in RequestFactory, bug fixes (issue767802)

http://gwt-code-reviews.appspot.com/767802/diff/1/3 File user/src/com/google/gwt/requestfactory/client/impl/RecordJsoImpl.java (right): http://gwt-code-reviews.appspot.com/767802/diff/1/3#newcode93 user/src/com/google/gwt/requestfactory/client/impl/RecordJsoImpl.java:93: eval("xyz=" + json); Sho

[gwt-contrib] Re: Enables test of relationship persistence. (issue783801)

A little premature, the test is failing. But the rest is good to go. On 2010/08/19 23:49:58, Ray Ryan wrote: http://gwt-code-reviews.appspot.com/783801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Enables test of relationship persistence. (issue783801)

Reviewers: cromwellian, Description: Enables test of relationship persistence. Also finally got rid of the generics warnings around RequestFactory.create(). Let's not do that again, mmkay? Review by: cromwell...@google.com Please review this at http://gwt-code-reviews.appspot.com/783801/show

[gwt-contrib] Re: Support for Record types as method params in RequestFactory, bug fixes (issue767802)

LGTM On Thu, Aug 19, 2010 at 4:48 PM, wrote: > http://gwt-code-reviews.appspot.com/767802/show > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Support for Record types as method params in RequestFactory, bug fixes (issue767802)

http://gwt-code-reviews.appspot.com/767802/diff/1/3 File user/src/com/google/gwt/requestfactory/client/impl/RecordJsoImpl.java (right): http://gwt-code-reviews.appspot.com/767802/diff/1/3#newcode317 user/src/com/google/gwt/requestfactory/client/impl/RecordJsoImpl.java:317: RequestFactoryJsonImpl

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

No more matching on rendered strings, in it goes... On 2010/08/19 22:52:28, Ray Ryan wrote: http://gwt-code-reviews.appspot.com/780802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

http://gwt-code-reviews.appspot.com/780802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

http://gwt-code-reviews.appspot.com/780802/diff/3001/4026 File user/src/com/google/gwt/user/client/ui/ValueListBox.java (right): http://gwt-code-reviews.appspot.com/780802/diff/3001/4026#newcode35 user/src/com/google/gwt/user/client/ui/ValueListBox.java:35: private final Map indexToValue = new H

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

LGTM http://gwt-code-reviews.appspot.com/780802/diff/3001/4026 File user/src/com/google/gwt/user/client/ui/ValueListBox.java (right): http://gwt-code-reviews.appspot.com/780802/diff/3001/4026#newcode35 user/src/com/google/gwt/user/client/ui/ValueListBox.java:35: private final Map indexToValue =

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

http://gwt-code-reviews.appspot.com/780802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

Also noticed that ValueBoxBase test wasn't running, and wasn't passing. All better now. http://gwt-code-reviews.appspot.com/780802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

Ready for re-review http://gwt-code-reviews.appspot.com/780802/diff/3001/4002 File bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditActivity.java (right): http://gwt-code-reviews.appspot.com/780802/diff/3001/4002#newcode88 bikeshed/src/com/google/gwt/sample/expenses/gwt/u

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

http://gwt-code-reviews.appspot.com/780802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updated common.ant.xml to copy pom.xml (if found) to build/out (issue782801)

http://gwt-code-reviews.appspot.com/782801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: chrome broken

On Thursday, August 19, 2010 16:36:36 Ray Cromwell wrote: > Could you use the Chrome Inspector to post the JSON payload that came back? Sure, the response that fails on the client side is: {"result":3,"related":{}} The request here was a RequestObject and I do expect 3 to be the response of this

[gwt-contrib] Re: Updated common.ant.xml to copy pom.xml (if found) to build/out (issue782801)

Description updated to "Copy source to the output folder". On 2010/08/19 20:26:14, Dan Rice wrote: LGTM http://gwt-code-reviews.appspot.com/782801/diff/1/2 File samples/build.xml (right): http://gwt-code-reviews.appspot.com/782801/diff/1/2#newcode64 samples/build.xml:64: analysis of GWT

[gwt-contrib] Re: Fix memory leaks in DevMode (issue766803)

LGTM if it LGTjat. http://gwt-code-reviews.appspot.com/766803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: chrome broken

Could you use the Chrome Inspector to post the JSON payload that came back? On Thu, Aug 19, 2010 at 11:24 AM, Pascal Patry wrote: > On Thursday, August 19, 2010 14:15:56 Ray Ryan wrote: > > Your gwt-servlet jar might be stale, try re-genning it. (ant dist-dev) > > I don't think, since I'm usual

[gwt-contrib] Re: Updated common.ant.xml to copy pom.xml (if found) to build/out (issue782801)

LGTM http://gwt-code-reviews.appspot.com/782801/diff/1/2 File samples/build.xml (right): http://gwt-code-reviews.appspot.com/782801/diff/1/2#newcode64 samples/build.xml:64: Does this description need to be changed? http://gwt-code-reviews.appspot.com/782801/show -- http://groups.google.com/g

[gwt-contrib] Re: Fix memory leaks in DevMode (issue766803)

On 2010/08/19 20:05:46, conroy wrote: Rietveld's interdiff handling is absurdly bugged. ClearStaticData is no longer deleted, contrary to what it shows on the summary. The only change to CompilationStateBuilder vs. HEAD is a new comment clarifying the resourceContentCache/keepAliveLatest relati

[gwt-contrib] Updated common.ant.xml to copy pom.xml (if found) to build/out (issue782801)

Reviewers: rice_google.comm, Description: Updated common.ant.xml to copy pom.xml (if found) to build/out Added .place-holder to ensure war dir existence Please review this at http://gwt-code-reviews.appspot.com/782801/show Affected files: M samples/build.xml M samples/common.ant.xml A s

[gwt-contrib] Re: Fix memory leaks in DevMode (issue766803)

http://gwt-code-reviews.appspot.com/766803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8579 committed - Added gwt-maven-plugin to M3 maven repo.

Revision: 8579 Author: rda...@google.com Date: Thu Aug 19 12:36:40 2010 Log: Added gwt-maven-plugin to M3 maven repo. http://code.google.com/p/google-web-toolkit/source/detail?r=8579 Added: /2.1.0.M3/gwt/maven/org/codehaus/mojo/gwt-maven-plugin /2.1.0.M3/gwt/maven/org/codehaus/mojo/gwt-maven-p

[gwt-contrib] [google-web-toolkit] r8578 committed - Directories for the gwt-maven-plugin.

Revision: 8578 Author: rda...@google.com Date: Thu Aug 19 12:33:19 2010 Log: Directories for the gwt-maven-plugin. http://code.google.com/p/google-web-toolkit/source/detail?r=8578 Added: /2.1.0.M3/gwt/maven/org /2.1.0.M3/gwt/maven/org/codehaus /2.1.0.M3/gwt/maven/org/codehaus/mojo -- http://

[gwt-contrib] [google-web-toolkit] r8577 committed - Initial artifact set for GWT 2.1 M3 and App Engine 1.3.6

Revision: 8577 Author: rda...@google.com Date: Thu Aug 19 12:18:26 2010 Log: Initial artifact set for GWT 2.1 M3 and App Engine 1.3.6 http://code.google.com/p/google-web-toolkit/source/detail?r=8577 Added: /2.1.0.M3/gwt/maven /2.1.0.M3/gwt/maven/com /2.1.0.M3/gwt/maven/com/google /2.1.0.M3/g

[gwt-contrib] [google-web-toolkit] r8576 committed - Remove improper add of maven directory.

Revision: 8576 Author: rda...@google.com Date: Thu Aug 19 11:48:20 2010 Log: Remove improper add of maven directory. http://code.google.com/p/google-web-toolkit/source/detail?r=8576 Deleted: /2.1.0.M3/gwt/maven -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8575 committed - Adding maven repo directories.

Revision: 8575 Author: rda...@google.com Date: Thu Aug 19 11:47:00 2010 Log: Adding maven repo directories. http://code.google.com/p/google-web-toolkit/source/detail?r=8575 Added: /2.1.0.M3/gwt /2.1.0.M3/gwt/maven -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix memory leaks in DevMode (issue766803)

On 2010/08/19 16:50:01, scottb wrote: Still need answer on JJS -> i18n clear cache. http://gwt-code-reviews.appspot.com/766803/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right): http://gwt-code-reviews.appspot.com/766803/diff/1/3#newcode223 dev/core/

[gwt-contrib] [google-web-toolkit] r8574 committed - Added dir for the 2.1.0.M3 release.

Revision: 8574 Author: rda...@google.com Date: Thu Aug 19 11:34:56 2010 Log: Added dir for the 2.1.0.M3 release. http://code.google.com/p/google-web-toolkit/source/detail?r=8574 Added: /2.1.0.M3 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added all safehtml packages. (issue771801)

http://gwt-code-reviews.appspot.com/771801/diff/25001/26004 File user/src/com/google/gwt/safehtml/shared/OnlyToBeUsedInGeneratedCodeStringBlessedAsSafeHtml.java (right): http://gwt-code-reviews.appspot.com/771801/diff/25001/26004#newcode31 user/src/com/google/gwt/safehtml/shared/OnlyToBeUsedInGe

Re: [gwt-contrib] Re: chrome broken

On Thursday, August 19, 2010 14:15:56 Ray Ryan wrote: > Your gwt-servlet jar might be stale, try re-genning it. (ant dist-dev) I don't think, since I'm usually building as: ant clean; ant buildonly doc; cd distro-source; ant It did make a difference by fixing Firefox completely. The problem is st

[gwt-contrib] Re: Added all safehtml packages. (issue771801)

http://gwt-code-reviews.appspot.com/771801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: chrome broken

Your gwt-servlet jar might be stale, try re-genning it. (ant dist-dev) On Thu, Aug 19, 2010 at 11:13 AM, Pascal Patry wrote: > On Thursday, August 19, 2010 13:48:53 rjrjr wrote: > > We believe this was fixed at r8572. Can anyone confirm? > > It fixed the latest issue in Firefox, however, Chrome

Re: [gwt-contrib] Re: chrome broken

On Thursday, August 19, 2010 13:48:53 rjrjr wrote: > We believe this was fixed at r8572. Can anyone confirm? It fixed the latest issue in Firefox, however, Chrome is still broken. Stack Trace: java.lang.IllegalArgumentException: invoke arguments: JS value of type int, expected com.google.gwt.r

[gwt-contrib] Re: Public: Start of a sample application showing GWT validation. (issue760802)

http://gwt-code-reviews.appspot.com/760802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: chrome broken

On Thursday, August 19, 2010 13:48:53 rjrjr wrote: > We believe this was fixed at r8572. Can anyone confirm? sure, won't be long. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: chrome broken

We believe this was fixed at r8572. Can anyone confirm? On Aug 18, 3:45 pm, Ray Cromwell wrote: > Thanks, there will be a fix for this by COB today. > > -Ray > > > > On Wed, Aug 18, 2010 at 2:38 PM, Pascal Patry wrote: > > On Wednesday, August 18, 2010 16:41:39 you wrote: > > > On Wednesday, Aug

[gwt-contrib] Re: Initial support for round-trip edits in the DynaTableRF sample. (issue767801)

Another sanity check, still sane. I haven't looked in as much depth as I should, but I'm not scared. http://gwt-code-reviews.appspot.com/767801/diff/14001/2014 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/PersonEditorWorkflow.java (right): http://gwt-code-reviews.appspo

[gwt-contrib] RR : Add to UiBinder to allow access to static fields. (issue781801)

Reviewers: Ray Ryan, Message: This patch allows ui.xml files to refer to static fields. Single fields: Wildcard (like import static Inner.*): Enum values (also works as a single field): Setting an element's attribute to the name of an enum value: Description: Add to UiBinder to

[gwt-contrib] Re: Fix memory leaks in DevMode (issue766803)

Still need answer on JJS -> i18n clear cache. http://gwt-code-reviews.appspot.com/766803/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right): http://gwt-code-reviews.appspot.com/766803/diff/1/3#newcode223 dev/core/src/com/google/gwt/dev/javac/CompilationStat

[gwt-contrib] Re: Fix memory leaks in DevMode (issue766803)

http://gwt-code-reviews.appspot.com/766803/diff/1/2 File dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java (right): http://gwt-code-reviews.appspot.com/766803/diff/1/2#newcode499 dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:499: * manage static state. On 2010

[gwt-contrib] Re: Fix memory leaks in DevMode (issue766803)

http://gwt-code-reviews.appspot.com/766803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix memory leaks in DevMode (issue766803)

http://gwt-code-reviews.appspot.com/766803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: TypeOracle transitive invalidation based only on API types (issue775804)

LGTM http://gwt-code-reviews.appspot.com/775804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: TypeOracle transitive invalidation based only on API types (issue775804)

Ah, ok. My question was not phrased correctly, but I was actually wondering about visiting annotation type *refs*, not the annotation types themselves. My bad. Anyway, thanks for clearing that up. On 2010/08/19 15:46:05, scottb wrote: On Thu, Aug 19, 2010 at 11:41 AM,

Re: [gwt-contrib] Re: Added all safehtml packages. (issue771801)

Sure, I will add a note about the intended usage in the code. I will be moving the existing widgets over to SafeHtml soon, and that will, hopefully, provide some good examples as well. Philip On Thu, Aug 19, 2010 at 10:42 AM, Arthur Kalmenson wrote: > I'm just wondering, the idea of this is to

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

Please add test cases (or a TODO) for ValueListBox and anything else that is reasonably stable. http://gwt-code-reviews.appspot.com/780802/diff/3001/4002 File bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditActivity.java (right): http://gwt-code-reviews.appspot.com/78080

[gwt-contrib] Re: TypeOracle transitive invalidation based only on API types (issue775804)

On Thu, Aug 19, 2010 at 11:41 AM, wrote: > Why do we no longer visit annotation types? We visit annotation types; what we don't visit is annotation elements on other types. IE, we don't visit the @Override on a method. The reasoning has to do with how the actual dependencies work in TypeOracl

[gwt-contrib] Re: TypeOracle transitive invalidation based only on API types (issue775804)

Why do we no longer visit annotation types? http://gwt-code-reviews.appspot.com/775804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Added all safehtml packages. (issue771801)

I'm just wondering, the idea of this is to display potentially unsafe HTML we got from the server, right? Is there a way to discourage using this to sanitizing HTML on the client before sending it to the server? I can definitely see newer programmers assuming that doing this sanitization on the cli

Re: [gwt-contrib] IE6/7/8 huge speed problems when adding Stylenames on the fly.

If it is in fact layout and not syle matching that is bogging you down, some good rules of thumb: 1. Try minimize the use of "float" when styling elements. 2. Tables that have "fixed" layout will lay out faster than if left to size to its contents. But, it may not look like you expect it to :). 3.

[gwt-contrib] Re: IE6/7/8 huge speed problems when adding Stylenames on the fly.

Hi, In a few situation we have indeed a few rules that match ".stylename TD" I'll see if I can get rid of them. Thanks, David On Aug 19, 4:11 pm, Jaime Yap wrote: > Setting the styles directly will still run layout. But It will not run style > matching. This might give you a bit of speed up, bu

Re: [gwt-contrib] IE6/7/8 huge speed problems when adding Stylenames on the fly.

Setting the styles directly will still run layout. But It will not run style matching. This might give you a bit of speed up, but I think you should take a second look at the way you are styling your application. The assumption that CssResource won't help might be a little off. Setting the style n

[gwt-contrib] Another annoying bug in IE with regards to keyboard events

Hi, Sorry if I trol this newsgroup too much with my questions, but I asked this before in the GWT group and this group, but I did it while you were all busy planning for the GoogleIO days. I filed an issue for keyboard events not being triggered in IE with GWT when you click away a popup panel. h

[gwt-contrib] Re: IE6/7/8 huge speed problems when adding Stylenames on the fly.

> We haven't built anything like this, but we've definitely seen this problem > before. It doesn't seem unreasonable to be able to extract the text of a > CSSResource rule's properties (a bit unfortunate, since it only affects IE > and would be slower everywhere else -- maybe it would be better to

Re: [gwt-contrib] IE6/7/8 huge speed problems when adding Stylenames on the fly.

[+some people who have looked at this problem in the past] Le 19 août 2010 09:36, stuckagain a écrit : > Hi, > > I found out that using something like addStylename() in an onmouseover > can have really catastrophic effects on performance in IE (6/7 and 8). > In fact IE8 seems to be worse than th

[gwt-contrib] IE6/7/8 huge speed problems when adding Stylenames on the fly.

Hi, I found out that using something like addStylename() in an onmouseover can have really catastrophic effects on performance in IE (6/7 and 8). In fact IE8 seems to be worse than the older versions. In my applications the browser locks up for many seconds even minutes running at 100% CPU. DynaTr

[gwt-contrib] Re: Adds a markTimeline() method to SpeedTracerLogger. (issue776801)

http://gwt-code-reviews.appspot.com/776801/diff/8001/9002 File dev/core/src/com/google/gwt/dev/Permutation.java (right): http://gwt-code-reviews.appspot.com/776801/diff/8001/9002#newcode3 dev/core/src/com/google/gwt/dev/Permutation.java:3: * On 2010/08/19 01:13:43, scottb wrote: I see you caugh

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

Updated ValueListBox with some bug fixes http://gwt-code-reviews.appspot.com/780802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

http://gwt-code-reviews.appspot.com/780802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

Reviewers: cromwellian, Description: Introduces ValueListBox, and uses it in Scaffold to pick employees. Review by: cromwell...@google.com Please review this at http://gwt-code-reviews.appspot.com/780802/show Affected files: M bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/Emp

[gwt-contrib] Re: Fix memory leaks in DevMode (issue766803)

These caches contain types which have a circular reference pattern with the TypeOracle. If we make a hard reference to the cache here, we end up pinning the TypeOracle. You could break hard reference on TypeOracle for example by using weak reference on "method" from "ImageResourceGenera