[gwt-contrib] Re: Comment on ImageResource in google-web-toolkit

2010-09-08 Thread codesite-noreply
Comment by asinghjaunpur: can u give me complete example of resourcebundeling in eclips and also liker concept For more information: http://code.google.com/p/google-web-toolkit/wiki/ImageResource -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: First pass at generating a GWT Validator. (issue845801)

2010-09-08 Thread bobv
LGTM http://gwt-code-reviews.appspot.com/845801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Allow RPC stats system extensions (issue751801)

2010-09-08 Thread bobv
http://gwt-code-reviews.appspot.com/751801/diff/1/2 File user/src/com/google/gwt/rpc/client/impl/RpcCallbackAdapter.java (right): http://gwt-code-reviews.appspot.com/751801/diff/1/2#newcode73 user/src/com/google/gwt/rpc/client/impl/RpcCallbackAdapter.java:73: this(streamFactory, methodName, new

[gwt-contrib] Re: RR: Add statistics to optimizers (issue841801)

2010-09-08 Thread zundel
I'll make the change to remove all of the numVisit++ references. then I'll add a test for the OptimizerStats class and fix up to pass checkstyle before requesting a code review. http://gwt-code-reviews.appspot.com/841801/diff/1/4 File

[gwt-contrib] Re: Add streaming HTML parser library to tools/lib, as well as the guava library it depends on. (issue850801)

2010-09-08 Thread pdr
LGTM http://gwt-code-reviews.appspot.com/850801/diff/1/11 File user/test/com/google/gwt/safehtml/SafeHtmlGwtSuite.java (right): http://gwt-code-reviews.appspot.com/850801/diff/1/11#newcode22 user/test/com/google/gwt/safehtml/SafeHtmlGwtSuite.java:22: import

[gwt-contrib] Re: Add streaming HTML parser library to tools/lib, as well as the guava library it depends on. (issue850801)

2010-09-08 Thread xtof
http://gwt-code-reviews.appspot.com/850801/diff/1/11 File user/test/com/google/gwt/safehtml/SafeHtmlGwtSuite.java (right): http://gwt-code-reviews.appspot.com/850801/diff/1/11#newcode22 user/test/com/google/gwt/safehtml/SafeHtmlGwtSuite.java:22: import

[gwt-contrib] Re: Implement keyboard navigation for CellBrowser (issue843801)

2010-09-08 Thread jlabanca
http://gwt-code-reviews.appspot.com/843801/diff/4001/5002 File user/src/com/google/gwt/user/cellview/client/CellBrowser.java (right): http://gwt-code-reviews.appspot.com/843801/diff/4001/5002#newcode222 user/src/com/google/gwt/user/cellview/client/CellBrowser.java:222:

[gwt-contrib] Adds source infos in the test AST nodes in ConstantsAssumptionTest. (issue831804)

2010-09-08 Thread spoon
Reviewers: aizatsky, Description: Adds source infos in the test AST nodes in ConstantsAssumptionTest. Review by: aizat...@google.com Please review this at http://gwt-code-reviews.appspot.com/831804/show Affected files: M

[gwt-contrib] Re: Adds source infos in the test AST nodes in ConstantsAssumptionTest. (issue831804)

2010-09-08 Thread spoon
Can you review this tiny patch, Mike? Without this patch, there are assertion failures. http://gwt-code-reviews.appspot.com/831804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add SafeHtml support to ui widgets. (issue829801)

2010-09-08 Thread pdr
Done. I apologize about the duplicate/overlapping reviews, but I've rolled the results of this review into: http://gwt-code-reviews.appspot.com/847801/show http://gwt-code-reviews.appspot.com/829801/diff/8020/24004 File user/src/com/google/gwt/user/client/ui/CheckBox.java (right):

[gwt-contrib] Re: Add SafeHtml support to UI widgets (2) (issue847801)

2010-09-08 Thread pdr
http://gwt-code-reviews.appspot.com/847801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Update TypeAccessor.BOOL.canSet() to reflect the types that its toBoolean() method will accept. (issue852801)

2010-09-08 Thread bobv
Reviewers: kjin, Description: Update TypeAccessor.BOOL.canSet() to reflect the types that its toBoolean() method will accept. Patch by: bobv Review by: kjin Please review this at http://gwt-code-reviews.appspot.com/852801/show Affected files: M

[gwt-contrib] Re: Update TypeAccessor.BOOL.canSet() to reflect the types that its toBoolean() method will accept. (issue852801)

2010-09-08 Thread scottb
LGTM http://gwt-code-reviews.appspot.com/852801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8730 committed - Public: First pass at generating a GWT Validator....

2010-09-08 Thread codesite-noreply
Revision: 8730 Author: ncha...@google.com Date: Wed Sep 8 07:45:57 2010 Log: Public: First pass at generating a GWT Validator. This stub never returns any violations. Review at http://gwt-code-reviews.appspot.com/845801 Review by: robertvaw...@google.com

[gwt-contrib] Re: Adds source infos in the test AST nodes in ConstantsAssumptionTest. (issue831804)

2010-09-08 Thread kjin
LGTM On 2010/09/08 15:26:06, Lex wrote: Can you review this tiny patch, Mike? Without this patch, there are assertion failures. http://gwt-code-reviews.appspot.com/831804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds source infos in the test AST nodes in ConstantsAssumptionTest. (issue831804)

2010-09-08 Thread spoon
Thanks! http://gwt-code-reviews.appspot.com/831804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8731 committed - Re-rolled r8701....

2010-09-08 Thread codesite-noreply
Revision: 8731 Author: to...@google.com Date: Wed Sep 8 09:04:51 2010 Log: Re-rolled r8701. Was: Support adding code-gen/runtime related classes directly to the secondary JDT compilation for the GWT AST. http://code.google.com/p/google-web-toolkit/source/detail?r=8731 Modified:

[gwt-contrib] Re: Fix DevMode memory leaks by attaching cache lifetimes to the GeneratorContext (issue826802)

2010-09-08 Thread conroy
http://gwt-code-reviews.appspot.com/826802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: RR: Add statistics to optimizers (issue841801)

2010-09-08 Thread zundel
http://gwt-code-reviews.appspot.com/841801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: RR: Add statistics to optimizers (issue841801)

2010-09-08 Thread zundel
The updated patch simply iterates of the tree to count the nodes at the beginning of each loop. In my tests, the cost of that walk is 5ms on a small program, whereas the cost of the biggest optimizer is 100ms, so I feel comfortable leaving it in there. Here is the new trace output: Pass 1:

[gwt-contrib] [google-web-toolkit] r8733 committed - Added a way for EntityProxy to have a stable equality using getStableI...

2010-09-08 Thread codesite-noreply
Revision: 8733 Author: amitman...@google.com Date: Wed Sep 8 11:08:25 2010 Log: Added a way for EntityProxy to have a stable equality using getStableId(). The getStableId() is stable across creates and updates on the client. Patch by: amitmanjhi Suggested by: robertvawter Review by: rjrjr

[gwt-contrib] Re: Add statistics to optimizers (issue841801)

2010-09-08 Thread scottb
LGTM, just nits. http://gwt-code-reviews.appspot.com/841801/diff/19001/20002 File dev/core/src/com/google/gwt/dev/jjs/ast/JModVisitor.java (right): http://gwt-code-reviews.appspot.com/841801/diff/19001/20002#newcode271 dev/core/src/com/google/gwt/dev/jjs/ast/JModVisitor.java:271: private int

[gwt-contrib] Re: Fix DevMode memory leaks by attaching cache lifetimes to the GeneratorContext (issue826802)

2010-09-08 Thread conroy
http://gwt-code-reviews.appspot.com/826802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix DevMode memory leaks by attaching cache lifetimes to the GeneratorContext (issue826802)

2010-09-08 Thread scottb
LGTM http://gwt-code-reviews.appspot.com/826802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Adds a -strict option to the GWT compiler. If this option is specified, (issue853801)

2010-09-08 Thread spoon
Reviewers: scottb, Description: Adds a -strict option to the GWT compiler. If this option is specified, then the compile will fail if any of the input files are bad. Review by: sco...@google.com Please review this at http://gwt-code-reviews.appspot.com/853801/show Affected files: M

[gwt-contrib] [google-web-toolkit] r8734 committed - Fix ROO-1362 caused by non-public GWT class....

2010-09-08 Thread codesite-noreply
Revision: 8734 Author: cromwell...@google.com Date: Wed Sep 8 14:28:44 2010 Log: Fix ROO-1362 caused by non-public GWT class. Review at http://gwt-code-reviews.appspot.com/835802 Review by: rj...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8734 Added:

[gwt-contrib] [google-web-toolkit] r8735 committed - Add -ea to JVM and GWT args for tests...

2010-09-08 Thread codesite-noreply
Revision: 8735 Author: k...@google.com Date: Wed Sep 8 15:25:08 2010 Log: Add -ea to JVM and GWT args for tests Review at http://gwt-code-reviews.appspot.com/818802 http://code.google.com/p/google-web-toolkit/source/detail?r=8735 Modified: /trunk/common.ant.xml /trunk/dev/build.xml

[gwt-contrib] Re: Change UiBinder Message generation to use consistent examples for HTML and Widget placeholders t... (issue838801)

2010-09-08 Thread mbx
http://gwt-code-reviews.appspot.com/838801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Change UiBinder Message generation to use consistent examples for HTML and Widget placeholders t... (issue838801)

2010-09-08 Thread mbx
Reviewers: rjrjr, Description: Change UiBinder Message generation to use consistent examples for HTML and Widget placeholders to facilitate sharing of messages with embedded HTML elements or widgets. Please review this at http://gwt-code-reviews.appspot.com/838801/show Affected files: M

[gwt-contrib] Fix bug 2822942 Remove calls to System.currentTimeMillis in tests (issue849801)

2010-09-08 Thread zhuyi
Reviewers: rice, Description: Fix bug 2822942 Remove calls to System.currentTimeMillis in tests Review by: r...@google.com Please review this at http://gwt-code-reviews.appspot.com/849801/show Affected files: M user/test/com/google/gwt/emultest/java/sql/SqlDateTest.java M

Re: [gwt-contrib] Re: Uibinder parser api

2010-09-08 Thread Ray Ryan
The 2.1 release branch will be cut from trunk. Trunk does not include a public api to add new parsers to UiBinder. If anyone wants to submit a patch to make it possible to subclass UiBinderGenerator and tweak its parsers that way, s.t. you can provide an alternative replace-with rule for your