Re: [gwt-contrib] Re: Adds accessibility to certain GWT AST nodes (issue1304802)

2011-01-27 Thread Grzegorz Kossakowski
Thanks for reply. This is in line with my schedule. I'll be watching your progress with great interest. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Warn users of JRE 1.5 that their days are numbered (issue1328802)

2011-01-27 Thread rchandia
LGTM On 2011/01/27 04:48:37, bobv wrote: LGTM http://gwt-code-reviews.appspot.com/1328802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Adding new style theme called Clean, and using the new theme in Showcase and in the default GWT ... (issue1330801)

2011-01-27 Thread jlabanca
Reviewers: pdr, Description: Adding new style theme called Clean, and using the new theme in Showcase and in the default GWT app. Also fixing a style bug in VerticalSplitPanel that causes the splitter to be too wide. Author: josht (styles), jlabanca Please review this at

[gwt-contrib] Re: Adding new style theme called Clean, and using the new theme in Showcase and in the default GWT ... (issue1330801)

2011-01-27 Thread pdr
Few nits about the styles: button image is off by 1px in showcase button example, and a few blue border elements remain. http://gwt-code-reviews.appspot.com/1330801/diff/1/8 File user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome.css (right):

[gwt-contrib] [google-web-toolkit] r9634 committed - Add link to Issue 5946 GraphNavigationGwtTest

2011-01-27 Thread codesite-noreply
Revision: 9634 Author: ncha...@google.com Date: Thu Jan 27 07:01:18 2011 Log: Add link to Issue 5946 GraphNavigationGwtTest http://code.google.com/p/google-web-toolkit/source/detail?r=9634 Modified: /wiki/BeanValidation.wiki === ---

[gwt-contrib] Re: Adding new style theme called Clean, and using the new theme in Showcase and in the default GWT ... (issue1330801)

2011-01-27 Thread jlabanca
http://gwt-code-reviews.appspot.com/1330801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding new style theme called Clean, and using the new theme in Showcase and in the default GWT ... (issue1330801)

2011-01-27 Thread jlabanca
http://gwt-code-reviews.appspot.com/1330801/diff/1/8 File user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome.css (right): http://gwt-code-reviews.appspot.com/1330801/diff/1/8#newcode233 user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome.css:233: line-height: 0px;

[gwt-contrib] Re: AbstractPlaceHistoryMapper doesn't process tokens correctly wrt empty prefixes (issue1316801)

2011-01-27 Thread rjrjr
r9635 http://gwt-code-reviews.appspot.com/1316801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9635 committed - In r8817, we landed a patch that allows @Prefix(), i.e. a...

2011-01-27 Thread codesite-noreply
Revision: 9635 Author: t.bro...@gmail.com Date: Thu Jan 27 07:38:01 2011 Log: In r8817, we landed a patch that allows @Prefix(), i.e. a non-prefixed PlaceTokenizer, and produces a separator-less history token as a result. The token parsing however wasn't updated, and such a token would always go

[gwt-contrib] Resolve gwt-servlet 2.1.0 issue 5918 (issue1331801)

2011-01-27 Thread drfibonacci
Reviewers: rjrjr, Description: Explicitly add gwt-servlet current version as a dependency to gwt-maven-plugin Please review this at http://gwt-code-reviews.appspot.com/1331801/show Affected files: samples/expenses/pom.xml Index: samples/expenses/pom.xml

[gwt-contrib] Re: Resolve gwt-servlet 2.1.0 issue 5918 (issue1331801)

2011-01-27 Thread rjrjr
I submitted this yesterday r9630. Can you look and confirm I did it right? rhttp://code.google.com/p/google-web-toolkit/source/detail?r=9630 http://gwt-code-reviews.appspot.com/1331801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9636 committed - Warn users of JRE 1.5 that their days are numbered...

2011-01-27 Thread codesite-noreply
Revision: 9636 Author: rj...@google.com Date: Thu Jan 27 05:31:37 2011 Log: Warn users of JRE 1.5 that their days are numbered Addresses http://code.google.com/p/google-web-toolkit/issues/detail?id=5884 Review at http://gwt-code-reviews.appspot.com/1328802 Review by: rchan...@google.com

[gwt-contrib] Re: Resolve gwt-servlet 2.1.0 issue 5918 (issue1331801)

2011-01-27 Thread drfibonacci
yep, r9630 is good. I'll close this out. http://gwt-code-reviews.appspot.com/1331801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9637 committed - Change GWT History to work when multiple applications are loaded withi...

2011-01-27 Thread codesite-noreply
Revision: 9637 Author: jhollenb...@google.com Date: Thu Jan 27 07:30:25 2011 Log: Change GWT History to work when multiple applications are loaded within the same page. Patch by: jhollenbach Review by: jat, jgw Review at http://gwt-code-reviews.appspot.com/1322801

[gwt-contrib] [google-web-toolkit] r9639 committed - Cherry picking r9636 into releases/2.2, jre 1.5 deprecation warning

2011-01-27 Thread codesite-noreply
Revision: 9639 Author: rj...@google.com Date: Thu Jan 27 08:11:12 2011 Log: Cherry picking r9636 into releases/2.2, jre 1.5 deprecation warning http://code.google.com/p/google-web-toolkit/source/detail?r=9639 Modified: /releases/2.2/dev/core/src/com/google/gwt/util/tools/ToolBase.java

[gwt-contrib] Fix the mac build for leopard users of the npapi/xpcom plugins. (issue1323802)

2011-01-27 Thread conroy
Reviewers: jat, fabiomfv, Description: Fix the mac build for leopard users of the npapi/xpcom plugins. Please review this at http://gwt-code-reviews.appspot.com/1323802/show Affected files: M plugins/config.mk M plugins/npapi/Makefile M

[gwt-contrib] Re: Fix the mac build for leopard users of the npapi/xpcom plugins. (issue1323802)

2011-01-27 Thread jat
I have no way to test it, but LGTM http://gwt-code-reviews.appspot.com/1323802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix the mac build for leopard users of the npapi/xpcom plugins. (issue1323802)

2011-01-27 Thread fabiomfv
LTGM http://gwt-code-reviews.appspot.com/1323802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Initial version of HTML5 Audio and Video (issue1318803)

2011-01-27 Thread pdr
Reviewers: rice, jlabanca, Description: Initial version of HTML5 Audio and Video Original patch by rice, updated by pdr. Please review this at http://gwt-code-reviews.appspot.com/1318803/show Affected files: A user/src/com/google/gwt/dom/client/AudioElement.java M

[gwt-contrib] Re: Add mnemonics for DevMode swing UI. (issue1328801)

2011-01-27 Thread conroy
On 2011/01/26 21:57:09, jat wrote: LGTM http://gwt-code-reviews.appspot.com/1328801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Comment on LightweightCollections in google-web-toolkit

2011-01-27 Thread codesite-noreply
Comment by javierfe...@gmail.com: Any update on this? Thanks For more information: http://code.google.com/p/google-web-toolkit/wiki/LightweightCollections -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9640 committed - Public: (by t.bro...@gmail.com):

2011-01-27 Thread codesite-noreply
Revision: 9640 Author: rj...@google.com Date: Thu Jan 27 09:39:02 2011 Log: Public: (by t.bro...@gmail.com): http://code.google.com/p/google-web-toolkit/source/detail?r=9640 Modified: /trunk/user/src/com/google/gwt/dom/client/DOMImplSafari.java

[gwt-contrib] [google-web-toolkit] r9641 committed - Fix the mac build for leopard users of the npapi/xpcom plugins....

2011-01-27 Thread codesite-noreply
Revision: 9641 Author: con...@google.com Date: Thu Jan 27 09:50:46 2011 Log: Fix the mac build for leopard users of the npapi/xpcom plugins. Review at http://gwt-code-reviews.appspot.com/1323802 http://code.google.com/p/google-web-toolkit/source/detail?r=9641 Modified:

[gwt-contrib] Use 'boolean' instead of 'Z' for JSNI primitive type qualifiers. (issue1295805)

2011-01-27 Thread scottb
Reviewers: bobv, Message: This patch is transitional, we will continue to support the only style for now. Please review this at http://gwt-code-reviews.appspot.com/1295805/show Affected files: M dev/core/src/com/google/gwt/dev/javac/JsniChecker.java M

[gwt-contrib] Re: Add test org.hibernate.jsr303.tck.tests.validation.graphnavigation.GraphNavigationGwtTest (issue1332801)

2011-01-27 Thread rchandia
LGTM On 2011/01/27 20:44:18, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1332801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] [google-web-toolkit] r9640 committed - Public: (by t.bro...@gmail.com):

2011-01-27 Thread Chris Conroy
The real log message (now correct in svn) for this change is: Public (t.bro...@gmail.com): Addresses http://code.google.com/p/google-web-toolkit/issues/detail?id=5563 For GIN friendliness, make the PlaceHistoryMapperGenerator return null when it encounters a concrete implementation. (Returning

Re: [gwt-contrib] [google-web-toolkit] r9640 committed - Public: (by t.bro...@gmail.com):

2011-01-27 Thread Chris Conroy
correction Public (by t.bro...@gmail.com): Description: http://code.google.com/p/google-web-toolkit/issues/detail?id=4916 http://www.google.com/url?sa=Dq=http%3A//code.google.com/p/google-web-toolkit/issues/detail%3Fid%3D4916 Remove old workaround code from DOMImplSafari

[gwt-contrib] [google-web-toolkit] r9642 committed - Sort format some files....

2011-01-27 Thread codesite-noreply
Revision: 9642 Author: sco...@google.com Date: Thu Jan 27 12:46:16 2011 Log: Sort format some files. Review by: zun...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=9642 Modified: /trunk/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java

[gwt-contrib] [google-web-toolkit] r9643 committed - At application startup, assert that the specified user.agent selection...

2011-01-27 Thread codesite-noreply
Revision: 9643 Author: fre...@google.com Date: Thu Jan 27 13:56:33 2011 Log: At application startup, assert that the specified user.agent selection property value indeed matches the expected value for the executing browser / user agent, thus avoid long hours debugging strange error messages

[gwt-contrib] [google-web-toolkit] r9644 committed - Fixes a javadoc typo in the app generated by WebAppCreator.

2011-01-27 Thread codesite-noreply
Revision: 9644 Author: rj...@google.com Date: Thu Jan 27 14:03:30 2011 Log: Fixes a javadoc typo in the app generated by WebAppCreator. http://code.google.com/p/google-web-toolkit/source/detail?r=9644 Modified: /trunk/user/src/com/google/gwt/user/tools/SharedClassTemplate.javasrc

[gwt-contrib] Snipping JRE 1.5 hostile Override annotations from UserAgentAsserter (issue1334801)

2011-01-27 Thread rjrjr
Reviewers: fredsa, Description: Snipping JRE 1.5 hostile Override annotations from UserAgentAsserter patch. We only just deprecated 1.5, need to be friendly for one more relese. Please review this at http://gwt-code-reviews.appspot.com/1334801/show Affected files: M

[gwt-contrib] [google-web-toolkit] r9645 committed - Add test org.hibernate.jsr303.tck.tests.validation.graphnavigation.Gra...

2011-01-27 Thread codesite-noreply
Revision: 9645 Author: ncha...@google.com Date: Thu Jan 27 14:17:20 2011 Log: Add test org.hibernate.jsr303.tck.tests.validation.graphnavigation.GraphNavigationGwtTest [JSR 303 TCK Result] 91 of 257 (35.41%) Pass with 33 Failures and 16 Errors. Review at

[gwt-contrib] Improvements to JsniChecker. (issue1333801)

2011-01-27 Thread scottb
Reviewers: bobv, Description: - JsniChecker now implements ALL of the JSNI checks that were being done in GenerateJavaAST. - JsniCheckerTest tests them all. - JsniChecker reports the resolved refs it collected. - Tighter type on jsni method map. Please review this at

[gwt-contrib] [google-web-toolkit] r9646 committed - Snipping JRE 1.5 hostile Override annotations from UserAgentAsserter...

2011-01-27 Thread codesite-noreply
Revision: 9646 Author: rj...@google.com Date: Thu Jan 27 16:01:17 2011 Log: Snipping JRE 1.5 hostile Override annotations from UserAgentAsserter patch. We only just deprecated 1.5, need to be friendly for one more relese. Review at http://gwt-code-reviews.appspot.com/1334801 Review by: