[gwt-contrib] Template embedding in the GWT

2011-08-02 Thread Sanjay Jain
Hello All I have template with its css and html.Now I want to get all the look and features (compatibility) of that template in my gwt application. I am not getting the right way to do that. One way which I thought is that for control there will be a .html file , which will be added to the gwt

[gwt-contrib] Re: Simplify the use of TckCompileTestCase by always using the module named (issue1467811)

2011-08-02 Thread rchandia
LGTM http://gwt-code-reviews.appspot.com/1467811/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add Provided Field Null Validation (issue1486801)

2011-08-02 Thread rchandia
http://gwt-code-reviews.appspot.com/1486801/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (right):

[gwt-contrib] Making lazy widgets generation the default option. (issue1499809)

2011-08-02 Thread hermes
Reviewers: rjrjr, Description: Making lazy widgets generation the default option. Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/1499809/ Affected files: M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml M

[gwt-contrib] Re: Include enclosing class in generated class name (issue1499804)

2011-08-02 Thread rchandia
LGTM http://gwt-code-reviews.appspot.com/1499804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove the pre-GwtAstBuilder compile chain. (issue1465805)

2011-08-02 Thread zundel
LGTM http://gwt-code-reviews.appspot.com/1465805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Making lazy widgets generation the default option. (issue1499809)

2011-08-02 Thread Ray Ryan
Lets warn gwt-announce that the default will change next Tuesday, and encourage them to try it out themselves in the meantime. Are you okay driving that, and with waiting another week? On Aug 2, 2011 6:33 AM, her...@google.com wrote: Reviewers: rjrjr, Description: Making lazy widgets

[gwt-contrib] Re: Adding a spot for database column name in Column. Allows us to create an updated SQL statement w... (issue1503806)

2011-08-02 Thread jlabanca
http://gwt-code-reviews.appspot.com/1503806/diff/3/user/src/com/google/gwt/user/cellview/client/Column.java File user/src/com/google/gwt/user/cellview/client/Column.java (right):

[gwt-contrib] Re: Replace RequestFactoryInterfaceValidator with an annotation-processor-based approach. (issue1503804)

2011-08-02 Thread rjrjr
http://gwt-code-reviews.appspot.com/1503804/diff/1/samples/dynatablerf/build.xml File samples/dynatablerf/build.xml (right): http://gwt-code-reviews.appspot.com/1503804/diff/1/samples/dynatablerf/build.xml#newcode8 samples/dynatablerf/build.xml:8: !-- Run the annotation processor -- This is a

[gwt-contrib] [google-web-toolkit] r10485 committed - Eliminates the code for the long deprecated urn:with feature....

2011-08-02 Thread codesite-noreply
Revision: 10485 Author: rj...@google.com Date: Mon Aug 1 13:27:49 2011 Log: Eliminates the code for the long deprecated urn:with feature. Review at http://gwt-code-reviews.appspot.com/1500808 Review by: her...@google.com

[gwt-contrib] [google-web-toolkit] r10486 committed - Simplify the use of TckCompileTestCase by always using the module name...

2011-08-02 Thread codesite-noreply
Revision: 10486 Author: gwt.mirror...@gmail.com Date: Tue Aug 2 05:56:59 2011 Log: Simplify the use of TckCompileTestCase by always using the module named TckTest.gwt.xml. Add asserts for generator compile time errors. Review at http://gwt-code-reviews.appspot.com/1467811 Review

[gwt-contrib] unit cache with binary annotations

2011-08-02 Thread Stephen Haberman
Hi, I ran into an odd boundary case with the unit cache today that I thought I'd report. I had a class, Foo, using a binary-only annotation, @Bar. Somehow my classpath was wrong, and so I got a (valid) compilation error from ecj that Foo couldn't be compiled without Bar. However, after fixing

[gwt-contrib] [google-web-toolkit] r10487 committed - Adding a spot for database column name in Column. Allows us to create ...

2011-08-02 Thread codesite-noreply
Revision: 10487 Author: porte...@google.com Date: Tue Aug 2 07:46:31 2011 Log: Adding a spot for database column name in Column. Allows us to create an updated SQL statement when the sort column changes, using only the Column itself. Review at

[gwt-contrib] Re: Adding a spot for database column name in Column. Allows us to create an updated SQL statement w... (issue1503806)

2011-08-02 Thread stephen . haberman
http://gwt-code-reviews.appspot.com/1503806/diff/2002/user/src/com/google/gwt/user/cellview/client/Column.java File user/src/com/google/gwt/user/cellview/client/Column.java (right):

[gwt-contrib] Re: Adding a spot for database column name in Column. Allows us to create an updated SQL statement w... (issue1503806)

2011-08-02 Thread Jeff Larsen
I'm inclined to agree with Stephen here. No where else in GWT widgetry is there a reference to database related things. I don't think this is a big deal either, but it seems like a more application specific thing rather than something that belongs inside GWT proper. --

Re: [gwt-contrib] unit cache with binary annotations

2011-08-02 Thread Eric Ayers
I see how that could happen. We don't take annotations into account in the computing of dependencies in BytecodeSignatureMaker.CompileDependencyVisitor. Filed issue: http://code.google.com/p/google-web-toolkit/issues/detail?id=6646 -Eric. On Tue, Aug 2, 2011 at 2:57 PM, Stephen Haberman

Re: [gwt-contrib] Re: Adding a spot for database column name in Column. Allows us to create an updated SQL statement w... (issue1503806)

2011-08-02 Thread Ray Ryan
I was biting my tongue on this one, but I guess I'll jump in and agree, this smells bad. @jlabanca, is there no hook in Column or maybe Cell.Context where this kind of app-specific data can be added? On Tue, Aug 2, 2011 at 12:32 PM, Jeff Larsen larse...@gmail.com wrote: I'm inclined to agree

Re: [gwt-contrib] Re: Adding a spot for database column name in Column. Allows us to create an updated SQL statement w... (issue1503806)

2011-08-02 Thread Ray Ryan
It's John L's call, but that's certainly my preference. On Tue, Aug 2, 2011 at 1:10 PM, John Porter Simons porte...@google.comwrote: The other way we (me and dramos@) discussed doing this was, in our CellTable subclass, have a map from Column to String to store these database column names. I

[gwt-contrib] Re: Adding a spot for database column name in Column. Allows us to create an updated SQL statement w... (issue1503806)

2011-08-02 Thread jlabanca
This came up before, and here is the rationale. If you add an app specific data object to Column, you have to add another parameterized type to Column. That's more verbose, somewhat confusing, and it will be Void for most users anyway. I'm a big fan of parameterized types because they make the

[gwt-contrib] Remove unneeded loop over cached units (issue1503807)

2011-08-02 Thread stephen . haberman
Reviewers: zundel, Please review this at http://gwt-code-reviews.appspot.com/1503807/ Affected files: M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java Index: dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java diff --git

[gwt-contrib] Fix: http://code.google.com/p/google-web-toolkit/issues/detail?id=6367 (issue1508802)

2011-08-02 Thread meder
Reviewers: tobyr, jat, Description: Fix: http://code.google.com/p/google-web-toolkit/issues/detail?id=6367 Create shared utils package and include it in gwt-dev and gwt-servlet Please review this at http://gwt-code-reviews.appspot.com/1508802/ Affected files: M

[gwt-contrib] Re: Fix: http://code.google.com/p/google-web-toolkit/issues/detail?id=6367 (issue1508802)

2011-08-02 Thread tobyr
On 2011/08/03 00:22:49, meder wrote: LGTM http://gwt-code-reviews.appspot.com/1508802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10488 committed - Created wiki page through web user interface.

2011-08-02 Thread codesite-noreply
Revision: 10488 Author: b...@google.com Date: Tue Aug 2 17:49:09 2011 Log: Created wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=10488 Added: /wiki/RequestFactoryInterfaceValidation.wiki === ---

[gwt-contrib] [google-web-toolkit] r10489 committed - Fix: http://code.google.com/p/google-web-toolkit/issues/detail?id=6367...

2011-08-02 Thread codesite-noreply
Revision: 10489 Author: gwt.mirror...@gmail.com Date: Tue Aug 2 20:51:04 2011 Log: Fix: http://code.google.com/p/google-web-toolkit/issues/detail?id=6367 Create shared utils package and include it in gwt-dev and gwt-servlet Review at http://gwt-code-reviews.appspot.com/1508802