LGTM
http://gwt-code-reviews.appspot.com/1601803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1601805/diff/1/user/src/com/google/web/bindery/autobean/shared/ValueCodex.java
File user/src/com/google/web/bindery/autobean/shared/ValueCodex.java
(right):
OK, two more runs of the benchmark (using ant benchmark
-Dgwt.benchmark.testcase.includes=**/ValueCodexBenchmark.class)
scrambled the results (I also slightly modified one of the test, but
that's another story). I decided to keep the change in nevertheless
(based on the 80/20 rule and the fact
committed as r10779
http://gwt-code-reviews.appspot.com/1606803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: drfibonacci,
Description:
Document a bug in maven-gae-plugin that prevents gae:unpack goal in
mobilewebapp from running if gae.home is set in ~/.m2/settings.xml
Please review this at http://gwt-code-reviews.appspot.com/1607803/
Affected files:
M
http://gwt-code-reviews.appspot.com/1607803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
As I understand it, there are two cases where createStyleRuler is
called, and attached as a __styleRuler expando:
- in initParent, the expando then references a child element; I'm not
sure this creates a leak, as there's no loop here. It could easily be
changed to use an instance variable
Ping: rdayal or scheglov
On 2011/12/01 08:11:49, tbroyer wrote:
LGTM
http://gwt-code-reviews.appspot.com/1602805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
Just reorder the method alphabetically within the other public methods.
In GWT, we sort by visibility first, then alphabetically.
http://gwt-code-reviews.appspot.com/1606804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1606804/diff/2002/user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java
File
user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java
(right):
http://gwt-code-reviews.appspot.com/1607803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/12/07 19:38:28, mdempsky wrote:
LGTM.
http://gwt-code-reviews.appspot.com/1606804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1606804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1605804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I have tacitly presumed that a LGTM from the reviewers is kinda mandatory
for a commit to be made. However, I have just noticed a commit made today
without a explicit LGTM.
http://code.google.com/p/google-web-toolkit/source/detail?r=10780
http://gwt-code-reviews.appspot.com/1506802
--
On Wed, Dec 7, 2011 at 3:58 PM, karthik reddy karthik.ele...@gmail.comwrote:
I have tacitly presumed that a LGTM from the reviewers is kinda
mandatory for a commit to be made. However, I have just noticed a commit
made today without a explicit LGTM.
Since GWT code is committed to an
LGTM.
http://gwt-code-reviews.appspot.com/1602805/diff/1/user/test/com/google/gwt/uibinder/test/client/UiProvidedNullTest.java
File
user/test/com/google/gwt/uibinder/test/client/UiProvidedNullTest.java
(right):
I see. Thanks for clarifying, John.
--
Karthik Reddy
https://plus.google.com/103243388366746199136
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Note also that sometimes we have to rollback or patch something in an
emergency that has broken important internal apps, so we will often
rollback or quickfix these without the regular delay of going through
the public issue tracker, but hopefully these are rare instances.
-Ray
On Wed, Dec 7,
http://gwt-code-reviews.appspot.com/1607803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
lgtm
http://gwt-code-reviews.appspot.com/1607803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1606803/diff/1/eclipse/dev/.classpath
File eclipse/dev/.classpath (right):
http://gwt-code-reviews.appspot.com/1606803/diff/1/eclipse/dev/.classpath#newcode43
eclipse/dev/.classpath:43: classpathentry kind=var
path=GWT_TOOLS/lib/jscomp/sourcemap-rebased.jar/
- in initParent, the expando then references a child element; I'm
not sure this creates a leak, as there's no loop here.
If I don't clear the __styleRuler on the parent, doing just this:
LayoutPanel p = new LayoutPanel();
RootPanel.get().add(p);
RootPanel.get().remove(p);
Leaks.
23 matches
Mail list logo
