Hi,
The lazy parsing would only happen during deserialisation in the client. I
think it is safe to assume that a BigInteger created through toString on
the server will not result in a parse exception in the client code - or are
there known incompatibilities ?
I don't want that the regular
Forgot to mention this code-snippet I found in the BigInteger class:
/**
* The magnitude of this big integer. This array is in little endian
order and
* each digit is a 32-bit unsigned integer. For example: {@code 13} is
* represented as [ 13 ] {@code -13} is represented as [ 13 ]
Daniel Kurka has posted comments on this change.
Change subject: Adds Timer#isRunning().
..
Patch Set 2:
(1 comment)
File user/src/com/google/gwt/user/client/Timer.java
On Thursday, June 13, 2013 9:18:23 AM UTC+2, stuckagain wrote:
Forgot to mention this code-snippet I found in the BigInteger class:
/**
* The magnitude of this big integer. This array is in little endian
order and
* each digit is a 32-bit unsigned integer. For example:
Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3180
to look at the new patch set (#12).
Change subject: adding compare for several number types
Daniel Kurka has posted comments on this change.
Change subject: adding compare for several number types
..
Patch Set 12:
Updated Patch to deal with normal numbers first, but I don't think this
ends up being more readable.
Daniel Kurka has posted comments on this change.
Change subject: Add show relative to Element in PopupPanel
..
Patch Set 2:
(2 comments)
File
Hello Leeroy Jenkins, Thomas Broyer,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3340
to look at the new patch set (#3).
Change subject: Add show relative to Element in PopupPanel
Hello Goktug Gokdogan,
I'd like you to reexamine a rebased change. Please visit
https://gwt-review.googlesource.com/2976
to look at the new rebased patch set (#4).
Change subject: Add static is(...) to complement as as(...).
Thomas Broyer has posted comments on this change.
Change subject: Fix support for Document.{get,set}ScrollLeft() in RTL for
safari and ie9.
..
Patch Set 2: Code-Review+1
(1 comment)
Thomas Broyer has posted comments on this change.
Change subject: Failing tests for java.util.Objects
..
Patch Set 1: Code-Review+2
(1 comment)
File
Thomas Broyer has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 9:
@Andrey: thanks; but no need to create a new issue here, it's the
continuity of the original issue (and fixing
Thomas Broyer has submitted this change and it was merged.
Change subject: Failing tests for java.util.Objects
..
Failing tests for java.util.Objects
Fixes issue 8193
Change-Id: I394c80559ce4e872826f832f0aca24fcd0e156ba
---
Thomas Broyer has posted comments on this change.
Change subject: Failing tests for java.util.Objects
..
Patch Set 1:
Now let's see if it indeed fixes the build ;-)
--
To view, visit https://gwt-review.googlesource.com/3400
Daniel Kurka has posted comments on this change.
Change subject: Change DOM access in HTMLTable for IE
..
Patch Set 2:
(2 comments)
File
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3212
to look at the new patch set (#3).
Change subject: Change DOM access in HTMLTable for IE
..
Change DOM
Thomas Broyer has posted comments on this change.
Change subject: Change DOM access in HTMLTable for IE
..
Patch Set 3: Code-Review+1
According to the MDN, using 'children' in all browsers would work. The
problem is that
Hello Thomas Broyer, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3212
to look at the new patch set (#4).
Change subject: Change DOM access in HTMLTable for IE
..
Thomas Broyer has posted comments on this change.
Change subject: Change DOM access in HTMLTable for IE
..
Patch Set 4: Code-Review+1
(1 comment)
File
Daniel Kurka has posted comments on this change.
Change subject: Change DOM access in HTMLTable for IE
..
Patch Set 4:
I am about to test behavior on IE10 and see if it leaks as well. If it does
not we can simply leave it
Thomas Broyer has uploaded a new change for review.
https://gwt-review.googlesource.com/3421
Change subject: Add drawImage(VideoElement, …) overloads
..
Add drawImage(VideoElement, …) overloads
Bug: issue 8192
Change-Id:
Daniel Kurka has posted comments on this change.
Change subject: Change DOM access in HTMLTable for IE
..
Patch Set 4:
So IE10 leaks as well without the workaround.
Sending out a repro to MS, but I think we have to deal with
Daniel Kurka has posted comments on this change.
Change subject: Add drawImage(VideoElement, …) overloads
..
Patch Set 1: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3421
To unsubscribe, visit
Leif Åstrand has posted comments on this change.
Change subject: Use JSON.parse() instead of eval() to deserialize rpc
callback payload
..
Patch Set 11: Code-Review-1
This patch does not work as it stands for a couple of
Thomas Broyer has posted comments on this change.
Change subject: Make Element.hasTagName(...) case-insensitive.
..
Patch Set 7: Code-Review+2
@Matthew: any idea why Jenkins doesn't pick it up?
--
To view, visit
Thomas Broyer has posted comments on this change.
Change subject: Fix support for Document.{get,set}ScrollLeft() in RTL for
safari and ie9.
..
Patch Set 2:
(1 comment)
Thomas Broyer has posted comments on this change.
Change subject: Make Element.hasTagName(...) case-insensitive.
..
Patch Set 7:
Hoorays!
--
To view, visit https://gwt-review.googlesource.com/2975
To unsubscribe, visit
Thomas Broyer has submitted this change and it was merged.
Change subject: Make Element.hasTagName(...) case-insensitive.
..
Make Element.hasTagName(...) case-insensitive.
Helpful because the various Element TAG constants are
Thomas Broyer has posted comments on this change.
Change subject: Fix support for Document.{get,set}ScrollLeft() in RTL for
safari and ie9.
..
Patch Set 2:
(1 comment)
Hello Thomas Broyer, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3212
to look at the new patch set (#5).
Change subject: Change DOM access in HTMLTable for IE
..
Daniel Kurka has posted comments on this change.
Change subject: Change DOM access in HTMLTable for IE
..
Patch Set 4:
(1 comment)
File
Hello Matthew Dempsky, Leeroy Jenkins, Brian Slesinsky,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/2512
to look at the new patch set (#5).
Change subject: Adding a DOM clear method to RootPanel
Daniel Kurka has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 4:
(1 comment)
File
Daniel Kurka has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 5:
I would like to see this get landed or abandoned. I think having it would
have a small value, but if
Hello Matthew Dempsky, Leeroy Jenkins, Brian Slesinsky,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/2512
to look at the new patch set (#6).
Change subject: Adding a DOM clear method to RootPanel
Matthew Dempsky has posted comments on this change.
Change subject: Failing tests for java.util.Objects
..
Patch Set 1:
(1 comment)
Thanks for submitting and getting the build green (or blue) again! :)
Matthew Dempsky has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 9:
Gerrit is a bit different than Google practices internally, because
internally only the CL author can actually
John A. Tamplin has posted comments on this change.
Change subject: adding compare for several number types
..
Patch Set 12: Code-Review+2
The intent wasn't to make it more readable, but to give a slight
performance
On Thu, Jun 13, 2013 at 3:18 AM, David david.no...@gmail.com wrote:
Forgot to mention this code-snippet I found in the BigInteger class:
/**
* The magnitude of this big integer. This array is in little endian
order and
* each digit is a 32-bit unsigned integer. For example: {@code
On Thu, Jun 13, 2013 at 3:14 AM, David david.no...@gmail.com wrote:
The lazy parsing would only happen during deserialisation in the client. I
think it is safe to assume that a BigInteger created through toString on
the server will not result in a parse exception in the client code - or are
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3361
to look at the new patch set (#2).
Change subject: Ensure clinits get called for JSO instance methods.
..
John,
Well, if I don't have support for this patch then I better stop working on
it. I can understand that this is not seen as a priority for GWT. Worst
case I just replace the BigInteger/BigDecimal class in the project itself,
that is basically what I did right now.
Oracle sequences can be
I'm beginning to think such a change does not belong in GWT. In your
example, wouldn't you be better served by only sending strings to the
client rather than BigDecimals, if they client never does anything with
them but send them back?
Thats exactly what I thought too. If its just a
I've shared an item with you:
Corp Textarea annoucement
https://docs.google.com/document/d/1uSFPO8tKsVvbs9RVOz9Mbyg-Llf_VABI-eoiWBfV_vs/edit?usp=sharing
It's not an attachment -- it's stored online. To open this item, just click
the link above.
Hey Goktug,
please let me know if this is a
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Add support for 'ImageResource' to @url substitution in
css. Only 'DataResource' used to be supported.
..
Add support for 'ImageResource' to @url
Goktug Gokdogan has posted comments on this change.
Change subject: Add support for 'ImageResource' to @url substitution in
css. Only 'DataResource' used to be supported.
..
Patch Set 2: Code-Review+2
--
To view, visit
On Thu, Jun 13, 2013 at 3:03 PM, David david.no...@gmail.com wrote:
Well, if I don't have support for this patch then I better stop working on
it. I can understand that this is not seen as a priority for GWT. Worst
case I just replace the BigInteger/BigDecimal class in the project itself,
Brian Slesinsky has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 6:
(1 comment)
I still don't think it's necessary but I'm okay with a helper method if
it's very
Daniel Kurka has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 6:
With that rationale we should name it clearWidgetsAndDom?
--
To view, visit
Goktug Gokdogan has posted comments on this change.
Change subject: adding compare for several number types
..
Patch Set 12:
(1 comment)
The comparison functions are usually used in non linear algorithm like
sorting so
I agree; this seems like a workaround for one application that picked the
wrong datatype. Maybe we should warn about BigDecimal being slow somewhere?
If someone wants to do some performance tests of GWT-RPC serialization,
publishing the results would be useful to the community.
My recommendation
Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3180
to look at the new patch set (#13).
Change subject: adding compare for several number types
Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3180
to look at the new patch set (#14).
Change subject: adding compare for several number types
Goktug Gokdogan has posted comments on this change.
Change subject: adding compare for several number types
..
Patch Set 14: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit
Daniel Kurka has submitted this change and it was merged.
Change subject: adding compare for several number types
..
adding compare for several number types
-Byte.compare
-Short.compare
-Integer.compare
-Long.compare
John A. Tamplin has posted comments on this change.
Change subject: Ensure clinits get called for JSO instance methods.
..
Patch Set 2: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3361
To unsubscribe,
Brian Slesinsky has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 6:
Admittedly it's a judgment call. I'm somewhat biased in favor of shorter
names and somewhat against
Brian Slesinsky has posted comments on this change.
Change subject: Use JSON.parse() instead of eval() to deserialize rpc
callback payload
..
Patch Set 11:
Sounds like we need more tests. Serialization code generally does
Goktug Gokdogan has posted comments on this change.
Change subject: Set display to none for table columns that should not be
visible.
..
Patch Set 3:
Aliseya, you very likely responded to my comments but I can't see them.
Goktug Gokdogan has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 6:
It is better to just call it clear so that people will need to read the
javadoc instead of making
Brian Slesinsky has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 6: Code-Review+2
This is a pretty minor change, breakage is unlikely, and I don't think it
matters too
Goktug Gokdogan has posted comments on this change.
Change subject: Set display to none for table columns that should not be
visible.
..
Patch Set 1:
(1 comment)
File
Daniel Kurka has submitted this change and it was merged.
Change subject: Adding a DOM clear method to RootPanel
..
Adding a DOM clear method to RootPanel
By calling rootPanel.clear(true) the user can clear
widgets AND DOM
Goktug Gokdogan has posted comments on this change.
Change subject: Set display to none for table columns that should not be
visible.
..
Patch Set 3: Code-Review+2
Ok, I (or him) might have misinterpreted what is going on.
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Set display to none for table columns that should not be
visible.
..
Set display to none for table columns that should not be visible.
Change-Id:
Goktug Gokdogan has posted comments on this change.
Change subject: Adds Timer#isRunning().
..
Patch Set 2:
(1 comment)
File user/src/com/google/gwt/user/client/Timer.java
In my opinion, having the tool-bar in gwt makes perfectly sense,
RichTextArea is almost unusable without a bar in any project. It's
plenty of gwt projects which have copied and pasted the code from the
showcase.
I think that you should face this issue in some steps:
1.- Listen to GWT contributors
67 matches
Mail list logo
