http://gwt-code-reviews.appspot.com/847801/diff/8002/13005
File user/src/com/google/gwt/user/client/ui/Anchor.java (right):
http://gwt-code-reviews.appspot.com/847801/diff/8002/13005#newcode117
user/src/com/google/gwt/user/client/ui/Anchor.java:117:
this(html.asString(), true);
On 2010/09/10
On Friday, September 10, 2010, p...@google.com wrote:
One of the reasons to delegate to setHTML() is to support external
implementations that have overridden setHTML(). Your suggestion makes a
lot of sense, but to support the external users, I think we should stick
with the setHTML() version.
http://gwt-code-reviews.appspot.com/847801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM!
http://gwt-code-reviews.appspot.com/847801/diff/8002/13005
File user/src/com/google/gwt/user/client/ui/Anchor.java (right):
http://gwt-code-reviews.appspot.com/847801/diff/8002/13005#newcode117
user/src/com/google/gwt/user/client/ui/Anchor.java:117:
this(html.asString(), true);
This is
http://gwt-code-reviews.appspot.com/847801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM with mostly nits.
A general concern is inconsistency about naming -- most places, the
SafeHtml version is just an overload, and that makes the most sense to
me. Some places rename the method to be setSafeHtml instead of setHtml,
for example, and I don't think that difference is relevant to
http://gwt-code-reviews.appspot.com/847801/diff/1/2
File tools/api-checker/config/gwt20_21userApi.conf (right):
http://gwt-code-reviews.appspot.com/847801/diff/1/2#newcode115
tools/api-checker/config/gwt20_21userApi.conf:115: # there needs to be:
method(SafeHtml html), etc.
On 2010/09/07
LGTM
http://gwt-code-reviews.appspot.com/847801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
